June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: add pfcp msg test

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 to look at the new patch set (#3). Change subject: add pfcp msg test ...................................................................... add pfcp msg test Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d --- M configure.ac M tests/Makefile.am A tests/libosmo-pfcp/Makefile.am A tests/libosmo-pfcp/pfcp_test.c A tests/libosmo-pfcp/pfcp_test.ok M tests/testsuite.at 6 files changed, 699 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d Gerrit-Change-Number: 27638 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement PFCP header and msg handling

by neels

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27631 ) Change subject: libosmo-pfcp: implement PFCP header and msg handling ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3f85ea052a6b7c064244a8093777e53a47c8c61e Gerrit-Change-Number: 27631 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 06 Jun 2022 23:45:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-upf[master]: pfcp/Makefile.am: add missing pfcp_ies_auto.h entry

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/28224 ) Change subject: pfcp/Makefile.am: add missing pfcp_ies_auto.h entry ...................................................................... pfcp/Makefile.am: add missing pfcp_ies_auto.h entry Even though it is a generated header, it must still be listed in pfcp_HEADERS. Change-Id: I6fbfe1fcd084f2d16334bb3e44d9891d9485d59f --- M include/osmocom/pfcp/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/24/28224/1 diff --git a/include/osmocom/pfcp/Makefile.am b/include/osmocom/pfcp/Makefile.am index 4bfc194..65b0102 100644 --- a/include/osmocom/pfcp/Makefile.am +++ b/include/osmocom/pfcp/Makefile.am @@ -1,5 +1,6 @@ pfcp_HEADERS = \ pfcp_ies_custom.h \ + pfcp_ies_auto.h \ pfcp_proto.h \ pfcp_strs.h \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I6fbfe1fcd084f2d16334bb3e44d9891d9485d59f Gerrit-Change-Number: 28224 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-upf[master]: pfcp ie: tweak CP Function Features

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/28225 ) Change subject: pfcp ie: tweak CP Function Features ...................................................................... pfcp ie: tweak CP Function Features The spec indicates three bytes of CP Function Features, but both wireshark and ttcn3 expect only one byte. This makes sense because only eight CP F.F. flags are defined. Drop those two always-zero bytes, hence pass the wireshark dissector and ttcn3 parsing without warnings. Change-Id: Icda891a2f3401e58f142f229465403d5dc8befe5 --- M include/osmocom/pfcp/pfcp_ies_custom.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/25/28225/1 diff --git a/include/osmocom/pfcp/pfcp_ies_custom.h b/include/osmocom/pfcp/pfcp_ies_custom.h index 9f26550..c28fdb2 100644 --- a/include/osmocom/pfcp/pfcp_ies_custom.h +++ b/include/osmocom/pfcp/pfcp_ies_custom.h @@ -73,7 +73,7 @@ * printf("%s\n", osmo_pfcp_bits_to_str_c(x.bits, osmo_pfcp_cp_feature_strs)); */ struct osmo_pfcp_ie_cp_function_features { - uint8_t bits[3]; + uint8_t bits[1]; }; /* 3GPP TS 29.244 8.2.37 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Icda891a2f3401e58f142f229465403d5dc8befe5 Gerrit-Change-Number: 28225 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-upf[master]: api: osmo_pfcp_ie_node_id_to_str_c

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/28226 ) Change subject: api: osmo_pfcp_ie_node_id_to_str_c ...................................................................... api: osmo_pfcp_ie_node_id_to_str_c Change-Id: I5c580bc510afce58a03dea0861db9630b063b2ae --- M include/osmocom/pfcp/pfcp_ies_custom.h M src/libosmo-pfcp/pfcp_ies_custom.c 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/26/28226/1 diff --git a/include/osmocom/pfcp/pfcp_ies_custom.h b/include/osmocom/pfcp/pfcp_ies_custom.h index c28fdb2..08e62d1 100644 --- a/include/osmocom/pfcp/pfcp_ies_custom.h +++ b/include/osmocom/pfcp/pfcp_ies_custom.h @@ -48,6 +48,9 @@ }; }; +int osmo_pfcp_ie_node_id_to_str_buf(char *buf, size_t buflen, const struct osmo_pfcp_ie_node_id *node_id); +char *osmo_pfcp_ie_node_id_to_str_c(void *ctx, const struct osmo_pfcp_ie_node_id *node_id); + bool osmo_pfcp_bits_get(const uint8_t *bits, unsigned int bitpos); void osmo_pfcp_bits_set(uint8_t *bits, unsigned int bitpos, bool val); int osmo_pfcp_bits_to_str_buf(char *buf, size_t buflen, const uint8_t *bits, const struct value_string *bit_strs); diff --git a/src/libosmo-pfcp/pfcp_ies_custom.c b/src/libosmo-pfcp/pfcp_ies_custom.c index 660a08d..5975a29 100644 --- a/src/libosmo-pfcp/pfcp_ies_custom.c +++ b/src/libosmo-pfcp/pfcp_ies_custom.c @@ -317,9 +317,8 @@ return 0; } -int osmo_pfcp_enc_to_str_node_id(char *buf, size_t buflen, const void *encode_from) +int osmo_pfcp_ie_node_id_to_str_buf(char *buf, size_t buflen, const struct osmo_pfcp_ie_node_id *node_id) { - const struct osmo_pfcp_ie_node_id *node_id = encode_from; struct osmo_strbuf sb = { .buf = buf, .len = buflen }; switch (node_id->type) { @@ -343,6 +342,16 @@ return sb.chars_needed; } +char *osmo_pfcp_ie_node_id_to_str_c(void *ctx, const struct osmo_pfcp_ie_node_id *node_id) +{ + OSMO_NAME_C_IMPL(ctx, 64, "ERROR", osmo_pfcp_ie_node_id_to_str_buf, node_id) +} + +int osmo_pfcp_enc_to_str_node_id(char *buf, size_t buflen, const void *encode_from) +{ + return osmo_pfcp_ie_node_id_to_str_buf(buf, buflen, encode_from); +} + bool osmo_pfcp_bits_get(const uint8_t *bits, unsigned int bitpos) { unsigned int bytenum = bitpos / 8; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I5c580bc510afce58a03dea0861db9630b063b2ae Gerrit-Change-Number: 28226 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_lost_sdcch_during_assignment (SCCPlite)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28223 ) Change subject: BSC_Tests: fix TC_lost_sdcch_during_assignment (SCCPlite) ...................................................................... BSC_Tests: fix TC_lost_sdcch_during_assignment (SCCPlite) When running ttcn3-bsc-test against osmo-bsc in SCCPlite mode, TC_lost_sdcch_during_assignment fails with the following output: Local verdict of MTC: fail reason: "Timeout of T_guard" Final verdict of PTC: fail reason: "Unexpected DLCX received" One key problem is that in f_TC_lost_sdcch_during_assignment() we expect to receive a DLCX message on port MGCP, but somehow it gets caught by the as_Media_mgw earlier than we attempt to receive it. * Fix this race condition by activating the as_Media_mgw with fail_on_dlcx := false, so that it does not catch DLCX messages. Another problem is that for SCCPlite we're running the MGCP_Emulation component with multi_conn_mode=true, so that all MGCP messages are arriving at port MGCP_MULTI (not MGCP) wrapped into MGCP_RecvFrom. * Expect the DLCX message on either of the two ports depending on the value of g_pars.aoip (AoIP or SCCPlite mode). This change makes BSC_Tests.TC_lost_sdcch_during_assignment pass. Change-Id: If4807d3d7d196682f7f22732ad47bcbb72858ed3 --- M bsc/BSC_Tests.ttcn 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/28223/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 2e804e1..d9b178f 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11283,7 +11283,7 @@ /* we should now have a COMPL_L3 at the MSC */ f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); - activate(as_Media_mgw()); + activate(as_Media_mgw(fail_on_dlcx := false)); var RslChannelNr chan_nr := { u := { ch0 := RSL_CHAN_NR_Bm_ACCH }, tn := 1 }; f_rslem_register(0, chan_nr); @@ -11312,9 +11312,18 @@ BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); var MgcpCommand mgcp; - MGCP.receive(tr_DLCX()) -> value mgcp { - MGCP.send(ts_DLCX_ACK2(mgcp.line.trans_id)); - }; + var MGCP_RecvFrom mrf; + var template MgcpMessage msg_dlcx := { command := tr_DLCX }; + alt { + [g_pars.aoip] MGCP.receive(tr_DLCX) -> value mgcp { + MGCP.send(ts_DLCX_ACK2(mgcp.line.trans_id)); + } + [not g_pars.aoip] MGCP_MULTI.receive(tr_MGCP_RecvFrom_any(msg_dlcx)) -> value mrf { + MGCP_MULTI.send(t_MGCP_SendToMrf(mrf, MgcpMessage:{ + response := ts_DLCX_ACK2(mrf.msg.command.line.trans_id) + })); + } + } f_sleep(0.5); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4807d3d7d196682f7f22732ad47bcbb72858ed3 Gerrit-Change-Number: 28223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bsc-test/osmo-bsc.cfg: configure 3 additional TRX instances for...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28215 ) Change subject: ttcn3-bsc-test/osmo-bsc.cfg: configure 3 additional TRX instances for BTS2 ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iba4fbd5c9ed59783df4ac64e68b2beef73a812ff Gerrit-Change-Number: 28215 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Jun 2022 15:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/StatsD_Checker: make logging messages more readable

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28222 ) Change subject: library/StatsD_Checker: make logging messages more readable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0484f36184fe3724c57cedcf203894d701b91605 Gerrit-Change-Number: 28222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jun 2022 14:21:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add support for per-TRX RSL connections

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28212 ) Change subject: BSC_Tests: add support for per-TRX RSL connections ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic0fd97234464ef624010a5f01189aa61f3393b84 Gerrit-Change-Number: 28212 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jun 2022 14:21:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_chan_alloc_algo_{a,de}scending

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28214 ) Change subject: BSC_Tests: add TC_chan_alloc_algo_{a,de}scending ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Not sure if going through the BORKEN state is a good idea, but OK. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic74a9cd264320a9a17648f9331b67fb2c2404122 Gerrit-Change-Number: 28214 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jun 2022 14:19:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022