April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: abis_rsl: Fix typo in log message

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27816 ) Change subject: abis_rsl: Fix typo in log message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia614541ccb02beddc7a869b9fb9151393959844c Gerrit-Change-Number: 27816 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 18 Apr 2022 10:55:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-mgw[for-1.9.0]: Bump version: 1.9.0.1-1a099 → 1.9.1

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27821 ) Change subject: Bump version: 1.9.0.1-1a099 → 1.9.1 ...................................................................... Bump version: 1.9.0.1-1a099 → 1.9.1 Change-Id: I8801d482858f4c9f44f9d320e4393e8fab43b58f --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index ec34937..1768ebc 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-mgw (1.9.1) unstable; urgency=medium + + [ Vadim Yanitskiy ] + * libosmo-mgcp: e1: fix memleaks in e1_recv_cb() + + -- Harald Welte <laforge(a)osmocom.org> Mon, 18 Apr 2022 10:58:50 +0200 + osmo-mgw (1.9.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: for-1.9.0 Gerrit-Change-Id: I8801d482858f4c9f44f9d320e4393e8fab43b58f Gerrit-Change-Number: 27821 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-mgw[for-1.9.0]: libosmo-mgcp: e1: fix memleaks in e1_recv_cb()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27820 ) Change subject: libosmo-mgcp: e1: fix memleaks in e1_recv_cb() ...................................................................... libosmo-mgcp: e1: fix memleaks in e1_recv_cb() Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Fixes: OS#5533 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index e88b8c5..9a6efe2 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -338,6 +338,7 @@ trunk = mgcp_trunk_by_line_num(cfg, ts->line->num); if (!trunk) { LOGP(DE1, LOGL_ERROR, "E1-RX: unable to find a trunk for E1-line %u!\n", ts->line->num); + msgb_free(msg); return; } @@ -359,6 +360,9 @@ /* Trigger sending of pending E1 traffic */ e1_send(ts, trunk); + + /* e1inp_rx_ts() does not free() msgb */ + msgb_free(msg); } static int e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: for-1.9.0 Gerrit-Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Gerrit-Change-Number: 27820 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-mgw[for-1.9.0]: Bump version: 1.9.0.1-1a099 → 1.9.1

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27821 ) Change subject: Bump version: 1.9.0.1-1a099 → 1.9.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: for-1.9.0 Gerrit-Change-Id: I8801d482858f4c9f44f9d320e4393e8fab43b58f Gerrit-Change-Number: 27821 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Apr 2022 10:52:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-mgw[for-1.9.0]: libosmo-mgcp: e1: fix memleaks in e1_recv_cb()

by laforge

Attention is currently required from: fixeria, pespin, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27820 ) Change subject: libosmo-mgcp: e1: fix memleaks in e1_recv_cb() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: for-1.9.0 Gerrit-Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Gerrit-Change-Number: 27820 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 18 Apr 2022 10:52:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-mgw[for-1.9.0]: Bump version: 1.9.0.1-1a099 → 1.9.1

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27821 ) Change subject: Bump version: 1.9.0.1-1a099 → 1.9.1 ...................................................................... Bump version: 1.9.0.1-1a099 → 1.9.1 Change-Id: I8801d482858f4c9f44f9d320e4393e8fab43b58f --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/21/27821/1 diff --git a/debian/changelog b/debian/changelog index ec34937..1768ebc 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-mgw (1.9.1) unstable; urgency=medium + + [ Vadim Yanitskiy ] + * libosmo-mgcp: e1: fix memleaks in e1_recv_cb() + + -- Harald Welte <laforge(a)osmocom.org> Mon, 18 Apr 2022 10:58:50 +0200 + osmo-mgw (1.9.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: for-1.9.0 Gerrit-Change-Id: I8801d482858f4c9f44f9d320e4393e8fab43b58f Gerrit-Change-Number: 27821 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-mgw[for-1.9.0]: libosmo-mgcp: e1: fix memleaks in e1_recv_cb()

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27820 ) Change subject: libosmo-mgcp: e1: fix memleaks in e1_recv_cb() ...................................................................... libosmo-mgcp: e1: fix memleaks in e1_recv_cb() Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Fixes: OS#5533 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/20/27820/1 diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index e88b8c5..9a6efe2 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -338,6 +338,7 @@ trunk = mgcp_trunk_by_line_num(cfg, ts->line->num); if (!trunk) { LOGP(DE1, LOGL_ERROR, "E1-RX: unable to find a trunk for E1-line %u!\n", ts->line->num); + msgb_free(msg); return; } @@ -359,6 +360,9 @@ /* Trigger sending of pending E1 traffic */ e1_send(ts, trunk); + + /* e1inp_rx_ts() does not free() msgb */ + msgb_free(msg); } static int e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: for-1.9.0 Gerrit-Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Gerrit-Change-Number: 27820 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: Fix compile errors on #warning with '-Wall' on gcc-11.2

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27819 ) Change subject: Fix compile errors on #warning with '-Wall' on gcc-11.2 ...................................................................... Fix compile errors on #warning with '-Wall' on gcc-11.2 pcu_sock.c: In function ‘pcu_tx_info_ind’: pcu_sock.c:197:2: error: #warning "isn't dl_tbf_ext wrong?: * 10 and no ntohs" [-Werror=cpp] 197 | #warning "isn't dl_tbf_ext wrong?: * 10 and no ntohs" | ^~~~~~~ pcu_sock.c:199:2: error: #warning "isn't ul_tbf_ext wrong?: * 10 and no ntohs" [-Werror=cpp] 199 | #warning "isn't ul_tbf_ext wrong?: * 10 and no ntohs" | ^~~~~~~ Change-Id: I9ef7e18f56aa86b48f0ffeec58406260736170f3 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/27819/1 diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index d6dd9a7..5dc4829 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -194,9 +194,12 @@ if (rlcc->cs_mask & (1 << GPRS_MCS9)) info_ind->flags |= PCU_IF_FLAG_MCS9; } +#pragma GCC diagnostic push +#pragma GCC diagnostic warning "-Wcpp" #warning "isn't dl_tbf_ext wrong?: * 10 and no ntohs" info_ind->dl_tbf_ext = rlcc->parameter[T_DL_TBF_EXT]; #warning "isn't ul_tbf_ext wrong?: * 10 and no ntohs" +#pragma GCC diagnostic pop info_ind->ul_tbf_ext = rlcc->parameter[T_UL_TBF_EXT]; info_ind->initial_cs = rlcc->initial_cs; info_ind->initial_mcs = rlcc->initial_mcs; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ef7e18f56aa86b48f0ffeec58406260736170f3 Gerrit-Change-Number: 27819 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: lchan_fsm: Ignore other SAPIs of RLL_REL_IND for SAPI=0 is received

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27818 ) Change subject: lchan_fsm: Ignore other SAPIs of RLL_REL_IND for SAPI=0 is received ...................................................................... lchan_fsm: Ignore other SAPIs of RLL_REL_IND for SAPI=0 is received If the BTS tells us SAPI=0 is gone, there is no point in trying to keep the lchan around for SAPI=3, as it is not possible to operate GSM with SAPI=0 gone. This occurred with RBS6000, which don't seem to send RLL REL IND for SAPI3 after doing so for SAPI0. However, rather than an ericsson-specific hack, let's make this the general rule: If SAPI=0 is gone, don't stop the lchan from being released. Change-Id: Ia9caa5b0a5efdc459d94621367376927959a6e65 Related: OS#5530 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/27818/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 00bb605..0b23f6c 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -1203,6 +1203,13 @@ if (lchan->conn && sapi == 0 && !(link_id & 0xc0)) { LOG_LCHAN(lchan, LOGL_DEBUG, "lchan is releasing\n"); gscon_lchan_releasing(lchan->conn, lchan); + + /* if SAPI=0 is gone, it makes no sense if other SAPIs are still around, + * this is not a valid configuration and we should forget about them. + * This is particularly relevant in case of Ericsson RBS6000, which doesn't + * seem to send a RLL_REL_IND for SAPI=3 if there was already one for SAPI=0 */ + for_each_active_sapi(sapi, 1, lchan) + lchan->sapis[sapi] = LCHAN_SAPI_UNUSED; } /* The caller shall check whether all SAPIs are released and cause a state chg */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia9caa5b0a5efdc459d94621367376927959a6e65 Gerrit-Change-Number: 27818 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: Handle unknown rllr_ind enum values in rll_ind_cb()

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27817 ) Change subject: Handle unknown rllr_ind enum values in rll_ind_cb() ...................................................................... Handle unknown rllr_ind enum values in rll_ind_cb() If we receive something unexpected, log it (and free the msgb!) Change-Id: I43fab6a3a1c5e7a6545d6ef848636f5ba1be1576 Related: OS#5530 (only tangentially related) --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/27817/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index f8c240f..bb96aeb 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -1255,6 +1255,10 @@ GSM0808_CAUSE_BSS_NOT_EQUIPPED); msgb_free(msg); break; + default: + LOGPLCHAN(lchan, DRLL, LOGL_NOTICE, "Received unknown rllr_ind %u\n", rllr_ind); + msgb_free(msg); + break; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I43fab6a3a1c5e7a6545d6ef848636f5ba1be1576 Gerrit-Change-Number: 27817 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022