Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27778 )
Change subject: osmo-bts-trx: amr_loop: do not miss C/I samples
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bts-trx/amr_loop.c:
https://gerrit.osmocom.org/c/osmo-bts/+/27778/comment/feb1856d_2d08d77c
PS1, Line 53: if (mi != chan_state->dl_cmr)
> Doesn't this mean that you end up with an average lqual_cb which was received while the MS was using […]
This is a good question, and it applies to the MS/BS power loops too. There we keep averaging samples regardless of the indicated UP/DL power levels, so do we here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27778
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ieb5473ead7200f652b5d0e339e4e252d6567482d
Gerrit-Change-Number: 27778
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Apr 2022 13:14:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27808 )
Change subject: ttcn3-bsc-test/osmo-bsc.cfg: set AMR link adaptation params
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Idf5b22c7d50d283d24edf5ccd8de9051f7c2642f
Gerrit-Change-Number: 27808
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Apr 2022 13:08:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27812 )
Change subject: Set rate_ctr_group name for each line
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27812
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I200e068f1bbc495fb806402877551924beea214e
Gerrit-Change-Number: 27812
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 17 Apr 2022 11:23:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27811 )
Change subject: Make use of libosmcoore cpu_sched_vty
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27811
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I1b8021e6dc864af6e301fced427e24c8bb21ca2f
Gerrit-Change-Number: 27811
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 17 Apr 2022 11:23:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment