April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: prioritize FACCH in s/tx_tch_common()/tch_dl_dequeue()/s

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27804 ) Change subject: osmo-bts-trx: prioritize FACCH in s/tx_tch_common()/tch_dl_dequeue()/s ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9822b1a17185d5487f0f6d3ed0203e806c053d7d Gerrit-Change-Number: 27804 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Apr 2022 05:50:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in libosmo-abis[master]: input/e1d: fix a memleak in handle_ts_raw_read()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27814 ) Change subject: input/e1d: fix a memleak in handle_ts_raw_read() ...................................................................... input/e1d: fix a memleak in handle_ts_raw_read() Change-Id: I18965d1ef67a388e7bcdddd0314a9090e34c89e0 --- M src/input/e1d.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/input/e1d.c b/src/input/e1d.c index a959b40..ddd1bc4 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -232,6 +232,7 @@ ret = read(bfd->fd, msg->data, D_TSX_ALLOC_SIZE); if (ret < 0 || ret != D_TSX_ALLOC_SIZE) { LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "read error %d %s\n", ret, strerror(errno)); + msgb_free(msg); return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I18965d1ef67a388e7bcdddd0314a9090e34c89e0 Gerrit-Change-Number: 27814 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in libosmo-abis[master]: input/e1d: use msgb_hexdump_l2() in handle_ts_raw_read()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27815 ) Change subject: input/e1d: use msgb_hexdump_l2() in handle_ts_raw_read() ...................................................................... input/e1d: use msgb_hexdump_l2() in handle_ts_raw_read() Change-Id: I17f4ab1315f0fdab71ccbe45fc83facf2c9ea641 --- M src/input/e1d.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/input/e1d.c b/src/input/e1d.c index ddd1bc4..4ab7c36 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -242,7 +242,7 @@ msgb_put(msg, ret); msg->l2h = msg->data; - LOGPITS(e1i_ts, DLMIB, LOGL_DEBUG, "RAW CHAN RX: %s\n", osmo_hexdump(msgb_l2(msg), ret)); + LOGPITS(e1i_ts, DLMIB, LOGL_DEBUG, "RAW CHAN RX: %s\n", msgb_hexdump_l2(msg)); ret = e1inp_rx_ts(e1i_ts, msg, 0, 0); /* physical layer indicates that data has been sent, * we thus can send some more data */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I17f4ab1315f0fdab71ccbe45fc83facf2c9ea641 Gerrit-Change-Number: 27815 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in libosmo-abis[master]: input/e1d: use msgb_hexdump_l2() in handle_ts_raw_read()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27815 ) Change subject: input/e1d: use msgb_hexdump_l2() in handle_ts_raw_read() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I17f4ab1315f0fdab71ccbe45fc83facf2c9ea641 Gerrit-Change-Number: 27815 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Apr 2022 05:42:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in libosmo-abis[master]: input/e1d: fix a memleak in handle_ts_raw_read()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27814 ) Change subject: input/e1d: fix a memleak in handle_ts_raw_read() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I18965d1ef67a388e7bcdddd0314a9090e34c89e0 Gerrit-Change-Number: 27814 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Apr 2022 05:42:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-mgw[master]: libosmo-mgcp: e1: fix memleaks in e1_recv_cb()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27813 ) Change subject: libosmo-mgcp: e1: fix memleaks in e1_recv_cb() ...................................................................... libosmo-mgcp: e1: fix memleaks in e1_recv_cb() Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Fixes: OS#5533 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index e88b8c5..9a6efe2 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -338,6 +338,7 @@ trunk = mgcp_trunk_by_line_num(cfg, ts->line->num); if (!trunk) { LOGP(DE1, LOGL_ERROR, "E1-RX: unable to find a trunk for E1-line %u!\n", ts->line->num); + msgb_free(msg); return; } @@ -359,6 +360,9 @@ /* Trigger sending of pending E1 traffic */ e1_send(ts, trunk); + + /* e1inp_rx_ts() does not free() msgb */ + msgb_free(msg); } static int e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Gerrit-Change-Number: 27813 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-mgw[master]: libosmo-mgcp: e1: fix memleaks in e1_recv_cb()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27813 ) Change subject: libosmo-mgcp: e1: fix memleaks in e1_recv_cb() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Gerrit-Change-Number: 27813 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Apr 2022 05:41:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in libosmo-abis[master]: input/e1d: use msgb_hexdump_l2() in handle_ts_raw_read()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27815 ) Change subject: input/e1d: use msgb_hexdump_l2() in handle_ts_raw_read() ...................................................................... input/e1d: use msgb_hexdump_l2() in handle_ts_raw_read() Change-Id: I17f4ab1315f0fdab71ccbe45fc83facf2c9ea641 --- M src/input/e1d.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/15/27815/1 diff --git a/src/input/e1d.c b/src/input/e1d.c index ddd1bc4..4ab7c36 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -242,7 +242,7 @@ msgb_put(msg, ret); msg->l2h = msg->data; - LOGPITS(e1i_ts, DLMIB, LOGL_DEBUG, "RAW CHAN RX: %s\n", osmo_hexdump(msgb_l2(msg), ret)); + LOGPITS(e1i_ts, DLMIB, LOGL_DEBUG, "RAW CHAN RX: %s\n", msgb_hexdump_l2(msg)); ret = e1inp_rx_ts(e1i_ts, msg, 0, 0); /* physical layer indicates that data has been sent, * we thus can send some more data */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I17f4ab1315f0fdab71ccbe45fc83facf2c9ea641 Gerrit-Change-Number: 27815 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in libosmo-abis[master]: input/e1d: fix a memleak in handle_ts_raw_read()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27814 ) Change subject: input/e1d: fix a memleak in handle_ts_raw_read() ...................................................................... input/e1d: fix a memleak in handle_ts_raw_read() Change-Id: I18965d1ef67a388e7bcdddd0314a9090e34c89e0 --- M src/input/e1d.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/14/27814/1 diff --git a/src/input/e1d.c b/src/input/e1d.c index a959b40..ddd1bc4 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -232,6 +232,7 @@ ret = read(bfd->fd, msg->data, D_TSX_ALLOC_SIZE); if (ret < 0 || ret != D_TSX_ALLOC_SIZE) { LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "read error %d %s\n", ret, strerror(errno)); + msgb_free(msg); return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I18965d1ef67a388e7bcdddd0314a9090e34c89e0 Gerrit-Change-Number: 27814 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-mgw[master]: libosmo-mgcp: e1: fix memleaks in e1_recv_cb()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27813 ) Change subject: libosmo-mgcp: e1: fix memleaks in e1_recv_cb() ...................................................................... libosmo-mgcp: e1: fix memleaks in e1_recv_cb() Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Fixes: OS#5533 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/13/27813/1 diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index e88b8c5..9a6efe2 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -338,6 +338,7 @@ trunk = mgcp_trunk_by_line_num(cfg, ts->line->num); if (!trunk) { LOGP(DE1, LOGL_ERROR, "E1-RX: unable to find a trunk for E1-line %u!\n", ts->line->num); + msgb_free(msg); return; } @@ -359,6 +360,9 @@ /* Trigger sending of pending E1 traffic */ e1_send(ts, trunk); + + /* e1inp_rx_ts() does not free() msgb */ + msgb_free(msg); } static int e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Gerrit-Change-Number: 27813 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022