March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ggsn[master]: gtp: Small log improvements in gtp_create_pdp_ind()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27415 ) Change subject: gtp: Small log improvements in gtp_create_pdp_ind() ...................................................................... gtp: Small log improvements in gtp_create_pdp_ind() Drop unneeded log line, rewrite line to better fit code path. Change-Id: Id254e04d539cc055fee8c16fb66cd897b041557e --- M gtp/gtp.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/gtp/gtp.c b/gtp/gtp.c index f847e43..aeb9603 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1754,8 +1754,6 @@ in_addr2gsna(&pdp->gsnlc, &gsn->gsnc); in_addr2gsna(&pdp->gsnlu, &gsn->gsnu); - DEBUGP(DLGTP, "gtp_create_pdp_ind: Before gtp_pdp_tidget\n"); - if (!gtp_pdp_getimsi(gsn, &pdp_old, pdp->imsi, pdp->nsapi)) { /* Found old pdp with same tid. Now the voodoo begins! */ /* 09.60 / 29.060 allows create on existing context to "steal" */ @@ -1777,7 +1775,7 @@ * QoS: MS will get originally negotiated QoS. * End user address (EUA). MS will get old EUA anyway. * Protocol configuration option (PCO): Only application can verify */ - DEBUGP(DLGTP, "gtp_create_pdp_ind: Old context found\n"); + DEBUGP(DLGTP, "gtp_create_pdp_ind: Reusing old context\n"); /* Copy remote flow label */ pdp_old->flru = pdp->flru; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id254e04d539cc055fee8c16fb66cd897b041557e Gerrit-Change-Number: 27415 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Log detection of rx duplicate

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27414 ) Change subject: gtp: Log detection of rx duplicate ...................................................................... gtp: Log detection of rx duplicate Change-Id: I8bc9143db6743ad4fae2fe6d6fe0417648e9eec9 --- M gtp/gtp.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/gtp/gtp.c b/gtp/gtp.c index 3051255..f847e43 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -827,11 +827,18 @@ struct sockaddr_in *peer, uint16_t seq) { struct qmsg_t *qmsg; + char buf[INET_ADDRSTRLEN]; if (queue_seqget(gsn->queue_resp, &qmsg, peer, seq)) { return EOF; /* Notfound */ } + + buf[0] = '\0'; + inet_ntop(AF_INET, &peer->sin_addr, buf, sizeof(buf)); + LOGP(DLGTP, LOGL_INFO, + "Rx duplicate seq=%" PRIu16 " from %s, retrans resp\n", seq, buf); + if (fcntl(qmsg->fd, F_SETFL, 0)) { LOGP(DLGTP, LOGL_ERROR, "fnctl()\n"); return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8bc9143db6743ad4fae2fe6d6fe0417648e9eec9 Gerrit-Change-Number: 27414 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Use switch statement in gtp_create_pdp_ind()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27413 ) Change subject: gtp: Use switch statement in gtp_create_pdp_ind() ...................................................................... gtp: Use switch statement in gtp_create_pdp_ind() Double if had to be changed to if-else anyway, so let's simply use a switch statement. Change-Id: I91e8722947e58776742521d89abef8ae7584cb25 --- M gtp/gtp.c 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/gtp/gtp.c b/gtp/gtp.c index 829d2d2..3051255 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1554,7 +1554,8 @@ GTPCAUSE_INVALID_MESSAGE); } - if (version == 1) { + switch (version) { + case 1: /* Linked NSAPI (conditional) */ /* If included this is the Secondary PDP Context Activation Procedure */ /* In secondary activation IMSI is not included, so the context must be */ @@ -1646,9 +1647,9 @@ if (gtpie_gettlv(ie, GTPIE_TFT, 0, &pdp->tft.l, &pdp->tft.v, sizeof(pdp->tft.v))) { } - } - /* if (version == 1) */ - if (version == 0) { + break; /* version 1 */ + + case 0: if (gtpie_gettv0(ie, GTPIE_QOS_PROFILE0, 0, pdp->qos_req0, sizeof(pdp->qos_req0))) { gsn->missing++; @@ -1671,6 +1672,7 @@ return gtp_create_pdp_resp(gsn, version, pdp, GTPCAUSE_MAN_IE_MISSING); } + break; } /* SGSN address for signalling (mandatory) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I91e8722947e58776742521d89abef8ae7584cb25 Gerrit-Change-Number: 27413 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Log retrans queue register&free entries

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27417 ) Change subject: gtp: Log retrans queue register&free entries ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4e12376652fc7a6a96fbdcb579dbe916c1473012 Gerrit-Change-Number: 27417 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 10:17:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Fix typo in comment

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27419 ) Change subject: gtp: Fix typo in comment ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0e38e0966081d8b37c3f816f5330b4f52f81b7fa Gerrit-Change-Number: 27419 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 10:15:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Log retrans queue register&free entries

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27417 ) Change subject: gtp: Log retrans queue register&free entries ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4e12376652fc7a6a96fbdcb579dbe916c1473012 Gerrit-Change-Number: 27417 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 10:15:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: gtp: Use switch statement in gtp_create_pdp_ind()

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27413 ) Change subject: gtp: Use switch statement in gtp_create_pdp_ind() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I91e8722947e58776742521d89abef8ae7584cb25 Gerrit-Change-Number: 27413 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 10:12:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: lib/DIAMETER: Allow sending CEA with AuthAppId

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27424 to look at the new patch set (#3). Change subject: lib/DIAMETER: Allow sending CEA with AuthAppId ...................................................................... lib/DIAMETER: Allow sending CEA with AuthAppId The new message is to be used by Gy interface emulation, which according to RFC4006 uses AppId 4 "Credit Control Application". The application is apparently not 3GPP vendor specific. Change-Id: I0e33673d65140aad34d2efcae3c7f49154ceb99f --- M ggsn_tests/GGSN_Tests.ttcn M library/DIAMETER_Emulation.ttcn M library/DIAMETER_Templates.ttcn M mme/MME_Tests.ttcn M pgw/PGW_Tests.ttcn 5 files changed, 41 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/27424/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e33673d65140aad34d2efcae3c7f49154ceb99f Gerrit-Change-Number: 27424 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: osmo_time_cc: rate_ctr presence should not affect counting

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27425 ) Change subject: osmo_time_cc: rate_ctr presence should not affect counting ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I380b28d7ab0a6c8aab6c7e2a64bc73cab14863d2 Gerrit-Change-Number: 27425 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 10:05:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn_tests: Wait for retrans queues to drain after each test

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27420 ) Change subject: ggsn_tests: Wait for retrans queues to drain after each test ...................................................................... ggsn_tests: Wait for retrans queues to drain after each test Otherwise a new test may reuse the same GTP seqnum, and if it's still in the gtp retransmit resp queue of the GGSN, it may be identified as a duplicate retransmittion of a previous message (previous test) and send back the previous response instead of processing the request. Related: OS#5485 Change-Id: I1b04691987b883f63c95c0322a477db4a43df2b1 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 50 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 05d335a..eb09555 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -259,6 +259,17 @@ } } + function f_shutdown_helper() runs on GT_CT { + /* Sleep N3_REQUESTS * T3_REQUEST seconds, nowadays 5*3=15s. + * This ensures all retransmit queues are cleared before jumping + * into next tests, hence avoding situation where a test resuses + * a seqnum still in the GGSN's resp queue (dup req detector). + * See OS#5485 avout decreasing time. We could also add a new + * VTY command that calls gtp_clear_queues() */ + f_sleep(15.0); + setverdict(pass); + } + /* Altstep implementing responses to any incoming echo requests */ private altstep pingpong() runs on GT_CT { var Gtp1cUnitdata ud; @@ -1023,6 +1034,7 @@ var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInet6, valueof(t_EuaIPv6Dyn))); f_pdp_ctx_act(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test IPv6 context activation for dynamic IPv6 EUA wirh request of IPv6 DNS in PCO */ @@ -1046,6 +1058,7 @@ } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv6 EUA with IPv6 DNS in PCO and router solicitation/advertisement */ @@ -1065,6 +1078,7 @@ f_send_gtpu(ctx, f_gen_icmpv6_neigh_solicit_for_pdp(ctx)); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv6 EUA with IPv6 DNS in PCO and router solicitation/advertisement. @@ -1096,6 +1110,7 @@ f_wait_icmp6_echo_reply(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Check that attempting RA with another ll src addr won't work, packet dropped: */ @@ -1115,6 +1130,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Assert that packets with wrong global src addr are dropped by GGSN */ @@ -1135,6 +1151,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Send an IPv4 ICMP ECHO REQUEST to APN6, should fail (packet dropped */ @@ -1154,6 +1171,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Validate if different clients (pdp ctx) can reach one another through GGSN. */ @@ -1186,6 +1204,7 @@ f_pdp_ctx_del(ctxA, '1'B); f_pdp_ctx_del(ctxB, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA without DNS request */ @@ -1194,6 +1213,7 @@ var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn))); f_pdp_ctx_act(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in IPCP */ @@ -1219,6 +1239,7 @@ } } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in IPCP + PAP authentication (broken) */ @@ -1252,6 +1273,7 @@ setverdict(fail, "PAP isn't an AuthenticateAck: ", pap); } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in PCO */ @@ -1274,6 +1296,7 @@ } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4 EUA. @@ -1293,6 +1316,7 @@ f_wait_icmp4_echo_reply(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Assert that packets with wrong global src addr are dropped by GGSN */ @@ -1310,6 +1334,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Send an IPv6 RA to APN4, should fail (packet dropped) */ @@ -1325,6 +1350,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Helper function for tests below. */ @@ -1347,12 +1373,14 @@ testcase TC_pdp4_clients_interact_with_txseq() runs on GT_CT { use_gtpu_txseq := true; f_pdp4_clients_interact(); + f_shutdown_helper(); } /* Validate if different clients (pdp ctx) can reach one another through GGSN (without Tx sequence number). */ testcase TC_pdp4_clients_interact_without_txseq() runs on GT_CT { use_gtpu_txseq := false; f_pdp4_clients_interact(); + f_shutdown_helper(); } testcase TC_echo_req_resp() runs on GT_CT { @@ -1365,6 +1393,7 @@ [] T_default.timeout { setverdict(fail); } } T_default.stop; + f_shutdown_helper(); } testcase TC_echo_req_resp_gtpu() runs on GT_CT { @@ -1377,6 +1406,7 @@ [] T_default.timeout { setverdict(fail); } } T_default.stop; + f_shutdown_helper(); } /* Test if the parser can cope with PCO that only contain either a @@ -1422,6 +1452,7 @@ setverdict(fail, "Secondary DNS IPv4 PCO option not found"); } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test if the parser can cope with PCO that contains primary and secondary DNS in a separate IPCP container. @@ -1458,6 +1489,7 @@ setverdict(fail, "Secondary DNS IPv4 PCO option not found"); } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Validate that SUT updates remote TEIC when requested through UpdatePDPContextRequest */ @@ -1473,6 +1505,7 @@ f_pdp_ctx_update(ctx, new_teic := new_teic); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Validate that SUT updates remote TEID when requested through UpdatePDPContextRequest */ @@ -1500,6 +1533,7 @@ f_wait_icmp4_echo_reply(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA without DNS request */ @@ -1508,6 +1542,7 @@ var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInet46, valueof(t_EuaIPv4Dynv6Dyn))); f_pdp_ctx_act(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4v6 EUA with IPv4 DNS in IPCP */ @@ -1534,6 +1569,7 @@ } } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4v6 EUA with IPv6 DNS in PCO and router solicitation/advertisement */ @@ -1548,6 +1584,7 @@ f_send_gtpu(ctx, f_gen_icmpv6_neigh_solicit_for_pdp46(ctx)); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA with request of IPv4 DNS in PCO */ @@ -1571,6 +1608,7 @@ } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA with request of IPv6 DNS in PCO */ @@ -1594,6 +1632,7 @@ } f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Test PDP context activation for dynamic IPv4v6 EUA. @@ -1612,6 +1651,7 @@ f_wait_icmp4_echo_reply(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Assert that packets with wrong ipv4 src addr are dropped by GGSN on APN IPv4v6 */ @@ -1628,6 +1668,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Check that attempting RA with another ll src addr won't work, packet dropped: */ @@ -1643,6 +1684,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Assert that packets with wrong ipv6 global src addr are dropped by GGSN on APN IPv4v6 */ @@ -1663,6 +1705,7 @@ f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); } /* Validate if different clients (pdp ctx) can reach one another through GGSN. */ @@ -1695,6 +1738,7 @@ f_pdp_ctx_del(ctxA, '1'B); f_pdp_ctx_del(ctxB, '1'B); + f_shutdown_helper(); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA on a v4-only APN */ @@ -1733,6 +1777,7 @@ f_pdp_ctx_del(ctx4, '1'B); } + f_shutdown_helper(); } /* Validate if 2nd CtxCreateReq with increased Recovery IE causes ggsn to drop 1st one (while keeping 2nd one). */ @@ -1795,6 +1840,7 @@ T_default.stop; f_pdp_ctx_del(ctxB, '1'B); + f_shutdown_helper(); } @@ -1817,6 +1863,7 @@ /* Now send a new pdp ctx del (increased seqnum). It should fail with cause "non-existent": */ var OCT1 cause_nonexistent := 'C0'O; f_pdp_ctx_del(ctx, '1'B, cause_nonexistent, expect_diameter := false); + f_shutdown_helper(); } /* Activate PDP context + trigger Recovery procedure through EchoResp */ @@ -1859,7 +1906,7 @@ } T_echo.stop; f_pdp_ctx_exp_del_req(ctx, omit, true); - setverdict(pass); + f_shutdown_helper(); } /* Test creation, user plane and deletion of big amount (1000) of concurrent PDP context */ @@ -1972,7 +2019,7 @@ T_next.stop; T_default.stop; - setverdict(pass); + f_shutdown_helper(); } /* Test callocation of PDP contexts until reaching addr pool exhaustion */ @@ -2073,7 +2120,7 @@ T_next.stop; T_default.stop; - setverdict(pass); + f_shutdown_helper(); } control { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b04691987b883f63c95c0322a477db4a43df2b1 Gerrit-Change-Number: 27420 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022