March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: fix inp_sig_cb(): dispatch TS_EV_OML_DOWN to all transceivers

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16352 ) Change subject: fix inp_sig_cb(): dispatch TS_EV_OML_DOWN to all transceivers ...................................................................... fix inp_sig_cb(): dispatch TS_EV_OML_DOWN to all transceivers When running a multi-trx setup, upon stopping osmo-bts one can see: DCHAN ERROR lchan_fsm.c:80 lchan(0-1-7-TCH_F-0)[0x612000010120]{UNUSED}: (type=NONE) lchan allocation failed in state UNUSED: LCHAN_EV_TS_ERROR DCHAN ERROR lchan_fsm.c:144 lchan(0-1-7-TCH_F-0)[0x612000010120]{UNUSED}: (type=NONE) lchan activation failed (lchan allocation failed in state UNUSED: LCHAN_EV_TS_ERROR) These messages show up when the following conditions are met: * BTS model speaks A-bis over IP (ip.access, e.g. nanoBTS), and * BTS has more than one transceiver configured. The problem is that unlike traditional E1 based BTS models, ip.access ones have a single global A-bis/OML link for all transceivers. Thus when it goes down, in inp_sig_cb() we need to notify all timeslots *of all TRXes*, not just TRX0. Change-Id: I3dc657ac5a2c5334747bd4f4db1a658acb323942 Fixes: OS#5479 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 167b0a3..3c8f381 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -465,7 +465,12 @@ if (isd->link_type == E1INP_SIGN_OML) { rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_OML_FAIL)); - all_ts_dispatch_event(trx, TS_EV_OML_DOWN); + /* ip.access BTS models have a single global A-bis/OML link for all + * transceivers, so once it's lost we need to notify them all. */ + if (is_ipaccess_bts(trx->bts)) + gsm_bts_all_ts_dispatch(trx->bts, TS_EV_OML_DOWN, NULL); + else /* Other BTS models (e.g. Ericsson) have per-TRX OML links */ + gsm_trx_all_ts_dispatch(trx, TS_EV_OML_DOWN, NULL); } else if (isd->link_type == E1INP_SIGN_RSL) { rate_ctr_inc(rate_ctr_group_get_ctr(trx->bts->bts_ctrs, BTS_CTR_BTS_RSL_FAIL)); acc_ramp_abort(&trx->bts->acc_ramp); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/16352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3dc657ac5a2c5334747bd4f4db1a658acb323942 Gerrit-Change-Number: 16352 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_iu_attach_encr with UEA > 0

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428 ) Change subject: sgsn: add TC_iu_attach_encr with UEA > 0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a7c3b156830058c43f15f55883ea301d2d01d5f Gerrit-Change-Number: 27428 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 08:29:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-sgsn[master]: Iu: add UEA encryption

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/27427 ) Change subject: Iu: add UEA encryption ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/27427/comment/50984a53_c18ebaf2 PS3, Line 926: * away from it a long time ago. */ Create an issue and reference it here, and maybe shorten the comment? same below and in the commit message. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/27427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I27e8e0078c45426bf227bb44aac82a4875d18d0f Gerrit-Change-Number: 27427 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 08:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: VTY: fix ambiguity in BTS specific command definitions

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27412 ) Change subject: VTY: fix ambiguity in BTS specific command definitions ...................................................................... VTY: fix ambiguity in BTS specific command definitions Most of the BTS specific VTY commands restrict BTS number to '<0-0>', while bts_c0_power_red_cmd has '<0-255>'. This confuses libosmovty: OsmoBTS# bts ? <0-0> BTS number <0-255> BTS Number OsmoBTS# bts 0 ? % Ambiguous command. OsmoBTS# bts 0 c0-power-red 0 % Ambiguous command. Let's stick to '<0-0>', we don't support multiple BTS anyway. Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 --- M src/common/vty.c M tests/osmo-bts.vty 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/vty.c b/src/common/vty.c index 97bd658..8925999 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -1329,7 +1329,7 @@ DEFUN(bts_c0_power_red, bts_c0_power_red_cmd, - "bts <0-255> c0-power-red <0-6>", + "bts <0-0> c0-power-red <0-6>", "BTS Specific Commands\n" BTS_NR_STR "BCCH carrier power reduction operation\n" "Power reduction value (in dB, even numbers only)\n") diff --git a/tests/osmo-bts.vty b/tests/osmo-bts.vty index fb74747..c4b6618 100644 --- a/tests/osmo-bts.vty +++ b/tests/osmo-bts.vty @@ -107,7 +107,7 @@ show timer [(bts|abis)] [TNNNN] bts <0-0> trx <0-255> ts <0-7> (lchan|shadow-lchan) <0-7> rtp jitter-buffer <0-10000> test send-failure-event-report <0-255> - bts <0-255> c0-power-red <0-6> + bts <0-0> c0-power-red <0-6> show e1_driver show e1_line [<0-255>] [stats] show e1_timeslot [<0-255>] [<0-31>] -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 Gerrit-Change-Number: 27412 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: VTY: fix ambiguity in BTS specific command definitions

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27412 ) Change subject: VTY: fix ambiguity in BTS specific command definitions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6 Gerrit-Change-Number: 27412 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 07:23:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: fix inp_sig_cb(): dispatch TS_EV_OML_DOWN to all transceivers

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16352 ) Change subject: fix inp_sig_cb(): dispatch TS_EV_OML_DOWN to all transceivers ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/16352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3dc657ac5a2c5334747bd4f4db1a658acb323942 Gerrit-Change-Number: 16352 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 07:23:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: cosmetic: use rate_ctr_inc2() instead of rate_ctr_inc()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27410 ) Change subject: osmo-bts-trx: cosmetic: use rate_ctr_inc2() instead of rate_ctr_inc() ...................................................................... osmo-bts-trx: cosmetic: use rate_ctr_inc2() instead of rate_ctr_inc() Change-Id: Id4c5999876ff284b80a021e075bf46eb9d4670a2 Related: SYS#5855 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 0534086..8118223 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -161,7 +161,7 @@ br->fn, br->tn, SCHED_FH_PARAMS_VALS(ts)); struct bts_trx_priv *priv = (struct bts_trx_priv *) ts->trx->bts->model_priv; - rate_ctr_inc(rate_ctr_group_get_ctr(priv->ctrs, BTSTRX_CTR_SCHED_DL_FH_NO_CARRIER)); + rate_ctr_inc2(priv->ctrs, BTSTRX_CTR_SCHED_DL_FH_NO_CARRIER); return NULL; } @@ -347,7 +347,7 @@ bi->fn, bi->tn, SCHED_FH_PARAMS_VALS(&src_trx->ts[bi->tn])); struct bts_trx_priv *priv = (struct bts_trx_priv *) src_trx->bts->model_priv; - rate_ctr_inc(rate_ctr_group_get_ctr(priv->ctrs, BTSTRX_CTR_SCHED_UL_FH_NO_CARRIER)); + rate_ctr_inc2(priv->ctrs, BTSTRX_CTR_SCHED_UL_FH_NO_CARRIER); return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id4c5999876ff284b80a021e075bf46eb9d4670a2 Gerrit-Change-Number: 27410 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27411 ) Change subject: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss' ...................................................................... osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss' This new rate counter allows to monitor the efficiency of the radio carrier cache used for routing Downlink bursts when baseband frequency hopping is in use. Change-Id: Ie6da829e47298476267c8df2dcedafad564cbbb4 Related: SYS#5855 --- M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/main.c M src/osmo-bts-trx/scheduler_trx.c 3 files changed, 8 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/l1_if.h b/src/osmo-bts-trx/l1_if.h index 50369d9..18d84c2 100644 --- a/src/osmo-bts-trx/l1_if.h +++ b/src/osmo-bts-trx/l1_if.h @@ -30,6 +30,7 @@ enum { BTSTRX_CTR_SCHED_DL_MISS_FN, BTSTRX_CTR_SCHED_DL_FH_NO_CARRIER, + BTSTRX_CTR_SCHED_DL_FH_CACHE_MISS, BTSTRX_CTR_SCHED_UL_FH_NO_CARRIER, }; diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c index 5d680f0..75b15fe 100644 --- a/src/osmo-bts-trx/main.c +++ b/src/osmo-bts-trx/main.c @@ -70,6 +70,10 @@ "trx_sched:dl_fh_no_carrier", "Frequency hopping: no carrier found for a Downlink burst (check hopping parameters)" }, + [BTSTRX_CTR_SCHED_DL_FH_CACHE_MISS] = { + "trx_sched:dl_fh_cache_miss", + "Frequency hopping: no Downlink carrier found in cache (lookup performed)" + }, [BTSTRX_CTR_SCHED_UL_FH_NO_CARRIER] = { "trx_sched:ul_fh_no_carrier", "Frequency hopping: no carrier found for an Uplink burst (check hopping parameters)" diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 8118223..3a6418b 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -148,9 +148,12 @@ if (ts->fh_trx_list[idx] != NULL) return ts->fh_trx_list[idx]->pinst; + struct bts_trx_priv *priv = (struct bts_trx_priv *) ts->trx->bts->model_priv; + /* The "cache" may not be filled yet, lookup the transceiver */ llist_for_each_entry(trx, &ts->trx->bts->trx_list, list) { if (trx->arfcn == ts->hopping.arfcn_list[idx]) { + rate_ctr_inc2(priv->ctrs, BTSTRX_CTR_SCHED_DL_FH_CACHE_MISS); ts->fh_trx_list[idx] = trx; return trx->pinst; } @@ -160,7 +163,6 @@ "for a Downlink burst (fn=%u, tn=%u, " SCHED_FH_PARAMS_FMT ")\n", br->fn, br->tn, SCHED_FH_PARAMS_VALS(ts)); - struct bts_trx_priv *priv = (struct bts_trx_priv *) ts->trx->bts->model_priv; rate_ctr_inc2(priv->ctrs, BTSTRX_CTR_SCHED_DL_FH_NO_CARRIER); return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie6da829e47298476267c8df2dcedafad564cbbb4 Gerrit-Change-Number: 27411 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27411 ) Change subject: osmo-bts-trx: new rate counter 'trx_sched:dl_fh_cache_miss' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie6da829e47298476267c8df2dcedafad564cbbb4 Gerrit-Change-Number: 27411 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 07:22:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: cosmetic: use rate_ctr_inc2() instead of rate_ctr_inc()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27410 ) Change subject: osmo-bts-trx: cosmetic: use rate_ctr_inc2() instead of rate_ctr_inc() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id4c5999876ff284b80a021e075bf46eb9d4670a2 Gerrit-Change-Number: 27410 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 07:21:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022