March 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: ttcn3-ggsn-ogs: Use new bind_dev config option for GTP sockets

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27354 ) Change subject: ttcn3-ggsn-ogs: Use new bind_dev config option for GTP sockets ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie23db8ffb4868e4bc75783e2f6eb7a725b376ea7 Gerrit-Change-Number: 27354 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 15 Mar 2022 13:54:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27511 ) Change subject: bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic3dfc4e31a7ed078cdfdaced9986ee9551c5aa7c Gerrit-Change-Number: 27511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 10:22:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add f_cipher_mode_bssmap_to_rr()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27518 ) Change subject: bsc: add f_cipher_mode_bssmap_to_rr() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cc8cbed96f2838af1b0e41c5dfa6760c45d9ad1 Gerrit-Change-Number: 27518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 10:21:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: use select() statement in f_cipher_mode_bssmap_to_rsl()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27517 ) Change subject: bsc: use select() statement in f_cipher_mode_bssmap_to_rsl() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e1c6762d2dd1efac2bd7ead3caf25e25dd3e7ad Gerrit-Change-Number: 27517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Mar 2022 10:21:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[2021q4]: gsm48_make_ho_cmd(): make 'struct gsm_lchan' pointer const

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27513 ) Change subject: gsm48_make_ho_cmd(): make 'struct gsm_lchan' pointer const ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2021q4 Gerrit-Change-Id: I731179bf7f5d711ca114e36af661faccf0caa19f Gerrit-Change-Number: 27513 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 22:25:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add altstep as_dl_sacch_lapdm_ab

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27519 ) Change subject: BTS_Tests: add altstep as_dl_sacch_lapdm_ab ...................................................................... BTS_Tests: add altstep as_dl_sacch_lapdm_ab Change-Id: I3ba17683892e8aa1694bb6dd32d8b37660020026 --- M bts/BTS_Tests.ttcn 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/27519/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 1d3dfe7..3a3d7cc 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -917,6 +917,27 @@ } } +/* This altstep triggers on receipt of a Downlink SACCH containing a L2 payload + * that matches the given LAPDm frame, as well as the given SACCH L1 header. */ +private altstep as_dl_sacch_lapdm_ab(out SacchL1Header l1h, out LapdmFrameAB frame, + template (present) LapdmFrameAB tr_frame := ?, + template (present) SacchL1Header tr_l1h := ?, + template (present) GsmSapi sapi := ?) +runs on ConnHdlr { + var L1ctlDlMessage dl_msg; + template (present) RslLinkId link_id := tr_RslLinkID_SACCH(sapi); + template (present) L1ctlDataReq tr_data := { + l1header := tr_l1h, + l2_payload := decmatch tr_frame + }; + + [] as_l1ctl_dl_msg(dl_msg, decmatch tr_data, g_chan_nr, link_id) { + var octetstring data := dl_msg.payload.data_ind.payload; + l1h := dec_SacchL1Header(substr(data, 0, 2)); + frame := dec_LapdmFrameAB(substr(data, 2, lengthof(data) - 2)); + } +} + /* This altstep is built on top of as_dl_dcch_lapdm_ab(), and triggers on receipt * of a LAPDm AB frame with a L3 payload matching the given template. The L3 * payload is treated as PDU_ML3_NW_MS. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ba17683892e8aa1694bb6dd32d8b37660020026 Gerrit-Change-Number: 27519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27511 ) Change subject: bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3 ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic3dfc4e31a7ed078cdfdaced9986ee9551c5aa7c Gerrit-Change-Number: 27511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 19:37:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add f_cipher_mode_bssmap_to_rr()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27518 ) Change subject: bsc: add f_cipher_mode_bssmap_to_rr() ...................................................................... bsc: add f_cipher_mode_bssmap_to_rr() Change-Id: I6cc8cbed96f2838af1b0e41c5dfa6760c45d9ad1 Related: SYS#5838 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/27518/1 diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index a37a3b8..b0daf61 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -797,6 +797,26 @@ } } +/* Convert the cipher representation on BSSMAP to the one used on RR (3GPP TS 44.018) */ +function f_cipher_mode_bssmap_to_rr(OCT1 alg_bssmap) return BIT3 +{ + select (alg_bssmap) { + case ('01'O) /* A5/0 */ { return '000'B; } /* SC=0 */ + case ('02'O) /* A5/1 */ { return '000'B; } /* SC=1 */ + case ('04'O) /* A5/2 */ { return '001'B; } /* SC=1 */ + case ('08'O) /* A5/3 */ { return '010'B; } /* SC=1 */ + case ('10'O) /* A5/4 */ { return '011'B; } /* SC=1 */ + case ('20'O) /* A5/5 */ { return '100'B; } /* SC=1 */ + case ('40'O) /* A5/6 */ { return '101'B; } /* SC=1 */ + case ('80'O) /* A5/7 */ { return '110'B; } /* SC=1 */ + case else { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected Encryption Algorithm: " & + oct2str(alg_bssmap)); + return '000'B; + } + } +} + function f_verify_encr_info(RSL_Message rsl) runs on MSC_ConnHdlr { var RSL_IE_Body encr_info; var RSL_AlgId alg_rsl; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cc8cbed96f2838af1b0e41c5dfa6760c45d9ad1 Gerrit-Change-Number: 27518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: use select() statement in f_cipher_mode_bssmap_to_rsl()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27517 ) Change subject: bsc: use select() statement in f_cipher_mode_bssmap_to_rsl() ...................................................................... bsc: use select() statement in f_cipher_mode_bssmap_to_rsl() Change-Id: I6e1c6762d2dd1efac2bd7ead3caf25e25dd3e7ad Related: SYS#5838 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 11 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/27517/1 diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index 95cdb7c..a37a3b8 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -780,41 +780,20 @@ /* Convert the cipher representation on BSSMAP to the representation used on RSL */ function f_cipher_mode_bssmap_to_rsl(OCT1 alg_bssmap) return RSL_AlgId { - /* A5 0 */ - if (alg_bssmap == '01'O) { - return RSL_ALG_ID_A5_0; - } - /* A5 1 */ - else if (alg_bssmap == '02'O) { - return RSL_ALG_ID_A5_1; - } - /* A5 2 */ - else if (alg_bssmap == '04'O) { - return RSL_ALG_ID_A5_2; - } - /* A5 3 */ - else if (alg_bssmap == '08'O) { - return RSL_ALG_ID_A5_3; - } - /* A5 4 */ - else if (alg_bssmap == '10'O) { - return RSL_ALG_ID_A5_4; - } - /* A5 5 */ - else if (alg_bssmap == '20'O) { - return RSL_ALG_ID_A5_5; - } - /* A5 6 */ - else if (alg_bssmap == '40'O) { - return RSL_ALG_ID_A5_6; - } - /* A5 7 */ - else if (alg_bssmap == '80'O) { - return RSL_ALG_ID_A5_7; - } else { + select (alg_bssmap) { + case ('01'O) { return RSL_ALG_ID_A5_0; } + case ('02'O) { return RSL_ALG_ID_A5_1; } + case ('04'O) { return RSL_ALG_ID_A5_2; } + case ('08'O) { return RSL_ALG_ID_A5_3; } + case ('10'O) { return RSL_ALG_ID_A5_4; } + case ('20'O) { return RSL_ALG_ID_A5_5; } + case ('40'O) { return RSL_ALG_ID_A5_6; } + case ('80'O) { return RSL_ALG_ID_A5_7; } + case else { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected Encryption Algorithm: " & oct2str(alg_bssmap)); return RSL_ALG_ID_A5_0; + } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e1c6762d2dd1efac2bd7ead3caf25e25dd3e7ad Gerrit-Change-Number: 27517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-bsc[2021q4]: gsm48_make_ho_cmd(): make 'struct gsm_lchan' pointer const

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27513 ) Change subject: gsm48_make_ho_cmd(): make 'struct gsm_lchan' pointer const ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Why is this backported? This patch is not really required, but made cherry-picking the actual bugfix patches easier for me (with no conflicts). Shall I abandon it and rework the patches above (thus spend additional time achieving the identical result)? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2021q4 Gerrit-Change-Id: I731179bf7f5d711ca114e36af661faccf0caa19f Gerrit-Change-Number: 27513 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 18:30:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022