March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add altstep as_dl_sacch_lapdm_ab

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27519 ) Change subject: BTS_Tests: add altstep as_dl_sacch_lapdm_ab ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ba17683892e8aa1694bb6dd32d8b37660020026 Gerrit-Change-Number: 27519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:51:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration

by laforge

Attention is currently required from: iedemam, neels, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 16: Code-Review+1 (1 comment) Patchset: PS15: > I realized that osmo_time_cc does behave differently when there is no rate_ctr. […] that patch is now merged, FYI -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 16 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix HR SID detection (wrong offset)

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27430 ) Change subject: osmo-bts-trx: rx_tchh_fn(): fix HR SID detection (wrong offset) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie5fa776dcb2b2203a97aed56ecbf2450af7d87c1 Gerrit-Change-Number: 27430 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:49:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): mark valid SID frames as such

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27520 ) Change subject: osmo-bts-trx: rx_tchh_fn(): mark valid SID frames as such ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09cec984bb60c754908126acf0300a2cc602485c Gerrit-Change-Number: 27520 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:48:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): mark valid SID frames as such

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27520 ) Change subject: osmo-bts-trx: rx_tchh_fn(): mark valid SID frames as such ...................................................................... Patch Set 1: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27520/comment/3a4bca52_f329dc14 PS1, Line 154: tch_data[0] = (0x02 << 4); > why aren't you using enum osmo_amr_type here? Furthermore, 2 seems to be AMR_5_90, not sure why that […] This branch has nothing to do with AMR... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I09cec984bb60c754908126acf0300a2cc602485c Gerrit-Change-Number: 27520 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:48:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27511 ) Change subject: bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3 ...................................................................... bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3 According to 3GPP TS 44.018, section 9.1.15, the RR Handover Command message may optionally contain the Cipher Mode Setting IE (10.5.2.9). Section 9.1.15.10 states that this IE may be omitted in case of the intra-RAT GERAN-to-GERAN handover, however in case of the inter-RAT handover (e.g. EUTRAN-to-GERAN), this IE *shall* always be included. In f_ho_into_this_bsc(), check presence and correctness of the Cipher Mode Setting IE. Add TC_srvcc_eutran_to_geran_a5_3, which is similar to TC_srvcc_eutran_to_geran, but enables ciphering on the target channel. This patch makes all SRVCC relates test cases fail, until [1] is merged. Change-Id: Ic3dfc4e31a7ed078cdfdaced9986ee9551c5aa7c Related: [1] osmo-bsc.git I1d270e82d0a9b12897fc94dae4e8999aa132a22f Related: SYS#5838 --- M bsc/BSC_Tests.ttcn M bsc/expected-results.xml 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 8f70452..758b989 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6115,6 +6115,26 @@ log("handoverCommand: verified TSC = ", got_tsc); } + /* Check the Cipher Mode Setting IE (shall be present during inter-RAT handover) */ + if (ispresent(ho_command.msgs.rrm.handoverCommand.cipherModeSetting)) { + var CipherModeSetting_TV cms := ho_command.msgs.rrm.handoverCommand.cipherModeSetting; + var template (present) CipherModeSetting_TV tr_cms := { + sC := '0'B, /* no ciphering by default */ + algorithmIdentifier := '000'B, + elementIdentifier := ? + }; + if (ispresent(g_pars.encr) and g_pars.encr.enc_alg_expect != '01'O) { /* A5/N */ + tr_cms.algorithmIdentifier := f_cipher_mode_bssmap_to_rr(g_pars.encr.enc_alg_expect); + tr_cms.sC := '1'B; + } + if (not match(cms, tr_cms)) { + setverdict(fail, "RR Handover Command: unexpected Cipher Mode Setting IE: ", + cms, ", expected: ", tr_cms); + } + } else { + setverdict(fail, "RR Handover Command: Cipher Mode Setting IE is not present"); + } + /* Now the MSC forwards the RR Handover Command to the other BSC, which * tells the MS to handover to the new lchan. Here comes the new MS on * the new lchan with a Handover RACH: */ @@ -6260,6 +6280,20 @@ f_shutdown_helper(); } +/* Same as TC_srvcc_eutran_to_geran, but enables ciphering on the target channel. */ +testcase TC_srvcc_eutran_to_geran_a5_3() runs on test_CT { + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + pars.encr := f_encr_params('08'O); /* only A5/3 */ + pars.last_used_eutran_plmn := '323454'O; + pars.exp_fast_return := true; + f_tc_ho_into_this_bsc_main(pars); + + f_ctrs_bsc_and_bts_add(0, "srvcc:attempted"); + f_ctrs_bsc_and_bts_add(0, "srvcc:completed"); + f_ctrs_bsc_and_bts_verify(); + f_shutdown_helper(); +} + /* Same as TC_srvcc_eutran_to_geran, but test explicitly forbiding fast return on the BTS. As a result, RR Release shouldn't contain the EUTRAN neighbor list when the channel is released. */ @@ -11367,6 +11401,7 @@ execute( TC_ho_into_this_bsc_tla_v6() ); } execute( TC_srvcc_eutran_to_geran() ); + execute( TC_srvcc_eutran_to_geran_a5_3() ); execute( TC_srvcc_eutran_to_geran_src_sai() ); execute( TC_srvcc_eutran_to_geran_ho_out() ); execute( TC_srvcc_eutran_to_geran_forbid_fast_return() ); diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index f9f022e..572c657 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -157,6 +157,7 @@ <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_a5_4' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_tla_v6' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_a5_3' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_ho_out' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_forbid_fast_return' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_ho_out_forbid_fast_return' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic3dfc4e31a7ed078cdfdaced9986ee9551c5aa7c Gerrit-Change-Number: 27511 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: use select() statement in f_cipher_mode_bssmap_to_rsl()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27517 ) Change subject: bsc: use select() statement in f_cipher_mode_bssmap_to_rsl() ...................................................................... bsc: use select() statement in f_cipher_mode_bssmap_to_rsl() Change-Id: I6e1c6762d2dd1efac2bd7ead3caf25e25dd3e7ad Related: SYS#5838 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 11 insertions(+), 32 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index 95cdb7c..a37a3b8 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -780,41 +780,20 @@ /* Convert the cipher representation on BSSMAP to the representation used on RSL */ function f_cipher_mode_bssmap_to_rsl(OCT1 alg_bssmap) return RSL_AlgId { - /* A5 0 */ - if (alg_bssmap == '01'O) { - return RSL_ALG_ID_A5_0; - } - /* A5 1 */ - else if (alg_bssmap == '02'O) { - return RSL_ALG_ID_A5_1; - } - /* A5 2 */ - else if (alg_bssmap == '04'O) { - return RSL_ALG_ID_A5_2; - } - /* A5 3 */ - else if (alg_bssmap == '08'O) { - return RSL_ALG_ID_A5_3; - } - /* A5 4 */ - else if (alg_bssmap == '10'O) { - return RSL_ALG_ID_A5_4; - } - /* A5 5 */ - else if (alg_bssmap == '20'O) { - return RSL_ALG_ID_A5_5; - } - /* A5 6 */ - else if (alg_bssmap == '40'O) { - return RSL_ALG_ID_A5_6; - } - /* A5 7 */ - else if (alg_bssmap == '80'O) { - return RSL_ALG_ID_A5_7; - } else { + select (alg_bssmap) { + case ('01'O) { return RSL_ALG_ID_A5_0; } + case ('02'O) { return RSL_ALG_ID_A5_1; } + case ('04'O) { return RSL_ALG_ID_A5_2; } + case ('08'O) { return RSL_ALG_ID_A5_3; } + case ('10'O) { return RSL_ALG_ID_A5_4; } + case ('20'O) { return RSL_ALG_ID_A5_5; } + case ('40'O) { return RSL_ALG_ID_A5_6; } + case ('80'O) { return RSL_ALG_ID_A5_7; } + case else { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected Encryption Algorithm: " & oct2str(alg_bssmap)); return RSL_ALG_ID_A5_0; + } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e1c6762d2dd1efac2bd7ead3caf25e25dd3e7ad Gerrit-Change-Number: 27517 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add f_cipher_mode_bssmap_to_rr()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27518 ) Change subject: bsc: add f_cipher_mode_bssmap_to_rr() ...................................................................... bsc: add f_cipher_mode_bssmap_to_rr() Change-Id: I6cc8cbed96f2838af1b0e41c5dfa6760c45d9ad1 Related: SYS#5838 --- M bsc/MSC_ConnectionHandler.ttcn 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index a37a3b8..b0daf61 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -797,6 +797,26 @@ } } +/* Convert the cipher representation on BSSMAP to the one used on RR (3GPP TS 44.018) */ +function f_cipher_mode_bssmap_to_rr(OCT1 alg_bssmap) return BIT3 +{ + select (alg_bssmap) { + case ('01'O) /* A5/0 */ { return '000'B; } /* SC=0 */ + case ('02'O) /* A5/1 */ { return '000'B; } /* SC=1 */ + case ('04'O) /* A5/2 */ { return '001'B; } /* SC=1 */ + case ('08'O) /* A5/3 */ { return '010'B; } /* SC=1 */ + case ('10'O) /* A5/4 */ { return '011'B; } /* SC=1 */ + case ('20'O) /* A5/5 */ { return '100'B; } /* SC=1 */ + case ('40'O) /* A5/6 */ { return '101'B; } /* SC=1 */ + case ('80'O) /* A5/7 */ { return '110'B; } /* SC=1 */ + case else { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected Encryption Algorithm: " & + oct2str(alg_bssmap)); + return '000'B; + } + } +} + function f_verify_encr_info(RSL_Message rsl) runs on MSC_ConnHdlr { var RSL_IE_Body encr_info; var RSL_AlgId alg_rsl; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cc8cbed96f2838af1b0e41c5dfa6760c45d9ad1 Gerrit-Change-Number: 27518 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27511 ) Change subject: bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic3dfc4e31a7ed078cdfdaced9986ee9551c5aa7c Gerrit-Change-Number: 27511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:47:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: add f_cipher_mode_bssmap_to_rr()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27518 ) Change subject: bsc: add f_cipher_mode_bssmap_to_rr() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cc8cbed96f2838af1b0e41c5dfa6760c45d9ad1 Gerrit-Change-Number: 27518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Mar 2022 12:47:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022