Attention is currently required from: manawyrm.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27281 )
Change subject: readme: Add info about the fork, list of added drivers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27281
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I54d3000d4535b9279f53a8c30870e897bdcf0f91
Gerrit-Change-Number: 27281
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Comment-Date: Tue, 22 Feb 2022 07:39:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27270 )
Change subject: GTP_Codec_Port: Check length field of GTPV1C received packets
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27270
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie9447b7ec7f7f5ee35cd0393265f5edb5578bdaf
Gerrit-Change-Number: 27270
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Feb 2022 06:17:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: manawyrm.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/dahdi-linux/+/27281
to look at the new patch set (#2).
Change subject: readme: Add info about the fork, list of added drivers
......................................................................
readme: Add info about the fork, list of added drivers
Change-Id: I54d3000d4535b9279f53a8c30870e897bdcf0f91
---
M README
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/81/27281/2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27281
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I54d3000d4535b9279f53a8c30870e897bdcf0f91
Gerrit-Change-Number: 27281
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: manawyrm.
laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27280 )
Change subject: zaphfc: Port support for HFC-S cards
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: Ifd09d82ea2b6d6245207609da849350db45d91f6
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-MessageType: deleteVote
Attention is currently required from: manawyrm.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27280 )
Change subject: zaphfc: Port support for HFC-S cards
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: Ifd09d82ea2b6d6245207609da849350db45d91f6
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 22:17:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: manawyrm.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/dahdi-linux/+/27280
to look at the new patch set (#2).
Change subject: zaphfc: Port support for HFC-S cards
......................................................................
zaphfc: Port support for HFC-S cards
This ports the current zaphfc driver from the Debian bullseye patchset.
Change-Id: Ifd09d82ea2b6d6245207609da849350db45d91f6
---
M drivers/dahdi/Kbuild
M drivers/dahdi/Kconfig
A drivers/dahdi/zaphfc/Kbuild
A drivers/dahdi/zaphfc/base.c
A drivers/dahdi/zaphfc/fifo.c
A drivers/dahdi/zaphfc/fifo.h
A drivers/dahdi/zaphfc/zaphfc.h
7 files changed, 2,611 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/80/27280/2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: Ifd09d82ea2b6d6245207609da849350db45d91f6
Gerrit-Change-Number: 27280
Gerrit-PatchSet: 2
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-MessageType: newpatchset
laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-tools/+/27275 )
Change subject: dahdi_pcap: Fix the use of the pkttype field
......................................................................
dahdi_pcap: Fix the use of the pkttype field
* pkttype is big-endian, so '3' is not valid, but htons(3)
* let's not use magic numbers but the actual #define PACKET_*
* differentiate PACKET_HOST (rx) from PACKET_OUTGOING (tx),
which makes wireshark properly show rx/tx packets, allows coloring
or filtering based on direction, etc.
Change-Id: I8c66a011a0fa0c5275bf3d5cf6b42064f02e28c0
---
M dahdi_pcap.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
manawyrm: Looks good to me, approved
diff --git a/dahdi_pcap.c b/dahdi_pcap.c
index 225fe78..0eadde3 100644
--- a/dahdi_pcap.c
+++ b/dahdi_pcap.c
@@ -41,6 +41,7 @@
#include <sys/ioctl.h>
#include <stdlib.h>
#include <getopt.h>
+#include <linux/if_packet.h>
#define BLOCK_SIZE 512
#define MAX_CHAN 16
@@ -161,7 +162,7 @@
hdr.caplen = res+sizeof(struct lapd_sll_hdr)-2;
hdr.len = res+sizeof(struct lapd_sll_hdr)-2;
- lapd->sll_pkttype = 3;
+ lapd->sll_pkttype = htons(is_read ? PACKET_HOST : PACKET_OUTGOING);
lapd->sll_hatype = 0;
lapd->sll_halen = htons(8);
// lapd->sll_addr = ???
--
To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/27275
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-tools
Gerrit-Branch: master
Gerrit-Change-Id: I8c66a011a0fa0c5275bf3d5cf6b42064f02e28c0
Gerrit-Change-Number: 27275
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: roox <mardnh(a)gmx.de>
Gerrit-MessageType: merged
Attention is currently required from: roox, laforge.
manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-tools/+/27275 )
Change subject: dahdi_pcap: Fix the use of the pkttype field
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/27275
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-tools
Gerrit-Branch: master
Gerrit-Change-Id: I8c66a011a0fa0c5275bf3d5cf6b42064f02e28c0
Gerrit-Change-Number: 27275
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: roox <mardnh(a)gmx.de>
Gerrit-Attention: roox <mardnh(a)gmx.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 21 Feb 2022 20:46:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: roox, laforge.
manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-tools/+/27273 )
Change subject: Fix compilation with gcc-10.2.0
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Interesting that it breaks on 10.2.0, it compiles fine on gcc version 11.2.0 (debian bookworm).
Still, good change.
--
To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/27273
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-tools
Gerrit-Branch: master
Gerrit-Change-Id: I1d6f46874f74e1dfc70cabf7c4a8b8cdae9af4fa
Gerrit-Change-Number: 27273
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: roox <mardnh(a)gmx.de>
Gerrit-Attention: roox <mardnh(a)gmx.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 21 Feb 2022 20:40:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/dahdi-tools/+/27277
to look at the new patch set (#2).
Change subject: add contrib/jenkins.sh for jenkins.osmocom.org build verification
......................................................................
add contrib/jenkins.sh for jenkins.osmocom.org build verification
Change-Id: I47701be92476ba9adfdf9783747c6c511cec1903
---
A contrib/jenkins.sh
1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-tools refs/changes/77/27277/2
--
To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/27277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-tools
Gerrit-Branch: master
Gerrit-Change-Id: I47701be92476ba9adfdf9783747c6c511cec1903
Gerrit-Change-Number: 27277
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-tools/+/27275 )
Change subject: dahdi_pcap: Fix the use of the pkttype field
......................................................................
dahdi_pcap: Fix the use of the pkttype field
* pkttype is big-endian, so '3' is not valid, but htons(3)
* let's not use magic numbers but the actual #define PACKET_*
* differentiate PACKET_HOST (rx) from PACKET_OUTGOING (tx),
which makes wireshark properly show rx/tx packets, allows coloring
or filtering based on direction, etc.
Change-Id: I8c66a011a0fa0c5275bf3d5cf6b42064f02e28c0
---
M dahdi_pcap.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-tools refs/changes/75/27275/1
diff --git a/dahdi_pcap.c b/dahdi_pcap.c
index 225fe78..0eadde3 100644
--- a/dahdi_pcap.c
+++ b/dahdi_pcap.c
@@ -41,6 +41,7 @@
#include <sys/ioctl.h>
#include <stdlib.h>
#include <getopt.h>
+#include <linux/if_packet.h>
#define BLOCK_SIZE 512
#define MAX_CHAN 16
@@ -161,7 +162,7 @@
hdr.caplen = res+sizeof(struct lapd_sll_hdr)-2;
hdr.len = res+sizeof(struct lapd_sll_hdr)-2;
- lapd->sll_pkttype = 3;
+ lapd->sll_pkttype = htons(is_read ? PACKET_HOST : PACKET_OUTGOING);
lapd->sll_hatype = 0;
lapd->sll_halen = htons(8);
// lapd->sll_addr = ???
--
To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/27275
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-tools
Gerrit-Branch: master
Gerrit-Change-Id: I8c66a011a0fa0c5275bf3d5cf6b42064f02e28c0
Gerrit-Change-Number: 27275
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-tools/+/27276 )
Change subject: dahdi_pcap: Allow caller to specify network / user mode
......................................................................
dahdi_pcap: Allow caller to specify network / user mode
A LAPD dissector (such as the one in wireshark) needs to know if
the local side is the user or the network in order to properly
decode/display the trace. This is encoded in the sll_addr field
whose first octet indicates if the local (capturing) node serves
as the network or user side of ISDN.
Change-Id: Ief575bc4118fe5f20ef4b374d29eca442b04dabb
---
M dahdi_pcap.c
1 file changed, 22 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/dahdi-tools refs/changes/76/27276/1
diff --git a/dahdi_pcap.c b/dahdi_pcap.c
index 0eadde3..1e69a36 100644
--- a/dahdi_pcap.c
+++ b/dahdi_pcap.c
@@ -101,7 +101,7 @@
return fd;
}
-int log_packet(struct chan_fds * fd, char is_read, pcap_dumper_t * dump)
+int log_packet(struct chan_fds * fd, char is_read, int we_are_network, pcap_dumper_t * dump)
{
unsigned char buf[BLOCK_SIZE * 4];
int res = 0;
@@ -165,7 +165,7 @@
lapd->sll_pkttype = htons(is_read ? PACKET_HOST : PACKET_OUTGOING);
lapd->sll_hatype = 0;
lapd->sll_halen = htons(8);
- // lapd->sll_addr = ???
+ lapd->sll_addr[0] = we_are_network;
lapd->sll_protocol[0] = 0x00;
lapd->sll_protocol[1] = 0x30;
@@ -198,10 +198,11 @@
printf("Usage: dahdi_pcap [OPTIONS]\n");
printf("Capture packets from DAHDI channels to pcap file\n\n");
printf("Options:\n");
- printf(" -p, --proto=[mtp2|lapd] The protocol to capture, default mtp2\n");
- printf(" -c, --chan=<channels> Comma separated list of channels to capture from, max %d. Mandatory\n", MAX_CHAN);
- printf(" -f, --file=<filename> The pcap file to capture to. Mandatory\n");
- printf(" -h, --help Display this text\n");
+ printf(" -p, --proto=[mtp2|lapd] The protocol to capture, default mtp2\n");
+ printf(" -c, --chan=<channels> Comma separated list of channels to capture from, max %d. Mandatory\n", MAX_CHAN);
+ printf(" -r, --role=[network|user] Is the local side the network or user side in ISDN?\n");
+ printf(" -f, --file=<filename> The pcap file to capture to. Mandatory\n");
+ printf(" -h, --help Display this text\n");
}
int main(int argc, char **argv)
@@ -211,6 +212,7 @@
int num_chans = 0;
int max_fd = 0;
int proto = DLT_MTP2_WITH_PHDR;
+ int we_are_network = 0;
int i;
int packetcount;
@@ -221,12 +223,13 @@
static struct option long_options[] = {
{"proto", required_argument, 0, 'p'},
{"chan", required_argument, 0, 'c'},
+ {"role", required_argument, 0, 'r'},
{"file", required_argument, 0, 'f'},
{"help", 0, 0, 'h'},
{0, 0, 0, 0}
};
- c = getopt_long(argc, argv, "p:c:f:?",
+ c = getopt_long(argc, argv, "p:c:r:f:?",
long_options, &option_index);
if (c == -1)
break;
@@ -269,6 +272,16 @@
}
max_fd++;
break;
+ case 'r':
+ if (!strcasecmp("network", optarg))
+ we_are_network = 1;
+ else if (!strcasecmp("user", optarg))
+ we_are_network = 0;
+ else {
+ fprintf(stderr, "Role must be user or network!\n");
+ exit(1);
+ }
+ break;
case 'f':
// File to capture to
filename=optarg;
@@ -318,11 +331,11 @@
{
if(FD_ISSET(chans[i].rfd, &rd_set))
{
- packetcount += log_packet(&chans[i], 1, dump);
+ packetcount += log_packet(&chans[i], 1, we_are_network, dump);
}
if(FD_ISSET(chans[i].tfd, &rd_set))
{
- packetcount += log_packet(&chans[i], 0, dump);
+ packetcount += log_packet(&chans[i], 0, we_are_network, dump);
}
}
printf("Packets captured: %d\r", packetcount);
--
To view, visit https://gerrit.osmocom.org/c/dahdi-tools/+/27276
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-tools
Gerrit-Branch: master
Gerrit-Change-Id: Ief575bc4118fe5f20ef4b374d29eca442b04dabb
Gerrit-Change-Number: 27276
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: iedemam, neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )
Change subject: WIP: New stats for lchan life duration.
......................................................................
Patch Set 9:
(1 comment)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/9d01083c_7a72c2aa
PS8, Line 1514: "Cummulative number of active milliseconds on TCH chans",
> I agree the name is messy. […]
sounds great
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 9
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 18:27:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <michael(a)kapsulate.com>
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels.
iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )
Change subject: WIP: New stats for lchan life duration.
......................................................................
Patch Set 9:
(11 comments)
Patchset:
PS9:
Hi Neels,
Thanks for the extensive review. I have addressed many of your individual comments but not yet made the switch to your recommended approach for increasing accuracy. I will submit another update tomorrow. For now, I wanted to clean up the noise on this changeset so far and clarify its purpose.
Thanks again,
-Michael
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/9d9705a8_8f4ae15f
PS8, Line 1130: unsigned long long gsm_lchan_active_duration_ms(const struct gsm_lchan *lchan);
> (idea: use uint64_t for a fixed size independent from arch. […]
Done
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/71d1a3aa_870a5141
PS8, Line 1514: "Cummulative number of active milliseconds on TCH chans",
> ("Cumulative") […]
I agree the name is messy. However, this will indeed hold the cumulative number of milliseconds, not the average duration per activation. I am deriving the average based on this total in the VTY. I am also planning to use this total to show Erlangs per site.
Perhaps "Cumulative number of milliseconds of TCH channel activity."?
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/30f5d6cc_d4f24e9b
PS8, Line 574: uint duration_s = (gsm_lchan_active_duration_ms(lchan) + 500) / 1000;
> the +500 acts as a round(), yet the reported descriptions below suggest that floor() should be used […]
Done
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/6d99f3ed_038fd742
PS8, Line 3826: uint64_t activations_tch = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_ACT_TCH)->current;
> osmocom style dictates that local variables are declared at the start of the function (or scope)
Done
File src/osmo-bsc/gsm_data.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/a2e11d99_13e44cab
PS8, Line 348: /* Get duration of active time for this lchan in milliseconds */
> Rather: […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/273efcdf_40c620a0
PS8, Line 352: if (lchan->activate.concluded) {
> osmocom style asks for early-exit: […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/e7f20f1a_ff1fca66
PS8, Line 357: duration = elapsed.tv_sec * 1000LL + elapsed.tv_nsec / 1000000;
> the LL on the 1000 has no effect, the first operand defines the integer size for calculation. […]
Done
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/0de12fcb_1e7b022d
PS8, Line 1810:
> You should rather put this bit in a new lchan_st_established_onleave() function. […]
This is a great bit of information. I do think it is important to capture the error timeouts. If we see SDCCH averages trending toward a long timeout value, we know something is up. I've moved the stat increment code and log to lchan_fsm_unused_onenter.
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/2de06a3f_096d9a4e
PS8, Line 1811: /* Add active milliseconds to cummulative counts per channel type */
> /* Report how long this lchan was active, to add to the average activity duration metric. […]
Adopted. However, I will use "cumulative duration" to reflect that stat's purpose as mentioned before.
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/d1cd083c_5099ffff
PS8, Line 1817: LOG_LCHAN(lchan, LOGL_INFO, "GSM_LCHAN_TCH was active for %llu milliseconds\n", duration_ms);
> i would rather just have a single LOG_LCHAN() that uses gsm_chan_t_name() above the switch, because […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 9
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 18:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: iedemam.
Hello Jenkins Builder, neels,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27081
to look at the new patch set (#9).
Change subject: WIP: New stats for lchan life duration.
......................................................................
WIP: New stats for lchan life duration.
This patch adds two stats which track cummulative lchan lifetime by
type TCH and SDCCH. These new counters will accomplish two things:
1) Provide a glanceable way to see if lchan durations look healthy. When
examining a site, short-lived (<5s) and long-lived (>30s) TCH lchans
are difficult to tell apart. If we only see short-lived TCH lchans,
there is most likely an RF or signaling problem to investigate. This
new counter will expose channel ages in the VTY output
2) Provide a more accurate count for Erlangs per site. Currently, we
are basing Erlangs on active TCH channel counts per stats period. This
method skews high very quickly. Each active TCH in that period
translates into the full 10s of activity. This counter should improve
accuracy by two orders of magnitude.
Approach:
- For now: a time calculation between channel activation and release
- Maybe cleaner: use osmo_time_cc
Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
---
M include/osmocom/bsc/bts.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/bts.c
M src/osmo-bsc/bts_trx_vty.c
M src/osmo-bsc/bts_vty.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/lchan_fsm.c
7 files changed, 71 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/27081/9
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 9
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 )
Change subject: bsc_nat_fsm: initial conn-oriented forwarding
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/a5e80a3a_77442897
PS3, Line 78: *peer_addr_in = called_addr;
> Ack
This doesn't look good to me, you are tricking the compiler here. Because at the caller, it will expect those 2 pointers to be not modified after the function, but they may through peer_addr_in.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
Gerrit-Change-Number: 27260
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 13:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 )
Change subject: bsc_nat_fsm: initial conn-oriented forwarding
......................................................................
Patch Set 3:
(2 comments)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/ee5ae3d2_77942105
PS3, Line 74: static int sccp_sap_get_peer_addr_in(struct bsc_nat_ss7_inst *src, struct osmo_sccp_addr **peer_addr_in,
> I think both *called_addr and *calling_addr arguments can be marked 'const'?
Done
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/8c0ab1fe_f9cba3eb
PS3, Line 78: *peer_addr_in = called_addr;
> ... you would need to cast pointers here and below, but I think it's fine.
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
Gerrit-Change-Number: 27260
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 13:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
Hello Jenkins Builder, laforge, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
to look at the new patch set (#4).
Change subject: bsc_nat_fsm: initial conn-oriented forwarding
......................................................................
bsc_nat_fsm: initial conn-oriented forwarding
Implement a simple version of forwarding Connection Request, Connection
Confirm, Data Form, Released SCCP messages. This is still assuming that
there is just one BSC, one MSC, the same connection ID is used in RAN
and CN. Future patches will add a mapping between RAN and CN sides and
allow multiple BSCs.
With this patch it is possible to perform a call between two MS in the
following network structure:
MS1 --.
BTS --- BSC --- BSCNAT --- MSC
MS2 --'
Related: SYS#5560
Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
---
M src/osmo-bsc-nat/bsc_nat_fsm.c
1 file changed, 88 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/60/27260/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
Gerrit-Change-Number: 27260
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newpatchset
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27265 )
Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11
......................................................................
scripts/osmo-ci-docker-rebuild: x86: skip deb11
Don't attempt to build debian-bullseye (11) in docker on debian 10 x86,
as it results in:
GPG error: http://security.debian.org/debian-security bullseye-security InRelease: At least one invalid signature was encountered.
E: The repository 'http://security.debian.org/debian-security bullseye-security InRelease' is not signed.
This is a temporary measure until we've upgraded the only jenkins node
that runs debian 10 on x86, gtp0-deb10build32.
Related: OS#5453
Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3
---
M scripts/osmo-ci-docker-rebuild.sh
1 file changed, 13 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/scripts/osmo-ci-docker-rebuild.sh b/scripts/osmo-ci-docker-rebuild.sh
index cf0b102..f46bec1 100755
--- a/scripts/osmo-ci-docker-rebuild.sh
+++ b/scripts/osmo-ci-docker-rebuild.sh
@@ -4,8 +4,19 @@
. scripts/common.sh
docker_images_require \
"debian-stretch-jenkins" \
- "debian-buster-jenkins" \
- "debian-bullseye-erlang" \
+ "debian-buster-jenkins"
+
+if [ "$(arch)" = "i686" ] && \
+ grep -q '^ID=debian' /etc/os-release && \
+ grep -q '^VERSION_ID="10"' /etc/os-release; then
+ # Attempting to run debian-bullseye (11) in docker on debian 10 x86
+ # doesn't work. Skip it here for gtp0-deb10build32 until we've moved it
+ # away from debian 10.
+ echo "Skipping build of debian-bullseye-erlang (OS#5453)"
+else
+ docker_images_require \
+ "debian-bullseye-erlang"
+fi
if [ "$(arch)" = "x86_64" ]; then
docker_images_require \
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3
Gerrit-Change-Number: 27265
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27037 )
Change subject: net: run.sh: fix infinite "q Enter to close" msgs
......................................................................
net: run.sh: fix infinite "q Enter to close" msgs
Fix the logic that is supposed to display a "q Enter to close" message
once and wait for user input, in case one of the Osmocom programs
crashed.
Explicitly read from /dev/tty, as it may not be connected as default
stdin anymore at this point. This happens when using the new code paths
with tmux as terminal, but also happened before recent refactorings for
me with all terminals.
Related: https://media.ccc.de/v/osmodevcall-20211210-osmith-osmo-dev-ttcn3#t=801
Change-Id: Iebb799493f76fd57f24b15c998ded2bd8e284e6b
---
M net/templates/run.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved; Verified
diff --git a/net/templates/run.sh b/net/templates/run.sh
index 1d78db5..64419a6 100755
--- a/net/templates/run.sh
+++ b/net/templates/run.sh
@@ -118,7 +118,7 @@
while true; do
echo 'q Enter to close'
- read q_to_close
+ read q_to_close < /dev/tty
if [ "x\$q_to_close" = xq ]; then
break
fi
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27037
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: Iebb799493f76fd57f24b15c998ded2bd8e284e6b
Gerrit-Change-Number: 27037
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: merged
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27267 )
Change subject: net/templates/run.sh: put log name in trace.pcap
......................................................................
net/templates/run.sh: put log name in trace.pcap
It's hard to distinguish multiple wireshark windows with trace.pcap
files, as only the file name and not the path is shown in the title.
Make it easier to distinguish them by adding the log name to the file
name.
Change-Id: I7007d7c1e74aef46f1942f4f6f675adebb890955
---
M net/templates/run.sh
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved; Verified
diff --git a/net/templates/run.sh b/net/templates/run.sh
index 64419a6..0a8cfb1 100755
--- a/net/templates/run.sh
+++ b/net/templates/run.sh
@@ -298,11 +298,13 @@
newlogdir="log/$log_name"
#scp "bts:/tmp/{bts,pcu}.log" "bts:neels/osmo-{bts,pcu}.cfg" "$logdir"
else
- newlogdir="autolog/log_$(date +%Y-%m-%d_%H-%M-%S)"
+ log_name="log_$(date +%Y-%m-%d_%H-%M-%S)"
+ newlogdir="autolog/$log_name"
fi
mkdir -p "$(dirname "$newlogdir")"
mergecap -w "$logdir/trace.pcap" "$logdir/"*.single.pcap && rm -f "$logdir/"*.single.pcap
+mv "$logdir/trace.pcap" "$logdir/trace-$log_name.pcap"
if [ -x "$newlogdir" ]; then
echo "already exists, move it manually: $newlogdir"
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I7007d7c1e74aef46f1942f4f6f675adebb890955
Gerrit-Change-Number: 27267
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: merged
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27036 )
Change subject: net: run.sh: support tmux as terminal
......................................................................
net: run.sh: support tmux as terminal
Create one tmux session, with each Osmocom program in one window, if
tmux is chosen as "terminal". This allows using osmo-dev's run.sh over
ssh without X forwarding. Also the existing supported terminals
automatically scroll to the bottom as soon as there is new output,
making it hard to read logs.
Change-Id: Iaef08fb3cb3c6f58cd8490a631e177a03af9c974
---
M net/config_2g3g
M net/templates/run.sh
2 files changed, 22 insertions(+), 7 deletions(-)
Approvals:
osmith: Looks good to me, approved; Verified
diff --git a/net/config_2g3g b/net/config_2g3g
index a46f55e..e50d13c 100644
--- a/net/config_2g3g
+++ b/net/config_2g3g
@@ -1,5 +1,5 @@
# Terminal for launching Osmocom programs
-# Supported: urxvt, xterm
+# Supported: urxvt, xterm, tmux
TERMINAL="urxvt"
ETH_DEV=eth0
diff --git a/net/templates/run.sh b/net/templates/run.sh
index 332b168..1d78db5 100755
--- a/net/templates/run.sh
+++ b/net/templates/run.sh
@@ -1,5 +1,13 @@
#!/usr/bin/env bash
+# tmux: start this script inside a new session
+tmux_session="CN"
+if [ "${TERMINAL}" = "tmux" ] && [ "$1" != "inside-tmux" ]; then
+ echo "Starting tmux session '$tmux_session'"
+ unset TMUX
+ exec tmux new-session -s "$tmux_session" -n "RUN" "$0" "inside-tmux"
+fi
+
if ! ../fill_config.py --check-stale; then
echo
echo "WARNING: STALE CONFIGS - your net configs are older than the templates they should be based on!"
@@ -46,7 +54,7 @@
find_term() {
# Find a terminal program and write to the global "terminal" variable
- local programs="urxvt xterm"
+ local programs="urxvt xterm tmux"
if [ -z "${TERMINAL}" ]; then
echo "ERROR: TERMINAL is not defined in your osmo-dev net config file. Please add it."
@@ -118,12 +126,19 @@
EOF
chmod +x "$launcher"
- $terminal \
- -title "CN:$title" \
- -e sh -c "$launcher" \
- &
+ case "$terminal" in
+ tmux)
+ tmux new-window -d -n "$title" "$launcher &; echo \$! > $pidfile_term; fg; wait"
+ ;;
+ *)
+ $terminal \
+ -title "CN:$title" \
+ -e sh -c "$launcher" \
+ &
- echo "$!" > "$pidfile_term"
+ echo "$!" > "$pidfile_term"
+ ;;
+ esac
}
kill_pids() {
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27036
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: Iaef08fb3cb3c6f58cd8490a631e177a03af9c974
Gerrit-Change-Number: 27036
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: merged