February 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: ts_51_011: Better decode of EF_OPL LAI

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27334 ) Change subject: ts_51_011: Better decode of EF_OPL LAI ...................................................................... ts_51_011: Better decode of EF_OPL LAI before: { "lai": "62f2300000fffe", "pnn_record_id": 1 } after: { "lai": { "mcc_nmc": "262f03", "lac_min": "0000", "lac_max": "fffe" }, "pnn_record_id": 1 } Change-Id: I82581220e9c33a8e67cbefd5dfeb40bbc2c31179 --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/27334/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 9a6aff9..7e5fd3b 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -889,7 +889,7 @@ class EF_OPL(LinFixedEF): def __init__(self, fid='6fc6', sfid=None, name='EF.OPL', rec_len={8, 8}, desc='Operator PLMN List', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=rec_len, **kwargs) - self._construct = Struct('lai'/Bytes(7), 'pnn_record_id'/Int8ub) + self._construct = Struct('lai'/Struct('mcc_nmc'/BcdAdapter(Bytes(3)), 'lac_min'/Bytes(2), 'lac_max'/Bytes(2)), 'pnn_record_id'/Int8ub) # TS 51.011 Section 10.3.44 + TS 31.102 4.2.62 class EF_MBI(LinFixedEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I82581220e9c33a8e67cbefd5dfeb40bbc2c31179 Gerrit-Change-Number: 27334 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_31_102: Fix decoding of UServiceTable

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27332 ) Change subject: ts_31_102: Fix decoding of UServiceTable ...................................................................... ts_31_102: Fix decoding of UServiceTable range(0,7) in python is 0..6, and not 0..7, so we need range(0.8) to produce the desired range covering all bits of a byte. This resulted in services 8,16,24,... not being displayed in the decoded output of EF.UST / EF.IST. Change-Id: I22bbc481de342685352bf5b13d54931d3f37f9b7 --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/27332/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index c6bfa2d..3298534 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -554,7 +554,7 @@ ret = {} for i in range(0, len(in_bin)): byte = in_bin[i] - for bitno in range(0, 7): + for bitno in range(0, 8): service_nr = i * 8 + bitno + 1 ret[service_nr] = { 'activated': True if byte & (1 << bitno) else False -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I22bbc481de342685352bf5b13d54931d3f37f9b7 Gerrit-Change-Number: 27332 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_51_011: Properly decode EF.OPL

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27333 ) Change subject: ts_51_011: Properly decode EF.OPL ...................................................................... ts_51_011: Properly decode EF.OPL The OPL has 7 bytes "LAI" as the LAI actually contains a LAC range (so two more bytes for the end of the 16bit range). Change-Id: I74bcf10b0a8977af0f2844044a812c5780af1706 --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/27333/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index ddfed95..9a6aff9 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -889,7 +889,7 @@ class EF_OPL(LinFixedEF): def __init__(self, fid='6fc6', sfid=None, name='EF.OPL', rec_len={8, 8}, desc='Operator PLMN List', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=rec_len, **kwargs) - self._construct = Struct('lai'/Bytes(5), 'pnn_record_id'/Int8ub) + self._construct = Struct('lai'/Bytes(7), 'pnn_record_id'/Int8ub) # TS 51.011 Section 10.3.44 + TS 31.102 4.2.62 class EF_MBI(LinFixedEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I74bcf10b0a8977af0f2844044a812c5780af1706 Gerrit-Change-Number: 27333 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: osmo-hnbgw.cfg: use local port 2729 as default for MGCP client

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27331 ) Change subject: osmo-hnbgw.cfg: use local port 2729 as default for MGCP client ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I55179c2bff3e6ef0e54fee6b1b90fc76f541e58e Gerrit-Change-Number: 27331 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Feb 2022 14:13:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: osmo-hnbgw.cfg: use local port 2729 as default for MGCP client

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27331 ) Change subject: osmo-hnbgw.cfg: use local port 2729 as default for MGCP client ...................................................................... osmo-hnbgw.cfg: use local port 2729 as default for MGCP client There are several osmo processes that talk to osmo-mgw via osmo-mgcp-client. The sample config for osmo-bsc suggest 2727 and the sample config for osmo-msc suggests 2728 as local port default. To make it less likely for users to get port collisions whlie setting up their networks we should use a different port for osmo-hnbgw. Lets use 2729. Change-Id: I55179c2bff3e6ef0e54fee6b1b90fc76f541e58e --- M doc/examples/osmo-hnbgw/osmo-hnbgw.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/31/27331/1 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg index a683187..53b5508 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg @@ -25,6 +25,7 @@ hnbap-allow-tmsi 1 mgcp mgw remote-ip 127.0.0.1 + mgw local-port 2729 mgw remote-port 2427 mgw reset-endpoint rtpbridge/* -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27331 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I55179c2bff3e6ef0e54fee6b1b90fc76f541e58e Gerrit-Change-Number: 27331 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-hnbgw: depend on osmo-mgw

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27330 ) Change subject: osmo-hnbgw: depend on osmo-mgw ...................................................................... osmo-hnbgw: depend on osmo-mgw Fix for: | checking for LIBOSMOMGCPCLIENT... no | configure: error: Package requirements (libosmo-mgcp-client >= 1.9.0) were not met: | | No package 'libosmo-mgcp-client' found Required since osmo-hnbgw Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4. Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 --- M recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc b/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc index 3e45f9b..696c864 100644 --- a/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc +++ b/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc @@ -3,7 +3,7 @@ LICENSE = "AGPLv3" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -DEPENDS = "libosmocore libosmo-netif libosmo-sccp osmo-iuh libasn1c lksctp-tools" +DEPENDS = "libosmocore libosmo-netif libosmo-sccp osmo-iuh libasn1c lksctp-tools osmo-mgw" INC_PR="r0.${META_TELEPHONY_OSMO_INC}" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 Gerrit-Change-Number: 27330 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-hnbgw: depend on osmo-mgw

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27330 ) Change subject: osmo-hnbgw: depend on osmo-mgw ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 Gerrit-Change-Number: 27330 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Feb 2022 13:04:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-hnbgw: depend on osmo-mgw

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27330 ) Change subject: osmo-hnbgw: depend on osmo-mgw ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: added reference to osmo-hnbgw commit, re-applying +2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 Gerrit-Change-Number: 27330 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Feb 2022 13:04:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-hnbgw: depend on osmo-mgw

by osmith

Attention is currently required from: osmith. Hello laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/meta-telephony/+/27330 to look at the new patch set (#2). Change subject: osmo-hnbgw: depend on osmo-mgw ...................................................................... osmo-hnbgw: depend on osmo-mgw Fix for: | checking for LIBOSMOMGCPCLIENT... no | configure: error: Package requirements (libosmo-mgcp-client >= 1.9.0) were not met: | | No package 'libosmo-mgcp-client' found Required since osmo-hnbgw Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4. Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 --- M recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/30/27330/2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 Gerrit-Change-Number: 27330 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_102_221: properly decode short file identifier

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27328 ) Change subject: ts_102_221: properly decode short file identifier ...................................................................... ts_102_221: properly decode short file identifier The SFI TLV contanins not the raw SFI, but it contains the SFI shifted to left by 3 bits (for some strange reason). So let's un-shift it. Change-Id: Ibc69b99010d2a25cbb69b6a3d1585d0cb63f1345 --- M pySim/ts_102_221.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index ac2a60e..708b50b 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -186,7 +186,14 @@ # ETSI TS 102 221 11.1.1.4.8 class ShortFileIdentifier(BER_TLV_IE, tag=0x88): - _construct = HexAdapter(COptional(Bytes(1))) + # If the length of the TLV is 1, the SFI value is indicated in the 5 most significant bits (bits b8 to b4) + # of the TLV value field. In this case, bits b3 to b1 shall be set to 0 + class Shift3RAdapter(Adapter): + def _decode(self, obj, context, path): + return obj >> 3 + def _encode(self, obj, context, path): + return obj << 3 + _construct = COptional(Shift3RAdapter(Byte)) # ETSI TS 102 221 11.1.1.4.9 class LifeCycleStatusInteger(BER_TLV_IE, tag=0x8A): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc69b99010d2a25cbb69b6a3d1585d0cb63f1345 Gerrit-Change-Number: 27328 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022