Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345
to look at the new patch set (#2).
Change subject: octsim: tester support
......................................................................
octsim: tester support
This adds tests for the octsim tester that try all voltages on all slots,
5v tests use the default (slow) rate because the cables apparently make higher
rates at higher voltages a bit error prone.
Change-Id: Id7c7e529a5444cffc8e79b385959a522dc9a6beb
---
M octsim/OCTSIM_Tests.cfg
M octsim/OCTSIM_Tests.ttcn
2 files changed, 439 insertions(+), 51 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/27345/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id7c7e529a5444cffc8e79b385959a522dc9a6beb
Gerrit-Change-Number: 27345
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27344 )
Change subject: simtrace emulation: adjust templates to support octsim tester
......................................................................
Patch Set 2:
(1 comment)
File library/SIMTRACE_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27344/comment/0a1eaa0b_40e4…
PS1, Line 218: ts_SIMTRACE_CEMU_CONFIG(template (value) CardEmu_FeatureFlags flags, integer slotnr) :=
> if you say "integer slotnr := 0" then the template will be backwards compatible, i. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27344
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I00576170a2b6921d99906ed8bd45d9eece053056
Gerrit-Change-Number: 27344
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 25 Feb 2022 19:03:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27340 )
Change subject: simtrace: Add support for slot_mux_nr to CardEmu_BD_Config
......................................................................
Patch Set 2:
(1 comment)
File library/SIMTRACE_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27340/comment/6cd1903a_f84c…
PS1, Line 225: ?
> I guess this should be * not ?, otherwise any message without this entirely optional part would no l […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27340
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id29584764a2f27b9de5fa9ff67fd0ae3e912f02e
Gerrit-Change-Number: 27340
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 25 Feb 2022 19:02:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27332 )
Change subject: ts_31_102: Fix decoding of UServiceTable
......................................................................
ts_31_102: Fix decoding of UServiceTable
range(0,7) in python is 0..6, and not 0..7, so we need range(0.8)
to produce the desired range covering all bits of a byte.
This resulted in services 8,16,24,... not being displayed in
the decoded output of EF.UST / EF.IST.
Change-Id: I22bbc481de342685352bf5b13d54931d3f37f9b7
---
M pySim/ts_31_102.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index c6bfa2d..3298534 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -554,7 +554,7 @@
ret = {}
for i in range(0, len(in_bin)):
byte = in_bin[i]
- for bitno in range(0, 7):
+ for bitno in range(0, 8):
service_nr = i * 8 + bitno + 1
ret[service_nr] = {
'activated': True if byte & (1 << bitno) else False
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I22bbc481de342685352bf5b13d54931d3f37f9b7
Gerrit-Change-Number: 27332
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27337 )
Change subject: ts_31_102: Further decode TAI in EF.OPL5G
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27337
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie5a5ce74713deb0e151218ae553d3f3d96cef17d
Gerrit-Change-Number: 27337
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 25 Feb 2022 18:18:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27336 )
Change subject: ts_31_102: Further decode LAI in EF_LOCI
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27336
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I21d9356e541eb320848a373804781ae0bef7d012
Gerrit-Change-Number: 27336
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 25 Feb 2022 18:18:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment