February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ggsn[master]: vty: Fix cmd 'no echo-interval' doing nothing

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27346 ) Change subject: vty: Fix cmd 'no echo-interval' doing nothing ...................................................................... vty: Fix cmd 'no echo-interval' doing nothing It was incorrectly implemented and in practice was a NOOP. Change-Id: I5e03c4965d05871d3f2e56675da6e75af0ec18c2 --- M ggsn/ggsn_vty.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c index 1738e70..9591bf7 100644 --- a/ggsn/ggsn_vty.c +++ b/ggsn/ggsn_vty.c @@ -389,10 +389,9 @@ NO_STR "Send an echo request to this static GGSN every interval.\n") { struct ggsn_ctx *ggsn = (struct ggsn_ctx *) vty->index; - int prev_interval = ggsn->cfg.echo_interval; struct sgsn_peer *sgsn; - if (prev_interval == ggsn->cfg.echo_interval) + if (ggsn->cfg.echo_interval == 0) return CMD_SUCCESS; ggsn->cfg.echo_interval = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27346 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5e03c4965d05871d3f2e56675da6e75af0ec18c2 Gerrit-Change-Number: 27346 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)

by pespin

Attention is currently required from: laforge, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27352 ) Change subject: libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think there's one static such array per remote GSN so in real networks with many SGSNs this might […] I'd expect a host targeting many SGSNs to really have enough memory to handle that. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6034b0fab2b2e5962314c2fca2f893246ce5cf4f Gerrit-Change-Number: 27352 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 28 Feb 2022 14:38:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: vty: Fix cmd 'no echo-interval' doing nothing

by osmith

Attention is currently required from: pespin, keith, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27346 ) Change subject: vty: Fix cmd 'no echo-interval' doing nothing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27346 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5e03c4965d05871d3f2e56675da6e75af0ec18c2 Gerrit-Change-Number: 27346 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Feb 2022 13:47:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ci[master]: jobs/ttcn3-testsuites: adjust nplab-m3ua timers

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27349 ) Change subject: jobs/ttcn3-testsuites: adjust nplab-m3ua timers ...................................................................... jobs/ttcn3-testsuites: adjust nplab-m3ua timers Fix sporadic errors related to the clean up script running while images being built: failed to get digest sha256:8ea2ba9a1... Closes: OS#5447 Change-Id: If722fddce8de65a1ae012a46d6a202f430e0c69d --- M jobs/ttcn3-testsuites.yml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index f2fadc5..5fb994d 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -23,7 +23,7 @@ # debian-stretch nightly - order by time - nplab-m3ua-test: blocking: "^(nplab|NPLAB-.*)-m3ua-test.*" - timer: 00 03 * * * + timer: 10 03 * * * - nplab-sua-test: blocking: "^(nplab|NPLAB-.*)-sua-test.*" timer: 15 03 * * * @@ -158,7 +158,7 @@ # debian-stretch latest stable - nplab-m3ua-test-latest: blocking: "^(nplab|NPLAB-.*)-m3ua-test.*" - timer: 00 03 * * * + timer: 10 03 * * * - nplab-sua-test-latest: blocking: "^(nplab|NPLAB-.*)-sua-test.*" timer: 15 03 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If722fddce8de65a1ae012a46d6a202f430e0c69d Gerrit-Change-Number: 27349 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-ci[master]: jobs/ttcn3-testsuites: adjust nplab-m3ua timers

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27349 ) Change subject: jobs/ttcn3-testsuites: adjust nplab-m3ua timers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If722fddce8de65a1ae012a46d6a202f430e0c69d Gerrit-Change-Number: 27349 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Feb 2022 13:44:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)

by laforge

Attention is currently required from: pespin, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27352 ) Change subject: libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase) ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I think there's one static such array per remote GSN so in real networks with many SGSNs this might become a problem. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6034b0fab2b2e5962314c2fca2f893246ce5cf4f Gerrit-Change-Number: 27352 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 28 Feb 2022 13:43:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: libgtp: Fix ggsn crash if pdp alloc array is full (PDP_MAX)

by laforge

Attention is currently required from: pespin, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27351 ) Change subject: libgtp: Fix ggsn crash if pdp alloc array is full (PDP_MAX) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0d94ffad97eb4fef477d981bf285bf99740592a3 Gerrit-Change-Number: 27351 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 28 Feb 2022 13:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in docker-playground[master]: ttcn3-ggsn: Modify configs to alloc bigger IPv4 pools

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27348 ) Change subject: ttcn3-ggsn: Modify configs to alloc bigger IPv4 pools ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > please make sure to also do those changes in the configs in osmo-ttcn3-hacks I don't see any osmo-ggsn.cfg in ggsn_tests/ there, so I thought I leave whoever uses it without docker to fill in a proper config file which works for him. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27348 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If3344c8acc9bc3b43ed0a13af52807d2a6050a81 Gerrit-Change-Number: 27348 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 28 Feb 2022 13:34:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27352 ) Change subject: libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: With this patch, most probably meta-telephony.git/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch needs to be updated. It probably makes more sense to actually reduce PDP_MAX in there, since in those kind of embedded devices we expect to run only 1 BTS so we shouldn't need more than let's say 128 concurrent pdp contexts. For a 2 TRX BTS, we could have up to 15 PDCH TS, at a maximum of 7 USFs per TS: 15 * 7 = 105 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6034b0fab2b2e5962314c2fca2f893246ce5cf4f Gerrit-Change-Number: 27352 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 28 Feb 2022 13:30:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ggsn[master]: libgtp: Fix ggsn crash if pdp alloc array is full (PDP_MAX)

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/27351 ) Change subject: libgtp: Fix ggsn crash if pdp alloc array is full (PDP_MAX) ...................................................................... libgtp: Fix ggsn crash if pdp alloc array is full (PDP_MAX) osmo-ggsn crashes when concurrent pdp context 1024 is created, due to the gsn->pdpa array (of size PDP_MAX, 1024) being full. The crash happens because return code of gtp_pdp_newpdp was not checked, and hence a pointer "pdp" pointing to a temporary not-fully-allocated object was being passed to gsn->cb_create_context_ind() callback. Let's avoid crashing and instead reject the PDP context. Related: OS#5469 Change-Id: I0d94ffad97eb4fef477d981bf285bf99740592a3 --- M gtp/gtp.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/51/27351/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 59fd355..7c781de 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1809,7 +1809,16 @@ } } - gtp_pdp_newpdp(gsn, &pdp, pdp->imsi, pdp->nsapi, pdp); + rc = gtp_pdp_newpdp(gsn, &pdp, pdp->imsi, pdp->nsapi, pdp); + if (rc != 0) { + GTP_LOGPKG(LOGL_ERROR, peer, pack, len, + "Failed creating a new PDP context, array full (%u)\n", PDP_MAX); + /* &pdp in gtp_pdp_newpdp is untouched if it failed: */ + rc = gtp_create_pdp_resp(gsn, version, pdp, GTPCAUSE_NO_MEMORY); + /* Don't pass it to emit_cb_recovery, since allocation failed and it was already rejected: */ + pdp = NULL; + goto recover_ret; + } /* Callback function to validate login */ if (gsn->cb_create_context_ind != 0) @@ -1820,6 +1829,8 @@ rc = gtp_create_pdp_resp(gsn, version, pdp, GTPCAUSE_NOT_SUPPORTED); } + +recover_ret: if (recovery_recvd) emit_cb_recovery(gsn, peer, pdp, recovery); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/27351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0d94ffad97eb4fef477d981bf285bf99740592a3 Gerrit-Change-Number: 27351 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022