February 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: ts_102_221: Fix decoding the 'num_of_rec' field

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27329 ) Change subject: ts_102_221: Fix decoding the 'num_of_rec' field ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e258547dad21a248650cfbc02e0576268d3b3fd Gerrit-Change-Number: 27329 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 12:41:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in pysim[master]: ts_102_221: properly decode short file identifier

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27328 ) Change subject: ts_102_221: properly decode short file identifier ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc69b99010d2a25cbb69b6a3d1585d0cb63f1345 Gerrit-Change-Number: 27328 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 12:41:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: make sure the command-line specified point codes are ...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27325 ) Change subject: sccp_demo_user: make sure the command-line specified point codes are used ...................................................................... sccp_demo_user: make sure the command-line specified point codes are used Change-Id: I983066199e5d8f056895fdad370e3b4439b4dba4 --- M examples/internal.h M examples/sccp_demo_user.c M examples/sccp_test_vty.c 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/examples/internal.h b/examples/internal.h index ef560ed..5dd439c 100644 --- a/examples/internal.h +++ b/examples/internal.h @@ -12,6 +12,9 @@ struct osmo_sccp_user; +extern struct osmo_sccp_addr g_calling_addr; +extern struct osmo_sccp_addr g_called_addr; + int sccp_test_user_vty_install(struct osmo_sccp_instance *inst, int ssn); int sccp_test_server_init(struct osmo_sccp_instance *sccp); diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 5f443e2..bcb95f4 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -300,6 +300,8 @@ } sccp_test_server_init(g_sccp); } + g_calling_addr.pc = local_pc; + g_called_addr.pc = remote_pc; while (1) { osmo_select_main(0); diff --git a/examples/sccp_test_vty.c b/examples/sccp_test_vty.c index c477c8b..044ecf2 100644 --- a/examples/sccp_test_vty.c +++ b/examples/sccp_test_vty.c @@ -13,13 +13,13 @@ static struct osmo_sccp_user *g_scu; -static struct osmo_sccp_addr g_calling_addr = { +struct osmo_sccp_addr g_calling_addr = { .presence = OSMO_SCCP_ADDR_T_SSN | OSMO_SCCP_ADDR_T_PC, .ri = OSMO_SCCP_RI_SSN_PC, .pc = 23, }; -static struct osmo_sccp_addr g_called_addr = { +struct osmo_sccp_addr g_called_addr = { .presence = OSMO_SCCP_ADDR_T_SSN | OSMO_SCCP_ADDR_T_PC, .ssn = 1, .ri = OSMO_SCCP_RI_SSN_PC, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I983066199e5d8f056895fdad370e3b4439b4dba4 Gerrit-Change-Number: 27325 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Allow user to specify logmask on command line

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27326 ) Change subject: sccp_demo_user: Allow user to specify logmask on command line ...................................................................... sccp_demo_user: Allow user to specify logmask on command line Change-Id: Ie1cf37b3501e26330b038b7ee17a5273d81c92d8 --- M examples/sccp_demo_user.c 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index bcb95f4..84ad84b 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -120,6 +120,7 @@ " %s:%d in client mode)\n" " -L: local point code (default is %d in server mode, %d in client mode)\n" " -R: remote point code (default is %d in server mode, %d in client mode)\n", + " -d: LOGMASK (libosmocore log mask string, e.g. -d DLINP,1:DLSS7,2)\n" DEFAULT_LOCAL_ADDRESS_SERVER, DEFAULT_LOCAL_PORT_SERVER, DEFAULT_LOCAL_ADDRESS_CLIENT, DEFAULT_LOCAL_PORT_CLIENT, DEFAULT_REMOTE_ADDRESS_SERVER, DEFAULT_REMOTE_PORT_SERVER, @@ -184,7 +185,10 @@ bool lflag = false, rflag = false, Lflag = false, Rflag = false; enum osmo_ss7_asp_protocol protocol = OSMO_SS7_ASP_PROT_M3UA; - while ((ch = getopt(argc, argv, "p:cl:r:L:R:C:")) != -1) { + void *tall_ctx = talloc_named_const(NULL, 1, "sccp_demo_user"); + init_logging(tall_ctx); + + while ((ch = getopt(argc, argv, "p:cl:r:L:R:C:d:")) != -1) { switch (ch) { case 'p': rc = get_string_value(osmo_ss7_asp_protocol_vals, optarg); @@ -238,6 +242,9 @@ case 'C': config_file = optarg; break; + case 'd': + log_parse_category_mask(osmo_stderr_target, optarg); + break; default: usage(); } @@ -253,8 +260,6 @@ signal(SIGUSR1, &signal_handler); signal(SIGUSR2, &signal_handler); - void *tall_ctx = talloc_named_const(NULL, 1, "sccp_demo_user"); - init_logging(tall_ctx); OSMO_ASSERT(osmo_ss7_init() == 0); osmo_fsm_log_addr(false); vty_info.tall_ctx = tall_ctx; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie1cf37b3501e26330b038b7ee17a5273d81c92d8 Gerrit-Change-Number: 27326 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: enable stats / rate_counter timers

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27327 ) Change subject: sccp_demo_user: enable stats / rate_counter timers ...................................................................... sccp_demo_user: enable stats / rate_counter timers Change-Id: I135704d401de2cf439e51882e22323b31db14a2a --- M examples/sccp_demo_user.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 84ad84b..1a4ebac 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -11,6 +11,8 @@ #include <osmocom/core/logging.h> #include <osmocom/core/application.h> #include <osmocom/core/fsm.h> +#include <osmocom/core/stats.h> +#include <osmocom/core/rate_ctr.h> #include <osmocom/vty/vty.h> #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h> @@ -260,6 +262,8 @@ signal(SIGUSR1, &signal_handler); signal(SIGUSR2, &signal_handler); + osmo_stats_init(tall_ctx); + rate_ctr_init(tall_ctx); OSMO_ASSERT(osmo_ss7_init() == 0); osmo_fsm_log_addr(false); vty_info.tall_ctx = tall_ctx; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I135704d401de2cf439e51882e22323b31db14a2a Gerrit-Change-Number: 27327 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Add 'show stats' to VTY

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27324 ) Change subject: sccp_demo_user: Add 'show stats' to VTY ...................................................................... sccp_demo_user: Add 'show stats' to VTY this allows us to inspect statistics of the demo user via VTY Change-Id: Ica48d4e0c9cedb9adb94ae08c5201207b8836e1c --- M examples/sccp_demo_user.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 82309ea..5f443e2 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -14,6 +14,7 @@ #include <osmocom/vty/vty.h> #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h> +#include <osmocom/vty/stats.h> #include <osmocom/vty/misc.h> #include <osmocom/sigtran/osmo_ss7.h> @@ -260,6 +261,7 @@ vty_init(&vty_info); logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); + osmo_stats_vty_add_cmds(); osmo_fsm_vty_add_cmds(); osmo_ss7_vty_init_asp(NULL); osmo_sccp_vty_init(); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ica48d4e0c9cedb9adb94ae08c5201207b8836e1c Gerrit-Change-Number: 27324 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27279 ) Change subject: sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa) ...................................................................... sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa) Change-Id: Iecb03df43709903b1cfe248e68d6624b995c563d --- M examples/sccp_demo_user.c 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 88aead3..82309ea 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -28,16 +28,17 @@ static struct osmo_sccp_instance *g_sccp; -static struct osmo_sccp_instance *sua_server_helper(int local_port, const char *local_address, int local_pc, +static struct osmo_sccp_instance *sua_server_helper(enum osmo_ss7_asp_protocol protocol, + int local_port, const char *local_address, int local_pc, int remote_port, const char *remote_address, int remote_pc) { struct osmo_sccp_instance *sccp; - sccp = osmo_sccp_simple_server(NULL, local_pc, OSMO_SS7_ASP_PROT_M3UA, local_port, local_address); + sccp = osmo_sccp_simple_server(NULL, local_pc, protocol, local_port, local_address); if (sccp == NULL) return NULL; - osmo_sccp_simple_server_add_clnt(sccp, OSMO_SS7_ASP_PROT_M3UA, "client", remote_pc, local_port, + osmo_sccp_simple_server_add_clnt(sccp, protocol, "client", remote_pc, local_port, remote_port, remote_address); return sccp; @@ -110,6 +111,7 @@ " [-r REMOTE_ADDRESS[:REMOTE_PORT]]\n" " [-L LOCAL_POINT_CODE] [-R REMOTE_POINT_CODE]\n" "Options:\n" + " -p: protocol to use (m3ua, sua, ipa; default is ipa)\n" " -c: Run in client mode (default is server mode)\n" " -l: local IP address and SCTP port (default is %s:%d in server mode,\n" " %s:%d in client mode)\n" @@ -179,9 +181,16 @@ int remote_port = DEFAULT_REMOTE_PORT_SERVER; int remote_pc = DEFAULT_PC_CLIENT; bool lflag = false, rflag = false, Lflag = false, Rflag = false; + enum osmo_ss7_asp_protocol protocol = OSMO_SS7_ASP_PROT_M3UA; - while ((ch = getopt(argc, argv, "cl:r:L:R:C:")) != -1) { + while ((ch = getopt(argc, argv, "p:cl:r:L:R:C:")) != -1) { switch (ch) { + case 'p': + rc = get_string_value(osmo_ss7_asp_protocol_vals, optarg); + if (rc < 0) + exit(1); + protocol = rc; + break; case 'c': client = true; @@ -273,7 +282,7 @@ } if (client) { - g_sccp = osmo_sccp_simple_client(NULL, "client", local_pc, OSMO_SS7_ASP_PROT_M3UA, + g_sccp = osmo_sccp_simple_client(NULL, "client", local_pc, protocol, local_port, local_address, remote_port, remote_address); if (g_sccp == NULL) { perror("Could not create SCCP client"); @@ -281,7 +290,7 @@ } sccp_test_user_vty_install(g_sccp, OSMO_SCCP_SSN_BSSAP); } else { - g_sccp = sua_server_helper(local_port, local_address, local_pc, + g_sccp = sua_server_helper(protocol, local_port, local_address, local_pc, remote_port, remote_address, remote_pc); if (g_sccp == NULL) { perror("Could not create SCCP server"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iecb03df43709903b1cfe248e68d6624b995c563d Gerrit-Change-Number: 27279 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-hnbgw: depend on osmo-mgw

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27330 ) Change subject: osmo-hnbgw: depend on osmo-mgw ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 Gerrit-Change-Number: 27330 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Feb 2022 12:40:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-hnbgw: depend on osmo-mgw

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27330 ) Change subject: osmo-hnbgw: depend on osmo-mgw ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: It's usually useful to state here the osmo-hnbgw commit from which it starts to be needed. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 Gerrit-Change-Number: 27330 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Feb 2022 09:54:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-hnbgw: depend on osmo-mgw

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/27330 ) Change subject: osmo-hnbgw: depend on osmo-mgw ...................................................................... osmo-hnbgw: depend on osmo-mgw Fix for: | checking for LIBOSMOMGCPCLIENT... no | configure: error: Package requirements (libosmo-mgcp-client >= 1.9.0) were not met: | | No package 'libosmo-mgcp-client' found Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 --- M recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/30/27330/1 diff --git a/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc b/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc index 3e45f9b..696c864 100644 --- a/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc +++ b/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc @@ -3,7 +3,7 @@ LICENSE = "AGPLv3" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -DEPENDS = "libosmocore libosmo-netif libosmo-sccp osmo-iuh libasn1c lksctp-tools" +DEPENDS = "libosmocore libosmo-netif libosmo-sccp osmo-iuh libasn1c lksctp-tools osmo-mgw" INC_PR="r0.${META_TELEPHONY_OSMO_INC}" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I79b0525cff5030d72235640eddeabd7540f1bcf9 Gerrit-Change-Number: 27330 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: enable stats / rate_counter timers

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27327 ) Change subject: sccp_demo_user: enable stats / rate_counter timers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I135704d401de2cf439e51882e22323b31db14a2a Gerrit-Change-Number: 27327 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 09:24:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Allow user to specify logmask on command line

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27326 ) Change subject: sccp_demo_user: Allow user to specify logmask on command line ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie1cf37b3501e26330b038b7ee17a5273d81c92d8 Gerrit-Change-Number: 27326 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 09:23:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: make sure the command-line specified point codes are ...

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27325 ) Change subject: sccp_demo_user: make sure the command-line specified point codes are used ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I983066199e5d8f056895fdad370e3b4439b4dba4 Gerrit-Change-Number: 27325 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 09:23:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Add 'show stats' to VTY

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27324 ) Change subject: sccp_demo_user: Add 'show stats' to VTY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ica48d4e0c9cedb9adb94ae08c5201207b8836e1c Gerrit-Change-Number: 27324 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 09:22:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa)

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27279 ) Change subject: sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iecb03df43709903b1cfe248e68d6624b995c563d Gerrit-Change-Number: 27279 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 09:21:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in pysim[master]: ts_102_221: Fix decoding the 'num_of_rec' field

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27329 ) Change subject: ts_102_221: Fix decoding the 'num_of_rec' field ...................................................................... ts_102_221: Fix decoding the 'num_of_rec' field It is a 8bit integer, not a 16bit integer. See TS 102 221 11.1.1.4.3 Change-Id: I3e258547dad21a248650cfbc02e0576268d3b3fd --- M pySim/ts_102_221.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/27329/1 diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index 708b50b..713d169 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -103,7 +103,7 @@ 'structure'/Enum(BitsInteger(3), no_info_given=0, transparent=1, linear_fixed=2, cyclic=6)) ) _construct = Struct('file_descriptor_byte'/FDB, Const(b'\x21'), - 'record_len'/COptional(Int16ub), 'num_of_rec'/COptional(Int16ub)) + 'record_len'/COptional(Int16ub), 'num_of_rec'/COptional(Int8ub)) # ETSI TS 102 221 11.1.1.4.4 class FileIdentifier(BER_TLV_IE, tag=0x83): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27329 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e258547dad21a248650cfbc02e0576268d3b3fd Gerrit-Change-Number: 27329 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-ci[master]: Reenable ttcn3-hnbgw-test

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27318 ) Change subject: Reenable ttcn3-hnbgw-test ...................................................................... Reenable ttcn3-hnbgw-test Now that mgw support is in osmo-hnbgw master and docker/ttcn3 testsuite is working we can enable the test again. Change-Id: I4c7d1ee876e90d52827b2d8cc57342298dd44061 Related: OS#5152 --- M jobs/ttcn3-testsuites.yml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 5b915c7..f2fadc5 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -150,7 +150,6 @@ - ttcn3-hnbgw-test: blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*" timer: 40 13 * * * - disabled: true - ttcn3-fr-test: blocking: "^(ttcn3|TTCN3-.*)-fr-test.*" timer: 40 10 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4c7d1ee876e90d52827b2d8cc57342298dd44061 Gerrit-Change-Number: 27318 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in pysim[master]: ts_102_221: properly decode short file identifier

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27328 ) Change subject: ts_102_221: properly decode short file identifier ...................................................................... ts_102_221: properly decode short file identifier The SFI TLV contanins not the raw SFI, but it contains the SFI shifted to left by 3 bits (for some strange reason). So let's un-shift it. Change-Id: Ibc69b99010d2a25cbb69b6a3d1585d0cb63f1345 --- M pySim/ts_102_221.py 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/28/27328/1 diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py index ac2a60e..708b50b 100644 --- a/pySim/ts_102_221.py +++ b/pySim/ts_102_221.py @@ -186,7 +186,14 @@ # ETSI TS 102 221 11.1.1.4.8 class ShortFileIdentifier(BER_TLV_IE, tag=0x88): - _construct = HexAdapter(COptional(Bytes(1))) + # If the length of the TLV is 1, the SFI value is indicated in the 5 most significant bits (bits b8 to b4) + # of the TLV value field. In this case, bits b3 to b1 shall be set to 0 + class Shift3RAdapter(Adapter): + def _decode(self, obj, context, path): + return obj >> 3 + def _encode(self, obj, context, path): + return obj << 3 + _construct = COptional(Shift3RAdapter(Byte)) # ETSI TS 102 221 11.1.1.4.9 class LifeCycleStatusInteger(BER_TLV_IE, tag=0x8A): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc69b99010d2a25cbb69b6a3d1585d0cb63f1345 Gerrit-Change-Number: 27328 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-ci[master]: Reenable ttcn3-hnbgw-test

by osmith

Attention is currently required from: daniel, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27318 ) Change subject: Reenable ttcn3-hnbgw-test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4c7d1ee876e90d52827b2d8cc57342298dd44061 Gerrit-Change-Number: 27318 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Feb 2022 07:38:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa)

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27279 ) Change subject: sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iecb03df43709903b1cfe248e68d6624b995c563d Gerrit-Change-Number: 27279 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 07:32:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: enable stats / rate_counter timers

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27327 ) Change subject: sccp_demo_user: enable stats / rate_counter timers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I135704d401de2cf439e51882e22323b31db14a2a Gerrit-Change-Number: 27327 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 07:32:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Allow user to specify logmask on command line

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27326 ) Change subject: sccp_demo_user: Allow user to specify logmask on command line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie1cf37b3501e26330b038b7ee17a5273d81c92d8 Gerrit-Change-Number: 27326 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 07:31:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: make sure the command-line specified point codes are ...

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27325 ) Change subject: sccp_demo_user: make sure the command-line specified point codes are used ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I983066199e5d8f056895fdad370e3b4439b4dba4 Gerrit-Change-Number: 27325 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 07:31:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Add 'show stats' to VTY

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27324 ) Change subject: sccp_demo_user: Add 'show stats' to VTY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ica48d4e0c9cedb9adb94ae08c5201207b8836e1c Gerrit-Change-Number: 27324 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 07:30:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa)

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27279 ) Change subject: sccp_demo_user: Add command line argument to specify protocol (m3ua/ipa) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iecb03df43709903b1cfe248e68d6624b995c563d Gerrit-Change-Number: 27279 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Feb 2022 07:30:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: enable stats / rate_counter timers

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27327 ) Change subject: sccp_demo_user: enable stats / rate_counter timers ...................................................................... sccp_demo_user: enable stats / rate_counter timers Change-Id: I135704d401de2cf439e51882e22323b31db14a2a --- M examples/sccp_demo_user.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/27/27327/1 diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 84ad84b..1a4ebac 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -11,6 +11,8 @@ #include <osmocom/core/logging.h> #include <osmocom/core/application.h> #include <osmocom/core/fsm.h> +#include <osmocom/core/stats.h> +#include <osmocom/core/rate_ctr.h> #include <osmocom/vty/vty.h> #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h> @@ -260,6 +262,8 @@ signal(SIGUSR1, &signal_handler); signal(SIGUSR2, &signal_handler); + osmo_stats_init(tall_ctx); + rate_ctr_init(tall_ctx); OSMO_ASSERT(osmo_ss7_init() == 0); osmo_fsm_log_addr(false); vty_info.tall_ctx = tall_ctx; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27327 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I135704d401de2cf439e51882e22323b31db14a2a Gerrit-Change-Number: 27327 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Add 'show stats' to VTY

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27324 ) Change subject: sccp_demo_user: Add 'show stats' to VTY ...................................................................... sccp_demo_user: Add 'show stats' to VTY this allows us to inspect statistics of the demo user via VTY Change-Id: Ica48d4e0c9cedb9adb94ae08c5201207b8836e1c --- M examples/sccp_demo_user.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/24/27324/1 diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 82309ea..5f443e2 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -14,6 +14,7 @@ #include <osmocom/vty/vty.h> #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h> +#include <osmocom/vty/stats.h> #include <osmocom/vty/misc.h> #include <osmocom/sigtran/osmo_ss7.h> @@ -260,6 +261,7 @@ vty_init(&vty_info); logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); + osmo_stats_vty_add_cmds(); osmo_fsm_vty_add_cmds(); osmo_ss7_vty_init_asp(NULL); osmo_sccp_vty_init(); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27324 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ica48d4e0c9cedb9adb94ae08c5201207b8836e1c Gerrit-Change-Number: 27324 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: make sure the command-line specified point codes are ...

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27325 ) Change subject: sccp_demo_user: make sure the command-line specified point codes are used ...................................................................... sccp_demo_user: make sure the command-line specified point codes are used Change-Id: I983066199e5d8f056895fdad370e3b4439b4dba4 --- M examples/internal.h M examples/sccp_demo_user.c M examples/sccp_test_vty.c 3 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/25/27325/1 diff --git a/examples/internal.h b/examples/internal.h index ef560ed..5dd439c 100644 --- a/examples/internal.h +++ b/examples/internal.h @@ -12,6 +12,9 @@ struct osmo_sccp_user; +extern struct osmo_sccp_addr g_calling_addr; +extern struct osmo_sccp_addr g_called_addr; + int sccp_test_user_vty_install(struct osmo_sccp_instance *inst, int ssn); int sccp_test_server_init(struct osmo_sccp_instance *sccp); diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 5f443e2..bcb95f4 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -300,6 +300,8 @@ } sccp_test_server_init(g_sccp); } + g_calling_addr.pc = local_pc; + g_called_addr.pc = remote_pc; while (1) { osmo_select_main(0); diff --git a/examples/sccp_test_vty.c b/examples/sccp_test_vty.c index c477c8b..044ecf2 100644 --- a/examples/sccp_test_vty.c +++ b/examples/sccp_test_vty.c @@ -13,13 +13,13 @@ static struct osmo_sccp_user *g_scu; -static struct osmo_sccp_addr g_calling_addr = { +struct osmo_sccp_addr g_calling_addr = { .presence = OSMO_SCCP_ADDR_T_SSN | OSMO_SCCP_ADDR_T_PC, .ri = OSMO_SCCP_RI_SSN_PC, .pc = 23, }; -static struct osmo_sccp_addr g_called_addr = { +struct osmo_sccp_addr g_called_addr = { .presence = OSMO_SCCP_ADDR_T_SSN | OSMO_SCCP_ADDR_T_PC, .ssn = 1, .ri = OSMO_SCCP_RI_SSN_PC, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I983066199e5d8f056895fdad370e3b4439b4dba4 Gerrit-Change-Number: 27325 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_demo_user: Allow user to specify logmask on command line

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27326 ) Change subject: sccp_demo_user: Allow user to specify logmask on command line ...................................................................... sccp_demo_user: Allow user to specify logmask on command line Change-Id: Ie1cf37b3501e26330b038b7ee17a5273d81c92d8 --- M examples/sccp_demo_user.c 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/26/27326/1 diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index bcb95f4..84ad84b 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -120,6 +120,7 @@ " %s:%d in client mode)\n" " -L: local point code (default is %d in server mode, %d in client mode)\n" " -R: remote point code (default is %d in server mode, %d in client mode)\n", + " -d: LOGMASK (libosmocore log mask string, e.g. -d DLINP,1:DLSS7,2)\n" DEFAULT_LOCAL_ADDRESS_SERVER, DEFAULT_LOCAL_PORT_SERVER, DEFAULT_LOCAL_ADDRESS_CLIENT, DEFAULT_LOCAL_PORT_CLIENT, DEFAULT_REMOTE_ADDRESS_SERVER, DEFAULT_REMOTE_PORT_SERVER, @@ -184,7 +185,10 @@ bool lflag = false, rflag = false, Lflag = false, Rflag = false; enum osmo_ss7_asp_protocol protocol = OSMO_SS7_ASP_PROT_M3UA; - while ((ch = getopt(argc, argv, "p:cl:r:L:R:C:")) != -1) { + void *tall_ctx = talloc_named_const(NULL, 1, "sccp_demo_user"); + init_logging(tall_ctx); + + while ((ch = getopt(argc, argv, "p:cl:r:L:R:C:d:")) != -1) { switch (ch) { case 'p': rc = get_string_value(osmo_ss7_asp_protocol_vals, optarg); @@ -238,6 +242,9 @@ case 'C': config_file = optarg; break; + case 'd': + log_parse_category_mask(osmo_stderr_target, optarg); + break; default: usage(); } @@ -253,8 +260,6 @@ signal(SIGUSR1, &signal_handler); signal(SIGUSR2, &signal_handler); - void *tall_ctx = talloc_named_const(NULL, 1, "sccp_demo_user"); - init_logging(tall_ctx); OSMO_ASSERT(osmo_ss7_init() == 0); osmo_fsm_log_addr(false); vty_info.tall_ctx = tall_ctx; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie1cf37b3501e26330b038b7ee17a5273d81c92d8 Gerrit-Change-Number: 27326 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in libosmocore[master]: stats: use tcp stat names as provided

by pespin

Attention is currently required from: iedemam, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: use tcp stat names as provided ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Makes sense to me. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 18:04:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Only route to an SGSN if the BVC is not blocked

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 ) Change subject: gbproxy: Only route to an SGSN if the BVC is not blocked ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 Gerrit-Change-Number: 27322 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 18:01:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-abis[master]: stats: add BTS index to IPA RSL TCP stats name

by pespin

Attention is currently required from: iedemam. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27323 ) Change subject: stats: add BTS index to IPA RSL TCP stats name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If7ae7f0e75de37e2e52a8ed724c861f57d0da574 Gerrit-Change-Number: 27323 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Thu, 24 Feb 2022 18:00:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: release call when FSM is not created

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 ) Change subject: mgw_fsm: release call when FSM is not created ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Gerrit-Change-Number: 27320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 17:30:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmo-abis[master]: stats: add BTS index to IPA RSL TCP stats name

by iedemam

iedemam has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27323 ) Change subject: stats: add BTS index to IPA RSL TCP stats name ...................................................................... stats: add BTS index to IPA RSL TCP stats name With this change, the new TCP stat names more closely resemble existing RSL related stat names. Change-Id: If7ae7f0e75de37e2e52a8ed724c861f57d0da574 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/23/27323/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index b410a7e..8dc1008 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -296,6 +296,7 @@ struct e1inp_ts *ts; struct osmo_fd *newbfd; struct e1inp_line *new_line; + char tcp_stat_name[32]; sign_link = line->ops->sign_link_up(&unit_data, line, @@ -342,9 +343,9 @@ "could not register FD\n"); goto err; } - char stat_name[16]; - snprintf(stat_name, sizeof(stat_name), "ipa-rsl-%u", unit_data.trx_id); - osmo_stats_tcp_osmo_fd_register(newbfd, stat_name); + snprintf(tcp_stat_name, sizeof(tcp_stat_name), "bts.%u.ipa-rsl.%u", + unit_data.bts_id, unit_data.trx_id); + osmo_stats_tcp_osmo_fd_register(newbfd, tcp_stat_name); e1i_ts = ipaccess_line_ts(newbfd, new_line); ipaccess_bsc_keepalive_fsm_alloc(e1i_ts, newbfd, "rsl_bsc_to_bts"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If7ae7f0e75de37e2e52a8ed724c861f57d0da574 Gerrit-Change-Number: 27323 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: check for more than one RAB assignment req

by daniel

Attention is currently required from: pespin, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27321 ) Change subject: ranap_rab_ass: check for more than one RAB assignment req ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27321/comment/4749c42f_9ad5f023 PS1, Line 694: then than -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0f1d868fd0b4dc413533d6fcc5482862825181be Gerrit-Change-Number: 27321 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 16:56:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: release call when FSM is not created

by daniel

Attention is currently required from: pespin, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 ) Change subject: mgw_fsm: release call when FSM is not created ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320/comment/1128ffdc_37d5ac4a PS1, Line 724: tx_release_req(map); > We could, but then the formatting of the message would be more difficult. […] Ok, I guess it improves the behaviour in any case. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Gerrit-Change-Number: 27320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 16:55:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Only route to an SGSN if the BVC is not blocked

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 ) Change subject: gbproxy: Only route to an SGSN if the BVC is not blocked ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: No Test for this yet, but it didn't break any existing tests either... -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 Gerrit-Change-Number: 27322 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 24 Feb 2022 16:19:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Only route to an SGSN if the BVC is not blocked

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 ) Change subject: gbproxy: Only route to an SGSN if the BVC is not blocked ...................................................................... gbproxy: Only route to an SGSN if the BVC is not blocked Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 --- M src/gb_proxy.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/22/27322/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 69a58d4..c2b958a 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -348,6 +348,8 @@ continue; if (sgsn->nse != sgsn_bvc->nse) continue; + if (!bssgp_bvc_fsm_is_unblocked(sgsn_bvc->fi)) + continue; return sgsn_bvc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 Gerrit-Change-Number: 27322 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in libosmocore[master]: stats: use tcp stat names as provided

by iedemam

Attention is currently required from: pespin, daniel. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: use tcp stat names as provided ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Hi all, Apologies for changing the sense of this patch so drastically. I wasn't sure if I should start a new changeset but did want to maintain the conversation surrounding the change. After using the new TCP stats in the field for awhile now, we are seeing some issues with the name being tied to the IP+port. As described in the new commit message, this constant name change on reconnects results in distinct stat key names for what is actually a single logical stat making observation difficult. Certainly name sanitation is still an issue elsewhere and should be addressed. I wanted to tackle each item individually though. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 15:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in libosmocore[master]: stats: use tcp stat names as provided

by iedemam

Attention is currently required from: iedemam, pespin, daniel. Hello Jenkins Builder, neels, fixeria, daniel, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27137 to look at the new patch set (#3). Change subject: stats: use tcp stat names as provided ...................................................................... stats: use tcp stat names as provided If an API user has defined a name for this particular stat, we should consider it unique and not append ip and port information from the connection. By appending ip and port information to all tcp stat names, we end up creating unique stat names every time a reconnection occurs and the source port changes. This makes the statistic impossible to track over time as it is continually using a different name. A quick example from the field over the course of a day: tcp.ipa-rsl-0,r=192.168.55.88.33056<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.33311<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.35510<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.35958<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.36110<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.39269<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.40394<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.40397<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.42920<->l=192.168.0.1.3003.tcp.rtt tcp.ipa-rsl-0,r=192.168.55.88.43839<->l=192.168.0.1.3003.tcp.rtt This change would treat tcp stats like other stats around the system. A unique name must be set by the API user. This would let us set a unique name like the following to avoid the situation above: bts.0.rsl.0.tcp.rtt Matching the existing rsl related stats: bts.0.rsl.delete_ind bts.0.rsl.ipa_nack bts.0.rsl.unknown ...they retain a constant name regardless of the underlying connectivity situation. Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 --- M src/stats_tcp.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/37/27137/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

Change in osmo-gsm-tester[master]: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 ) Change subject: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency ...................................................................... jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency Change-Id: Ic32160c8e1a00ae299344e029f3909a8e24c7291 --- M contrib/jenkins-build-osmo-hnbgw.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: daniel: Verified pespin: Looks good to me, approved diff --git a/contrib/jenkins-build-osmo-hnbgw.sh b/contrib/jenkins-build-osmo-hnbgw.sh index c495c21..556f9c1 100755 --- a/contrib/jenkins-build-osmo-hnbgw.sh +++ b/contrib/jenkins-build-osmo-hnbgw.sh @@ -10,6 +10,7 @@ build_repo libosmo-sccp ${SANITIZE_FLAGS} build_repo libasn1c ${SANITIZE_FLAGS} build_repo osmo-iuh ${SANITIZE_FLAGS} +build_repo osmo-mgw ${SANITIZE_FLAGS} build_repo osmo-hnbgw ${SANITIZE_FLAGS} -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic32160c8e1a00ae299344e029f3909a8e24c7291 Gerrit-Change-Number: 27319 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in osmo-gsm-tester[master]: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency

by pespin

Attention is currently required from: osmith, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 ) Change subject: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic32160c8e1a00ae299344e029f3909a8e24c7291 Gerrit-Change-Number: 27319 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 15:21:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gsm-tester[master]: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency

by pespin

Attention is currently required from: osmith, pespin. pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 ) Change subject: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic32160c8e1a00ae299344e029f3909a8e24c7291 Gerrit-Change-Number: 27319 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 2 months

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: release call when FSM is not created

by dexter

Attention is currently required from: pespin, daniel. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 ) Change subject: mgw_fsm: release call when FSM is not created ...................................................................... Patch Set 1: (1 comment) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320/comment/206b7d3e_281d0509 PS1, Line 724: tx_release_req(map); > Shouldn't we instead return a RAB assignment response with a failed list? We could, but then the formatting of the message would be more difficult. If we would have gone for multiple-rab support I would say we definitely do that, but here I think its better to kill everything with by sending an IuRelease. (I don't think this is a spec violation.) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Gerrit-Change-Number: 27320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 14:37:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gsm-tester[master]: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency

by daniel

Attention is currently required from: osmith, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 ) Change subject: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: The jenkins failure seems unrelated. I ran jenkins-build-osmo-hnbgw.sh locally and it built everything without issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic32160c8e1a00ae299344e029f3909a8e24c7291 Gerrit-Change-Number: 27319 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 14:17:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: release call when FSM is not created

by daniel

Attention is currently required from: pespin, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 ) Change subject: mgw_fsm: release call when FSM is not created ...................................................................... Patch Set 1: (1 comment) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320/comment/485bcd2e_bd5d67b3 PS1, Line 724: tx_release_req(map); Shouldn't we instead return a RAB assignment response with a failed list? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Gerrit-Change-Number: 27320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 14:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: release call when FSM is not created

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 ) Change subject: mgw_fsm: release call when FSM is not created ...................................................................... mgw_fsm: release call when FSM is not created While the FSM is created the RAB Assignment Requests is checked and parsed. In case of failure the context is freed, but the CN is not informed about the problem. The RAB AssignmentRequest will then most likely time out. However, lets make sure the call is released by re requesting an IU Release. Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Related: OS#5152 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/20/27320/1 diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index d4ef800..3da2b60 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -719,9 +719,9 @@ return 0; error: - /* TODO: If we fail in this early stage, we should generate an appropriate RAB AssignmentResponse to inform - * the core network about the failure. */ + /* Cleanup context and make sure that the call is cleared. */ mgw_fsm_priv_cleanup(mgw_fsm_priv); + tx_release_req(map); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Gerrit-Change-Number: 27320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: check for more than one RAB assignment req

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27321 ) Change subject: ranap_rab_ass: check for more than one RAB assignment req ...................................................................... ranap_rab_ass: check for more than one RAB assignment req The spec permits RAB AssignmentRequests with multiple RABs at a time. Even though one voice call is assigned only one RAB in practice. Since the current FSM implementation only supports a 1:1 scenario, lets check if the MSC really assigns only one RAB and block RAB Assignments that do not fit in this scheme. Change-Id: I0f1d868fd0b4dc413533d6fcc5482862825181be Related: OS#5152 --- M include/osmocom/hnbgw/ranap_rab_ass.h M src/osmo-hnbgw/mgw_fsm.c M src/osmo-hnbgw/ranap_rab_ass.c M tests/ranap_rab_ass/ranap_rab_ass_test.c M tests/ranap_rab_ass/ranap_rab_ass_test.ok 5 files changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/21/27321/1 diff --git a/include/osmocom/hnbgw/ranap_rab_ass.h b/include/osmocom/hnbgw/ranap_rab_ass.h index eb18de8..13fd2df 100644 --- a/include/osmocom/hnbgw/ranap_rab_ass.h +++ b/include/osmocom/hnbgw/ranap_rab_ass.h @@ -17,3 +17,5 @@ bool ranap_rab_ass_req_ies_check_release(RANAP_RAB_AssignmentRequestIEs_t *ies, uint8_t rab_id); bool ranap_rab_ass_resp_ies_check_failure(RANAP_RAB_AssignmentResponseIEs_t *ies, uint8_t rab_id); + +int ranap_rab_ass_req_ies_get_count(RANAP_RAB_AssignmentRequestIEs_t *ies); diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index 3da2b60..b777ef7 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -689,6 +689,16 @@ mgw_fsm_priv = talloc_zero(map, struct mgw_fsm_priv); mgw_fsm_priv->ranap_rab_ass_req_message = message; + /* This FSM only supports RAB assignments with a single RAB assignment only. This limitation has been taken + * into account under the assumption that voice calls typically require a single RAB only. Nevertheless, we + * will block all incoming RAB assignments that try to assign more (or less) then one RAB. */ + if (ranap_rab_ass_req_ies_get_count(&message->msg.raB_AssignmentRequestIEs) != 1) { + LOGP(DMGW, LOGL_ERROR, + "mgw_fsm_alloc_and_handle_rab_ass_req() rua_ctx_id=%d, RAB-AssignmentRequest with more than one RAB assignment -- abort!\n", + map->rua_ctx_id); + goto error; + } + /* Parse the RAB Assignment Request now, if it is bad for some reason we will exit early and not bother with * creating an FSM etc. */ ies = &mgw_fsm_priv->ranap_rab_ass_req_message->msg.raB_AssignmentRequestIEs; diff --git a/src/osmo-hnbgw/ranap_rab_ass.c b/src/osmo-hnbgw/ranap_rab_ass.c index 56886c7..5930451 100644 --- a/src/osmo-hnbgw/ranap_rab_ass.c +++ b/src/osmo-hnbgw/ranap_rab_ass.c @@ -620,3 +620,18 @@ return result; } + +/*! Find out how many RAB items are present in a RAB-SetupOrModifyList inside RANAP_RAB_AssignmentRequestIEs. + * \ptmap[in] ies user provided memory with RANAP_RAB_AssignmentRequestIEs. + * \returns number of RAB items, -1 on failure. */ +int ranap_rab_ass_req_ies_get_count(RANAP_RAB_AssignmentRequestIEs_t *ies) +{ + /* Make sure we indeed deal with a setup-or-modify list */ + if (!(ies->presenceMask & RAB_ASSIGNMENTREQUESTIES_RANAP_RAB_SETUPORMODIFYLIST_PRESENT)) { + RANAP_DEBUG + ("Decoding failed, the RANAP RAB AssignmentRequest did not contain a setup-or-modify list!\n"); + return -1; + } + + return ies->raB_SetupOrModifyList.list.count; +} diff --git a/tests/ranap_rab_ass/ranap_rab_ass_test.c b/tests/ranap_rab_ass/ranap_rab_ass_test.c index 052549e..9a98cf8 100644 --- a/tests/ranap_rab_ass/ranap_rab_ass_test.c +++ b/tests/ranap_rab_ass/ranap_rab_ass_test.c @@ -320,6 +320,33 @@ ranap_ran_rx_co_free(&message); } +void test_ranap_rab_ass_req_ies_get_count(void) +{ + int rc; + ranap_message message; + uint8_t testvec[] = { + 0x00, 0x00, 0x00, 0x59, 0x00, 0x00, 0x01, 0x00, + 0x36, 0x40, 0x52, 0x00, 0x00, 0x01, 0x00, 0x35, + 0x00, 0x48, 0x78, 0x22, 0xcd, 0x80, 0x10, 0x2f, + 0xa7, 0x20, 0x1a, 0x2c, 0x00, 0x00, 0xf4, 0x4c, + 0x08, 0x0a, 0x02, 0x80, 0x00, 0x51, 0x40, 0x00, + 0x27, 0x20, 0x28, 0x14, 0x00, 0x67, 0x40, 0x00, + 0x00, 0x22, 0x28, 0x14, 0x00, 0x3c, 0x40, 0x00, + 0x00, 0x00, 0x50, 0x3d, 0x02, 0x00, 0x02, 0x27, + 0xc0, 0x35, 0x00, 0x01, 0x0a, 0x09, 0x01, 0xa2, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x1f, 0x76, + 0x00, 0x00, 0x40, 0x01, 0x00, 0x00 + }; + + rc = ranap_ran_rx_co_decode(talloc_asn1_ctx, &message, testvec, sizeof(testvec)); + OSMO_ASSERT(rc == 0); + + rc = ranap_rab_ass_req_ies_get_count(&message.msg.raB_AssignmentRequestIEs); + printf("ranap_rab_ass_req_ies_get_count rc=%d\n", rc); + ranap_ran_rx_co_free(&message); +} + static const struct log_info_cat log_cat[] = { [DRANAP] = { .name = "RANAP", .loglevel = LOGL_DEBUG, .enabled = 1, @@ -382,6 +409,7 @@ test_ranap_rab_ass_resp_ies_replace_inet_addr(); test_ranap_rab_ass_resp_ies_check_failure(); test_ranap_rab_ass_req_ies_check_release(); + test_ranap_rab_ass_req_ies_get_count(); test_cleanup(); return 0; diff --git a/tests/ranap_rab_ass/ranap_rab_ass_test.ok b/tests/ranap_rab_ass/ranap_rab_ass_test.ok index 688925c..aca4ff3 100644 --- a/tests/ranap_rab_ass/ranap_rab_ass_test.ok +++ b/tests/ranap_rab_ass/ranap_rab_ass_test.ok @@ -18,3 +18,4 @@ ranap_rab_ass_resp_ies_check_failure rab_failed_at_hnb=0 (RAB ID 44, which is not in the message) ranap_rab_ass_req_ies_check_release rab_release_req=1 (RAB ID 23) ranap_rab_ass_req_ies_check_release rab_release_req=0 (RAB ID 44, which is not in the message) +ranap_rab_ass_req_ies_get_count rc=1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0f1d868fd0b4dc413533d6fcc5482862825181be Gerrit-Change-Number: 27321 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-ci[master]: Reenable ttcn3-hnbgw-test

by daniel

Attention is currently required from: osmith, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27318 ) Change subject: Reenable ttcn3-hnbgw-test ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > That's about osmo-gsm-tester building(?) osmo-hnbgw and it seems to complain about missing dependenc […] Fix for osmo-gsm-tester_build-osmo-hnbgw here: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4c7d1ee876e90d52827b2d8cc57342298dd44061 Gerrit-Change-Number: 27318 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 13:43:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gsm-tester[master]: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 ) Change subject: jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency ...................................................................... jenkins-build-osmo-hnbgw: Build osmo-mgw as dependency Change-Id: Ic32160c8e1a00ae299344e029f3909a8e24c7291 --- M contrib/jenkins-build-osmo-hnbgw.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/19/27319/1 diff --git a/contrib/jenkins-build-osmo-hnbgw.sh b/contrib/jenkins-build-osmo-hnbgw.sh index c495c21..556f9c1 100755 --- a/contrib/jenkins-build-osmo-hnbgw.sh +++ b/contrib/jenkins-build-osmo-hnbgw.sh @@ -10,6 +10,7 @@ build_repo libosmo-sccp ${SANITIZE_FLAGS} build_repo libasn1c ${SANITIZE_FLAGS} build_repo osmo-iuh ${SANITIZE_FLAGS} +build_repo osmo-mgw ${SANITIZE_FLAGS} build_repo osmo-hnbgw ${SANITIZE_FLAGS} -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/27319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic32160c8e1a00ae299344e029f3909a8e24c7291 Gerrit-Change-Number: 27319 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

2024

2023

2022

gerrit-log February 2022