February 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: add scripts/deactivate-ims.script to deactivate IMS related services
by laforge 21 Feb '22

21 Feb '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27239 ) Change subject: add scripts/deactivate-ims.script to deactivate IMS related services ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0cd93c8fa0024dd9d93647c565190abe94d3097e Gerrit-Change-Number: 27239 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 21 Feb 2022 09:05:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in pysim[master]: add scripts/deactivate-ims.script to deactivate IMS related services
by laforge 21 Feb '22

21 Feb '22

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/27239 to look at the new patch set (#2). Change subject: add scripts/deactivate-ims.script to deactivate IMS related services ...................................................................... add scripts/deactivate-ims.script to deactivate IMS related services Change-Id: I0cd93c8fa0024dd9d93647c565190abe94d3097e --- A scripts/deactivate-ims.script 1 file changed, 74 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/27239/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0cd93c8fa0024dd9d93647c565190abe94d3097e Gerrit-Change-Number: 27239 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

Change in osmo-ci[master]: ansible/ttcn3: don't install titan/libfftranscode
by osmith 21 Feb '22

21 Feb '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27206 ) Change subject: ansible/ttcn3: don't install titan/libfftranscode ...................................................................... ansible/ttcn3: don't install titan/libfftranscode With the last patch, the jenkins infrastructure will always run eclipse-titan in docker. Therefore do not install eclipse-titan and libfftranscode on jenkins nodes anymore. This avoids the problem that we couldn't upgrade libfftranscode with the existing ansible rules. libosmocore-utils is still being installed, as osmo-config-merge must be installed on the jenkins nodes. Closes: OS#5452 Change-Id: Ie46fe3dcb286a6258021fad9c35be10442544761 --- M ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml 1 file changed, 1 insertion(+), 14 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml index 5e15254..fc4fcc3 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml @@ -24,22 +24,9 @@ filename: obs_osmocom update_cache: yes -- name: install titan and libosmocore-utils +- name: install libosmocore-utils apt: name: - - eclipse-titan - libosmocore-utils update_cache: yes cache_valid_time: 3600 - -- name: Get DEB architecture - shell: dpkg --print-architecture - register: deb_architecture - -- name: Install libfftranscode0 - apt: - deb: https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode0_0.3_{{deb_a… - -- name: Install libfftranscode-dev - apt: - deb: https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode-dev_0.3_{{de… -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie46fe3dcb286a6258021fad9c35be10442544761 Gerrit-Change-Number: 27206 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ci[master]: jobs/gerrit-verifications: build ttcn3 in docker
by osmith 21 Feb '22

21 Feb '22

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27205 ) Change subject: jobs/gerrit-verifications: build ttcn3 in docker ...................................................................... jobs/gerrit-verifications: build ttcn3 in docker Build the testsuites in the same docker container during gerrit verification, as it will be the case when building and running the testsuites in the various ttcn3-* jenkins jobs. This avoids the need to install eclipse-titan and libfftranscode on the jenkins nodes. Related: OS#5452 Change-Id: I6a667255bb55a945b4c6279d711142aa252c6996 --- M jobs/gerrit-verifications.yml 1 file changed, 12 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 32c3e3b..f7a6312 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -261,12 +261,20 @@ cmd: '{timeout_cmd} ./contrib/jenkins.sh' - osmo-ttcn3-hacks: - repos_url: 'https://gerrit.osmocom.org/{repos}' slave_axis: !!python/tuple [ttcn3] - concurrent: false cmd: | - set -e - make deps; make clean; make compile + docker run \ + --rm \ + -v "$PWD:/build" \ + "registry.osmocom.org/osmocom-build/debian-bullseye-titan" \ + {timeout_cmd} \ + sh -e -x -c " + useradd --uid=1000 build; + cd /build; + su build -c 'make deps'; + su build -c 'make clean'; + su build -c 'make compile'; + " jobs: - 'gerrit-{repos}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6a667255bb55a945b4c6279d711142aa252c6996 Gerrit-Change-Number: 27205 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-sgsn[master]: Revert "sgsn: Handle different levels of QoS"
by pespin 20 Feb '22

20 Feb '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/27262 ) Change subject: Revert "sgsn: Handle different levels of QoS" ...................................................................... Revert "sgsn: Handle different levels of QoS" This reverts commit 4bd931f96d75d3e71b73a06e67f84ffdcab9caf6. The commit was wrong, and previous code is correct. Relevant specs: * TS 29.060 7.7.34 Quality of Service (QoS) Profile * TS 24.008 10.5.6.5 Quality of service As can be seen in TS 24.008 10.5.6.5, OSMO_IE_GSM_REQ_QOS never comes with the the ARP byte prepended. This is actually always prepended when sending the GTP message, as explained in TS 29.060 7.7.34. As a result, the Qos Service sent in Create PDP Context Request sent to the GGSN contained wrongly formatted Qos Profile IE, which was observed checking wireshark with a real phone. This was found due to open5gs-smfd being more strict about the possible lengths of the IE, since the wrongly formatted IE send in GTP had length=14, which is incorrect due to folllowing TS 24.008 10.5.6.5 wording: "Octets 15-22 are optional. If octet 15 is included, then octet 16 shall also be included, and octets 17-22may be included." In this case, due to the wrong format it was seen as including octet 15 but not 16. Change-Id: I4fc5ab823a27d27482858a7459337a2f8ae593c3 Related: SYS#5793 --- M src/sgsn/sgsn_libgtp.c 1 file changed, 5 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index 1ac3b44..6fb3adc 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -228,18 +228,11 @@ qos = TLVP_VAL(tp, OSMO_IE_GSM_REQ_QOS); } - if (qos_len <= 3) { - pdp->qos_req.l = qos_len + 1; - if (pdp->qos_req.l > sizeof(pdp->qos_req.v)) - pdp->qos_req.l = sizeof(pdp->qos_req.v); - pdp->qos_req.v[0] = 0; /* Allocation/Retention policy */ - memcpy(&pdp->qos_req.v[1], qos, pdp->qos_req.l - 1); - } else { - pdp->qos_req.l = qos_len; - if (pdp->qos_req.l > sizeof(pdp->qos_req.v)) - pdp->qos_req.l = sizeof(pdp->qos_req.v); - memcpy(pdp->qos_req.v, qos, pdp->qos_req.l); - } + pdp->qos_req.l = qos_len + 1; + if (pdp->qos_req.l > sizeof(pdp->qos_req.v)) + pdp->qos_req.l = sizeof(pdp->qos_req.v); + pdp->qos_req.v[0] = 0; /* Allocation/Retention policy */ + memcpy(&pdp->qos_req.v[1], qos, pdp->qos_req.l - 1); /* charging characteristics if present */ if (TLVP_LEN(tp, OSMO_IE_GSM_CHARG_CHAR) >= sizeof(pdp->cch_pdp)) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/27262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4fc5ab823a27d27482858a7459337a2f8ae593c3 Gerrit-Change-Number: 27262 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in dahdi-linux[master]: enable PPP and DAHDI_MIRROR by default.
by laforge 20 Feb '22

20 Feb '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27264 ) Change subject: enable PPP and DAHDI_MIRROR by default. ...................................................................... enable PPP and DAHDI_MIRROR by default. There's not really any reason to disable those, from what I can tell. Change-Id: Ib03074062ada7b6da485afac53b1550d31f1a5ca --- M include/dahdi/dahdi_config.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/64/27264/1 diff --git a/include/dahdi/dahdi_config.h b/include/dahdi/dahdi_config.h index 0a8f5a9..c441b62 100644 --- a/include/dahdi/dahdi_config.h +++ b/include/dahdi/dahdi_config.h @@ -80,6 +80,7 @@ * support. */ #define CONFIG_DAHDI_NET +#define CONFIG_DAHDI_PPP /* * Uncomment for Generic PPP support (i.e. DAHDIRAS) @@ -187,7 +188,7 @@ /* * Creates an interface for mirroring the raw channel data out to a pseudo-chan */ -/* #define CONFIG_DAHDI_MIRROR */ +#define CONFIG_DAHDI_MIRROR /* * Adds support for conference links. There are some non-Asterisk users of this -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ib03074062ada7b6da485afac53b1550d31f1a5ca Gerrit-Change-Number: 27264 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: jobs/gerrit-verifications: build ttcn3 in docker
by laforge 20 Feb '22

20 Feb '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27205 ) Change subject: jobs/gerrit-verifications: build ttcn3 in docker ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6a667255bb55a945b4c6279d711142aa252c6996 Gerrit-Change-Number: 27205 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 20 Feb 2022 16:21:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: ansible/ttcn3: don't install titan/libfftranscode
by laforge 20 Feb '22

20 Feb '22

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27206 ) Change subject: ansible/ttcn3: don't install titan/libfftranscode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie46fe3dcb286a6258021fad9c35be10442544761 Gerrit-Change-Number: 27206 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 20 Feb 2022 16:21:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: ranap_rab_ass_test: cosmetic: correct test function names
by laforge 20 Feb '22

20 Feb '22

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27200 ) Change subject: ranap_rab_ass_test: cosmetic: correct test function names ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib9db9d86e01551c8d9d8f8c4933025ca20ce5624 Gerrit-Change-Number: 27200 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 20 Feb 2022 16:21:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList
by laforge 20 Feb '22

20 Feb '22

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 20 Feb 2022 16:21:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log February 2022