Attention is currently required from: osmith, fixeria.
Hello Jenkins Builder, laforge, pespin, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
to look at the new patch set (#3).
Change subject: bsc_nat_fsm: initial conn-oriented forwarding
......................................................................
bsc_nat_fsm: initial conn-oriented forwarding
Implement a simple version of forwarding Connection Request, Connection
Confirm, Data Form, Released SCCP messages. This is still assuming that
there is just one BSC, one MSC, the same connection ID is used in RAN
and CN. Future patches will add a mapping between RAN and CN sides and
allow multiple BSCs.
With this patch it is possible to perform a call between two MS in the
following network structure:
MS1 --.
BTS --- BSC --- BSCNAT --- MSC
MS2 --'
Related: SYS#5560
Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
---
M src/osmo-bsc-nat/bsc_nat_fsm.c
1 file changed, 87 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/60/27260/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
Gerrit-Change-Number: 27260
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith, fixeria.
Hello Jenkins Builder, pespin, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/27265
to look at the new patch set (#3).
Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11
......................................................................
scripts/osmo-ci-docker-rebuild: x86: skip deb11
Don't attempt to build debian-bullseye (11) in docker on debian 10 x86,
as it results in:
GPG error: http://security.debian.org/debian-security bullseye-security InRelease: At least one invalid signature was encountered.
E: The repository 'http://security.debian.org/debian-security bullseye-security InRelease' is not signed.
This is a temporary measure until we've upgraded the only jenkins node
that runs debian 10 on x86, gtp0-deb10build32.
Related: OS#5453
Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3
---
M scripts/osmo-ci-docker-rebuild.sh
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/27265/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3
Gerrit-Change-Number: 27265
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 )
Change subject: bsc_nat_fsm: initial conn-oriented forwarding
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/ea9ab676_9dbf1989
PS2, Line 82: return 1;
Do you really need to return 1 here? isn't 0 enough? I wouldn't complicate function signatures for no reason.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
Gerrit-Change-Number: 27260
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 09:27:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin, fixeria.
Hello Jenkins Builder, pespin, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/27265
to look at the new patch set (#2).
Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11
......................................................................
scripts/osmo-ci-docker-rebuild: x86: skip deb11
Don't attempt to build debian-bullseye (11) in docker on debian 10 x86,
as it results in:
GPG error: http://security.debian.org/debian-security bullseye-security InRelease: At least one invalid signature was encountered.
E: The repository 'http://security.debian.org/debian-security bullseye-security InRelease' is not signed.
This is a temporary measure until we've upgraded the only jenkins node
that runs debian 10 on x86, gtp0-deb10build32.
Related: OS#5453
Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3
---
M scripts/osmo-ci-docker-rebuild.sh
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/27265/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3
Gerrit-Change-Number: 27265
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27265 )
Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11
......................................................................
scripts/osmo-ci-docker-rebuild: x86: skip deb11
Don't attempt to build debian-bullseye (11) in docker on debian 10 x86,
as it results in:
GPG error: http://security.debian.org/debian-security bullseye-security InRelease: At least one invalid signature was encountered.
E: The repository 'http://security.debian.org/debian-security bullseye-security InRelease' is not signed.
This is a temporary measure until we've upgraded the only jenkins node
that runs debian 10 on x86, gtp0-deb10build32.
Related: OS#5453
Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3
---
M scripts/osmo-ci-docker-rebuild.sh
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/27265/1
diff --git a/scripts/osmo-ci-docker-rebuild.sh b/scripts/osmo-ci-docker-rebuild.sh
index cf0b102..1491a3a 100755
--- a/scripts/osmo-ci-docker-rebuild.sh
+++ b/scripts/osmo-ci-docker-rebuild.sh
@@ -5,7 +5,18 @@
docker_images_require \
"debian-stretch-jenkins" \
"debian-buster-jenkins" \
- "debian-bullseye-erlang" \
+
+if [ "$(arch)" = "i686" ] && \
+ grep -q '^ID=debian' /etc/os-release && \
+ grep -q '^VERSION_ID="10"' /etc/os-release; then
+ # Attempting to run debian-bullseye (11) in docker on debian 10 x86
+ # doesn't work. Skip it here for gtp0-deb10build32 until we've moved it
+ # away from debian 10.
+ echo "Skipping build of debian-bullseye-erlang (OS#5453)"
+else
+ docker_images_require \
+ "debian-bullseye-erlang" \
+fi
if [ "$(arch)" = "x86_64" ]; then
docker_images_require \
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3
Gerrit-Change-Number: 27265
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27239 )
Change subject: add scripts/deactivate-ims.script to deactivate IMS related services
......................................................................
add scripts/deactivate-ims.script to deactivate IMS related services
Change-Id: I0cd93c8fa0024dd9d93647c565190abe94d3097e
---
A scripts/deactivate-ims.script
1 file changed, 74 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/scripts/deactivate-ims.script b/scripts/deactivate-ims.script
new file mode 100644
index 0000000..e5029da
--- /dev/null
+++ b/scripts/deactivate-ims.script
@@ -0,0 +1,74 @@
+# script to be used with pySim-shell.py which is part of the Osmocom pysim package,
+# found at https://osmocom.org/projects/pysim/wiki
+set echo true
+
+# this script will deactivate all IMS related services and files. This can be used
+# in case you do not wish to use any IMS services, or you do not wish to configure
+# the IMS specific files on the USIM/ISIM cards. The card will then behave like a 3G USIM
+# without any IMS capability, using the default fall-back mechanisms specified by 3GPP.
+
+# TODO: add your card-specific ADM pin at the end of the verify_adm line below
+verify_adm
+
+# deactivate any IMS related services in EF.UST
+select ADF.USIM
+select EF.UST
+ust_service_deactivate 93
+ust_service_deactivate 95
+ust_service_deactivate 104
+ust_service_deactivate 105
+ust_service_deactivate 106
+ust_service_deactivate 107
+ust_service_deactivate 108
+ust_service_deactivate 109
+ust_service_deactivate 110
+ust_service_deactivate 112
+ust_service_deactivate 114
+ust_service_deactivate 115
+ust_service_deactivate 118
+ust_service_deactivate 120
+ust_service_deactivate 131
+ust_service_deactivate 134
+
+# deactivate all IMS related files in ADF.USIM
+select ADF.USIM
+
+select EF.UICCIARI
+deactivate_file
+
+select EF.ePDGId
+deactivate_file
+
+select EF.ePDGSelection
+deactivate_file
+
+select EF.ePDGIdEm
+deactivate_file
+
+select EF.ePDGSelectionEm
+deactivate_file
+
+select EF.FromPreferred
+deactivate_file
+
+select EF.IMSConfigData
+deactivate_file
+
+select EF.3GPPPSDATAOFF
+deactivate_file
+
+select EF.3GPPPSDATAOFFservicelist
+deactivate_file
+
+select EF.XCAPConfigData
+deactivate_file
+
+select EF.MuDMiDConfigData
+deactivate_file
+
+echo "Please make sure to manually disable the ISIM applet as described in the end of the script"
+# you can currently only manually do this via GlobalPlatformPro or some other tool using
+# java -jar ./gp.jar --key-enc KIC1 --key-mac KID1 --key-dek KIK1 --lock-applet A0000000871004FFFFFFFF8907090000
+# (substituting KIC1/KID1/KIK1 with the card-specific keys, of course)
+
+quit
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/27239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0cd93c8fa0024dd9d93647c565190abe94d3097e
Gerrit-Change-Number: 27239
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged