February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: ggsn: TC_act_deact_retrans_duplicate: expect no diameter upon retrans

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27269 ) Change subject: ggsn: TC_act_deact_retrans_duplicate: expect no diameter upon retrans ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic579832bcaebfb22eb11156060c4385e41a5685a Gerrit-Change-Number: 27269 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 12:49:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: initial conn-oriented forwarding

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 ) Change subject: bsc_nat_fsm: initial conn-oriented forwarding ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/f5425a25_7a431792 PS3, Line 74: static int sccp_sap_get_peer_addr_in(struct bsc_nat_ss7_inst *src, struct osmo_sccp_addr **peer_addr_in, I think both *called_addr and *calling_addr arguments can be marked 'const'? https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/bbbc9acb_df5934bb PS3, Line 78: *peer_addr_in = called_addr; ... you would need to cast pointers here and below, but I think it's fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82 Gerrit-Change-Number: 27260 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 12:46:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: scripts/osmo-ci-docker-rebuild: x86: skip deb11

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27265 ) Change subject: scripts/osmo-ci-docker-rebuild: x86: skip deb11 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iba7679c027ca89a29393c220d01b195cfce4fec3 Gerrit-Change-Number: 27265 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 12:25:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: TC_act_deact_retrans_duplicate: expect no diameter upon retrans

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27269 ) Change subject: ggsn: TC_act_deact_retrans_duplicate: expect no diameter upon retrans ...................................................................... ggsn: TC_act_deact_retrans_duplicate: expect no diameter upon retrans Change-Id: Ic579832bcaebfb22eb11156060c4385e41a5685a --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/27269/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index bffdd4c..bef7949 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -474,7 +474,7 @@ T_default.stop; } - function f_pdp_ctx_del(PdpContext ctx, template BIT1 teardown_ind, OCT1 expect_causevalue := '80'O) runs on GT_CT { + function f_pdp_ctx_del(PdpContext ctx, template BIT1 teardown_ind, OCT1 expect_causevalue := '80'O, boolean expect_diameter := true) runs on GT_CT { var Gtp1cUnitdata ud; var default d; var OCT4 expect_teid; @@ -490,7 +490,7 @@ f_send_gtpc(ts_GTPC_DeletePDP(g_peer_c, g_c_seq_nr, ctx.teic_remote, ctx.nsapi, teardown_ind)); T_default.start; d := activate(pingpong()); - if (DIAMETER_PROC.checkstate("Connected")) { + if (DIAMETER_PROC.checkstate("Connected") and expect_diameter) { as_DIA_CCR(TERMINATION_REQUEST); } alt { @@ -1771,11 +1771,11 @@ duplicate. If it was not a duplicate, osmo-ggsn would answer with a failure since that PDP ctx was already deleted. */ g_c_seq_nr := g_c_seq_nr - 1; - f_pdp_ctx_del(ctx, '1'B); + f_pdp_ctx_del(ctx, '1'B, expect_diameter := false); /* Now send a new pdp ctx del (increased seqnum). It should fail with cause "non-existent": */ var OCT1 cause_nonexistent := 'C0'O; - f_pdp_ctx_del(ctx, '1'B, cause_nonexistent); + f_pdp_ctx_del(ctx, '1'B, cause_nonexistent, expect_diameter := false); } /* Activate PDP context + trigger Recovery procedure through EchoResp */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic579832bcaebfb22eb11156060c4385e41a5685a Gerrit-Change-Number: 27269 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: jobs/ttcn3-testsuites.yml: Add ttcn3-ggsn-test-ogs

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27268 ) Change subject: jobs/ttcn3-testsuites.yml: Add ttcn3-ggsn-test-ogs ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I61950f4fc613faae3a731ace394b76c8754bd3c4 Gerrit-Change-Number: 27268 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 11:08:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: jobs/ttcn3-testsuites.yml: Add ttcn3-ggsn-test-ogs

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27268 ) Change subject: jobs/ttcn3-testsuites.yml: Add ttcn3-ggsn-test-ogs ...................................................................... jobs/ttcn3-testsuites.yml: Add ttcn3-ggsn-test-ogs Change-Id: I61950f4fc613faae3a731ace394b76c8754bd3c4 --- M jobs/ttcn3-testsuites.yml 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/27268/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 5df5553..dbf162b 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -60,6 +60,11 @@ Test osmo-ggsn latest with the Linux kernel built from master of <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/"> torvalds/linux.git</a>. + - ttcn3-ggsn-test-ogs: + blocking: "^(ttcn3|TTCN3-.*)-ggsn-test.*" + timer: 35 04 * * * + description: | + Test open5gs-smfd + open5gs-upfd main. - ttcn3-msc-test: blocking: "^(ttcn3|TTCN3-.*)-msc-test.*" timer: 40 04 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I61950f4fc613faae3a731ace394b76c8754bd3c4 Gerrit-Change-Number: 27268 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-dev[master]: net: run.sh: fix infinite "q Enter to close" msgs

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27037 ) Change subject: net: run.sh: fix infinite "q Enter to close" msgs ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I've never seen this. […] https://media.ccc.de/v/osmodevcall-20211210-osmith-osmo-dev-ttcn3#t=801 After further analyzing I figured that stdin is not connected at this point - found a proper fix and updated the patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iebb799493f76fd57f24b15c998ded2bd8e284e6b Gerrit-Change-Number: 27037 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 10:38:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-dev[master]: net: run.sh: write launcher command to shell script

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27035 ) Change subject: net: run.sh: write launcher command to shell script ...................................................................... Patch Set 2: (1 comment) File net/templates/run.sh: https://gerrit.osmocom.org/c/osmo-dev/+/27035/comment/7609b7a5_38dd9d69 PS1, Line 43: wrapperdir="wrappers" > i'd prefer a single 'run' dir and keep both the launcher scripts as well as pids in it. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I15760d706b20628421c10a16514120f442d5477f Gerrit-Change-Number: 27035 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 10:37:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-dev[master]: net: require terminal to be configured

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27033 ) Change subject: net: require terminal to be configured ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > how about we keep only the 'TERMINAL=myterm' config and drop all of the confusing autmatic choices? […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I0afb6b0242c399334a2c37f18a5d26d5beeabedc Gerrit-Change-Number: 27033 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 10:37:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-dev[master]: net/templates/run.sh: put log name in trace.pcap

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/27267 ) Change subject: net/templates/run.sh: put log name in trace.pcap ...................................................................... net/templates/run.sh: put log name in trace.pcap It's hard to distinguish multiple wireshark windows with trace.pcap files, as only the file name and not the path is shown in the title. Make it easier to distinguish them by adding the log name to the file name. Change-Id: I7007d7c1e74aef46f1942f4f6f675adebb890955 --- M net/templates/run.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/67/27267/1 diff --git a/net/templates/run.sh b/net/templates/run.sh index 64419a6..0a8cfb1 100755 --- a/net/templates/run.sh +++ b/net/templates/run.sh @@ -298,11 +298,13 @@ newlogdir="log/$log_name" #scp "bts:/tmp/{bts,pcu}.log" "bts:neels/osmo-{bts,pcu}.cfg" "$logdir" else - newlogdir="autolog/log_$(date +%Y-%m-%d_%H-%M-%S)" + log_name="log_$(date +%Y-%m-%d_%H-%M-%S)" + newlogdir="autolog/$log_name" fi mkdir -p "$(dirname "$newlogdir")" mergecap -w "$logdir/trace.pcap" "$logdir/"*.single.pcap && rm -f "$logdir/"*.single.pcap +mv "$logdir/trace.pcap" "$logdir/trace-$log_name.pcap" if [ -x "$newlogdir" ]; then echo "already exists, move it manually: $newlogdir" -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7007d7c1e74aef46f1942f4f6f675adebb890955 Gerrit-Change-Number: 27267 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022