Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27101 )
Change subject: GGSN_Tests: fix DTE due to passing out-of-bound values to int2oct()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> You restarted the environment a lot of times it seems ;)
Not really ;) This happens because we initialize g_restart_ctr with a random value in f_init(): https://git.osmocom.org/osmo-ttcn3-hacks/tree/ggsn_tests/GGSN_Tests.ttcn#n2…
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27101
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I517b8e5d5872c36f7c759433a1cde338c90f16da
Gerrit-Change-Number: 27101
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Feb 2022 12:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27101 )
Change subject: GGSN_Tests: fix DTE due to passing out-of-bound values to int2oct()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
You restarted the environment a lot of times it seems ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27101
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I517b8e5d5872c36f7c759433a1cde338c90f16da
Gerrit-Change-Number: 27101
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Feb 2022 12:43:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 )
Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
> Regarding the patch, I would try to avoid downloading the files with wget, and rather run the config merge inside docker, where the config files are available in the checked out osmo-ttcn3-hacks.git. Then we would avoid the problem of having stale configs downloaded.
I understand the problem, thanks for pointing it out!
However, I am not sure if there is an easy & beautiful solution. The original config files are in osmo-ttcn3-hacks.git, so we need to take them from there somehow, apply the *.confmerge files (and some other sed quirks), and then feed the generated files to osmo-bsc and osmo-bts.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8
Gerrit-Change-Number: 20622
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Assignee: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 09 Feb 2022 12:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 )
Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
> Should this be marked as WIP? In OS#5377 fixeria wrote: "the configuration file is still not understood correctly"
I fixed various config parsing issues in the most recent patchset, so it's ready for review.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8
Gerrit-Change-Number: 20622
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Assignee: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 09 Feb 2022 12:33:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27101 )
Change subject: GGSN_Tests: fix DTE due to passing out-of-bound values to int2oct()
......................................................................
GGSN_Tests: fix DTE due to passing out-of-bound values to int2oct()
This patch fixes the following DTE happening sporadically:
04:09:29.373271 mtc GGSN_Tests.ttcn:1478 Dynamic test case error:
The first argument of function int2oct(), which is 256, does not fit in 1 octet.
Change-Id: I517b8e5d5872c36f7c759433a1cde338c90f16da
---
M ggsn_tests/GGSN_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/27101/1
diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 3b34c7f..ae24eeb 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -1475,7 +1475,7 @@
var PdpContext ctxB := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn)));
f_pdp_ctx_act(ctxA);
- g_restart_ctr := int2oct(oct2int(g_restart_ctr) + 1, 1);
+ g_restart_ctr := int2oct((oct2int(g_restart_ctr) + 1) mod 256, 1);
log("sending 2nd CreatePDP (recovery increased)");
f_send_gtpc(ts_GTPC_CreatePDP(g_peer_c, g_c_seq_nr, ctxB.imsi, g_restart_ctr,
@@ -1564,7 +1564,7 @@
/* Wait to receive second echo request and send incremented Restart
counter. This will fake a restarted SGSN, and pdp ctx allocated
should be released by GGSN */
- g_restart_ctr := int2oct(oct2int(g_restart_ctr) + 1, 1);
+ g_restart_ctr := int2oct((oct2int(g_restart_ctr) + 1) mod 256, 1);
GTPC.receive(tr_GTPC_PING(?)) -> value ud {
var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber);
GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr));
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27101
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I517b8e5d5872c36f7c759433a1cde338c90f16da
Gerrit-Change-Number: 27101
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27047 )
Change subject: core/utils.h: make use of OSMO_LIKELY in OSMO_ASSERT
......................................................................
core/utils.h: make use of OSMO_LIKELY in OSMO_ASSERT
Theoretically, this should improve performance of the code where
we frequently invoke OSMO_ASSERT(), like osmo-msc and osmo-bsc.
Change-Id: I29b32a2477ec92762f8f0ce5e5c5a30810f6abbe
---
M include/osmocom/core/utils.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h
index 182da08..ba2cafb 100644
--- a/include/osmocom/core/utils.h
+++ b/include/osmocom/core/utils.h
@@ -112,7 +112,7 @@
*/
#define OSMO_ASSERT(exp) \
do { \
- if (!(exp)) { \
+ if (OSMO_UNLIKELY(!(exp))) { \
osmo_panic("Assert failed %s %s:%d\n", #exp, __FILE__, __LINE__); \
} \
} while (0); /* some code invokes OSMO_ASSERT() without the semicolon */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I29b32a2477ec92762f8f0ce5e5c5a30810f6abbe
Gerrit-Change-Number: 27047
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: merged