Attention is currently required from: fixeria.
Hello fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/27103
to look at the new patch set (#2).
Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files
......................................................................
ttcn3-bts-test: use osmo-config-merge to generate config files
This uses the config files from osmo-ttcn3-hacks.git instead of keeping
local copies around here, which has shown many times will get out of
sync. Copy the files from the git repository checked out in the
ttcn3-bts-test docker image, so we don't need to take care of cloning
the repository again and checking out the same commit as used inside
that image. Original files are copied to *.src.cfg, and then merged with
the local *.confmerge files using osmo-conf-merge (*.gen.cfg).
Unfortunately, osmo-config-merge is not capable of removing text blocks
or substituting specific parts, so we fall-back to using sed where it's
needed. A good example is 'log gsmtap 127.0.0.1', as there is no
command for removing a logging target of such type.
Co-Authored-By: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de>
Co-Authored-By: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: If2d1ba8a775dc6c396f50f9853e633df110329a9
---
M .gitignore
M jenkins-common.sh
D ttcn3-bts-test/fh/osmo-bsc.cfg
A ttcn3-bts-test/fh/osmo-bsc.confmerge
M ttcn3-bts-test/jenkins.sh
D ttcn3-bts-test/oml/osmo-bts.cfg
A ttcn3-bts-test/oml/osmo-bts.confmerge
D ttcn3-bts-test/osmo-bsc.cfg
A ttcn3-bts-test/osmo-bsc.confmerge
D ttcn3-bts-test/osmo-bts.cfg
A ttcn3-bts-test/osmo-bts.confmerge
D ttcn3-bts-test/virtphy/osmo-bts.cfg
A ttcn3-bts-test/virtphy/osmo-bts.confmerge
13 files changed, 336 insertions(+), 851 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/03/27103/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27103
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If2d1ba8a775dc6c396f50f9853e633df110329a9
Gerrit-Change-Number: 27103
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
osmith has removed laforge from this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27103 )
Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files
......................................................................
Removed cc laforge.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27103
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If2d1ba8a775dc6c396f50f9853e633df110329a9
Gerrit-Change-Number: 27103
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: deleteReviewer
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27103 )
Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Alternative version of https://gerrit.osmocom.org/c/docker-playground/+/20622 that avoids downloading the files with wget, which solves the following problem:
* developer runs the testsuite for the first time, files get downloaded
* time passes
* files get updated in osmo-ttcn3-hacks
* developer runs the testsuite again, files are not updated
* tests are failing
* developer has to figure out why
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27103
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If2d1ba8a775dc6c396f50f9853e633df110329a9
Gerrit-Change-Number: 27103
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 09 Feb 2022 15:28:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 )
Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
Patchset:
PS6:
> However, I am not sure if there is an easy & beautiful solution. The original config files are in osmo-ttcn3-hacks.git, so we need to take them from there somehow, apply the *.confmerge files (and some other sed quirks), and then feed the generated files to osmo-bsc and osmo-bts.
How about this approach to avoid wget? https://gerrit.osmocom.org/c/docker-playground/+/27103
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8
Gerrit-Change-Number: 20622
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Assignee: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Feb 2022 15:26:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27101 )
Change subject: GGSN_Tests: fix DTE due to passing out-of-bound values to int2oct()
......................................................................
GGSN_Tests: fix DTE due to passing out-of-bound values to int2oct()
This patch fixes the following DTE happening sporadically:
04:09:29.373271 mtc GGSN_Tests.ttcn:1478 Dynamic test case error:
The first argument of function int2oct(), which is 256, does not fit in 1 octet.
Change-Id: I517b8e5d5872c36f7c759433a1cde338c90f16da
---
M ggsn_tests/GGSN_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 3b34c7f..ae24eeb 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -1475,7 +1475,7 @@
var PdpContext ctxB := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn)));
f_pdp_ctx_act(ctxA);
- g_restart_ctr := int2oct(oct2int(g_restart_ctr) + 1, 1);
+ g_restart_ctr := int2oct((oct2int(g_restart_ctr) + 1) mod 256, 1);
log("sending 2nd CreatePDP (recovery increased)");
f_send_gtpc(ts_GTPC_CreatePDP(g_peer_c, g_c_seq_nr, ctxB.imsi, g_restart_ctr,
@@ -1564,7 +1564,7 @@
/* Wait to receive second echo request and send incremented Restart
counter. This will fake a restarted SGSN, and pdp ctx allocated
should be released by GGSN */
- g_restart_ctr := int2oct(oct2int(g_restart_ctr) + 1, 1);
+ g_restart_ctr := int2oct((oct2int(g_restart_ctr) + 1) mod 256, 1);
GTPC.receive(tr_GTPC_PING(?)) -> value ud {
var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber);
GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr));
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27101
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I517b8e5d5872c36f7c759433a1cde338c90f16da
Gerrit-Change-Number: 27101
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged