February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: WIP: New stats for lchan life duration.

by pespin

Attention is currently required from: iedemam, neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: WIP: New stats for lchan life duration. ...................................................................... Patch Set 5: (3 comments) Patchset: PS5: Only minor linter stuff. Also indeed it may make sense to use the time_cc thing instead of printing stats, letting Neels look at that he'll know better. File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/c2d8e80a_7549dfe5 PS5, Line 3831: vty_out(vty," TCH %"PRIu64"", activations_tch); This tabulation looks really big, it probably needs to be " ". File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/607fd18d_d9c035ab PS5, Line 1815: case GSM_LCHAN_TCH_F: we put "case" line in the same column as "switch" in osmocom syntax style. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 5 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 08 Feb 2022 17:21:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: WIP: New stats for lchan life duration.

by iedemam

Attention is currently required from: neels, laforge, pespin. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: WIP: New stats for lchan life duration. ...................................................................... Patch Set 5: (7 comments) Patchset: PS5: Hi all, Thanks for the reviews so far. Latest patchset uploaded which addresses some concerns. I think our main disagreement is that of precision. The best of both worlds would be for me to store cumulative active time as seconds instead of milliseconds while still being able to show individual channel ages in milliseconds. This would require carrying remainders as state between activations which I think is ugly. Perhaps it is indeed enough to only track seconds. In the grand scheme of using this value to extrapolate Erlangs per site, it is still quite precise. Regards, -Michael File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/d981f7cc_ded2752b PS4, Line 575: vty_out(vty, " Activated %llu ms ago%s", duration_ms, VTY_NEWLINE); > Probably more interesting to print it in VTY as seconds? Doesn't look like we can glance millisecond […] SDCCH channels might not ever reach a full second. This was my thinking in using millisecond precision in the VTY. File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/88700fb3_6d23878f PS4, Line 3830: vty_out(vty, " Channel Activations : %"PRIu64" TCH", activations_tch); > I'd rather put it: […] You don't want to show total activations? Same comment as above about ms precision being needed to display SDCCH info in a meaningful way. I could add logic to simply show "<1s" for them. Sounds clean as well. File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/9ad59d86_98481bf2 PS4, Line 349: long long > wondering if a signed data type makes sense here, but this is not critical. true...everything is now unsigned long long File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/ad77c3bf_d66974a4 PS4, Line 1812: long long duration_ms = gsm_lchan_active_duration_ms(lchan); > Shouldn't this be an unsigned long long everywhere? Maybe simply use time_t? true...everything is now unsigned long long https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/d9f07147_63e75399 PS4, Line 1814: if (lchan->type == GSM_LCHAN_TCH_F || lchan->type == GSM_LCHAN_TCH_H) { > I'd go for a switch statement here, but not critical. done https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/a10937cb_11d0cbc0 PS4, Line 1816: rate_ctr_add(rate_ctr_group_get_ctr(bts_ctrs, BTS_CTR_LCHAN_TCH_TOTAL_ACTIVE_MILLISECONDS), duration_ms); > my gut feeling also goes more towards a stat_item, but I didn't spend a lot of time contemplating it […] Agreed. Converted to stat_item. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 5 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Feb 2022 17:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: WIP: New stats for lchan life duration.

by iedemam

Attention is currently required from: iedemam, neels, pespin. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 to look at the new patch set (#5). Change subject: WIP: New stats for lchan life duration. ...................................................................... WIP: New stats for lchan life duration. This patch adds two stats which track cummulative lchan lifetime by type TCH and SDCCH. These new counters will accomplish two things: 1) Provide a glanceable way to see if lchan durations look healthy. When examining a site, short-lived (<5s) and long-lived (>30s) TCH lchans are difficult to tell apart. If we only see short-lived TCH lchans, there is most likely an RF or signaling problem to investigate. This new counter will expose channel ages in the VTY output 2) Provide a more accurate count for Erlangs per site. Currently, we are basing Erlangs on active TCH channel counts per stats period. This method skews high very quickly. Each active TCH in that period translates into the full 10s of activity. This counter should improve accuracy by two orders of magnitude. Approach: - For now: a time calculation between channel activation and release - Maybe cleaner: use osmo_time_cc Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx_vty.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/lchan_fsm.c 7 files changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/27081/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 5 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-ggsn-tests-ogs: Configuration fixes for IPv6 tests

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27096 ) Change subject: ttcn3-ggsn-tests-ogs: Configuration fixes for IPv6 tests ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6fe98f6642bbd42376c9ed7353b58451c104eaca Gerrit-Change-Number: 27096 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Feb 2022 17:08:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-ggsn-tests-ogs: Set correct DNS address to get ping working

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27094 ) Change subject: ttcn3-ggsn-tests-ogs: Set correct DNS address to get ping working ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2a452ad871612d1c88b94579dadbe62b718b1475 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Feb 2022 17:08:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-ggsn-tests-ogs: use correct DNS addresses

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27095 ) Change subject: ttcn3-ggsn-tests-ogs: use correct DNS addresses ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia1045d86d6f07d41054f14be0b6efdf9c7169af2 Gerrit-Change-Number: 27095 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-ggsn-tests-ogs: Set correct DNS address to get ping working

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/27094 ) Change subject: ttcn3-ggsn-tests-ogs: Set correct DNS address to get ping working ...................................................................... ttcn3-ggsn-tests-ogs: Set correct DNS address to get ping working The DNS address provided is used by the test to ping. In osmo-ggsn, we configured the DNS to be the shared address between GTPC and GTPU. In open5gs, the addresses are different. Hence, let's pass the GTPU address instead of the GTPC address to make the setup easier (no need to have proper routing working between UPFD and SMFD containers). Change-Id: I2a452ad871612d1c88b94579dadbe62b718b1475 --- M ttcn3-ggsn-test/ogs/GGSN_Tests.cfg M ttcn3-ggsn-test/ogs/smfd.yaml 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/27094/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2a452ad871612d1c88b94579dadbe62b718b1475 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-ggsn-tests-ogs: Configuration fixes for IPv6 tests

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/27096 ) Change subject: ttcn3-ggsn-tests-ogs: Configuration fixes for IPv6 tests ...................................................................... ttcn3-ggsn-tests-ogs: Configuration fixes for IPv6 tests Change-Id: I6fe98f6642bbd42376c9ed7353b58451c104eaca --- M ttcn3-ggsn-test/ogs/smfd.yaml M ttcn3-ggsn-test/ogs/upfd-setup.sh M ttcn3-ggsn-test/ogs/upfd.yaml 3 files changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/27096/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6fe98f6642bbd42376c9ed7353b58451c104eaca Gerrit-Change-Number: 27096 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-ggsn-tests-ogs: Configuration fixes for IPv6 tests

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27096 ) Change subject: ttcn3-ggsn-tests-ogs: Configuration fixes for IPv6 tests ...................................................................... ttcn3-ggsn-tests-ogs: Configuration fixes for IPv6 tests Change-Id: I6fe98f6642bbd42376c9ed7353b58451c104eaca --- M ttcn3-ggsn-test/ogs/smfd.yaml M ttcn3-ggsn-test/ogs/upfd-setup.sh M ttcn3-ggsn-test/ogs/upfd.yaml 3 files changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/27096/1 diff --git a/ttcn3-ggsn-test/ogs/smfd.yaml b/ttcn3-ggsn-test/ogs/smfd.yaml index a0be176..0860074 100644 --- a/ttcn3-ggsn-test/ogs/smfd.yaml +++ b/ttcn3-ggsn-test/ogs/smfd.yaml @@ -342,10 +342,11 @@ subnet: - addr: 176.16.222.1/24 dnn: internet - - addr: 2001:780:44:2000:0:0:0:0/56 + - addr: 2001:780:44:2000:0:0:0:1/56 dnn: inet6 - addr: 176.16.46.1/24 - addr: 2001:780:44:2100:0:0:0:0/56 + dnn: inet46 + - addr: 2001:780:44:2100:0:0:0:1/56 dnn: inet46 dns: diff --git a/ttcn3-ggsn-test/ogs/upfd-setup.sh b/ttcn3-ggsn-test/ogs/upfd-setup.sh index fcd18a3..c96a561 100755 --- a/ttcn3-ggsn-test/ogs/upfd-setup.sh +++ b/ttcn3-ggsn-test/ogs/upfd-setup.sh @@ -19,9 +19,9 @@ create_tun "ogstun46" add_addr "ogstun4" "176.16.222.1/16" -add_addr "ogstun6" "2001:780:44:2000:0:0:0:1/64" +add_addr "ogstun6" "2001:780:44:2000:0:0:0:1/56" add_addr "ogstun46" "176.16.46.1/24" -add_addr "ogstun46" "2001:780:44:2100:0:0:0:1/64" +add_addr "ogstun46" "2001:780:44:2100:0:0:0:1/56" ip link set ogstun4 up ip link set ogstun6 up diff --git a/ttcn3-ggsn-test/ogs/upfd.yaml b/ttcn3-ggsn-test/ogs/upfd.yaml index 4e56f6e..8fe932b 100644 --- a/ttcn3-ggsn-test/ogs/upfd.yaml +++ b/ttcn3-ggsn-test/ogs/upfd.yaml @@ -159,11 +159,13 @@ - addr: 176.16.222.1/24 dnn: internet dev: ogstun4 - - addr: 2001:780:44:2000:0:0:0:1/64 + - addr: 2001:780:44:2000:0:0:0:1/56 dnn: inet6 dev: ogstun6 - addr: 176.16.46.1/24 - addr: 2001:780:44:2100:0:0:0:1/64 + dnn: inet46 + dev: ogstun46 + - addr: 2001:780:44:2100:0:0:0:1/56 dnn: inet46 dev: ogstun46 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6fe98f6642bbd42376c9ed7353b58451c104eaca Gerrit-Change-Number: 27096 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-ggsn-tests-ogs: Set correct DNS address to get ping working

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27094 ) Change subject: ttcn3-ggsn-tests-ogs: Set correct DNS address to get ping working ...................................................................... ttcn3-ggsn-tests-ogs: Set correct DNS address to get ping working The DNS address provided is used by the test to ping. In osmo-ggsn, we configured the DNS to be the shared address between GTPC and GTPU. In open5gs, the addresses are different. Hence, let's pass the GTPU address instead of the GTPC address to make the setup easier (no need to have proper routing working between UPFD and SMFD containers). Change-Id: I2a452ad871612d1c88b94579dadbe62b718b1475 --- M ttcn3-ggsn-test/ogs/smfd.yaml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/27094/1 diff --git a/ttcn3-ggsn-test/ogs/smfd.yaml b/ttcn3-ggsn-test/ogs/smfd.yaml index 1bdf03b..2e1fc08 100644 --- a/ttcn3-ggsn-test/ogs/smfd.yaml +++ b/ttcn3-ggsn-test/ogs/smfd.yaml @@ -349,7 +349,7 @@ dnn: inet46 dns: - - 172.18.3.201 + - 172.18.3.222 - 8.8.8.8 - fd02:db8:3::201 - 2001:4860:4860::8844 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2a452ad871612d1c88b94579dadbe62b718b1475 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022