December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: fixup: ttcn3-tcpdump*.sh: Fix output of special chars

by msuraev

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30682 ) Change subject: fixup: ttcn3-tcpdump*.sh: Fix output of special chars ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Checked in dash - works fine as well. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id28193a7ca00b5501a6852e5b4a5412fbaa5e063 Gerrit-Change-Number: 30682 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Dec 2022 18:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: Add osmo_stream_srv_link_is_opened()

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30686 ) Change subject: Add osmo_stream_srv_link_is_opened() ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91aa7da5f09ec4e8e2d21c827b45ed92e6b0e3d9 Gerrit-Change-Number: 30686 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 18 Dec 2022 18:10:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: osmo_stream_srv_link_close(): properly handle NULL input

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30685 ) Change subject: osmo_stream_srv_link_close(): properly handle NULL input ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie15bb3dc99bfe18065e03fde68d517b0d389b7ad Gerrit-Change-Number: 30685 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 18 Dec 2022 18:06:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-msc[master]: SMPP: use proper type for boolean variables

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30684 ) Change subject: SMPP: use proper type for boolean variables ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I033a2c863213a44f99827ef997f541a7a77f5d8a Gerrit-Change-Number: 30684 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 18 Dec 2022 17:43:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-msc[master]: libosmonetify SMPP

by msuraev

Attention is currently required from: laforge, pespin, fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 to look at the new patch set (#62). Change subject: libosmonetify SMPP ...................................................................... libosmonetify SMPP Use libosmo-netif instead of socket interface in OsmoMSC's SMPP. Closes: OS#5568 Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 --- M include/osmocom/smpp/smpp.h M include/osmocom/smpp/smpp_smsc.h M src/libsmpputil/smpp_smsc.c M src/libsmpputil/smpp_vty.c 4 files changed, 128 insertions(+), 151 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/49/28849/62 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 62 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-msc[master]: libosmonetify SMPP

by msuraev

Attention is currently required from: laforge, pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 ) Change subject: libosmonetify SMPP ...................................................................... Patch Set 61: (4 comments) File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/856e20e5_31b3bde1 PS49, Line 238: if (esme->use < 0) > Actually changing this check makes half of TTCN3 tests fail so I'd rather not mess with resource cou […] Done https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/bcdfc3e4_69c0b740 PS49, Line 825: static int esme_link_read_cb(struct osmo_stream_srv *conn) > Indeed, better rename it and make static. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/dad4182a_6c7e5517 PS49, Line 851: static int esme_link_close_cb(struct osmo_stream_srv *conn) > Simply give a look at the code. For instance: […] Done File src/libsmpputil/smpp_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/5dd757de_0e88a90b PS49, Line 83: bool is_running = smsc->link; > Sure, if it was used more than once. For a single call I don't think it's worth it. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 61 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Dec 2022 16:53:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-msc[master]: SMPP: refactor ref counting code

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30683 ) Change subject: SMPP: refactor ref counting code ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9cb530991f54aa78edaa885f1242f63c705b6fcb Gerrit-Change-Number: 30683 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 18 Dec 2022 16:51:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-msc[master]: libosmonetify SMPP

by msuraev

Attention is currently required from: laforge, fixeria, msuraev. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 to look at the new patch set (#61). Change subject: libosmonetify SMPP ...................................................................... libosmonetify SMPP Use libosmo-netif instead of socket interface in OsmoMSC's SMPP. Closes: OS#5568 Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 --- M include/osmocom/smpp/smpp.h M include/osmocom/smpp/smpp_smsc.h M src/libsmpputil/smpp_smsc.c M src/libsmpputil/smpp_vty.c 4 files changed, 127 insertions(+), 151 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/49/28849/61 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 61 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: fixup: ttcn3-tcpdump*.sh: Fix output of special chars

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30682 ) Change subject: fixup: ttcn3-tcpdump*.sh: Fix output of special chars ...................................................................... fixup: ttcn3-tcpdump*.sh: Fix output of special chars On ArchLinux /bin/sh is actually a symlink to bash, so bash is running in limited mode and emulating the Bourne Shell. The shell detection logic added in [1] does not work correctly for me because the cmdline would be 'sh' or '/bin/sh', not 'bash'. This is what I am getting: \033[1;32m====== FooBar_Tests.TC_foo_bar pass ======\033[0m Let's switch to printf, which does interpret the backslash escapes as expected by default, regardless of the actual shell in use. Also fix ttcn3-dumpcap-stop.sh, which was left untouched by [1]. Change-Id: Id28193a7ca00b5501a6852e5b4a5412fbaa5e063 Fixes: [1] bf45a5cff890a6103c68d76c1cf088c26ca9aa80 --- M ttcn3-dumpcap-stop.sh M ttcn3-tcpdump-stop.sh 2 files changed, 4 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/30682/1 diff --git a/ttcn3-dumpcap-stop.sh b/ttcn3-dumpcap-stop.sh index e13fbc0..188b8da 100755 --- a/ttcn3-dumpcap-stop.sh +++ b/ttcn3-dumpcap-stop.sh @@ -22,11 +22,10 @@ date if [ x"$VERDICT" = x"pass" ]; then - echo -e "\033[1;32m====== $TESTCASE $VERDICT ======\033[0m" + printf "\033[1;32m====== $TESTCASE $VERDICT ======\033[0m\n\n" else - echo -e "\033[1;31m------ $TESTCASE $VERDICT ------\033[0m" + printf "\033[1;31m------ $TESTCASE $VERDICT ------\033[0m\n\n" fi -echo if [ "z$TTCN3_PCAP_PATH" = "z" ]; then TTCN3_PCAP_PATH=/tmp diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index 0feaeaa..82d3a4f 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -26,21 +26,11 @@ date -# -e only works/is required only in Bash; in dash/POSIX shells it isn't required and will be part of the output -# SHELL environment variable doesn't always give name of current shell (e.g. for dash run inside bash...) -SHELL_NAME="$(cat /proc/$$/cmdline | tr -d '\0')" -if [ "$SHELL_NAME" = "bash" ]; then - ESCAPE_OPT="-e" -else - ESCAPE_OPT="" -fi - if [ x"$VERDICT" = x"pass" ]; then - echo $ESCAPE_OPT "\033[1;32m====== $TESTCASE $VERDICT ======\033[0m" + printf "\033[1;32m====== $TESTCASE $VERDICT ======\033[0m\n\n" else - echo $ESCAPE_OPT "\033[1;31m------ $TESTCASE $VERDICT ------\033[0m" + printf "\033[1;31m------ $TESTCASE $VERDICT ------\033[0m\n\n" fi -echo if [ "z$TTCN3_PCAP_PATH" = "z" ]; then TTCN3_PCAP_PATH=/tmp -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id28193a7ca00b5501a6852e5b4a5412fbaa5e063 Gerrit-Change-Number: 30682 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in pysim[master]: cards: check length of mnc more restrictively

by msuraev

Attention is currently required from: dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30635 ) Change subject: cards: check length of mnc more restrictively ...................................................................... Patch Set 1: (1 comment) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/30635/comment/34546a71_77b5c851 PS1, Line 213: raise RuntimeError('invalid length of mnc "{}"'.format(mnc)) It would be handy to also print what exactly we consider valid length in here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iee8f25416e0cc3be96dff025affb1dc11d919fcd Gerrit-Change-Number: 30635 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Dec 2022 14:05:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022