December 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: ctrl: add optional port to bind command

by msuraev

Attention is currently required from: osmith, laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 ) Change subject: ctrl: add optional port to bind command ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: > looks good, but please also send those patches porting over all the old osmo-* applications Sure, but shouldn't I wait for this to get merged first? Otherwise build verification will fail for them. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9 Gerrit-Change-Number: 30444 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 17 Dec 2022 16:11:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: osmo-stat-dummy: add rate counters and statsd tester

by msuraev

Attention is currently required from: laforge, pespin, msuraev. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30301 to look at the new patch set (#28). Change subject: osmo-stat-dummy: add rate counters and statsd tester ...................................................................... osmo-stat-dummy: add rate counters and statsd tester It's handy for testing rate counters as well as statsd metrics. Related: OS#5671 Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 --- M .gitignore M configure.ac M utils/Makefile.am A utils/osmo-stat-dummy/Makefile.am A utils/osmo-stat-dummy/osmo-stat-dummy.c A utils/osmo-stat-dummy/osmo-stat-dummy.cfg A utils/osmo-stat-dummy/osmo-stat-dummy.html 7 files changed, 446 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/30301/28 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 Gerrit-Change-Number: 30301 Gerrit-PatchSet: 28 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: ctrl: add optional port to bind command

by laforge

Attention is currently required from: osmith, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 ) Change subject: ctrl: add optional port to bind command ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: looks good, but please also send those patches porting over all the old osmo-* applications -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9 Gerrit-Change-Number: 30444 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Dec 2022 15:57:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: drop rate estimation code

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30304 ) Change subject: rate_ctr: drop rate estimation code ...................................................................... Patch Set 25: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I07232e9ff8bd62403ae82d9bd60d967d40b54ebc Gerrit-Change-Number: 30304 Gerrit-PatchSet: 25 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Dec 2022 15:55:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: WIP: vty: Add check against sensible default value for Ny1

by arehbein

Attention is currently required from: fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 ) Change subject: WIP: vty: Add check against sensible default value for Ny1 ...................................................................... Patch Set 9: (4 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/3e92aee9_e2d4e3a7 PS5, Line 837: static inline bool gsm_bts_check_ny1 > Is it really necessary to have this function static inline in a header? […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/51b4dada_6ddab62a PS5, Line 839: struct gsm_lchan *gl > const […] it's the initials of `gsm_lchan`. Do you mean I should put `struct gsm_lchang const *` instead to make clear contents are not to be changed? https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/03af4f18_96a50806 PS5, Line 842: if (gl) { > Not critical, but could be done a bit simpler: […] I would actually prefer it as is, at least I find there is a gain in readability that makes up for a few additional lines. https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/aacec502_8d726321 PS5, Line 855: talloc_strdup_append > Looks way too complicated, IMO. How about this? […] Ah yeah thanks! I don't know what I was doing there -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Dec 2022 15:52:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: WIP: vty: Add check against sensible default value for Ny1

by Jenkins Builder

Attention is currently required from: arehbein. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 ) Change subject: WIP: vty: Add check against sensible default value for Ny1 ...................................................................... Patch Set 9: (2 comments) File tests/nanobts_omlattr/nanobts_omlattr_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2035): https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/5fbc1f07_4f09a9cb PS9, Line 127: static unsigned long const T3105_TESTVAL = 13; Move const after static - use 'static const unsigned long' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2035): https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/a9063cba_116bdb99 PS9, Line 130: static unsigned long const NY1_TESTVAL = (GSM_T3124_MAX + GSM_NY1_REQ_DELTA)/T3105_TESTVAL + 1; Move const after static - use 'static const unsigned long' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Dec 2022 15:48:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: WIP: vty: Add check against sensible default value for Ny1

by arehbein

Attention is currently required from: arehbein. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 to look at the new patch set (#9). Change subject: WIP: vty: Add check against sensible default value for Ny1 ...................................................................... WIP: vty: Add check against sensible default value for Ny1 Related: OS#5475 Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M tests/nanobts_omlattr/nanobts_omlattr_test.c 4 files changed, 41 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/02/30602/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: WIP: vty: Add check against sensible default value for Ny1

by Jenkins Builder

Attention is currently required from: arehbein. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 ) Change subject: WIP: vty: Add check against sensible default value for Ny1 ...................................................................... Patch Set 8: (2 comments) File tests/nanobts_omlattr/nanobts_omlattr_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2034): https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/f11967da_2f0d6d68 PS8, Line 127: static unsigned long const T3105_TESTVAL = 13; Move const after static - use 'static const unsigned long' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2034): https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/36b163f1_985a5150 PS8, Line 130: static unsigned long const NY1_TESTVAL = (GSM_T3124_MAX + GSM_NY1_REQ_DELTA)/T3105_TESTVAL + 1; Move const after static - use 'static const unsigned long' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Dec 2022 15:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: WIP: vty: Add check against sensible default value for Ny1

by arehbein

Attention is currently required from: arehbein. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 to look at the new patch set (#8). Change subject: WIP: vty: Add check against sensible default value for Ny1 ...................................................................... WIP: vty: Add check against sensible default value for Ny1 Related: OS#5475 Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M tests/nanobts_omlattr/nanobts_omlattr_test.c 4 files changed, 48 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/02/30602/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: WIP: vty: Add check against sensible default value for Ny1

by Jenkins Builder

Attention is currently required from: arehbein. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 ) Change subject: WIP: vty: Add check against sensible default value for Ny1 ...................................................................... Patch Set 7: (2 comments) File tests/nanobts_omlattr/nanobts_omlattr_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2032): https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/7012e4c7_cc63112b PS7, Line 127: static unsigned long const T3105_TESTVAL = 13; Move const after static - use 'static const unsigned long' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2032): https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/11b288e9_1ca9f204 PS7, Line 130: static unsigned long const NY1_TESTVAL = (GSM_T3124_MAX + GSM_NY1_REQ_DELTA)/T3105_TESTVAL + 1; Move const after static - use 'static const unsigned long' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Dec 2022 15:26:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022