Attention is currently required from: dexter.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30629 )
Change subject: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/30629/comment/02992c58_3f36dcae
PS1, Line 11: networks. Also esch BTS model may have a preference for either one or the
typo: each BTS
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30629
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id53ebebdf987fc59cf4e38bcddb75663fd7bb8fc
Gerrit-Change-Number: 30629
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Dec 2022 13:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30075 )
Change subject: Fix compatibility with cmd2 >= 2.3.0
......................................................................
Patch Set 1:
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/30075/comment/74684054_53c85273
PS1, Line 26: from cmd2 import style, fg, bg
That's unnecessary complex and hard to read. It's better to simply bump the requirements for cmd2 to v2.3.0+
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/30075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9fd32c0fd8f6d40e00a318602af97c288605e8e5
Gerrit-Change-Number: 30075
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Dec 2022 13:54:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27391 )
Change subject: Revert "mgcp_codec: do not differentiate between oa and bwe when comparing codec"
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27391
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I0b2854ef2397f38606fab3425be586a3d0ca27d1
Gerrit-Change-Number: 27391
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Dec 2022 13:46:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30301 )
Change subject: osmo-stat-dummy: add rate counters and statsd tester
......................................................................
Patch Set 36:
(1 comment)
File utils/osmo-stat-dummy/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/30301/comment/62860377_1231c759
PS23, Line 6: osmo_stat_dummy_CFLAGS = -I../../.. $(TALLOC_CFLAGS) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOCTRL_CFLAGS)
> Because it's located in it's own subfolder (as you suggested) so it needs to go one level higher to […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7
Gerrit-Change-Number: 30301
Gerrit-PatchSet: 36
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Dec 2022 13:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment