December 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: pySim-prog: fix handling of mnclen parameter.

by laforge

Attention is currently required from: daniel, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30634 ) Change subject: pySim-prog: fix handling of mnclen parameter. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I48a109296efcd7a3f37c183ff53c5fc9544e3cfc Gerrit-Change-Number: 30634 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 11:14:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in pysim[master]: pySim-prog: clean up csv file reader function

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30632 ) Change subject: pySim-prog: clean up csv file reader function ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7ae995aa3297e77b983e59c75e1c3ef17e1d7cd4 Gerrit-Change-Number: 30632 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 11:14:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc-nat[master]: osmo-bsc-nat: Transition to use of 'telnet_init_default'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/30705 ) Change subject: osmo-bsc-nat: Transition to use of 'telnet_init_default' ...................................................................... osmo-bsc-nat: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: I7450b8618710bc7e51bfc57bdf1464c323471f16 --- M src/osmo-bsc-nat/main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bsc-nat/main.c b/src/osmo-bsc-nat/main.c index 01b08a2..9bf2500 100644 --- a/src/osmo-bsc-nat/main.c +++ b/src/osmo-bsc-nat/main.c @@ -128,7 +128,7 @@ exit(1); } - rc = telnet_init_dynif(tall_bsc_nat_ctx, g_bsc_nat, vty_get_bind_addr(), OSMO_VTY_PORT_BSC_NAT); + rc = telnet_init_default(tall_bsc_nat_ctx, g_bsc_nat, OSMO_VTY_PORT_BSC_NAT); if (rc < 0) { perror("Error binding VTY port"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/30705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7450b8618710bc7e51bfc57bdf1464c323471f16 Gerrit-Change-Number: 30705 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-hnbgw[master]: osmo-hnbgw: Transition to use of 'telnet_init_default'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/30713 ) Change subject: osmo-hnbgw: Transition to use of 'telnet_init_default' ...................................................................... osmo-hnbgw: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Id3256d09f62e802cc62fa9ba8aaafd403ccbb53e --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index a5cf533..5dba1e3 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -767,7 +767,7 @@ log_set_log_level(osmo_stderr_target, hnbgw_cmdline_config.log_level); - rc = telnet_init_dynif(tall_hnb_ctx, g_hnb_gw, vty_get_bind_addr(), OSMO_VTY_PORT_HNBGW); + rc = telnet_init_default(tall_hnb_ctx, g_hnb_gw, OSMO_VTY_PORT_HNBGW); if (rc < 0) { perror("Error binding VTY port"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/30713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id3256d09f62e802cc62fa9ba8aaafd403ccbb53e Gerrit-Change-Number: 30713 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc: Transition to use of 'telnet_init_default'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30704 ) Change subject: osmo-bsc: Transition to use of 'telnet_init_default' ...................................................................... osmo-bsc: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: I9d4dc72f8296f82937d2b97fd40a202f1ac98403 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index e1e1cb5..7b39937 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -488,8 +488,7 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(tall_bsc_ctx, bsc_gsmnet, vty_get_bind_addr(), - OSMO_VTY_PORT_NITB_BSC); + rc = telnet_init_default(tall_bsc_ctx, bsc_gsmnet, OSMO_VTY_PORT_NITB_BSC); if (rc < 0) return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9d4dc72f8296f82937d2b97fd40a202f1ac98403 Gerrit-Change-Number: 30704 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-gbproxy[master]: osmo-gbproxy: Transition to use of 'telnet_init_default'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/30710 ) Change subject: osmo-gbproxy: Transition to use of 'telnet_init_default' ...................................................................... osmo-gbproxy: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Ib76ab5df5d87112bf78effc4cd0939c57f30f46c --- M src/gb_proxy_main.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gb_proxy_main.c b/src/gb_proxy_main.c index da69f9c..243c51f 100644 --- a/src/gb_proxy_main.c +++ b/src/gb_proxy_main.c @@ -334,8 +334,7 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(tall_sgsn_ctx, NULL, - vty_get_bind_addr(), OSMO_VTY_PORT_GBPROXY); + rc = telnet_init_default(tall_sgsn_ctx, NULL, OSMO_VTY_PORT_GBPROXY); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/30710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ib76ab5df5d87112bf78effc4cd0939c57f30f46c Gerrit-Change-Number: 30710 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-e1-recorder[master]: osmo-e1-recorder: Transition to use of 'telnet_init_default'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30709 ) Change subject: osmo-e1-recorder: Transition to use of 'telnet_init_default' ...................................................................... osmo-e1-recorder: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Id8148f71f4231de40c4762094e2969d11821e5c4 --- M src/e1_recorder.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/e1_recorder.c b/src/e1_recorder.c index 7a93470..68d4543 100644 --- a/src/e1_recorder.c +++ b/src/e1_recorder.c @@ -208,7 +208,7 @@ } /* start telne tafte reading config for vty_get_bind_adr() */ - telnet_init_dynif(rec_tall_ctx, NULL, vty_get_bind_addr(), 4444); + telnet_init_default(rec_tall_ctx, NULL, 4444); while (1) { osmo_select_main(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Id8148f71f4231de40c4762094e2969d11821e5c4 Gerrit-Change-Number: 30709 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ggsn[master]: osmo-ggsn: Transition to use of 'telnet_init_default'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/30711 ) Change subject: osmo-ggsn: Transition to use of 'telnet_init_default' ...................................................................... osmo-ggsn: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: I51b7c175192759e26d1791723540841e72879b02 --- M ggsn/ggsn_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn/ggsn_main.c b/ggsn/ggsn_main.c index bc9e0c3..a7c96a7 100644 --- a/ggsn/ggsn_main.c +++ b/ggsn/ggsn_main.c @@ -223,7 +223,7 @@ exit(2); } - rc = telnet_init_dynif(tall_ggsn_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_GGSN); + rc = telnet_init_default(tall_ggsn_ctx, NULL, OSMO_VTY_PORT_GGSN); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/30711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I51b7c175192759e26d1791723540841e72879b02 Gerrit-Change-Number: 30711 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-e1d[master]: osmo-e1d: Transition to use of 'telnet_init_default'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/30708 ) Change subject: osmo-e1d: Transition to use of 'telnet_init_default' ...................................................................... osmo-e1d: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: I68fafc519d7c7ca9788bfcad7be1fadbb208cebe --- M src/osmo-e1d.c M src/osmo-e1gen.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-e1d.c b/src/osmo-e1d.c index 2a07763..dc264d9 100644 --- a/src/osmo-e1d.c +++ b/src/osmo-e1d.c @@ -205,7 +205,7 @@ exit(2); } - rv = telnet_init_dynif(g_e1d_ctx, e1d, vty_get_bind_addr(), OSMO_VTY_PORT_E1D); + rv = telnet_init_default(g_e1d_ctx, e1d, OSMO_VTY_PORT_E1D); if (rv != 0) { LOGP(DE1D, LOGL_FATAL, "Failed to bind VTY interface to %s:%u\n", vty_get_bind_addr(), OSMO_VTY_PORT_E1D); diff --git a/src/osmo-e1gen.c b/src/osmo-e1gen.c index 15d677a..008f083 100644 --- a/src/osmo-e1gen.c +++ b/src/osmo-e1gen.c @@ -411,7 +411,7 @@ exit(2); } - rv = telnet_init_dynif(g_e1d_ctx, e1d, vty_get_bind_addr(), OSMO_VTY_PORT_E1D); + rv = telnet_init_default(g_e1d_ctx, e1d, OSMO_VTY_PORT_E1D); if (rv != 0) { LOGP(DE1D, LOGL_FATAL, "Failed to bind VTY interface to %s:%u\n", vty_get_bind_addr(), OSMO_VTY_PORT_E1D); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/30708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I68fafc519d7c7ca9788bfcad7be1fadbb208cebe Gerrit-Change-Number: 30708 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-cbc[master]: osmo-cbc: Transition to use of 'telnet_init_default'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/30707 ) Change subject: osmo-cbc: Transition to use of 'telnet_init_default' ...................................................................... osmo-cbc: Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: I68f268cccc1ae00004aa63dbbf6708a581a1e705 --- M src/cbc_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/cbc_main.c b/src/cbc_main.c index fd8e4fe..e75b328 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -288,7 +288,7 @@ exit(1); } - rc = telnet_init_dynif(tall_cbc_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_CBC); + rc = telnet_init_default(tall_cbc_ctx, NULL, OSMO_VTY_PORT_CBC); if (rc < 0) { perror("Error binding VTY port"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/30707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I68f268cccc1ae00004aa63dbbf6708a581a1e705 Gerrit-Change-Number: 30707 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022