December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-sgsn[master]: Move gprs_gb_parse.[c,h] to tests/sgsn/

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30774 ) Change subject: Move gprs_gb_parse.[c,h] to tests/sgsn/ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia5a639832f52b2f015a2800bd0d94a28d7bc689b Gerrit-Change-Number: 30774 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 10:59:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: ctrl: take both address and port from vty config

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30662 ) Change subject: ctrl: take both address and port from vty config ...................................................................... ctrl: take both address and port from vty config Change-Id: Ic2c56ffee6237333d919c72bf26076ac24a1fa52 --- M include/osmocom/bsc/ctrl.h M src/osmo-bsc/bsc_ctrl_lookup.c M src/osmo-bsc/osmo_bsc_main.c 3 files changed, 4 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/bsc/ctrl.h b/include/osmocom/bsc/ctrl.h index af42b39..86d1bda 100644 --- a/include/osmocom/bsc/ctrl.h +++ b/include/osmocom/bsc/ctrl.h @@ -6,8 +6,7 @@ struct gsm_bts; struct bsc_msc_data; -struct ctrl_handle *bsc_controlif_setup(struct gsm_network *net, - const char *bind_addr, uint16_t port); +struct ctrl_handle *bsc_controlif_setup(struct gsm_network *net, uint16_t port); /* Used internally in different ctrl source code files: */ int bsc_bts_ctrl_cmds_install(void); diff --git a/src/osmo-bsc/bsc_ctrl_lookup.c b/src/osmo-bsc/bsc_ctrl_lookup.c index 6a11e32..145cda3 100644 --- a/src/osmo-bsc/bsc_ctrl_lookup.c +++ b/src/osmo-bsc/bsc_ctrl_lookup.c @@ -111,10 +111,7 @@ return -ERANGE; } -struct ctrl_handle *bsc_controlif_setup(struct gsm_network *net, - const char *bind_addr, uint16_t port) +struct ctrl_handle *bsc_controlif_setup(struct gsm_network *net, uint16_t port) { - return ctrl_interface_setup_dynip2(net, bind_addr, port, - bsc_ctrl_node_lookup, - _LAST_CTRL_NODE_BSC); + return ctrl_interface_setup2(net, port, bsc_ctrl_node_lookup, _LAST_CTRL_NODE_BSC); } diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 2656d23..e1e1cb5 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -945,9 +945,7 @@ /* start control interface after reading config for * ctrl_vty_get_bind_addr() */ - bsc_gsmnet->ctrl = bsc_controlif_setup(bsc_gsmnet, - ctrl_vty_get_bind_addr(), - OSMO_CTRL_PORT_NITB_BSC); + bsc_gsmnet->ctrl = bsc_controlif_setup(bsc_gsmnet, OSMO_CTRL_PORT_NITB_BSC); if (!bsc_gsmnet->ctrl) { fprintf(stderr, "Failed to init the control interface. Exiting.\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic2c56ffee6237333d919c72bf26076ac24a1fa52 Gerrit-Change-Number: 30662 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-hnbgw[master]: ctrl: take both address and port from vty config

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/30670 ) Change subject: ctrl: take both address and port from vty config ...................................................................... ctrl: take both address and port from vty config Change-Id: If5b80364c28fb1ca2bc00f4ece851de64c8ce6b1 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 2836ae1..a5cf533 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -773,8 +773,8 @@ exit(1); } - g_hnb_gw->ctrl = ctrl_interface_setup_dynip2(g_hnb_gw, ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_HNBGW, - hnb_ctrl_node_lookup, _LAST_CTRL_NODE_HNB); + g_hnb_gw->ctrl = ctrl_interface_setup2(g_hnb_gw, OSMO_CTRL_PORT_HNBGW, hnb_ctrl_node_lookup, + _LAST_CTRL_NODE_HNB); if (!g_hnb_gw->ctrl) { LOGP(DMAIN, LOGL_ERROR, "Failed to create CTRL interface on %s:%u\n", ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_HNBGW); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/30670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If5b80364c28fb1ca2bc00f4ece851de64c8ce6b1 Gerrit-Change-Number: 30670 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-hlr[master]: ctrl: take both address and port from vty config

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/30665 ) Change subject: ctrl: take both address and port from vty config ...................................................................... ctrl: take both address and port from vty config Change-Id: Iecae15333a4e77b38d9bce8c8e591af3d5fcf347 --- M include/osmocom/hlr/hlr.h M src/ctrl.c M src/hlr.c 3 files changed, 2 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/hlr/hlr.h b/include/osmocom/hlr/hlr.h index e8df5cd..3acb3c5 100644 --- a/include/osmocom/hlr/hlr.h +++ b/include/osmocom/hlr/hlr.h @@ -48,7 +48,6 @@ /* Control Interface */ struct ctrl_handle *ctrl; - const char *ctrl_bind_addr; /* Local bind addr */ char *gsup_bind_addr; diff --git a/src/ctrl.c b/src/ctrl.c index 11b0f5c..4e4afeb 100644 --- a/src/ctrl.c +++ b/src/ctrl.c @@ -771,11 +771,8 @@ struct ctrl_handle *hlr_controlif_setup(struct hlr *hlr) { int rc; - struct ctrl_handle *hdl = ctrl_interface_setup_dynip2(hlr, - hlr->ctrl_bind_addr, - OSMO_CTRL_PORT_HLR, - hlr_ctrl_node_lookup, - _LAST_CTRL_NODE_HLR); + struct ctrl_handle *hdl = ctrl_interface_setup2(hlr, OSMO_CTRL_PORT_HLR, hlr_ctrl_node_lookup, + _LAST_CTRL_NODE_HLR); if (!hdl) return NULL; diff --git a/src/hlr.c b/src/hlr.c index 193dd38..037ebfe 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -830,7 +830,6 @@ } proxy_init(g_hlr->gs); - g_hlr->ctrl_bind_addr = ctrl_vty_get_bind_addr(); g_hlr->ctrl = hlr_controlif_setup(g_hlr); dgsm_start(hlr_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Iecae15333a4e77b38d9bce8c8e591af3d5fcf347 Gerrit-Change-Number: 30665 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-smlc[master]: ctrl: take both address and port from vty config

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/30672 ) Change subject: ctrl: take both address and port from vty config ...................................................................... ctrl: take both address and port from vty config Change-Id: I5d73257c0233ce6772847809a6163b6ca4c88f83 --- M src/osmo-smlc/smlc_main.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-smlc/smlc_main.c b/src/osmo-smlc/smlc_main.c index 3f24a42..a2724b6 100644 --- a/src/osmo-smlc/smlc_main.c +++ b/src/osmo-smlc/smlc_main.c @@ -268,8 +268,7 @@ /* start control interface after reading config for * ctrl_vty_get_bind_addr() */ - g_smlc->ctrl = ctrl_interface_setup_dynip2(g_smlc, ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_SMLC, - smlc_ctrl_node_lookup, _LAST_CTRL_NODE_SMLC); + g_smlc->ctrl = ctrl_interface_setup2(g_smlc, OSMO_CTRL_PORT_SMLC, smlc_ctrl_node_lookup, _LAST_CTRL_NODE_SMLC); if (!g_smlc->ctrl) { fprintf(stderr, "Failed to init the control interface. Exiting.\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/30672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I5d73257c0233ce6772847809a6163b6ca4c88f83 Gerrit-Change-Number: 30672 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Initial libosmo-gprs-sndcp support

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30490 ) Change subject: sndcp: Initial libosmo-gprs-sndcp support ...................................................................... Patch Set 10: Code-Review+1 (1 comment) Patchset: PS10: Packaging and integration in Makefile.am files etc. looks good. I didn't look at all imported code in detail, and don't think it's required as you wrote: > Hence, this commit aims at being an initial point of having some working SNDCP stack by means of a few unit tests, but by no means aims to be a total working implementation. Some code paths are missing; bugs are expected at this point. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie05b5d721cf0a6147ed45c1feb75ad829865252b Gerrit-Change-Number: 30490 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 09:25:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ms-trx support

by osmith

Attention is currently required from: Hoernchen, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 31: (1 comment) Patchset: PS31: Fix for the CI failure: diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am index 5d88822..5493bf6 100644 --- a/Transceiver52M/Makefile.am +++ b/Transceiver52M/Makefile.am @@ -93,10 +93,13 @@ noinst_HEADERS += \ ms/ms.h \ ms/bladerf_specific.h \ ms/uhd_specific.h \ + ms/ms_rx_burst.h \ ms/ms_upper.h \ ms/itrq.h \ + ms/sch.h \ grgsm_vitac/viterbi_detector.h \ - grgsm_vitac/constants.h + grgsm_vitac/constants.h \ + grgsm_vitac/grgsm_vitac.h endif bin_PROGRAMS = -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 31 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 09:05:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: fixup: update osmocom-bb submodule to fix make distcheck

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30606 ) Change subject: fixup: update osmocom-bb submodule to fix make distcheck ...................................................................... Abandoned See https://gerrit.osmocom.org/c/osmo-trx/+/30607. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7dba8f09709ac7e6892d745698e19a5d37f84ba8 Gerrit-Change-Number: 30606 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: contrib/jenkins.sh: dump submodule status before building

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30603 ) Change subject: contrib/jenkins.sh: dump submodule status before building ...................................................................... contrib/jenkins.sh: dump submodule status before building Change-Id: I0f9d8f9213fd59605172fac011306c96c39bd5eb --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 584de07..728aab8 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -101,6 +101,7 @@ set -x cd "$base" +git submodule status autoreconf --install --force ./configure $CONFIG $MAKE $PARALLEL_MAKE -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0f9d8f9213fd59605172fac011306c96c39bd5eb Gerrit-Change-Number: 30603 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: contrib/jenkins.sh: dump submodule status before building

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30603 ) Change subject: contrib/jenkins.sh: dump submodule status before building ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0f9d8f9213fd59605172fac011306c96c39bd5eb Gerrit-Change-Number: 30603 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Dec 2022 21:34:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022