December 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: llc: Initialize gprs_cipher

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30773 ) Change subject: llc: Initialize gprs_cipher ...................................................................... llc: Initialize gprs_cipher Change-Id: Ifac6239a3695b69f694eb55574de64a62b0787ed --- M include/osmocom/gprs/llc/llc.h M src/llc/llc.c M tests/llc/llc_prim_test.c 3 files changed, 8 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/gprs/llc/llc.h b/include/osmocom/gprs/llc/llc.h index 062150e..32ea797 100644 --- a/include/osmocom/gprs/llc/llc.h +++ b/include/osmocom/gprs/llc/llc.h @@ -33,7 +33,7 @@ return get_value_string(osmo_gprs_llc_sapi_names, val); } -int osmo_gprs_llc_init(enum osmo_gprs_llc_location location); +int osmo_gprs_llc_init(enum osmo_gprs_llc_location location, const char *cipher_plugin_path); enum osmo_gprs_llc_log_cat { OSMO_GPRS_LLC_LOGC_LLC, diff --git a/src/llc/llc.c b/src/llc/llc.c index 402afab..3ddba6a 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -121,10 +121,14 @@ }, }; -int osmo_gprs_llc_init(enum osmo_gprs_llc_location location) +int osmo_gprs_llc_init(enum osmo_gprs_llc_location location, const char *cipher_plugin_path) { + int rc; OSMO_ASSERT(location == OSMO_GPRS_LLC_LOCATION_MS || location == OSMO_GPRS_LLC_LOCATION_SGSN) + if ((rc = gprs_cipher_load(cipher_plugin_path)) != 0) + return rc; + if (g_ctx) talloc_free(g_ctx); diff --git a/tests/llc/llc_prim_test.c b/tests/llc/llc_prim_test.c index 4630a4d..63f99aa 100644 --- a/tests/llc/llc_prim_test.c +++ b/tests/llc/llc_prim_test.c @@ -86,7 +86,7 @@ printf("==== %s() [start] ====\n", __func__); - rc = osmo_gprs_llc_init(OSMO_GPRS_LLC_LOCATION_MS); + rc = osmo_gprs_llc_init(OSMO_GPRS_LLC_LOCATION_MS, NULL); OSMO_ASSERT(rc == 0); osmo_gprs_llc_prim_set_up_cb(test_llc_prim_up_cb, NULL); @@ -156,7 +156,7 @@ printf("==== %s() [start] ====\n", __func__); - rc = osmo_gprs_llc_init(OSMO_GPRS_LLC_LOCATION_SGSN); + rc = osmo_gprs_llc_init(OSMO_GPRS_LLC_LOCATION_SGSN, NULL); OSMO_ASSERT(rc == 0); osmo_gprs_llc_prim_set_up_cb(test_llc_prim_up_cb, NULL); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ifac6239a3695b69f694eb55574de64a62b0787ed Gerrit-Change-Number: 30773 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-iuh[master]: contrib/jenkins.sh: werror with WITH_MANUALS too

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30750 ) Change subject: contrib/jenkins.sh: werror with WITH_MANUALS too ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6f1bbbc8d3ac04e8a82fb954c59ec30d6be46c13 Gerrit-Change-Number: 30750 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 12:36:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: trau_sync: support more than 40 bytes sync pattern.

by pespin

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29999 ) Change subject: trau_sync: support more than 40 bytes sync pattern. ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: > probably needs an update to TODO-RELEASE as it breaks ABI? why do you say it breaks ABI? I see only changes in a C file of a struct not allocated outside it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5be127ed5e39cb154e949b16fb08c26a1d816357 Gerrit-Change-Number: 29999 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 12:35:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-gprs[master]: llc: Initialize gprs_cipher

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30773 ) Change subject: llc: Initialize gprs_cipher ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/llc/llc.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30773/comment/eed91891_d298e140 PS1, Line 129: FIXME: pass path > indeed :P Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ifac6239a3695b69f694eb55574de64a62b0787ed Gerrit-Change-Number: 30773 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 12:34:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-gprs[master]: llc: Initialize gprs_cipher

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30773 to look at the new patch set (#2). Change subject: llc: Initialize gprs_cipher ...................................................................... llc: Initialize gprs_cipher Change-Id: Ifac6239a3695b69f694eb55574de64a62b0787ed --- M include/osmocom/gprs/llc/llc.h M src/llc/llc.c M tests/llc/llc_prim_test.c 3 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/73/30773/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ifac6239a3695b69f694eb55574de64a62b0787ed Gerrit-Change-Number: 30773 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmo-gprs[master]: llc: Initialize gprs_cipher

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30773 ) Change subject: llc: Initialize gprs_cipher ...................................................................... Patch Set 1: (1 comment) File src/llc/llc.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30773/comment/e9d9857a_d21a2b66 PS1, Line 129: FIXME: pass path > You already do below, don't you? indeed :P -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ifac6239a3695b69f694eb55574de64a62b0787ed Gerrit-Change-Number: 30773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 12:31:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-msc[master]: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec

by Jenkins Builder

Attention is currently required from: neels, laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30111 ) Change subject: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec ...................................................................... Patch Set 2: (1 comment) File src/libmsc/sdp_msg.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2247): https://gerrit.osmocom.org/c/osmo-msc/+/30111/comment/32b8b093_11c61ddf PS2, Line 266: codec->rate > 0? codec->rate : 8000); spaces required around that '?' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1892efd9360585f98419ebbd0df180f7f3a8160d Gerrit-Change-Number: 30111 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 23 Dec 2022 11:19:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-e1-recorder[master]: Add git-review config

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30727 ) Change subject: Add git-review config ...................................................................... Add git-review config Change-Id: I4ce3f6806fed00c452d859c164a42a4f9f3f7d1f --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..ef636c8 --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=osmo-e1-recorder -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I4ce3f6806fed00c452d859c164a42a4f9f3f7d1f Gerrit-Change-Number: 30727 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-e1-recorder[master]: Add git-review config

by laforge

Attention is currently required from: arehbein, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30727 ) Change subject: Add git-review config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/30727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I4ce3f6806fed00c452d859c164a42a4f9f3f7d1f Gerrit-Change-Number: 30727 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 11:16:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

by laforge

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 ) Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 11:16:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022