December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-gsm-tester[master]: jenkins-build-common: use 'git submodule update'

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30781 ) Change subject: jenkins-build-common: use 'git submodule update' ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: jenkins failure is unrelated. This patch is needed to fix the osmo-gsm-tester_build-osmo-trx jenkins job which has been failing. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic2b9207b942a8a9edff82737117b2ed9d6d3cfe3 Gerrit-Change-Number: 30781 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 14:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-gsm-tester[master]: jenkins-build-common: use 'git submodule update'

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30781 ) Change subject: jenkins-build-common: use 'git submodule update' ...................................................................... jenkins-build-common: use 'git submodule update' Now that we use git submodules in osmo-trx, make sure to initialize and update them before attempting to build. Fix for: Makefile.am:32: error: required directory ./osmocom-bb/src/host/trxcon does not exist Change-Id: Ic2b9207b942a8a9edff82737117b2ed9d6d3cfe3 --- M contrib/jenkins-build-common.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/81/30781/1 diff --git a/contrib/jenkins-build-common.sh b/contrib/jenkins-build-common.sh index 4a17d4d..b41fc05 100644 --- a/contrib/jenkins-build-common.sh +++ b/contrib/jenkins-build-common.sh @@ -102,6 +102,8 @@ echo "$(git rev-parse HEAD) $repo" >> "$prefix_real/${name}_git_hashes.txt" + git submodule update --init + cd "$base" } -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic2b9207b942a8a9edff82737117b2ed9d6d3cfe3 Gerrit-Change-Number: 30781 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ipc: remove old autotools workaround

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30780 ) Change subject: ipc: remove old autotools workaround ...................................................................... ipc: remove old autotools workaround Closes: OS#5845 Change-Id: I3f8a0204b1fda52d1228add8afde620274b164a5 --- M Transceiver52M/device/ipc/Makefile.am 1 file changed, 1 insertion(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/80/30780/1 diff --git a/Transceiver52M/device/ipc/Makefile.am b/Transceiver52M/device/ipc/Makefile.am index 7d8dd43..1653663 100644 --- a/Transceiver52M/device/ipc/Makefile.am +++ b/Transceiver52M/device/ipc/Makefile.am @@ -17,19 +17,11 @@ libdevice_la_LIBADD = $(top_builddir)/Transceiver52M/device/common/libdevice_common.la libdevice_la_CXXFLAGS = $(AM_CXXFLAGS) -DIPCMAGIC -#work around distclean issue on older autotools vers: -#a direct build of ../uhd/UHDDevice.cpp tries to clean -#../uhd/.dep/UHDDevice.Plo twice and fails -uhddev_ipc.cpp: - echo "#include \"../uhd/UHDDevice.cpp\"" >$@ -CLEANFILES= uhddev_ipc.cpp -BUILT_SOURCES = uhddev_ipc.cpp - if DEVICE_UHD bin_PROGRAMS = ipc-driver-test #ipc_driver_test_SHORTNAME = drvt -ipc_driver_test_SOURCES = ipc-driver-test.c uhdwrap.cpp ipc_shm.c ipc_chan.c ipc_sock.c uhddev_ipc.cpp +ipc_driver_test_SOURCES = ipc-driver-test.c uhdwrap.cpp ipc_shm.c ipc_chan.c ipc_sock.c ../uhd/UHDDevice.cpp ipc_driver_test_LDADD = \ shm.lo \ $(top_builddir)/Transceiver52M/device/common/libdevice_common.la \ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3f8a0204b1fda52d1228add8afde620274b164a5 Gerrit-Change-Number: 30780 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-hlr[master]: mslookup: use apn functions from libosmocore

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/30777 ) Change subject: mslookup: use apn functions from libosmocore ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I09d3c617fd6eb4075084ee106d3f3c5803861d2f Gerrit-Change-Number: 30777 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 14:20:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: obs: put git submodules into source packages

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30779 ) Change subject: obs: put git submodules into source packages ...................................................................... obs: put git submodules into source packages We started using git submodules with osmo-trx. Adjust the obs scripts to actually make the git submodules part of the source packages. Note that this didn't fail in jenkins before with the rpm build verification, as jenkins updates git submodules on its own. Fix for: [ 165s] Makefile.am:32: error: required directory ./osmocom-bb/src/host/trxcon does not exist Change-Id: I51b423f3885d6ead5c21a83bdf8ef6051dc34fe3 --- M scripts/obs/lib/git.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/scripts/obs/lib/git.py b/scripts/obs/lib/git.py index 8081a54..db1509b 100644 --- a/scripts/obs/lib/git.py +++ b/scripts/obs/lib/git.py @@ -56,6 +56,8 @@ lib.run_cmd(["git", "checkout", "-f", branch], cwd=repo_path) print(f"{project}: 'git reset --hard {branch}'") lib.run_cmd(["git", "reset", "--hard", branch], cwd=repo_path) + print(f"{project}: 'git submodule update --init'") + lib.run_cmd(["git", "submodule", "update", "--init"], cwd=repo_path) def checkout_from_review(project, gerrit_id): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I51b423f3885d6ead5c21a83bdf8ef6051dc34fe3 Gerrit-Change-Number: 30779 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: obs: put git submodules into source packages

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30779 ) Change subject: obs: put git submodules into source packages ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: merging this now, as this is trivial and required to fix the osmocom:master repository. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I51b423f3885d6ead5c21a83bdf8ef6051dc34fe3 Gerrit-Change-Number: 30779 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 14:19:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: obs: put git submodules into source packages

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30779 ) Change subject: obs: put git submodules into source packages ...................................................................... obs: put git submodules into source packages We started using git submodules with osmo-trx. Adjust the obs scripts to actually make the git submodules part of the source packages. Note that this didn't fail in jenkins before with the rpm build verification, as jenkins updates git submodules on its own. Fix for: [ 165s] Makefile.am:32: error: required directory ./osmocom-bb/src/host/trxcon does not exist Change-Id: I51b423f3885d6ead5c21a83bdf8ef6051dc34fe3 --- M scripts/obs/lib/git.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/79/30779/1 diff --git a/scripts/obs/lib/git.py b/scripts/obs/lib/git.py index 8081a54..db1509b 100644 --- a/scripts/obs/lib/git.py +++ b/scripts/obs/lib/git.py @@ -56,6 +56,8 @@ lib.run_cmd(["git", "checkout", "-f", branch], cwd=repo_path) print(f"{project}: 'git reset --hard {branch}'") lib.run_cmd(["git", "reset", "--hard", branch], cwd=repo_path) + print(f"{project}: 'git submodule update --init'") + lib.run_cmd(["git", "submodule", "update", "--init"], cwd=repo_path) def checkout_from_review(project, gerrit_id): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I51b423f3885d6ead5c21a83bdf8ef6051dc34fe3 Gerrit-Change-Number: 30779 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: clang-format: proper c++ standard

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30536 ) Change subject: clang-format: proper c++ standard ...................................................................... clang-format: proper c++ standard Change-Id: I9828093a08ed8b4c2a11f482f674368ac137d4dc --- M .clang-format 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/.clang-format b/.clang-format index a11c325..8c68525 100644 --- a/.clang-format +++ b/.clang-format @@ -515,7 +515,7 @@ SpacesInCStyleCastParentheses: false SpacesInParentheses: false SpacesInSquareBrackets: false -Standard: Cpp03 +Standard: Cpp11 TabWidth: 8 UseTab: Always ... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9828093a08ed8b4c2a11f482f674368ac137d4dc Gerrit-Change-Number: 30536 Gerrit-PatchSet: 18 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: clang-format: proper c++ standard

by Hoernchen

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30536 ) Change subject: clang-format: proper c++ standard ...................................................................... Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9828093a08ed8b4c2a11f482f674368ac137d4dc Gerrit-Change-Number: 30536 Gerrit-PatchSet: 17 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Dec 2022 13:41:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ipc: add missing override

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30487 ) Change subject: ipc: add missing override ...................................................................... ipc: add missing override Change-Id: Ib1493ac10b40d24372075d4cebd67015192675e0 --- M Transceiver52M/device/ipc/IPCDevice.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/device/ipc/IPCDevice.h b/Transceiver52M/device/ipc/IPCDevice.h index 35279a2..f70c95e 100644 --- a/Transceiver52M/device/ipc/IPCDevice.h +++ b/Transceiver52M/device/ipc/IPCDevice.h @@ -199,7 +199,7 @@ virtual double minRxGain(void) override; /* FIXME: return rx_gains[chan] ? receive factor from IPC Driver? */ - double rssiOffset(size_t chan) { return 0.0f; }; + double rssiOffset(size_t chan) override { return 0.0f; }; double setPowerAttenuation(int atten, size_t chan) override; double getPowerAttenuation(size_t chan = 0) override; 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib1493ac10b40d24372075d4cebd67015192675e0 Gerrit-Change-Number: 30487 Gerrit-PatchSet: 21 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022