November 2022 - gerrit-log - lists.osmocom.org

Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Unstable/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 66s] [393/504] installing lmodern-2.005-1 [ 67s] [394/504] installing sgml-data-2.0.11+nmu1 [ 67s] [395/504] installing libstdc++-12-dev-12.2.0-7 [ 68s] [396/504] installing libatk-bridge2.0-0-2.46.0-3 [ 68s] [397/504] installing libfontconfig1-2.13.1-4.5 [ 68s] Processing triggers for sgml-base (1.31) ... [ 68s] [398/504] installing libtool-2.4.7-4 [ 68s] [399/504] installing libenchant-2-2-2.3.3-1 [ 68s] [400/504] installing libpam-modules-1.5.2-5 [ 68s] [401/504] installing systemd-252-1 [ 69s] Created symlink /etc/systemd/system/getty.target.wants/getty(a)tty1.service -> /lib/systemd/system/getty@.service. [ 69s] Created symlink /etc/systemd/system/multi-user.target.wants/remote-fs.target -> /lib/systemd/system/remote-fs.target. [ 69s] Created symlink /etc/systemd/system/sysinit.target.wants/systemd-pstore.service -> /lib/systemd/system/systemd-pstore.service. [ 69s] Initializing machine ID from D-Bus machine ID. [ 69s] /usr/lib/tmpfiles.d/systemd.conf:28: Failed to resolve group 'systemd-journal'. [ 69s] /usr/lib/tmpfiles.d/systemd.conf:29: Failed to resolve group 'systemd-journal'. [ 69s] /usr/lib/tmpfiles.d/systemd.conf:30: Failed to resolve group 'systemd-journal'. [ 69s] dpkg: error processing package systemd (--install): [ 69s] installed systemd package post-installation script subprocess returned error exit status 65 [ 69s] Errors were encountered while processing: [ 69s] systemd [ 69s] exit ... [ 69s] ### VM INTERACTION START ### [ 69s] [ 55.526564][ T1] sysrq: Power Off [ 69s] [ 55.529682][ T7] reboot: Power down [ 69s] ### VM INTERACTION END ### [ 69s] [ 69s] sheep83 failed "build osmo-ggsn_1.9.0.2.3ed2.202211010053.dsc" at Tue Nov 1 09:56:24 UTC 2022. [ 69s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 7 months

1
0
0 0

Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/os… Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 80s] [393/504] installing lmodern-2.005-1 [ 81s] [394/504] installing sgml-data-2.0.11+nmu1 [ 82s] [395/504] installing libstdc++-12-dev-12.2.0-7 [ 83s] [396/504] installing libatk-bridge2.0-0-2.46.0-3 [ 83s] [397/504] installing libfontconfig1-2.13.1-4.5 [ 83s] Processing triggers for sgml-base (1.31) ... [ 83s] [398/504] installing libtool-2.4.7-4 [ 83s] [399/504] installing libenchant-2-2-2.3.3-1 [ 83s] [400/504] installing libpam-modules-1.5.2-5 [ 83s] [401/504] installing systemd-252-1 [ 84s] Created symlink /etc/systemd/system/getty.target.wants/getty(a)tty1.service -> /lib/systemd/system/getty@.service. [ 84s] Created symlink /etc/systemd/system/multi-user.target.wants/remote-fs.target -> /lib/systemd/system/remote-fs.target. [ 84s] Created symlink /etc/systemd/system/sysinit.target.wants/systemd-pstore.service -> /lib/systemd/system/systemd-pstore.service. [ 84s] Initializing machine ID from D-Bus machine ID. [ 84s] /usr/lib/tmpfiles.d/systemd.conf:28: Failed to resolve group 'systemd-journal'. [ 84s] /usr/lib/tmpfiles.d/systemd.conf:29: Failed to resolve group 'systemd-journal'. [ 84s] /usr/lib/tmpfiles.d/systemd.conf:30: Failed to resolve group 'systemd-journal'. [ 84s] dpkg: error processing package systemd (--install): [ 84s] installed systemd package post-installation script subprocess returned error exit status 65 [ 84s] Errors were encountered while processing: [ 84s] systemd [ 84s] exit ... [ 84s] ### VM INTERACTION START ### [ 84s] [ 65.413383][ T1] sysrq: Power Off [ 84s] [ 65.416439][ T16] reboot: Power down [ 84s] ### VM INTERACTION END ### [ 84s] [ 84s] lamb51 failed "build osmo-ggsn_1.9.0.dsc" at Tue Nov 1 09:56:21 UTC 2022. [ 84s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 7 months

1
0
0 0

Change in osmo-e1-hardware[master]: fw/e1-tracer: restrict dfu programming to e1-tracer devices

by tnt

Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29941 ) Change subject: fw/e1-tracer: restrict dfu programming to e1-tracer devices ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I6a17f01a621cd4af6827167427fafd2f9f277755 Gerrit-Change-Number: 29941 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 09:06:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1-hardware[master]: fw/e1-tracer: restrict dfu programming to e1-tracer devices

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29941 ) Change subject: fw/e1-tracer: restrict dfu programming to e1-tracer devices ...................................................................... Patch Set 3: (1 comment) File firmware/ice40-riscv/e1-tracer/Makefile: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29941/comment/89a386c8_254c… PS2, Line 87: $(DFU_UTIL) -R -d 1d50:6150,1d50:6151 -a 1 -D $< > dfu util doc says : […] nice catch! -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I6a17f01a621cd4af6827167427fafd2f9f277755 Gerrit-Change-Number: 29941 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 09:00:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <tnt(a)246tNt.com> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1-hardware[master]: doc/icE1usb: Fix typo

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29945 ) Change subject: doc/icE1usb: Fix typo ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I78fa7a69eed2d0112628396156174a83195f0238 Gerrit-Change-Number: 29945 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 01 Nov 2022 08:59:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29935 ) Change subject: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink ...................................................................... osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink Change-Id: I75ecf5369f31c8b8e9519d2b580355fa80c24196 --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 30 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index bf6703a..6a6331f 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -61,6 +61,15 @@ [24] = 1, /* TCH/F: a=17 / h=24 */ }; +/* TDMA frame number of burst 'a' should be used as the table index. */ +static const uint8_t sched_tchf_dl_amr_cmi_map[26] = { + [4] = 1, /* TCH/F: a=4 */ + [13] = 1, /* TCH/F: a=13 */ + [21] = 1, /* TCH/F: a=21 */ +}; + +extern const uint8_t sched_tchh_dl_amr_cmi_map[26]; + /*! \brief a single TCH/F burst was received by the PHY, process it */ int rx_tchf_fn(struct l1sched_ts *l1ts, const struct trx_ul_burst_ind *bi) { @@ -392,7 +401,7 @@ enum osmo_amr_type ft_codec; enum osmo_amr_quality bfi; int8_t sti, cmi; - bool amr_is_cmr = !dl_amr_fn_is_cmi(br->fn); + bool amr_is_cmr; if (rsl_cmode != RSL_CMOD_SPD_SPEECH) { LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Dropping speech frame, " @@ -430,6 +439,10 @@ "Codec (FT = %d) of RTP frame not in list\n", ft_codec); goto free_bad_msg; } + if (br->chan == TRXC_TCHF) + amr_is_cmr = !sched_tchf_dl_amr_cmi_map[br->fn % 26]; + else /* TRXC_TCHH_0 or TRXC_TCHH_1 */ + amr_is_cmr = !sched_tchh_dl_amr_cmi_map[br->fn % 26]; if (amr_is_cmr && chan_state->dl_ft != ft) { LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Codec (FT = %d) " " of RTP cannot be changed now, but in next frame\n", ft_codec); @@ -514,7 +527,8 @@ * the first FN 0,8,17 defines that CMR is included in frame. */ gsm0503_tch_afs_encode(*bursts_p, msg->l2h + sizeof(struct amr_hdr), - msgb_l2len(msg) - sizeof(struct amr_hdr), !dl_amr_fn_is_cmi(br->fn), + msgb_l2len(msg) - sizeof(struct amr_hdr), + !sched_tchf_dl_amr_cmi_map[br->fn % 26], chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 17073e0..37fd59d 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -66,6 +66,18 @@ [3] = 1, /* TCH/H(1): a=18 / d=24 / f=3 */ }; +/* TDMA frame number of burst 'a' should be used as the table index. + * This mapping is valid for both FACCH/H(0) and FACCH/H(1). */ +const uint8_t sched_tchh_dl_amr_cmi_map[26] = { + [4] = 1, /* TCH/H(0): a=4 */ + [13] = 1, /* TCH/H(0): a=13 */ + [21] = 1, /* TCH/H(0): a=21 */ + + [5] = 1, /* TCH/H(1): a=5 */ + [14] = 1, /* TCH/H(1): a=14 */ + [22] = 1, /* TCH/H(1): a=22 */ +}; + /* 3GPP TS 45.002, table 1 in clause 7: Mapping tables. * TDMA frame number of burst 'f' is always used as the table index. */ static const uint8_t sched_tchh_ul_facch_map[26] = { @@ -439,7 +451,8 @@ * in frame, the first FN 0,8,17 or 1,9,18 defines that CMR is * included in frame. */ gsm0503_tch_ahs_encode(*bursts_p, msg->l2h + sizeof(struct amr_hdr), - msgb_l2len(msg) - sizeof(struct amr_hdr), !dl_amr_fn_is_cmi(br->fn), + msgb_l2len(msg) - sizeof(struct amr_hdr), + !sched_tchh_dl_amr_cmi_map[br->fn % 26], chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I75ecf5369f31c8b8e9519d2b580355fa80c24196 Gerrit-Change-Number: 29935 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29936 ) Change subject: osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi() ...................................................................... osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi() The scheduler is now using the lookup tables instead of these functions. The only part using them is the AMR unit test. Change-Id: I1a9c80dd12252e7befe9c9bc8e8f7ee8648b5465 --- M src/osmo-bts-trx/sched_utils.h M tests/amr/amr_test.c M tests/amr/amr_test.ok 3 files changed, 1 insertion(+), 350 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_utils.h b/src/osmo-bts-trx/sched_utils.h index f76e49b..95f4a77 100644 --- a/src/osmo-bts-trx/sched_utils.h +++ b/src/osmo-bts-trx/sched_utils.h @@ -22,9 +22,6 @@ #pragma once #include <stdint.h> -#include <errno.h> -#include <stdbool.h> -#include <osmo-bts/scheduler.h> extern void *tall_bts_ctx; @@ -36,77 +33,3 @@ else return 10000 * n_errors / n_bits_total; } - -/*! determine whether an uplink AMR block is CMI according to 3GPP TS 45.009. - * \param[in] fn_begin frame number of the beginning of the block. - * \returns true in case of CMI; false otherwise. */ -static inline bool ul_amr_fn_is_cmi(uint32_t fn_begin) -{ - switch (fn_begin % 26) { - /*! See also: 3GPP TS 45.009, section 3.2.1.3 Transmitter/Receiver Synchronisation */ - /* valid for AHS subslot 0 and AFS: */ - case 0: - case 8: - case 17: - /* valid for AHS subslot 1: */ - case 1: - case 9: - case 18: - return true; - break; - /* Complementary values for sanity check */ - /* valid for AHS subslot 0 and AFS: */ - case 4: - case 13: - case 21: - /* valid for AHS subslot 1: */ - case 5: - case 14: - case 22: - return false; - break; - default: - LOGP(DL1P, LOGL_DEBUG, - "uplink frame number fn_begin=%u does not mark the beginning of a voice block!\n", fn_begin); - OSMO_ASSERT(false); - return false; - break; - } -} - -/*! determine the whether a downlink AMR block is CMI according to 3GPP TS 45.009. - * \param[in] fn_begin frame number of the beginning of the block. - * \returns true in case of CMI; false otherwise. */ -static inline bool dl_amr_fn_is_cmi(uint32_t fn_begin) -{ - switch (fn_begin % 26) { - /*! See also: 3GPP TS 45.009, section 3.2.1.3 Transmitter/Receiver Synchronisation */ - /* valid for AHS subslot 0 and AFS: */ - case 4: - case 13: - case 21: - /* valid for AHS subslot 1: */ - case 5: - case 14: - case 22: - return true; - break; - /* Complementary values for sanity check */ - /* valid for AHS subslot 0 and AFS: */ - case 0: - case 8: - case 17: - /* valid for AHS subslot 1: */ - case 1: - case 9: - case 18: - return false; - break; - default: - LOGP(DL1P, LOGL_DEBUG, - "downlink frame number fn_begin=%u does not mark the beginning of a voice block!\n", fn_begin); - OSMO_ASSERT(false); - return false; - break; - } -} diff --git a/tests/amr/amr_test.c b/tests/amr/amr_test.c index 480ff73..0fc58e7 100644 --- a/tests/amr/amr_test.c +++ b/tests/amr/amr_test.c @@ -27,126 +27,7 @@ #include <stdlib.h> #include <stdio.h> -#include "../../src/osmo-bts-trx/sched_utils.h" - -struct amr_cmi_test_data { - /* Frame number that marks the beginning of the voice block */ - uint32_t gsm_fn; - /* In uplink: True, when the voice block is a CMI block, false otherwise. */ - /* In downlink: False, when the voice block is a CMI block, true otherwise. */ - bool is_cmi; -}; - -/* The behavior of AHS in subslot 0 and AFS is the same */ -static const struct amr_cmi_test_data testvec_ahs_h0_and_afs[] = { - { 0, true }, - { 4, false }, - { 8, true }, - { 13, false }, - { 17, true }, - { 21, false }, - { 26, true }, - { 30, false }, - { 34, true }, - { 39, false }, - { 43, true }, - { 47, false }, - { 52, true }, - { 56, false }, - { 60, true }, - { 65, false }, - { 69, true }, - { 73, false }, - { 78, true }, - { 82, false }, - { 86, true }, - { 91, false }, - { 95, true }, - { 99, false }, -}; - -static const struct amr_cmi_test_data testvec_ahs_h1[] = { - { 1, true }, - { 5, false }, - { 9, true }, - { 14, false }, - { 18, true }, - { 22, false }, - { 27, true }, - { 31, false }, - { 35, true }, - { 40, false }, - { 44, true }, - { 48, false }, - { 53, true }, - { 57, false }, - { 61, true }, - { 66, false }, - { 70, true }, - { 74, false }, - { 79, true }, - { 83, false }, - { 87, true }, - { 92, false }, - { 96, true }, - { 100, false }, -}; - -static void test_amr_cmi_sched(void) -{ - unsigned int i; - bool res; - - printf("AMR transmission phase (CMI) in relation to GSM FN:\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h0_and_afs); i++) { - res = ul_amr_fn_is_cmi(testvec_ahs_h0_and_afs[i].gsm_fn); - printf("Uplink, AMR AHS on HR subslot 0: fn_begin=%u, CMI=%u\n", testvec_ahs_h0_and_afs[i].gsm_fn, res); - OSMO_ASSERT(res == testvec_ahs_h0_and_afs[i].is_cmi); - } - - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h0_and_afs); i++) { - res = dl_amr_fn_is_cmi(testvec_ahs_h0_and_afs[i].gsm_fn); - printf("Downlink, AMR AHS on HR subslot 0: fn_begin=%u, CMI=%u\n", testvec_ahs_h0_and_afs[i].gsm_fn, res); - OSMO_ASSERT(res == !testvec_ahs_h0_and_afs[i].is_cmi); - } - - printf("\n"); - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h1); i++) { - res = ul_amr_fn_is_cmi(testvec_ahs_h1[i].gsm_fn); - printf("Uplink, AMR AHS on HR subslot 1: fn_begin=%u, CMI=%u\n", testvec_ahs_h1[i].gsm_fn, res); - OSMO_ASSERT(res == testvec_ahs_h1[i].is_cmi); - } - - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h1); i++) { - res = dl_amr_fn_is_cmi(testvec_ahs_h1[i].gsm_fn); - printf("Downlink, AMR AHS on HR subslot 1: fn_begin=%u, CMI=%u\n", testvec_ahs_h1[i].gsm_fn, res); - OSMO_ASSERT(res == !testvec_ahs_h1[i].is_cmi); - } - - printf("\n"); - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h0_and_afs); i++) { - res = ul_amr_fn_is_cmi(testvec_ahs_h0_and_afs[i].gsm_fn); - printf("Uplink, AMR AFS: fn_begin=%u, CMI=%u\n", testvec_ahs_h0_and_afs[i].gsm_fn, res); - OSMO_ASSERT(res == testvec_ahs_h0_and_afs[i].is_cmi); - } - - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h0_and_afs); i++) { - res = dl_amr_fn_is_cmi(testvec_ahs_h0_and_afs[i].gsm_fn); - printf("Downlink, AMR AFS: fn_begin=%u, CMI=%u\n", testvec_ahs_h0_and_afs[i].gsm_fn, res); - OSMO_ASSERT(res == !testvec_ahs_h0_and_afs[i].is_cmi); - } -} +#include <errno.h> static void test_amr_parse_mr_conf(void) { @@ -185,7 +66,6 @@ log_set_print_level(osmo_stderr_target, 1); log_set_use_color(osmo_stderr_target, 0); - test_amr_cmi_sched(); test_amr_parse_mr_conf(); return EXIT_SUCCESS; } diff --git a/tests/amr/amr_test.ok b/tests/amr/amr_test.ok index f0d1830..921e8b9 100644 --- a/tests/amr/amr_test.ok +++ b/tests/amr/amr_test.ok @@ -1,155 +1,3 @@ -AMR transmission phase (CMI) in relation to GSM FN: -Uplink, AMR AHS on HR subslot 0: fn_begin=0, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=4, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=8, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=13, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=17, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=21, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=26, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=30, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=34, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=39, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=43, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=47, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=52, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=56, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=60, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=65, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=69, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=73, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=78, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=82, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=86, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=91, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=95, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=99, CMI=0 - -Downlink, AMR AHS on HR subslot 0: fn_begin=0, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=4, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=8, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=13, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=17, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=21, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=26, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=30, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=34, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=39, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=43, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=47, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=52, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=56, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=60, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=65, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=69, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=73, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=78, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=82, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=86, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=91, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=95, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=99, CMI=1 - - -Uplink, AMR AHS on HR subslot 1: fn_begin=1, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=5, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=9, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=14, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=18, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=22, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=27, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=31, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=35, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=40, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=44, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=48, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=53, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=57, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=61, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=66, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=70, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=74, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=79, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=83, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=87, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=92, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=96, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=100, CMI=0 - -Downlink, AMR AHS on HR subslot 1: fn_begin=1, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=5, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=9, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=14, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=18, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=22, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=27, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=31, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=35, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=40, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=44, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=48, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=53, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=57, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=61, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=66, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=70, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=74, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=79, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=83, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=87, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=92, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=96, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=100, CMI=1 - - -Uplink, AMR AFS: fn_begin=0, CMI=1 -Uplink, AMR AFS: fn_begin=4, CMI=0 -Uplink, AMR AFS: fn_begin=8, CMI=1 -Uplink, AMR AFS: fn_begin=13, CMI=0 -Uplink, AMR AFS: fn_begin=17, CMI=1 -Uplink, AMR AFS: fn_begin=21, CMI=0 -Uplink, AMR AFS: fn_begin=26, CMI=1 -Uplink, AMR AFS: fn_begin=30, CMI=0 -Uplink, AMR AFS: fn_begin=34, CMI=1 -Uplink, AMR AFS: fn_begin=39, CMI=0 -Uplink, AMR AFS: fn_begin=43, CMI=1 -Uplink, AMR AFS: fn_begin=47, CMI=0 -Uplink, AMR AFS: fn_begin=52, CMI=1 -Uplink, AMR AFS: fn_begin=56, CMI=0 -Uplink, AMR AFS: fn_begin=60, CMI=1 -Uplink, AMR AFS: fn_begin=65, CMI=0 -Uplink, AMR AFS: fn_begin=69, CMI=1 -Uplink, AMR AFS: fn_begin=73, CMI=0 -Uplink, AMR AFS: fn_begin=78, CMI=1 -Uplink, AMR AFS: fn_begin=82, CMI=0 -Uplink, AMR AFS: fn_begin=86, CMI=1 -Uplink, AMR AFS: fn_begin=91, CMI=0 -Uplink, AMR AFS: fn_begin=95, CMI=1 -Uplink, AMR AFS: fn_begin=99, CMI=0 - -Downlink, AMR AFS: fn_begin=0, CMI=0 -Downlink, AMR AFS: fn_begin=4, CMI=1 -Downlink, AMR AFS: fn_begin=8, CMI=0 -Downlink, AMR AFS: fn_begin=13, CMI=1 -Downlink, AMR AFS: fn_begin=17, CMI=0 -Downlink, AMR AFS: fn_begin=21, CMI=1 -Downlink, AMR AFS: fn_begin=26, CMI=0 -Downlink, AMR AFS: fn_begin=30, CMI=1 -Downlink, AMR AFS: fn_begin=34, CMI=0 -Downlink, AMR AFS: fn_begin=39, CMI=1 -Downlink, AMR AFS: fn_begin=43, CMI=0 -Downlink, AMR AFS: fn_begin=47, CMI=1 -Downlink, AMR AFS: fn_begin=52, CMI=0 -Downlink, AMR AFS: fn_begin=56, CMI=1 -Downlink, AMR AFS: fn_begin=60, CMI=0 -Downlink, AMR AFS: fn_begin=65, CMI=1 -Downlink, AMR AFS: fn_begin=69, CMI=0 -Downlink, AMR AFS: fn_begin=73, CMI=1 -Downlink, AMR AFS: fn_begin=78, CMI=0 -Downlink, AMR AFS: fn_begin=82, CMI=1 -Downlink, AMR AFS: fn_begin=86, CMI=0 -Downlink, AMR AFS: fn_begin=91, CMI=1 -Downlink, AMR AFS: fn_begin=95, CMI=0 -Downlink, AMR AFS: fn_begin=99, CMI=1 amr_parse_mr_conf() <- 20 a5 0d 46 52 54 amr_parse_mr_conf() -> num_modes=4 Mode[0] = 0/13/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a9c80dd12252e7befe9c9bc8e8f7ee8648b5465 Gerrit-Change-Number: 29936 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29935 ) Change subject: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > what happens to the old dl_amr_fn_is_cmi() function? can't it be dropped now? I am dropping it in a separate patch (next), because we also want to drop ul_amr_fn_is_cmi() and the related testcase. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I75ecf5369f31c8b8e9519d2b580355fa80c24196 Gerrit-Change-Number: 29935 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Nov 2022 08:46:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29935 ) Change subject: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I75ecf5369f31c8b8e9519d2b580355fa80c24196 Gerrit-Change-Number: 29935 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Nov 2022 08:44:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29936 ) Change subject: osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a9c80dd12252e7befe9c9bc8e8f7ee8648b5465 Gerrit-Change-Number: 29936 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Nov 2022 08:44:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022