Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29935 )
Change subject: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
what happens to the old dl_amr_fn_is_cmi() function? can't it be dropped now?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I75ecf5369f31c8b8e9519d2b580355fa80c24196
Gerrit-Change-Number: 29935
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Nov 2022 08:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29921 )
Change subject: contrib/jenkins.sh: Build e1-tracer host software
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
@osmith: So this fails as we don't have the software dependencies installed in the "hardware/firmware" docker container.
I guess the safest/sanest thing to do is to expand the jenkins job to have two separate steps: One related to the hardware/firmware (executed in the existing container) and one for the host software (executed in a normal osmocom software container)?
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29921
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I26e839de419c6eb86bf2a6250a1adf06b761d1fa
Gerrit-Change-Number: 29921
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Nov 2022 08:41:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29937 )
Change subject: BTS_Tests: fix TC_conn_fail_crit: tune the MS back to BCCH
......................................................................
BTS_Tests: fix TC_conn_fail_crit: tune the MS back to BCCH
osmo-bts-trx declares a connection failure when the radio link counter
S reaches 0. This counter is decreased every time the Viterbi decoder
yields a decoding error on the Uplink SACCH. For more details, see
3GPP TS 45.008, section 5.2.
The scheduler in osmo-bts-trx expects NOPE indications to be sent by
the transceiver in the absence of valid Uplink bursts. However, due
to the asynchronous nature of TRXD link, our virtual Um interface
implementation, fake_trx.py, does not generate NOPE indications on
it's own. Instead, trxcon is sending empty TRXDv0 PDUs (BURST.req),
which are then translated to proper TRXDv1 NOPE.ind by fake_trx.py.
The TC_conn_fail_crit currently sends L1CTL_DM_REL_REQ in order to
simulate connection loss, what makes trxcon disable all active
timeslots and thus stop sending NOPE.req to fake_trx.py.
Let's tune trxcon back to BCCH, in order to ensure that NOPE.req
messages are still being sent, so that osmo-bts-trx will be able
to declare a connection failure over the RSL as expected.
Change-Id: I34aee95111eafea90eeeea861682f1b4547d7b03
Related: Ic292d180ba64206fb4d88adb284f9f9d058b4587
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index cecdda1..9baee40 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3945,6 +3945,7 @@
f_est_dchan();
f_sleep(2.0);
L1CTL.send(ts_L1CTL_DM_REL_REQ(g_chan_nr));
+ f_l1_tune(L1CTL); /* tune back to BCCH */
timer T := 40.0;
T.start;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29937
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I34aee95111eafea90eeeea861682f1b4547d7b03
Gerrit-Change-Number: 29937
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29937 )
Change subject: BTS_Tests: fix TC_conn_fail_crit: tune the MS back to BCCH
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29937
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I34aee95111eafea90eeeea861682f1b4547d7b03
Gerrit-Change-Number: 29937
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Nov 2022 08:39:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29941
to look at the new patch set (#3).
Change subject: fw/e1-tracer: restrict dfu programming to e1-tracer devices
......................................................................
fw/e1-tracer: restrict dfu programming to e1-tracer devices
Let's explicitly specify the VID/PID of the e1-tracer in the dfu-util
invocation 'make dfuprog' to avoid accidentially programming other
attached dfu capable devices.
Change-Id: I6a17f01a621cd4af6827167427fafd2f9f277755
---
M firmware/ice40-riscv/e1-tracer/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/41/29941/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I6a17f01a621cd4af6827167427fafd2f9f277755
Gerrit-Change-Number: 29941
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29944 )
Change subject: doc/icE1usb: gateware is stored in flash and can be upgraded
......................................................................
doc/icE1usb: gateware is stored in flash and can be upgraded
Change-Id: I319ff4e75ba76543e562822b6b6d5968bccef237
---
M doc/manuals/chapters/gateware.adoc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/44/29944/1
diff --git a/doc/manuals/chapters/gateware.adoc b/doc/manuals/chapters/gateware.adoc
index 03487e1..a515cb1 100644
--- a/doc/manuals/chapters/gateware.adoc
+++ b/doc/manuals/chapters/gateware.adoc
@@ -6,6 +6,9 @@
picoRISCV soft-core running the [[firmware]] as well as the USB
device peripheral talking to the host PC.
+The gateware is stored in binary form on the device-internal
+non-volatile memory (SPI flash). It is field-upgradeable via USB.
+
As an OSHW project, all of it is available in source code format
at https://git.osmocom.org/osmo-e1-hardware/tree/gateware/icE1usb
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29944
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I319ff4e75ba76543e562822b6b6d5968bccef237
Gerrit-Change-Number: 29944
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29945 )
Change subject: doc/icE1usb: Fix typo
......................................................................
doc/icE1usb: Fix typo
Change-Id: I78fa7a69eed2d0112628396156174a83195f0238
---
M doc/manuals/chapters/hardware.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/45/29945/1
diff --git a/doc/manuals/chapters/hardware.adoc b/doc/manuals/chapters/hardware.adoc
index 4549cf4..bc27616 100644
--- a/doc/manuals/chapters/hardware.adoc
+++ b/doc/manuals/chapters/hardware.adoc
@@ -15,7 +15,7 @@
As icE1usb is an OSHW (Open Source Hardware) project, the full schematics
and design files are publicly available.
-The design files in KiCAD formwa are available at https://git.osmocom.org/osmo-e1-hardware/tree/hardware/icE1usb
+The design files in KiCAD format are available at https://git.osmocom.org/osmo-e1-hardware/tree/hardware/icE1usb
PDF rendered schematics are available at https://git.osmocom.org/osmo-e1-hardware/plain/hardware/icE1usb/r1.0/icE1us…
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29945
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I78fa7a69eed2d0112628396156174a83195f0238
Gerrit-Change-Number: 29945
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29946 )
Change subject: doc: Prepare for more than one user manual
......................................................................
doc: Prepare for more than one user manual
Move icE1usb specific chapters to chapters/icE1usb/ to prepare for
the upcoming e1-tracer user manual.
Change-Id: I4c6cdd4036051469640b86860ea19736aa04364a
---
M doc/manuals/Makefile
R doc/manuals/chapters/icE1usb/firmware.adoc
R doc/manuals/chapters/icE1usb/gateware.adoc
R doc/manuals/chapters/icE1usb/hardware.adoc
R doc/manuals/chapters/icE1usb/host-software.adoc
M doc/manuals/icE1usb-usermanual.adoc
6 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/46/29946/1
diff --git a/doc/manuals/Makefile b/doc/manuals/Makefile
index 2f87b57..63bd422 100644
--- a/doc/manuals/Makefile
+++ b/doc/manuals/Makefile
@@ -4,6 +4,6 @@
ASCIIDOC = icE1usb-usermanual.adoc
include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc
-icE1usb-usermanual.pdf: chapters/*.adoc
+icE1usb-usermanual.pdf: chapters/icE1usb/*.adoc
include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc
diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/icE1usb/firmware.adoc
similarity index 100%
rename from doc/manuals/chapters/firmware.adoc
rename to doc/manuals/chapters/icE1usb/firmware.adoc
diff --git a/doc/manuals/chapters/gateware.adoc b/doc/manuals/chapters/icE1usb/gateware.adoc
similarity index 100%
rename from doc/manuals/chapters/gateware.adoc
rename to doc/manuals/chapters/icE1usb/gateware.adoc
diff --git a/doc/manuals/chapters/hardware.adoc b/doc/manuals/chapters/icE1usb/hardware.adoc
similarity index 100%
rename from doc/manuals/chapters/hardware.adoc
rename to doc/manuals/chapters/icE1usb/hardware.adoc
diff --git a/doc/manuals/chapters/host-software.adoc b/doc/manuals/chapters/icE1usb/host-software.adoc
similarity index 100%
rename from doc/manuals/chapters/host-software.adoc
rename to doc/manuals/chapters/icE1usb/host-software.adoc
diff --git a/doc/manuals/icE1usb-usermanual.adoc b/doc/manuals/icE1usb-usermanual.adoc
index 5cfeef6..6069e07 100644
--- a/doc/manuals/icE1usb-usermanual.adoc
+++ b/doc/manuals/icE1usb-usermanual.adoc
@@ -6,12 +6,12 @@
include::./common/chapters/preface.adoc[]
-include::./chapters/hardware.adoc[]
+include::./chapters/icE1usb/hardware.adoc[]
-include::./chapters/gateware.adoc[]
+include::./chapters/icE1usb/gateware.adoc[]
-include::./chapters/firmware.adoc[]
+include::./chapters/icE1usb/firmware.adoc[]
-include::./chapters/host-software.adoc[]
+include::./chapters/icE1usb/host-software.adoc[]
include::./common/chapters/gfdl.adoc[]
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I4c6cdd4036051469640b86860ea19736aa04364a
Gerrit-Change-Number: 29946
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29942 )
Change subject: doc/icE1usb: fix warning about two list items '1'
......................................................................
doc/icE1usb: fix warning about two list items '1'
asciidoc: WARNING: firmware.adoc: line 25: list item index: expected 2 got 1
Change-Id: I7312538c6aa723e25176a6a5288ccab6c03e5f08
---
M doc/manuals/chapters/firmware.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/42/29942/1
diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc
index 5e4a11c..069a2ba 100644
--- a/doc/manuals/chapters/firmware.adoc
+++ b/doc/manuals/chapters/firmware.adoc
@@ -22,7 +22,7 @@
(obviously that requires a [still] working firmware present on the
device). To do so, please use `dfu-util -e`
-1. by pushing the push-button (see <<hw-pushbutton>>) during power-up.
+2. by pushing the push-button (see <<hw-pushbutton>>) during power-up.
Simply disconnect the USB cable, then push that button and keep it
pushed while re-attaching the USB cable.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29942
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I7312538c6aa723e25176a6a5288ccab6c03e5f08
Gerrit-Change-Number: 29942
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29943 )
Change subject: doc/icE1usb: Add link to older firmware builds
......................................................................
doc/icE1usb: Add link to older firmware builds
Change-Id: I8b97efbe4a644e5b9bbdec0bc764d55f7b59d2d2
---
M doc/manuals/chapters/firmware.adoc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/43/29943/1
diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc
index 069a2ba..3b47206 100644
--- a/doc/manuals/chapters/firmware.adoc
+++ b/doc/manuals/chapters/firmware.adoc
@@ -47,6 +47,8 @@
The latest firmware can be found at
https://ftp.osmocom.org/binaries/icE1usb/firmware/latest/
+a backlog of earlier builds can be found at
+https://ftp.osmocom.org/binaries/icE1usb/firmware/all/
The latest gateware can currently only be found at the personal developer
directory of tnt at https://people.osmocom.org/tnt/ice1usb/icE1usb-202010-bd399e96.bin
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29943
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I8b97efbe4a644e5b9bbdec0bc764d55f7b59d2d2
Gerrit-Change-Number: 29943
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange