Attention is currently required from: arehbein, lynxis lazus, dexter.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29903 )
Change subject: gb/vty: Show if NSVC is blocked locally by O&M/vty or by remote
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I tend to ignore the gerrit "Done" stuff as much as i can. it is possible to vote and merge a patch without clicking "Done" on all comments. I guess it is intended as a helpful feature but i'm not feeling it.
(Particularly, i find the UI to check-mark a number of N separate comments as "Done" really annoying.
Not all comments mean that something needs to be done. The magic that implicitly marks things as done / undone is sometimes leading to wrong markings. Or a patch owner marks things as Done without actually having addressed the comment. So i do not let that tick mark UI hog my attention.)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0e8a12c3e54b701c9e697d50de1c9cb0bcc817e0
Gerrit-Change-Number: 29903
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Nov 2022 13:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: lynxis lazus, dexter.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29903 )
Change subject: gb/vty: Show if NSVC is blocked locally by O&M/vty or by remote
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
> Its important to click "done" when an a comment is resolved.
Hmm I thought I had done that. Did I not? Edit: Ah I see now... I had, but it was stuck in draft mode.
File include/osmocom/core/fsm.h:
https://gerrit.osmocom.org/c/libosmocore/+/29903/comment/35e0e969_921f4cc8
PS3, Line 103: bool om_blocked;
> From my understanding, this is an NSVC related variable. […]
Done
File src/gb/gprs_ns2_vc_fsm.c:
https://gerrit.osmocom.org/c/libosmocore/+/29903/comment/a2c9fae8_bb1b3774
PS3, Line 341:
> ws
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0e8a12c3e54b701c9e697d50de1c9cb0bcc817e0
Gerrit-Change-Number: 29903
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Nov 2022 11:13:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29945 )
Change subject: doc/icE1usb: Fix typo
......................................................................
doc/icE1usb: Fix typo
Change-Id: I78fa7a69eed2d0112628396156174a83195f0238
---
M doc/manuals/chapters/hardware.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/doc/manuals/chapters/hardware.adoc b/doc/manuals/chapters/hardware.adoc
index 4549cf4..bc27616 100644
--- a/doc/manuals/chapters/hardware.adoc
+++ b/doc/manuals/chapters/hardware.adoc
@@ -15,7 +15,7 @@
As icE1usb is an OSHW (Open Source Hardware) project, the full schematics
and design files are publicly available.
-The design files in KiCAD formwa are available at https://git.osmocom.org/osmo-e1-hardware/tree/hardware/icE1usb
+The design files in KiCAD format are available at https://git.osmocom.org/osmo-e1-hardware/tree/hardware/icE1usb
PDF rendered schematics are available at https://git.osmocom.org/osmo-e1-hardware/plain/hardware/icE1usb/r1.0/icE1us…
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29945
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I78fa7a69eed2d0112628396156174a83195f0238
Gerrit-Change-Number: 29945
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29946 )
Change subject: doc: Prepare for more than one user manual
......................................................................
doc: Prepare for more than one user manual
Move icE1usb specific chapters to chapters/icE1usb/ to prepare for
the upcoming e1-tracer user manual.
Change-Id: I4c6cdd4036051469640b86860ea19736aa04364a
---
M doc/manuals/Makefile
R doc/manuals/chapters/icE1usb/firmware.adoc
R doc/manuals/chapters/icE1usb/gateware.adoc
R doc/manuals/chapters/icE1usb/hardware.adoc
R doc/manuals/chapters/icE1usb/host-software.adoc
M doc/manuals/icE1usb-usermanual.adoc
6 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
tnt: Looks good to me, approved
diff --git a/doc/manuals/Makefile b/doc/manuals/Makefile
index 2f87b57..63bd422 100644
--- a/doc/manuals/Makefile
+++ b/doc/manuals/Makefile
@@ -4,6 +4,6 @@
ASCIIDOC = icE1usb-usermanual.adoc
include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc
-icE1usb-usermanual.pdf: chapters/*.adoc
+icE1usb-usermanual.pdf: chapters/icE1usb/*.adoc
include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc
diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/icE1usb/firmware.adoc
similarity index 100%
rename from doc/manuals/chapters/firmware.adoc
rename to doc/manuals/chapters/icE1usb/firmware.adoc
diff --git a/doc/manuals/chapters/gateware.adoc b/doc/manuals/chapters/icE1usb/gateware.adoc
similarity index 100%
rename from doc/manuals/chapters/gateware.adoc
rename to doc/manuals/chapters/icE1usb/gateware.adoc
diff --git a/doc/manuals/chapters/hardware.adoc b/doc/manuals/chapters/icE1usb/hardware.adoc
similarity index 100%
rename from doc/manuals/chapters/hardware.adoc
rename to doc/manuals/chapters/icE1usb/hardware.adoc
diff --git a/doc/manuals/chapters/host-software.adoc b/doc/manuals/chapters/icE1usb/host-software.adoc
similarity index 100%
rename from doc/manuals/chapters/host-software.adoc
rename to doc/manuals/chapters/icE1usb/host-software.adoc
diff --git a/doc/manuals/icE1usb-usermanual.adoc b/doc/manuals/icE1usb-usermanual.adoc
index 5cfeef6..6069e07 100644
--- a/doc/manuals/icE1usb-usermanual.adoc
+++ b/doc/manuals/icE1usb-usermanual.adoc
@@ -6,12 +6,12 @@
include::./common/chapters/preface.adoc[]
-include::./chapters/hardware.adoc[]
+include::./chapters/icE1usb/hardware.adoc[]
-include::./chapters/gateware.adoc[]
+include::./chapters/icE1usb/gateware.adoc[]
-include::./chapters/firmware.adoc[]
+include::./chapters/icE1usb/firmware.adoc[]
-include::./chapters/host-software.adoc[]
+include::./chapters/icE1usb/host-software.adoc[]
include::./common/chapters/gfdl.adoc[]
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I4c6cdd4036051469640b86860ea19736aa04364a
Gerrit-Change-Number: 29946
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29942 )
Change subject: doc/icE1usb: fix warning about two list items '1'
......................................................................
doc/icE1usb: fix warning about two list items '1'
asciidoc: WARNING: firmware.adoc: line 25: list item index: expected 2 got 1
Change-Id: I7312538c6aa723e25176a6a5288ccab6c03e5f08
---
M doc/manuals/chapters/firmware.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
tnt: Looks good to me, approved
diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc
index 5e4a11c..069a2ba 100644
--- a/doc/manuals/chapters/firmware.adoc
+++ b/doc/manuals/chapters/firmware.adoc
@@ -22,7 +22,7 @@
(obviously that requires a [still] working firmware present on the
device). To do so, please use `dfu-util -e`
-1. by pushing the push-button (see <<hw-pushbutton>>) during power-up.
+2. by pushing the push-button (see <<hw-pushbutton>>) during power-up.
Simply disconnect the USB cable, then push that button and keep it
pushed while re-attaching the USB cable.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29942
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I7312538c6aa723e25176a6a5288ccab6c03e5f08
Gerrit-Change-Number: 29942
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29943 )
Change subject: doc/icE1usb: Add link to older firmware builds
......................................................................
doc/icE1usb: Add link to older firmware builds
Change-Id: I8b97efbe4a644e5b9bbdec0bc764d55f7b59d2d2
---
M doc/manuals/chapters/firmware.adoc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
tnt: Looks good to me, approved
diff --git a/doc/manuals/chapters/firmware.adoc b/doc/manuals/chapters/firmware.adoc
index 069a2ba..3b47206 100644
--- a/doc/manuals/chapters/firmware.adoc
+++ b/doc/manuals/chapters/firmware.adoc
@@ -47,6 +47,8 @@
The latest firmware can be found at
https://ftp.osmocom.org/binaries/icE1usb/firmware/latest/
+a backlog of earlier builds can be found at
+https://ftp.osmocom.org/binaries/icE1usb/firmware/all/
The latest gateware can currently only be found at the personal developer
directory of tnt at https://people.osmocom.org/tnt/ice1usb/icE1usb-202010-bd399e96.bin
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29943
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I8b97efbe4a644e5b9bbdec0bc764d55f7b59d2d2
Gerrit-Change-Number: 29943
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: merged