November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29993 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ied224520b9a09743bd19818ab00cbdf915baef34 Gerrit-Change-Number: 29993 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29993 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: ignoring linter results; just changing existing code here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ied224520b9a09743bd19818ab00cbdf915baef34 Gerrit-Change-Number: 29993 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:40:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ggsn[master]: cosmetic: gtp: Fix typo in comment

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29964 ) Change subject: cosmetic: gtp: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I54b80bba3126cb3ae534938e253721961d4e08c4 Gerrit-Change-Number: 29964 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:32:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libsmpp34[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29988 ) Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I42f0ef1c9eea62a2512a15543ff45d776155fdc5 Gerrit-Change-Number: 29988 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:27:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-hnbgw[master]: vty: Fix timers not printed when dumping running-config

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29968 ) Change subject: vty: Fix timers not printed when dumping running-config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I129bf412cd4b74e9f515411ef8f812a8261e57b2 Gerrit-Change-Number: 29968 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:26:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: obs: fix building rpms with man pages

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29992 ) Change subject: obs: fix building rpms with man pages ...................................................................... obs: fix building rpms with man pages Add the "%ext_man .gz" macro from OBS, so building rpms with man pages does not fail with errors like: File not found: /home/user/rpmbuild/BUILDROOT/osmo-ggsn-1.9.0.3.0d3b-0.x86_64/usr/share/man/man8/osmo-ggsn.8 Fixes: OS#5737 Change-Id: Ib6950fb46e9f94aabae98021b215f69838557045 --- M scripts/obs/data/build_rpm.sh A scripts/obs/data/rpmmacros 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/scripts/obs/data/build_rpm.sh b/scripts/obs/data/build_rpm.sh index 39f49ee..3ade17e 100755 --- a/scripts/obs/data/build_rpm.sh +++ b/scripts/obs/data/build_rpm.sh @@ -19,6 +19,7 @@ su "$BUILDUSER" -c "cp _temp/srcpkgs/$PACKAGE/$spec ~/rpmbuild/SPECS" su "$BUILDUSER" -c "cp _temp/srcpkgs/$PACKAGE/*.tar.* ~/rpmbuild/SOURCES" su "$BUILDUSER" -c "cp _temp/srcpkgs/$PACKAGE/rpmlintrc ~/rpmbuild/SOURCES" +su "$BUILDUSER" -c "cp /obs/data/rpmmacros ~/.rpmmacros" $yum_builddep "/home/$BUILDUSER/rpmbuild/SPECS/$spec" diff --git a/scripts/obs/data/rpmmacros b/scripts/obs/data/rpmmacros new file mode 100644 index 0000000..5ac26c7 --- /dev/null +++ b/scripts/obs/data/rpmmacros @@ -0,0 +1,5 @@ +# Default values for macros from OBS project config: +# https://build.opensuse.org/projects/CentOS:CentOS-8/prjconf + +%ext_info .gz +%ext_man .gz -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib6950fb46e9f94aabae98021b215f69838557045 Gerrit-Change-Number: 29992 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in libosmo-abis[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29976 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5ca56d885b5ce4d4c9f91ffc083c05a48d1306e4 Gerrit-Change-Number: 29976 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:26:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: obs: fix building rpms with man pages

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29992 ) Change subject: obs: fix building rpms with man pages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib6950fb46e9f94aabae98021b215f69838557045 Gerrit-Change-Number: 29992 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:26:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libsmpp34[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libsmpp34/+/29988 to look at the new patch set (#2). Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: I42f0ef1c9eea62a2512a15543ff45d776155fdc5 --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/88/29988/2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I42f0ef1c9eea62a2512a15543ff45d776155fdc5 Gerrit-Change-Number: 29988 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29993 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Patch Set 1: (2 comments) File tests/jibuf/jibuf_tool.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-710): https://gerrit.osmocom.org/c/libosmo-netif/+/29993/comment/45cc695a_bdb046c2 PS1, Line 506: void pcap_test_check(void) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-710): https://gerrit.osmocom.org/c/libosmo-netif/+/29993/comment/c0ee4259_a1648356 PS1, Line 510: void pcap_test(void) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ied224520b9a09743bd19818ab00cbdf915baef34 Gerrit-Change-Number: 29993 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 03 Nov 2022 11:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022