November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29981 to look at the new patch set (#2). Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I98a3c0d5cfda2c4b020652efb4f445f8288342b6 --- M src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c M src/libosmo-mgcp-client/mgcp_client_fsm.c M src/osmo-mgw/mgw_main.c M tests/mgcp/mgcp_test.c M tests/mgcp_client/mgcp_client_test.c 5 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/81/29981/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I98a3c0d5cfda2c4b020652efb4f445f8288342b6 Gerrit-Change-Number: 29981 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-mgw[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29991 to look at the new patch set (#2). Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: Ib397f3ad748e17f20b6177ef706af65088571f70 --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/91/29991/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib397f3ad748e17f20b6177ef706af65088571f70 Gerrit-Change-Number: 29991 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-ggsn[master]: Split gsn_t related APIs out of gtp.{c,h}

by Jenkins Builder

Attention is currently required from: laforge, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29965 ) Change subject: Split gsn_t related APIs out of gtp.{c,h} ...................................................................... Patch Set 2: (60 comments) File gtp/gsn.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b725e65e_be46b78d PS2, Line 68: int (*cb_delete_context) (struct pdp_t *); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/543ff95a_56b40c58 PS2, Line 68: int (*cb_delete_context) (struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/36ed6a93_f8791c01 PS2, Line 69: int (*cb_create_context_ind) (struct pdp_t *); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/9d3d2116_f9ff89c0 PS2, Line 69: int (*cb_create_context_ind) (struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b46a94c1_3f00bdbe PS2, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2b13fcbd_47c96dba PS2, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/04a08c52_e87fcf0a PS2, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c072f846_8fded976 PS2, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/32689aff_a52d304d PS2, Line 72: int (*cb_ran_info_relay_ind) (struct sockaddr_in *peer, union gtpie_member **ie); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4b99eb0e_fa84d245 PS2, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/6356a1bf_f240e83b PS2, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/eba7023e_15266efc PS2, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/97e4faa8_8df86f7f PS2, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/d64de49d_28595798 PS2, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/472a9dbf_23b29f50 PS2, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/75441155_c600177a PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/31900e2a_22c94648 PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/fdce0b76_f549b808 PS2, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4d5f1586_d212acdb PS2, Line 77: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, struct pdp_t *pdp, uint8_t recovery); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/87eddbce_7c0b82df PS2, Line 120: int (*cb_create_context_ind) (struct Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c1ea64db_af747dff PS2, Line 124: int (*cb_data_ind) (struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/65cb82ee_88192961 PS2, Line 124: int (*cb_data_ind) (struct pdp_t * pdp, Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/65c42418_2596f758 PS2, Line 127: int (*cb_delete_context) (struct pdp_t * Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/61c7bdbe_8b7f4a76 PS2, Line 133: int (*cb) (struct sockaddr_in * peer)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8c186918_a494f7f5 PS2, Line 133: int (*cb) (struct sockaddr_in * peer)); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/e28f0be0_a6752765 PS2, Line 136: int (*cb) (struct sockaddr_in * peer)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/db6528ea_c0ea0f4b PS2, Line 136: int (*cb) (struct sockaddr_in * peer)); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c39f3692_ac44d924 PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/d00eb78b_edcf6c18 PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/017094b7_4dd94def PS2, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2e45c7dc_a6437537 PS2, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp, Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b6c531ba_fc8691a1 PS2, Line 146: int (*cb) (struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/e0512f75_69b2dc0b PS2, Line 146: int (*cb) (struct sockaddr_in * peer, Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4f8cd68d_c12302a7 PS2, Line 150: int (*cb) (struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/853be247_a3acc0de PS2, Line 150: int (*cb) (struct sockaddr_in * peer, Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/67bf5f2c_1d4117ab PS2, Line 151: struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/82390934_485278d1 PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8ca9d718_5d670515 PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b7199d10_7095109d PS2, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/d2e8bf1c_2cc935cf PS2, Line 156: struct pdp_t * pdp, "foo * bar" should be "foo *bar" File gtp/gsn.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/ee427c53_dcbf6e47 PS2, Line 70: #define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/6cb494d8_c86ce4e5 PS2, Line 125: int (*cb) (struct sockaddr_in * peer)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c1fe374b_9cf8cc05 PS2, Line 125: int (*cb) (struct sockaddr_in * peer)) Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c936cff1_c5928f26 PS2, Line 132: int (*cb) (struct sockaddr_in * peer)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/fa576c23_1e289b03 PS2, Line 132: int (*cb) (struct sockaddr_in * peer)) Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7b21c5f1_e5d549cb PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7125fcee_ce5077a2 PS2, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2a4e8745_793778d2 PS2, Line 147: int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb) (struct pdp_t * pdp)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f62a7a4d_a60eae38 PS2, Line 154: int (*cb) (int type, int cause, Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/1941cb21_b1fa4836 PS2, Line 155: struct pdp_t * pdp, void *cbp)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/9b025aeb_7fbe720d PS2, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/bfd288c8_049ed37a PS2, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/ffb2792b_dcd93c57 PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/27923912_ec49d95c PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7b8413d4_5e173d9d PS2, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/226bf75a_99dab6d2 PS2, Line 190: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c730167b_d0b10e43 PS2, Line 198: int (*cb_data_ind) (struct pdp_t * pdp, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c8b04df1_9f858548 PS2, Line 198: int (*cb_data_ind) (struct pdp_t * pdp, Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/374c1624_91090adb PS2, Line 517: int (*cb_create_context_ind) (struct pdp_t * Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-719): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4defe9b3_e02628a8 PS2, Line 536: } adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I47cebb51bf08b9fcf7f115fc8dbea5f3493d4388 Gerrit-Change-Number: 29965 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:51:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ggsn[master]: cosmetic: gtp: Fix typo in comment

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29964 ) Change subject: cosmetic: gtp: Fix typo in comment ...................................................................... cosmetic: gtp: Fix typo in comment Change-Id: I54b80bba3126cb3ae534938e253721961d4e08c4 --- M gtp/gtp.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/gtp/gtp.c b/gtp/gtp.c index 2544555..d2f2219 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -543,7 +543,7 @@ * * The correct solution will be to make a queue containing response messages. * This queue should be checked whenever a request is received. If the - * response is allready in the queue that response should be transmitted. + * response is already in the queue that response should be transmitted. * It should be possible to find messages in this queue on the basis of * the sequence number and peer GSN IP address (The sequense number is unique * within each path). This need to be implemented by a hash table. Furthermore -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I54b80bba3126cb3ae534938e253721961d4e08c4 Gerrit-Change-Number: 29964 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-hlr[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/29990 to look at the new patch set (#2). Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: Id465254bf12eb84acb116c86711a5b52b4d3ad35 --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/90/29990/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id465254bf12eb84acb116c86711a5b52b4d3ad35 Gerrit-Change-Number: 29990 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-hlr[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/29980 to look at the new patch set (#2). Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I861be39275b40c522c02f553074c5a4489e87127 --- M src/ctrl.c M src/dgsm.c M src/hlr.c M src/hlr_db_tool.c M src/lu_fsm.c M src/mslookup/osmo-mslookup-client.c M src/mslookup_server.c M src/mslookup_server_mdns.c M tests/auc/auc_test.c M tests/auc/gen_ts_55_205_test_sets/main_template.c M tests/db/db_test.c M tests/mslookup/mdns_test.c M tests/mslookup/mslookup_client_test.c M tests/mslookup/mslookup_test.c 14 files changed, 24 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/80/29980/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I861be39275b40c522c02f553074c5a4489e87127 Gerrit-Change-Number: 29980 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29975 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Patch Set 5: (3 comments) File src/select.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-716): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/c18d53da_84e5cdfc PS5, Line 669: bool osmo_select_shutdown_done(void) { open brace '{' following function definitions go on the next line File src/vty/cpu_sched_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-716): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/8817832a_9ada5842 PS5, Line 92: static int get_num_cpus(void) { open brace '{' following function definitions go on the next line File tests/gsm0808/gsm0808_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-716): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/3383a635_a15e531d PS5, Line 1482: void test_cell_id_list_add(void) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:45:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29975 to look at the new patch set (#5). Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 --- M include/osmocom/core/counter.h M include/osmocom/core/select.h M include/osmocom/gprs/gprs_bssgp.h M include/osmocom/gsm/gsm0808.h M include/osmocom/vty/command.h M include/osmocom/vty/logging.h M src/counter.c M src/gb/gprs_bssgp.c M src/gsm/gsm0808.c M src/select.c M src/time_cc.c M src/vty/cpu_sched_vty.c M src/vty/logging_vty.c M src/vty/stats_vty.c M tests/abis/abis_test.c M tests/bitvec/bitvec_test.c M tests/bsslap/bsslap_test.c M tests/bssmap_le/bssmap_le_test.c M tests/codec/codec_ecu_fr_test.c M tests/ctrl/ctrl_test.c M tests/fr/fr_test.c M tests/fsm/fsm_dealloc_test.c M tests/fsm/fsm_test.c M tests/gad/gad_test.c M tests/gb/gprs_bssgp_rim_test.c M tests/gb/gprs_bssgp_test.c M tests/gb/gprs_ns_test.c M tests/gsm0408/gsm0408_test.c M tests/gsm0502/gsm0502_test.c M tests/gsm0808/gsm0808_test.c M tests/gsm23003/gsm23003_test.c M tests/gsm23236/gsm23236_test.c M tests/gsm29205/gsm29205_test.c M tests/gsm48/rest_octets_test.c M tests/lapd/lapd_test.c M tests/logging/logging_vty_test.c M tests/msgb/msgb_test.c M tests/sms/sms_test.c M tests/smscb/cbsp_test.c M tests/sockaddr_str/sockaddr_str_test.c M tests/socket/socket_test.c M tests/stats/stats_test.c M tests/tdef/tdef_test.c M tests/tdef/tdef_vty_config_root_test.c M tests/tdef/tdef_vty_config_subnode_test.c M tests/tdef/tdef_vty_dynamic_test.c M tests/time_cc/time_cc_test.c M tests/tlv/tlv_test.c M tests/use_count/use_count_test.c M tests/utils/utils_test.c M tests/vty/vty_test.c M tests/vty/vty_transcript_test.c M utils/osmo-aka-verify.c M utils/osmo-auc-gen.c M utils/osmo-ns-dummy.c 55 files changed, 214 insertions(+), 214 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/29975/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29979 to look at the new patch set (#2). Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I79c51b78d1b055361f9ef5434361847353791d0d --- M src/libosmo-gtlv/gtlv_gen.c M tests/libosmo-gtlv/gtlv_dec_enc_test.c M tests/libosmo-gtlv/gtlv_test.c M tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c M tests/libosmo-gtlv/test_tliv/tliv_test.c M tests/libosmo-pfcp/pfcp_test.c 6 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/79/29979/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I79c51b78d1b055361f9ef5434361847353791d0d Gerrit-Change-Number: 29979 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-pfcp[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29986 to look at the new patch set (#2). Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: I8e6cdc40cb77777677e5ffbbf3bf9e5c32555b2c --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/86/29986/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I8e6cdc40cb77777677e5ffbbf3bf9e5c32555b2c Gerrit-Change-Number: 29986 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022