November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29993 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: Ied224520b9a09743bd19818ab00cbdf915baef34 --- M tests/jibuf/jibuf_test.c M tests/jibuf/jibuf_tool.c 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/93/29993/1 diff --git a/tests/jibuf/jibuf_test.c b/tests/jibuf/jibuf_test.c index e1f51d6..7643797 100644 --- a/tests/jibuf/jibuf_test.c +++ b/tests/jibuf/jibuf_test.c @@ -622,7 +622,7 @@ /* This test aims at testing scenarios described in OS#3262, in which syncpoint packets can provoke a situation in which packets are stored out-of-order in the queue. */ -static void test_rtp_marker_queue_order() +static void test_rtp_marker_queue_order(void) { int min_delay = 60; struct msgb *msg; diff --git a/tests/jibuf/jibuf_tool.c b/tests/jibuf/jibuf_tool.c index b69686a..0502a98 100644 --- a/tests/jibuf/jibuf_tool.c +++ b/tests/jibuf/jibuf_tool.c @@ -336,7 +336,7 @@ return cb->data; } -void rand_send_rtp_packet() +void rand_send_rtp_packet(void) { struct rtp_pkt_info *pinfo; @@ -458,7 +458,7 @@ } } -void rand_test_check() +void rand_test_check(void) { uint32_t drop_threshold = NUM_PACKETS_TO_SEND * 5 / 100; if (packets_dropped > drop_threshold) { @@ -475,7 +475,7 @@ } } -void rand_test() +void rand_test(void) { srandom(time(NULL)); rtp_first_seq = (uint16_t) random(); @@ -503,11 +503,11 @@ rand_test_check(); } -void pcap_test_check() { +void pcap_test_check(void) { } -void pcap_test() { +void pcap_test(void) { osmo_pcap_init(); osmo_pcap.h = osmo_pcap_test_open(opt_pcap_file); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ied224520b9a09743bd19818ab00cbdf915baef34 Gerrit-Change-Number: 29993 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: obs: fix building rpms with man pages

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29992 ) Change subject: obs: fix building rpms with man pages ...................................................................... obs: fix building rpms with man pages Add the "%ext_man .gz" macro from OBS, so building rpms with man pages does not fail with errors like: File not found: /home/user/rpmbuild/BUILDROOT/osmo-ggsn-1.9.0.3.0d3b-0.x86_64/usr/share/man/man8/osmo-ggsn.8 Fixes: OS#5737 Change-Id: Ib6950fb46e9f94aabae98021b215f69838557045 --- M scripts/obs/data/build_rpm.sh A scripts/obs/data/rpmmacros 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/29992/1 diff --git a/scripts/obs/data/build_rpm.sh b/scripts/obs/data/build_rpm.sh index 39f49ee..3ade17e 100755 --- a/scripts/obs/data/build_rpm.sh +++ b/scripts/obs/data/build_rpm.sh @@ -19,6 +19,7 @@ su "$BUILDUSER" -c "cp _temp/srcpkgs/$PACKAGE/$spec ~/rpmbuild/SPECS" su "$BUILDUSER" -c "cp _temp/srcpkgs/$PACKAGE/*.tar.* ~/rpmbuild/SOURCES" su "$BUILDUSER" -c "cp _temp/srcpkgs/$PACKAGE/rpmlintrc ~/rpmbuild/SOURCES" +su "$BUILDUSER" -c "cp /obs/data/rpmmacros ~/.rpmmacros" $yum_builddep "/home/$BUILDUSER/rpmbuild/SPECS/$spec" diff --git a/scripts/obs/data/rpmmacros b/scripts/obs/data/rpmmacros new file mode 100644 index 0000000..5ac26c7 --- /dev/null +++ b/scripts/obs/data/rpmmacros @@ -0,0 +1,5 @@ +# Default values for macros from OBS project config: +# https://build.opensuse.org/projects/CentOS:CentOS-8/prjconf + +%ext_info .gz +%ext_man .gz -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib6950fb46e9f94aabae98021b215f69838557045 Gerrit-Change-Number: 29992 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/29985 to look at the new patch set (#2). Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: Icee84b6727f0242e7b2004214183c2389a0bb604 --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/85/29985/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icee84b6727f0242e7b2004214183c2389a0bb604 Gerrit-Change-Number: 29985 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29975 to look at the new patch set (#4). Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 --- M include/osmocom/core/counter.h M include/osmocom/core/select.h M include/osmocom/gprs/gprs_bssgp.h M include/osmocom/gsm/gsm0808.h M include/osmocom/vty/command.h M include/osmocom/vty/logging.h M src/counter.c M src/gb/gprs_bssgp.c M src/gsm/gsm0808.c M src/select.c M src/time_cc.c M src/vty/cpu_sched_vty.c M src/vty/logging_vty.c M src/vty/stats_vty.c M tests/abis/abis_test.c M tests/bitvec/bitvec_test.c M tests/bsslap/bsslap_test.c M tests/bssmap_le/bssmap_le_test.c M tests/codec/codec_ecu_fr_test.c M tests/ctrl/ctrl_test.c M tests/fr/fr_test.c M tests/fsm/fsm_dealloc_test.c M tests/fsm/fsm_test.c M tests/gad/gad_test.c M tests/gb/gprs_bssgp_rim_test.c M tests/gb/gprs_bssgp_test.c M tests/gb/gprs_ns_test.c M tests/gsm0408/gsm0408_test.c M tests/gsm0502/gsm0502_test.c M tests/gsm0808/gsm0808_test.c M tests/gsm23003/gsm23003_test.c M tests/gsm23236/gsm23236_test.c M tests/gsm29205/gsm29205_test.c M tests/gsm48/rest_octets_test.c M tests/lapd/lapd_test.c M tests/logging/logging_vty_test.c M tests/msgb/msgb_test.c M tests/sms/sms_test.c M tests/smscb/cbsp_test.c M tests/sockaddr_str/sockaddr_str_test.c M tests/socket/socket_test.c M tests/stats/stats_test.c M tests/tdef/tdef_test.c M tests/tdef/tdef_vty_config_root_test.c M tests/tdef/tdef_vty_config_subnode_test.c M tests/tdef/tdef_vty_dynamic_test.c M tests/time_cc/time_cc_test.c M tests/tlv/tlv_test.c M tests/use_count/use_count_test.c M tests/utils/utils_test.c M tests/vty/vty_test.c M tests/vty/vty_transcript_test.c M utils/osmo-aka-verify.c M utils/osmo-auc-gen.c M utils/osmo-ns-dummy.c 55 files changed, 214 insertions(+), 214 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/29975/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29983 to look at the new patch set (#4). Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: I8acd1b276f1ff8f015856d70fd582e457915ea11 --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/29983/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8acd1b276f1ff8f015856d70fd582e457915ea11 Gerrit-Change-Number: 29983 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-abis[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/29984 to look at the new patch set (#2). Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...if --enable-werror is used Change-Id: I707317f238faf598f32fffb629384dbd11e5fb45 --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/84/29984/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I707317f238faf598f32fffb629384dbd11e5fb45 Gerrit-Change-Number: 29984 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-abis[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/29976 to look at the new patch set (#2). Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore code that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I5ca56d885b5ce4d4c9f91ffc083c05a48d1306e4 --- M src/trau/osmo_ortp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/76/29976/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5ca56d885b5ce4d4c9f91ffc083c05a48d1306e4 Gerrit-Change-Number: 29976 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29975 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Patch Set 3: (4 comments) File include/osmocom/vty/command.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-704): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/51bd5200_6004bf40 PS3, Line 445: vector cmd_describe_command(vector vline, struct vty * vty, int *status); "foo * bar" should be "foo *bar" File src/select.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-704): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/4936fc83_faa99cce PS3, Line 669: bool osmo_select_shutdown_done(void) { open brace '{' following function definitions go on the next line File src/vty/cpu_sched_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-704): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/e58d21ac_a7eb1ca5 PS3, Line 92: static int get_num_cpus(void) { open brace '{' following function definitions go on the next line File tests/gsm0808/gsm0808_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-704): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/a6f3dc70_3ebfad8e PS3, Line 1482: void test_cell_id_list_add(void) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Nov 2022 11:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29983 to look at the new patch set (#3). Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ... if --enable-werror is used Change-Id: I8acd1b276f1ff8f015856d70fd582e457915ea11 --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/29983/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8acd1b276f1ff8f015856d70fd582e457915ea11 Gerrit-Change-Number: 29983 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29975 to look at the new patch set (#3). Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore cold that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 --- M include/osmocom/core/counter.h M include/osmocom/core/select.h M include/osmocom/gprs/gprs_bssgp.h M include/osmocom/gsm/gsm0808.h M include/osmocom/vty/command.h M include/osmocom/vty/logging.h M src/counter.c M src/gb/gprs_bssgp.c M src/gsm/gsm0808.c M src/select.c M src/time_cc.c M src/vty/cpu_sched_vty.c M src/vty/logging_vty.c M src/vty/stats_vty.c M tests/abis/abis_test.c M tests/bitvec/bitvec_test.c M tests/bsslap/bsslap_test.c M tests/bssmap_le/bssmap_le_test.c M tests/codec/codec_ecu_fr_test.c M tests/ctrl/ctrl_test.c M tests/fr/fr_test.c M tests/fsm/fsm_dealloc_test.c M tests/fsm/fsm_test.c M tests/gad/gad_test.c M tests/gb/gprs_bssgp_rim_test.c M tests/gb/gprs_bssgp_test.c M tests/gb/gprs_ns_test.c M tests/gsm0408/gsm0408_test.c M tests/gsm0502/gsm0502_test.c M tests/gsm0808/gsm0808_test.c M tests/gsm23003/gsm23003_test.c M tests/gsm23236/gsm23236_test.c M tests/gsm29205/gsm29205_test.c M tests/gsm48/rest_octets_test.c M tests/lapd/lapd_test.c M tests/logging/logging_vty_test.c M tests/msgb/msgb_test.c M tests/sms/sms_test.c M tests/smscb/cbsp_test.c M tests/sockaddr_str/sockaddr_str_test.c M tests/socket/socket_test.c M tests/stats/stats_test.c M tests/tdef/tdef_test.c M tests/tdef/tdef_vty_config_root_test.c M tests/tdef/tdef_vty_config_subnode_test.c M tests/tdef/tdef_vty_dynamic_test.c M tests/time_cc/time_cc_test.c M tests/tlv/tlv_test.c M tests/use_count/use_count_test.c M tests/utils/utils_test.c M tests/vty/vty_test.c M tests/vty/vty_transcript_test.c M utils/osmo-aka-verify.c M utils/osmo-auc-gen.c M utils/osmo-ns-dummy.c 55 files changed, 214 insertions(+), 214 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/29975/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022