Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30365 )
Change subject: mobile: make LUA support configurable via --with-lua53
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30365
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If440cee52410421034823a3749709e28c4136b95
Gerrit-Change-Number: 30365
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Nov 2022 09:28:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30361 )
Change subject: trxcon: link trxcon against libl1sched.la directly
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30361
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I8a1319077167f118d1909a8ab33d33a73f47541a
Gerrit-Change-Number: 30361
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Nov 2022 09:23:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30304 )
Change subject: rate_ctr: update estimation code
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30304
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I07232e9ff8bd62403ae82d9bd60d967d40b54ebc
Gerrit-Change-Number: 30304
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:56:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 )
Change subject: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> this is now the second time you have set something to +2 without two review +1 existing before. […]
I thought because of the heading in https://projects.osmocom.org/projects/cellular-infrastructure/wiki/Gerrit/e… that states there are exceptions for 'Urgent patches' (which I was under the impression this was, because it affected Jenkins):
> h3. Exceptions for Trivial / Urgent Patches
> A patch may receive a direct +2 when:
> * it is very trivial, like a typo fix in a comment or log string, so that it is not worth wasting review time on.
> * it reverts an earlier change that broke the master builds.
that a fixing could be also understood as a case of the second bullet point above (I know better now I suppose), also considering there was a +1 from you.
In the previous case I would have thought it do be a case of the first bullet point above.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e17d8313755c36f130982c921abf69d78c98ae6
Gerrit-Change-Number: 30364
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:55:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313 )
Change subject: ttcn3-tcpdump-stop.sh: Don't use lsof
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Ah this was meant to be a reply to Max's comment, but it seems like replies cannot refer to specific […]
This doesn't change the fact that this patch had exactly *one* positive review ("Revieew +1") at the time you decided to simply set it to +2 and merge it. This is not how the process works. You wait until somebody else has given a single +2, or there are two other people having voted with +1 which you are permitted to add to a +2: https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Code-Revie…
Particularly for a new developer in the project, it is important to follow the proces.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I38e132f49b0711d611d08b61c28b3092c991a191
Gerrit-Change-Number: 30313
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:35:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment