arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 )
Change subject: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
this is now the second time you have set something to
+2 without two review +1 existing before. […]
I thought because of the heading in
https://projects.osmocom.org/projects/cellular-infrastructure/wiki/Gerrit/e…
that states there are exceptions for 'Urgent patches' (which I was under the
impression this was, because it affected Jenkins):
h3. Exceptions for Trivial / Urgent Patches
A patch may receive a direct +2 when:
* it is very trivial, like a typo fix in a comment or log string, so that it is not worth
wasting review time on.
* it reverts an earlier change that broke the master builds.
that a fixing could be also understood as a case of the second bullet point above (I know
better now I suppose), also considering there was a +1 from you.
In the previous case I would have thought it do be a case of the first bullet point
above.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e17d8313755c36f130982c921abf69d78c98ae6
Gerrit-Change-Number: 30364
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:55:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment