November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed

by laforge

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 ) Change subject: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e17d8313755c36f130982c921abf69d78c98ae6 Gerrit-Change-Number: 30364 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Nov 2022 07:23:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: build libosmogapk for mobile app

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30366 to look at the new patch set (#2). Change subject: contrib/jenkins.sh: build libosmogapk for mobile app ...................................................................... contrib/jenkins.sh: build libosmogapk for mobile app Change-Id: I63186c338612039a46459b04ffc7060d97e78279 Related: OS#5599 --- M contrib/jenkins.sh 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/66/30366/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I63186c338612039a46459b04ffc7060d97e78279 Gerrit-Change-Number: 30366 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: integrate GAPK based audio (voice) I/O support

by fixeria

Attention is currently required from: fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30337 ) Change subject: mobile: integrate GAPK based audio (voice) I/O support ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib86b0746606c191573cc773f01172afbb52f33a9 Gerrit-Change-Number: 30337 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Nov 2022 00:15:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: contrib/jenkins.sh: build libosmogapk for mobile app

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30366 ) Change subject: contrib/jenkins.sh: build libosmogapk for mobile app ...................................................................... contrib/jenkins.sh: build libosmogapk for mobile app Change-Id: I63186c338612039a46459b04ffc7060d97e78279 Related: OS#5599 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/66/30366/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fafbdfb..410f32c 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -18,6 +18,7 @@ mkdir "$deps" || true osmo-build-dep.sh libosmocore "" ac_cv_path_DOXYGEN=false +osmo-build-dep.sh gapk # TODO: ask whether fail is expected, because osmocom-bb build succeeds? #"$deps"/libosmocore/contrib/verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]") -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30366 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I63186c338612039a46459b04ffc7060d97e78279 Gerrit-Change-Number: 30366 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: make LUA support configurable via --with-lua53

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30365 ) Change subject: mobile: make LUA support configurable via --with-lua53 ...................................................................... mobile: make LUA support configurable via --with-lua53 Change-Id: If440cee52410421034823a3749709e28c4136b95 --- M src/host/layer23/configure.ac 1 file changed, 13 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/65/30365/1 diff --git a/src/host/layer23/configure.ac b/src/host/layer23/configure.ac index f74efa2..50cb8ca 100644 --- a/src/host/layer23/configure.ac +++ b/src/host/layer23/configure.ac @@ -50,11 +50,19 @@ dnl optional dependencies -PKG_CHECK_MODULES(LIBLUA, lua53, [ - WITH_LUA=1], [ - WITH_LUA=0]) -AC_SUBST([WITH_LUA]) -AM_CONDITIONAL([BUILD_LUA], test "x$WITH_LUA" = "x1") +AC_ARG_WITH([lua53], [ + AS_HELP_STRING([--with-lua53], + [Enable LUA scripting support @<:@default=check@:>@]) +]) + +found_lua53=no +AS_IF([test "x$with_lua53" != "xno"], [ + PKG_CHECK_MODULES(LIBLUA, lua53, [found_lua53=yes], [found_lua53=no]) + AS_IF([test "x$with_lua53" = "xyes" -a "x$found_lua53" = "xno"], [ + AC_MSG_ERROR([lua53 support requested but pkg-config is unable to find it]) + ]) +]) +AM_CONDITIONAL([BUILD_LUA], test "x$found_lua53" = "xyes") dnl checks for header files AC_HEADER_STDC -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If440cee52410421034823a3749709e28c4136b95 Gerrit-Change-Number: 30365 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed

by arehbein

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 to look at the new patch set (#2). Change subject: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed ...................................................................... ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed Also: Fix possibly empty files not being deleted. Fixes: cf8c450ed5f9c8e9f767509fa156cf2368aaebe6 Fixes: OS#5796 Change-Id: I4e17d8313755c36f130982c921abf69d78c98ae6 --- M ttcn3-tcpdump-start.sh M ttcn3-tcpdump-stop.sh 2 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/30364/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e17d8313755c36f130982c921abf69d78c98ae6 Gerrit-Change-Number: 30364 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 ) Change subject: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed ...................................................................... ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed Also: Fix possibly empty files not being deleted. Fixes: cf8c450ed5f9c8e9f767509fa156cf2368aaebe6 Fixes: OS#5796 Change-Id: I4e17d8313755c36f130982c921abf69d78c98ae6 --- M ttcn3-tcpdump-start.sh M ttcn3-tcpdump-stop.sh 2 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/30364/1 diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index aa42e62..4c68448 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -21,8 +21,10 @@ kill_rm_pidfile() { # NOTE: This requires you to be root or something like # "laforge ALL=NOPASSWD: /usr/sbin/tcpdump, /bin/kill" in your sudoers file - if ! [ -e "$1" ] && [ -s "$1" ]; then - $SUDOSTR kill "$(cat "$1")" 2>&1 | grep -v "No such process" + if [ -e "$1" ]; then + if [ -s "$1" ]; then + $SUDOSTR kill "$(cat "$1")" 2>&1 | grep -v "No such process" + fi rm $1 fi } diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index b479530..0feaeaa 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -16,8 +16,10 @@ kill_rm_pidfile() { # NOTE: This requires you to be root or something like # "laforge ALL=NOPASSWD: /usr/sbin/tcpdump, /bin/kill" in your sudoers file - if ! [ -e "$1" ] && [ -s "$1" ]; then - $SUDOSTR kill "$(cat "$1")" 2>&1 | grep -v "No such process" + if [ -e "$1" ]; then + if [ -s "$1" ]; then + $SUDOSTR kill "$(cat "$1")" 2>&1 | grep -v "No such process" + fi rm $1 fi } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e17d8313755c36f130982c921abf69d78c98ae6 Gerrit-Change-Number: 30364 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm48_rr_tx_voice(): also permit TCH/H frames

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30333 ) Change subject: mobile: gsm48_rr_tx_voice(): also permit TCH/H frames ...................................................................... mobile: gsm48_rr_tx_voice(): also permit TCH/H frames The idea behind checking the ch_type in gsm48_rr_tx_voice() was likely to prevent sending of the (LCR originated) Uplink TCH frames before the actual traffic channel is established/modified. The problem is that this check allows TCH/F frames, but not TCH/H. Most likely, TCH/H was forgotten or never tested. Fix this. Change-Id: I06e84ad47bafd4676af0e136b825e77471587b23 Related: OS#5599 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 9f159d8..41aa7b8 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -5798,8 +5798,8 @@ goto error; } - if (ch_type != RSL_CHAN_Bm_ACCHs) { - LOGP(DRR, LOGL_INFO, "Current channel is not (yet) TCH/F\n"); + if (ch_type != RSL_CHAN_Bm_ACCHs && ch_type != RSL_CHAN_Lm_ACCHs) { + LOGP(DRR, LOGL_INFO, "Current channel is not (yet) TCH\n"); goto error; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I06e84ad47bafd4676af0e136b825e77471587b23 Gerrit-Change-Number: 30333 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: properly handle RR CHANNEL MODE MODIFY message

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30332 ) Change subject: mobile: properly handle RR CHANNEL MODE MODIFY message ...................................................................... mobile: properly handle RR CHANNEL MODE MODIFY message According to 3GPP TS 04.08, section 3.4.6.1.3 "Abnormal cases" of "channel mode modify procedure", if the MS doesn't support the indicated channel mode, it shall retain the old mode and return the associated channel mode information in the ACKNOWLEDGE message. Previously, if an indicated mode is not supported, we used to indicate the 'CHAN_MODE_UNACCT' RR case without sending the ACKNOWLEDGE message. Also, the result of gsm48_rr_set_mode() was ignored. Let's fix this! Change-Id: I952436ec796273e56341f9d3492b4a3b3a5dc410 Related: OS#5599 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 24 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 236dbbe..9f159d8 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -3604,7 +3604,7 @@ int payload_len = msgb_l3len(msg) - sizeof(*gh) - sizeof(*cm); struct gsm48_rr_cd *cd = &rr->cd_now; uint8_t ch_type, ch_subch, ch_ts; - uint8_t cause; + int rc; LOGP(DRR, LOGL_INFO, "CHANNEL MODE MODIFY\n"); @@ -3641,14 +3641,30 @@ gsm_print_arfcn(cd->arfcn), ch_ts, ch_subch, cd->tsc, cm->mode); } - /* mode */ - cause = gsm48_rr_check_mode(ms, cd->chan_nr, cm->mode); - if (cause) - return gsm48_rr_tx_rr_status(ms, cause); - cd->mode = cm->mode; - gsm48_rr_set_mode(ms, cd->chan_nr, cd->mode); - return gsm48_rr_tx_chan_modify_ack(ms, &cm->chan_desc, cm->mode); + /** + * According to 3GPP TS 04.08, section 3.4.6.1.3 + * "Abnormal cases" of "channel mode modify procedure", + * if the MS doesn't support the indicated channel mode, + * it shall retain the old mode and return the associated + * channel mode information in the ACKNOWLEDGE message. + */ + + /* Check if we support this channel mode */ + rc = gsm48_rr_check_mode(ms, cd->chan_nr, cm->mode); + if (rc) + goto ack; + + /* Attempt to apply this mode */ + rc = gsm48_rr_set_mode(ms, cd->chan_nr, cm->mode); + if (rc) + goto ack; + + /* Finally set (a new) mode */ + cd->mode = cm->mode; + +ack: + return gsm48_rr_tx_chan_modify_ack(ms, &cm->chan_desc, cd->mode); } /* 9.1.3 sending ASSIGNMENT COMPLETE */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I952436ec796273e56341f9d3492b4a3b3a5dc410 Gerrit-Change-Number: 30332 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: voice.h: use '#pragma once' include guard

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30334 ) Change subject: mobile: voice.h: use '#pragma once' include guard ...................................................................... mobile: voice.h: use '#pragma once' include guard Change-Id: I024e13c0f66ae1e42b0c8e2ff77874fcb883e85a Related: OS#5599 --- M src/host/layer23/include/osmocom/bb/mobile/voice.h 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/host/layer23/include/osmocom/bb/mobile/voice.h b/src/host/layer23/include/osmocom/bb/mobile/voice.h index a052418..b9817f8 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/voice.h +++ b/src/host/layer23/include/osmocom/bb/mobile/voice.h @@ -1,7 +1,4 @@ -#ifndef _voice_h -#define _voice_h +#pragma once int gsm_voice_init(struct osmocom_ms *ms); int gsm_send_voice(struct osmocom_ms *ms, struct gsm_data_frame *data); - -#endif /* _voice_h */ 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I024e13c0f66ae1e42b0c8e2ff77874fcb883e85a Gerrit-Change-Number: 30334 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <axilirator(a)gmail.com> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022