Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29888 )
Change subject: abis_rsl: be more clear about vendor specif RSL extension
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29888/comment/ca987a0e_e3902741
PS1, Line 966: /* Chapter 8.5.6 (Ericcson vendor specific RSL extension) */
This seems to imply this function only does the extension part. Rather document it:
/* Chapter 8.5.6 Immediate Assignment Command (with Ericcson vendor specific RSL extension) */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id27662e208ca8ac0a48851583c11fbacf85f988c
Gerrit-Change-Number: 29888
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Oct 2022 12:46:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29888 )
Change subject: abis_rsl: be more clear about vendor specif RSL extension
......................................................................
abis_rsl: be more clear about vendor specif RSL extension
The function rsl_ericsson_imm_assign_cmd has a comment "Chapter 8.5.6"
above it. However, thats only half true. The function implements
ericsson vendor specific RSL IEs, so lets be more clear about this in
the spec reference.
Change-Id: Id27662e208ca8ac0a48851583c11fbacf85f988c
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/29888/1
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 304e95c..e09c202 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -963,7 +963,7 @@
return abis_rsl_sendmsg(msg);
}
-/* Chapter 8.5.6 */
+/* Chapter 8.5.6 (Ericcson vendor specific RSL extension) */
int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val)
{
struct msgb *msg = rsl_imm_assign_cmd_common(bts, len, val);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id27662e208ca8ac0a48851583c11fbacf85f988c
Gerrit-Change-Number: 29888
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge, pespin, lynxis lazus.
Hello Jenkins Builder, laforge, lynxis lazus,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/29704
to look at the new patch set (#4).
Change subject: abis_rsl: when doing packet access, log t1,t3,t2 and fn
......................................................................
abis_rsl: when doing packet access, log t1,t3,t2 and fn
The the (relative) frame number that is forwarded to the PCU is an
important parameter which is computed from t1,t3,t2.
Change-Id: I83d20ba9e0ce6488d458ccf4a85c8445c30e3a89
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/29704/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29704
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I83d20ba9e0ce6488d458ccf4a85c8445c30e3a89
Gerrit-Change-Number: 29704
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset