October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: BSC: increase BSSMAP RESET-ACK timeout

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29891 ) Change subject: BSC: increase BSSMAP RESET-ACK timeout ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think it would be very interesting to understand how this phenomenon happens on your system. a 5 second round-trip time between sending a RESET from TTCN3 until receiving the ACK from the IUT (BSC) is way too long already. 10s is just ridiculous, IMHO. So either * TTCN3 thinks it has sent the message, but it takes a long time until it actually hits the wire, * your network has some kind of enormous delay, or * the RESET arrives in time, but something prevents the BSC from receiving/processing the RESET * or any of the above in the reverse direction for the ACK We may very well have a bug, if we have a RTT > 5s in test execution. Merging this patch might just plaster over it. correlating logs with pcap file should hopefully give you an idea of where the majority of the time was spent/wasted. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76fa91280472b87235cf985af68bc2a6183d5e4a Gerrit-Change-Number: 29891 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Oct 2022 13:12:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: Cosmetic: fix desc of neighbor_ident_add_neighbor

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29887 ) Change subject: Cosmetic: fix desc of neighbor_ident_add_neighbor ...................................................................... Cosmetic: fix desc of neighbor_ident_add_neighbor Change-Id: I6d78220156f8a4a4b246f9fcc5e9d066c2a90bbb --- M src/osmo-bsc/neighbor_ident_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/neighbor_ident_vty.c b/src/osmo-bsc/neighbor_ident_vty.c index e40fa8c..86adbf2 100644 --- a/src/osmo-bsc/neighbor_ident_vty.c +++ b/src/osmo-bsc/neighbor_ident_vty.c @@ -154,7 +154,7 @@ LOGP(DLINP, LOGL_NOTICE, fmt "\n", ## args); \ } while (0) \ -/* Delete a neighbor from neighborlist. When the parameter *vty is set to NULL all error messages are redirected to the +/* Add a neighbor from neighborlist. When the parameter *vty is set to NULL all error messages are redirected to the * logtext. */ int neighbor_ident_add_neighbor(struct vty *vty, struct gsm_bts *bts, struct neighbor *n) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6d78220156f8a4a4b246f9fcc5e9d066c2a90bbb Gerrit-Change-Number: 29887 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: extend TC_ho_meas_rep_multi_band for ARFCN=0

by laforge

Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29858 ) Change subject: BSC: extend TC_ho_meas_rep_multi_band for ARFCN=0 ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia8f94d72651061427afc9e34f678544f89d0149b Gerrit-Change-Number: 29858 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Oct 2022 13:09:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: add TC_ho_meas_rep_multi_band

by laforge

Attention is currently required from: osmith, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 ) Change subject: BSC: add TC_ho_meas_rep_multi_band ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 Gerrit-Change-Number: 29837 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Oct 2022 13:08:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: reset handover related vty cfg after ho tests

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29890 ) Change subject: BSC: reset handover related vty cfg after ho tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ca6909dec633f0c1f26b5e72a7cfc1931c0ec54 Gerrit-Change-Number: 29890 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Oct 2022 13:08:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-abis[master]: input/unixsocket: Remove write delay timer

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28064 ) Change subject: input/unixsocket: Remove write delay timer ...................................................................... input/unixsocket: Remove write delay timer Unlike with classic E1 or nanoBTS, there is no reason why we would use a delay timer when talking over a unix domain socket between two osmocom programs. Let's remove the write-delay timer. Change-Id: I642d2e4495a08ce45e9a4492e98255aacd0be39a --- M src/input/unixsocket.c 1 file changed, 1 insertion(+), 16 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/unixsocket.c b/src/input/unixsocket.c index 069f9c6..b738b3f 100644 --- a/src/input/unixsocket.c +++ b/src/input/unixsocket.c @@ -128,14 +128,6 @@ return ret; } -static void timeout_ts1_write(void *data) -{ - struct e1inp_ts *e1i_ts = (struct e1inp_ts *)data; - - /* trigger write of ts1, due to tx delay timer */ - ts_want_write(e1i_ts); -} - static int unixsocket_write_cb(struct osmo_fd *bfd) { struct e1inp_line *line = bfd->data; @@ -143,21 +135,14 @@ struct msgb *msg; struct e1inp_sign_link *sign_link; - osmo_fd_write_disable(bfd); - /* get the next msg for this timeslot */ msg = e1inp_tx_ts(e1i_ts, &sign_link); if (!msg) { - /* no message after tx delay timer */ + osmo_fd_write_disable(bfd); LOGPITS(e1i_ts, DLINP, LOGL_INFO, "no message available (line=%p)\n", line); return 0; } - /* set tx delay timer for next event */ - osmo_timer_setup(&e1i_ts->sign.tx_timer, timeout_ts1_write, e1i_ts); - - osmo_timer_schedule(&e1i_ts->sign.tx_timer, 0, e1i_ts->sign.delay); - LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "sending: %s (line=%p)\n", msgb_hexdump(msg), line); lapd_transmit(e1i_ts->lapd, sign_link->tei, sign_link->sapi, msg); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I642d2e4495a08ce45e9a4492e98255aacd0be39a Gerrit-Change-Number: 28064 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: add TC_ho_meas_rep_multi_band

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 ) Change subject: BSC: add TC_ho_meas_rep_multi_band ...................................................................... Patch Set 7: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/af85c232_70e9… PS2, Line 12013: f_bts_0_cfg(BSCVTY, I've talked to Neels and the handover tests didn't reset this yet. Added logic to do this in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29890 and using it here now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 Gerrit-Change-Number: 29837 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Oct 2022 13:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: increase BSSMAP RESET-ACK timeout

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29891 ) Change subject: BSC: increase BSSMAP RESET-ACK timeout ...................................................................... BSC: increase BSSMAP RESET-ACK timeout On my laptop I hit the 5 seconds timeout every other time I start tests, so increase it to 10 seconds. Change-Id: I76fa91280472b87235cf985af68bc2a6183d5e4a --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/29891/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 4753ae9..075ff32 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -909,7 +909,7 @@ private function f_legacy_bssap_reset(integer bssap_idx := 0) runs on test_CT { var BSSAP_N_UNITDATA_ind ud_ind; var boolean reset_received := false; - timer T := 5.0; + timer T := 10.0; BSSAP.send(ts_BSSAP_UNITDATA_req(g_bssap[bssap_idx].sccp_addr_peer, g_bssap[bssap_idx].sccp_addr_own, ts_BSSMAP_Reset(0, g_osmux_enabled_cn))); T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76fa91280472b87235cf985af68bc2a6183d5e4a Gerrit-Change-Number: 29891 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: add TC_ho_meas_rep_multi_band

by osmith

Attention is currently required from: osmith, neels. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 to look at the new patch set (#7). Change subject: BSC: add TC_ho_meas_rep_multi_band ...................................................................... BSC: add TC_ho_meas_rep_multi_band Related: OS#5717 Related: osmo-bsc Ic5e4f0531e08685460948b102367825588d839ba Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 --- M bsc/BSC_Tests.ttcn M library/BSSMAP_Templates.ttcn 2 files changed, 97 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/29837/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 Gerrit-Change-Number: 29837 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: reset handover related vty cfg after ho tests

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29890 ) Change subject: BSC: reset handover related vty cfg after ho tests ...................................................................... BSC: reset handover related vty cfg after ho tests Reset the handover related configuration to what is in osmo-bsc.cfg after running handover tests. Change-Id: I8ca6909dec633f0c1f26b5e72a7cfc1931c0ec54 --- M bsc/BSC_Tests.ttcn 1 file changed, 38 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/29890/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 81a1901..98cdb45 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -883,12 +883,24 @@ } -friend function f_shutdown_helper() runs on test_CT { +friend function f_shutdown_helper(boolean ho := false) runs on test_CT { /* Run the subscr and conn leak test only when the VTY is initialized */ if (BSCVTY.checkstate("Mapped") and mp_verify_talloc_count) { f_verify_talloc_count(BSCVTY, {"struct bsc_subscr", "struct gsm_subscriber_connection"}); } + /* Reset handover related configuration */ + if (ho) { + f_bts_0_cfg(BSCVTY, + {"no neighbors", + "neighbor-list mode manual-si5", + "neighbor-list add arfcn 100", + "neighbor-list add arfcn 200", + "si5 neighbor-list add arfcn 10", + "si5 neighbor-list add arfcn 20", + "handover algorithm 1"}); + } + all component.stop; setverdict(pass); mtc.stop; @@ -5672,7 +5684,7 @@ f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); f_ctrs_bts_add(1, "incoming_intra_bsc_ho:completed"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } function f_tc_ho_int_a5(OCT1 encr_alg, charstring enc_a5 := "0 1 3") runs on test_CT { @@ -5701,7 +5713,7 @@ f_ctrs_bts_add(1, "incoming_intra_bsc_ho:completed"); f_ctrs_bsc_and_bts_verify(); f_vty_encryption_a5_reset(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } testcase TC_ho_int_a5_0() runs on test_CT { @@ -5824,7 +5836,7 @@ f_ctrs_bts_add(1, "incoming_intra_bsc_ho:attempted"); f_ctrs_bts_add(1, "incoming_intra_bsc_ho:stopped"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* Expecting MGCP to DLCX the endpoint's two connections: towards BTS and towards MSC */ @@ -5958,7 +5970,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:attempted"); f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:completed"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_mo_l3_transceive(RSL_DCHAN_PT rsl := RSL, @@ -6042,7 +6054,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:attempted"); f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:timeout"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* BSC asks for inter-BSC HO, receives BSSMAP Handover Command, but MS reports @@ -6124,7 +6136,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:attempted"); f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:failed"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* BSC asks for inter-BSC-out HO, receives BSSMAP Handover Command, but then no reply is received about HO outcome @@ -6225,7 +6237,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:attempted"); f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:timeout"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_ho_into_this_bsc(charstring id, template (omit) BSSMAP_oldToNewBSSIEs oldToNewBSSIEs := omit) runs on MSC_ConnHdlr { @@ -6431,7 +6443,7 @@ testcase TC_ho_into_this_bsc() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); f_tc_ho_into_this_bsc_main(pars); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } function f_tc_ho_into_this_bsc_a5(TestHdlrEncrParams encr, charstring vty_a5_cfg := VTY_A5_DEFAULT, @@ -6440,7 +6452,7 @@ pars.encr := encr; pars.expect_ho_fail := expect_fail; f_tc_ho_into_this_bsc_main(pars, vty_a5_cfg); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } testcase TC_ho_into_this_bsc_a5_0() runs on test_CT { @@ -6485,7 +6497,7 @@ var TestHdlrParams pars := f_gen_test_hdlr_pars(); pars.host_aoip_tla := "::6"; f_tc_ho_into_this_bsc_main(pars); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* Similar to TC_ho_into_this_bsc, but when in SRVCC, HO Req contains "Old BSS @@ -6502,7 +6514,7 @@ f_ctrs_bsc_and_bts_add(0, "srvcc:attempted"); f_ctrs_bsc_and_bts_add(0, "srvcc:completed"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* Same as TC_srvcc_eutran_to_geran, but enables ciphering on the target channel. */ @@ -6516,7 +6528,7 @@ f_ctrs_bsc_and_bts_add(0, "srvcc:attempted"); f_ctrs_bsc_and_bts_add(0, "srvcc:completed"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* Same as TC_srvcc_eutran_to_geran, but test explicitly forbiding fast return @@ -6697,7 +6709,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:attempted"); f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:stopped"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_tc_ho_in_fail_msc_clears_after_ho_detect(charstring id) runs on MSC_ConnHdlr { @@ -6788,7 +6800,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:attempted"); f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:stopped"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* The new BSS's lchan times out before the MSC decides that handover failed. */ @@ -6878,7 +6890,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:attempted"); f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:error"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* Same as f_tc_ho_in_fail_no_detect, but MSC fails to send a Clear Command */ @@ -6960,7 +6972,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:attempted"); f_ctrs_bsc_and_bts_add(0, "interbsc_ho_in:error"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* An incoming inter-BSC HO can either issue the Handover Request message attached to the initial SCCP N-Connect (as in @@ -6970,7 +6982,7 @@ var TestHdlrParams pars := f_gen_test_hdlr_pars(); pars.inter_bsc_ho_in__ho_req_in_initial_sccp_cr := false; f_tc_ho_into_this_bsc_main(pars); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } type record of charstring Commands; @@ -7204,7 +7216,7 @@ f_ctrs_bts_add(1, "incoming_intra_bsc_ho:failed"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_tc_ho_neighbor_config_2(charstring id) runs on MSC_ConnHdlr { @@ -7257,7 +7269,7 @@ f_ctrs_bsc_and_bts_add(0, "handover:error"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_tc_ho_neighbor_config_3(charstring id) runs on MSC_ConnHdlr { @@ -7309,7 +7321,7 @@ f_ctrs_bts_add(2, "incoming_intra_bsc_ho:failed"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_tc_ho_neighbor_config_4(charstring id) runs on MSC_ConnHdlr { @@ -7366,7 +7378,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:timeout"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_tc_ho_neighbor_config_5(charstring id) runs on MSC_ConnHdlr { @@ -7409,7 +7421,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:timeout"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_tc_ho_neighbor_config_6(charstring id) runs on MSC_ConnHdlr { @@ -7451,7 +7463,7 @@ f_ctrs_bsc_and_bts_add(0, "handover:error"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_tc_ho_neighbor_config_7(charstring id) runs on MSC_ConnHdlr { @@ -7508,7 +7520,7 @@ f_ctrs_bsc_and_bts_add(0, "interbsc_ho_out:timeout"); f_ctrs_bsc_and_bts_verify(); - f_shutdown_helper(); + f_shutdown_helper(ho := true); } /* OS#3041: Open and close N connections in a normal fashion, and expect no @@ -10367,7 +10379,7 @@ f_sleep(1.0); vc_conn := f_start_handler(refers(f_tc_ho_during_lcs_loc_req), pars); vc_conn.done; - f_shutdown_helper(); + f_shutdown_helper(ho := true); } private function f_tc_emerg_call_and_lcs_loc_req(charstring id) runs on MSC_ConnHdlr -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ca6909dec633f0c1f26b5e72a7cfc1931c0ec54 Gerrit-Change-Number: 29890 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022