Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29888 )
Change subject: abis_rsl: be more clear about vendor specif RSL extension
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29888/comment/b65d7100_820b5c51
PS1, Line 966: /* Chapter 8.5.6 (Ericcson vendor specific RSL extension) */
> This seems to imply this function only does the extension part. Rather document it: […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id27662e208ca8ac0a48851583c11fbacf85f988c
Gerrit-Change-Number: 29888
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Oct 2022 14:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29893 )
Change subject: pcuif_proto: cosmetic: rename gsm_pcu_if_info_ts to gsm_pcu_if_info_trx_ts
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Make sure to also update the copy in osmo-bsc to be on pair with these ones.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29893
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If8b50181d3b609612aa8433b635052aadddd3484
Gerrit-Change-Number: 29893
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Oct 2022 13:56:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment