October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: pcu: fix coding style in f_ms_handle_pkt_neighbor_cell_data()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29627 ) Change subject: pcu: fix coding style in f_ms_handle_pkt_neighbor_cell_data() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie30c2e031c17c8a6173499635cf10656c33b7e7f Gerrit-Change-Number: 29627 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 09:05:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: cosmetic: fix coding style in f_ms_rx_pkt_ass_pacch()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29626 ) Change subject: pcu: cosmetic: fix coding style in f_ms_rx_pkt_ass_pacch() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I901a540e4461eed6019a8e3288ea0bb1f5c4d57d Gerrit-Change-Number: 29626 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 09:05:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: cosmetic: fix coding style in f_tx_data_ind_fn()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29625 ) Change subject: pcu: cosmetic: fix coding style in f_tx_data_ind_fn() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib7ffed5573281b343c7691ff218458a0641ee8b0 Gerrit-Change-Number: 29625 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 09:04:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library: add send template for PACKET_UL_DUMMY_CTRL

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29624 ) Change subject: library: add send template for PACKET_UL_DUMMY_CTRL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2e1a0a0523d3e6f7ba8a270ff21fbe17a90a61d0 Gerrit-Change-Number: 29624 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 09:04:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library: add missing '(value)' specifier to ts_RLCMAC_CTRL_ACK

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29623 ) Change subject: library: add missing '(value)' specifier to ts_RLCMAC_CTRL_ACK ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia3176d0443255cba909ec571cda93875704b08b3 Gerrit-Change-Number: 29623 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 09:04:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library: s/tr_RLCMAC_DUMMY_CTRL/tr_RLCMAC_DL_DUMMY_CTRL/

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29622 ) Change subject: library: s/tr_RLCMAC_DUMMY_CTRL/tr_RLCMAC_DL_DUMMY_CTRL/ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b19c6679eb432b062e28aee9dd1220dbf33ee31 Gerrit-Change-Number: 29622 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 09:04:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: add TC_dl_multislot_tbf_ack_wrong_ts reproducing OS#5696

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29629 ) Change subject: pcu: add TC_dl_multislot_tbf_ack_wrong_ts reproducing OS#5696 ...................................................................... pcu: add TC_dl_multislot_tbf_ack_wrong_ts reproducing OS#5696 Change-Id: I0c632721e167ae14c0f3d57b08019f0650771df5 Related: OS#5696 --- M pcu/PCU_Tests.ttcn 1 file changed, 67 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/29629/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 611ca23..504de08 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -4543,6 +4543,72 @@ f_shutdown(__BFILE__, __LINE__, final := true); } +/* Reproduce weird behavior explained in OS#5696 */ +testcase TC_dl_multislot_tbf_ack_wrong_ts() runs on RAW_PCU_Test_CT { + var octetstring data := f_rnd_octstring(8); + const TsTrxBtsNum nr_ts6 := {6, 0, 0, 0}; + const TsTrxBtsNum nr_ts7 := {7, 0, 0, 0}; + var GprsMS ms := valueof(t_GprsMS_def); + var RlcmacDlBlock dl_block; + var uint32_t poll_fn; + var uint32_t dl_fn; + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + + var PCUIF_info_ind info_ind := valueof(ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS)); + /* Configure both TS6 and TS7 as PDCH to enable multi-slot TBFs */ + f_PCUIF_PDCHMask_set(info_ind, '00000011'B, 0); + f_PCUIF_PDCHMask_set(info_ind, '00000000'B, (1 .. 7)); + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), info_ind); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + /* Establish an Uplink TBF (assuming TS6) */ + f_ms_establish_ul_tbf(ms); + + /* (TS6) Send an Uplink block, so this TBF becomes "active" */ + f_ms_tx_ul_data_block(ms, data, with_tlli := true, nr := nr_ts6); + + /* (TS6) DL ACK/NACK ends contention resolution */ + f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, poll_fn, nr := nr_ts6); + + /* SGSN sends some DL data, PCU will assign Downlink resource on PACCH */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); + + /* (TS6) Expect an RLC/MAC block with Packet Downlink Assignment on PACCH (see 11.2.29) */ + f_ms_rx_pkt_ass_pacch(ms, poll_fn, tr_RLCMAC_DL_PACKET_ASS, nr := nr_ts6); + /* Expect a multi-slot TBF including TS6 and TS7 */ + if (not match(ms.dl_tbf.ass.pacch.timeslot_alloc, '00000011'B)) { + setverdict(fail, "Unexpected TIMESLOT_ALLOCATION in Pkt DL Ass"); + f_shutdown(__BFILE__, __LINE__); + } + + /* Packet Downlink Assignment polls the MS, so we need to ACKnowledge it. + * SE K800i sends a dummy block on TS6 and then the ACK on TS7. */ + f_ms_tx_ul_block(ms, ts_RLCMAC_UL_DUMMY_CTRL(ms.tlli), + poll_fn, wait := false, nr := nr_ts6); + f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), + poll_fn, wait := false, nr := nr_ts7); + BTS.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_SENT, { tdma_fn := poll_fn })); + BTS.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_SENT, { tdma_fn := poll_fn })); + + if (false) { /* for debugging only */ + var BTS_PDTCH_Block pdtch_msg; + f_pcuif_rx_data_req_pdtch(pdtch_msg, nr := nr_ts6); + log("======== (TS6) Rx data: ", pdtch_msg.dl_block); + f_pcuif_rx_data_req_pdtch(pdtch_msg, nr := nr_ts7); + log("======== (TS7) Rx data: ", pdtch_msg.dl_block); + } + + f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, nr := nr_ts6); + + f_shutdown(__BFILE__, __LINE__, final := true); +} + /* Verify concurrent PDCH use of EGPRS and GPRS (EGPRS dl rlcmac blk is * downgraded to CS1-4 so that GPRS can read the USF). * See 3GPP TS 44.060 5.2.4a "Multiplexing of GPRS, EGPRS and EGPRS2 capable mobile stations" @@ -6866,6 +6932,7 @@ execute( TC_ul_tbf_reestablish_with_pkt_dl_ack_nack() ); execute( TC_ul_tbf_reestablish_with_pkt_dl_ack_nack_egprs() ); + execute( TC_dl_multislot_tbf_ack_wrong_ts() ); execute( TC_multiplex_dl_gprs_egprs() ); execute( TC_pcuif_info_ind_subsequent() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c632721e167ae14c0f3d57b08019f0650771df5 Gerrit-Change-Number: 29629 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: cosmetic: fix coding style in f_ms_rx_pkt_ass_pacch()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29626 ) Change subject: pcu: cosmetic: fix coding style in f_ms_rx_pkt_ass_pacch() ...................................................................... pcu: cosmetic: fix coding style in f_ms_rx_pkt_ass_pacch() Change-Id: I901a540e4461eed6019a8e3288ea0bb1f5c4d57d --- M pcu/GPRS_Components.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/29626/1 diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 0f16d02..0f805ca 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -533,12 +533,12 @@ arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), block_nr := nr.blk_nr)); alt { - [] as_ms_rx_pkt_ass_pacch(ms, poll_fn, t_pkt_ass, nr, dl_block); - [ignore_dummy] as_ms_rx_ignore_dummy(ms, nr); - /* TODO: fail */ - [] BTS.receive { - setverdict(fail, "Unexpected BTS message"); - f_shutdown(__BFILE__, __LINE__); + [] as_ms_rx_pkt_ass_pacch(ms, poll_fn, t_pkt_ass, nr, dl_block); + [ignore_dummy] as_ms_rx_ignore_dummy(ms, nr); + /* TODO: fail */ + [] BTS.receive { + setverdict(fail, "Unexpected BTS message"); + f_shutdown(__BFILE__, __LINE__); } } return dl_block; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I901a540e4461eed6019a8e3288ea0bb1f5c4d57d Gerrit-Change-Number: 29626 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: fix coding style in f_ms_handle_pkt_neighbor_cell_data()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29627 ) Change subject: pcu: fix coding style in f_ms_handle_pkt_neighbor_cell_data() ...................................................................... pcu: fix coding style in f_ms_handle_pkt_neighbor_cell_data() Change-Id: Ie30c2e031c17c8a6173499635cf10656c33b7e7f --- M pcu/GPRS_Components.ttcn 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/29627/1 diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 0f805ca..eb29787 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -976,15 +976,15 @@ block_nr := nr.blk_nr)); alt { [exp_container_idx == 0] as_ms_rx_ignore_dummy(ms, nr); - [exp_container_idx > 0] as_rx_fail_dummy(nr); - [] as_ms_rx_pkt_neighbor_cell_data(ms, exp_si, exp_container_idx, si_offset, nr, single_step); - [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DL_CTRL(?, ?) - )) -> value data_msg { - var GlobalTfi gtfi := { is_dl_tfi := false, tfi := ms.ul_tbf.tfi }; - setverdict(fail, "Rx unexpected DL block: ", data_msg.dl_block, " vs exp ", - tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_NEIGH_CELL_DATA(gtfi, exp_container_idx))); - f_shutdown(__BFILE__, __LINE__); + [exp_container_idx > 0] as_rx_fail_dummy(nr); + [] as_ms_rx_pkt_neighbor_cell_data(ms, exp_si, exp_container_idx, si_offset, nr, single_step); + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + tr_RLCMAC_DL_CTRL(?, ?))) -> value data_msg { + var GlobalTfi gtfi := { is_dl_tfi := false, tfi := ms.ul_tbf.tfi }; + setverdict(fail, "Rx unexpected DL block: ", data_msg.dl_block, " vs exp ", + tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_NEIGH_CELL_DATA(gtfi, exp_container_idx))); + f_shutdown(__BFILE__, __LINE__); } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie30c2e031c17c8a6173499635cf10656c33b7e7f Gerrit-Change-Number: 29627 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: f_pcuif_tx_data_ind(): make waiting behavior configurable

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29628 ) Change subject: pcu: f_pcuif_tx_data_ind(): make waiting behavior configurable ...................................................................... pcu: f_pcuif_tx_data_ind(): make waiting behavior configurable By default, f_pcuif_tx_data_ind() waits for TDMA_EV_PDTCH_BLOCK_SENT making it impossible to send Uplink blocks with the same TDMA FN but dufferent TDMA TN (multi-slot TBFs). This change allows sending several UL blocks without waiting for TDMA_EV_PDTCH_BLOCK_SENT. Change-Id: I3200b8a2973f97f08714654e525c631da5d6e382 Related: OS#5696 --- M pcu/GPRS_Components.ttcn 1 file changed, 13 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/29628/1 diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index eb29787..b1dd28d 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -639,13 +639,15 @@ /* Enqueue DATA.ind (both TDMA frame and block numbers to be patched) */ function f_ms_tx_data_ind(inout GprsMS ms, octetstring data, uint32_t fn := 0, + boolean wait := true, /* wait for TDMA_EV_PDTCH_BLOCK_SENT? */ template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum) runs on MS_BTS_IFACE_CT { - f_pcuif_tx_data_ind(data, fn, ms.ta, ms.lqual_cb, nr := nr); + f_pcuif_tx_data_ind(data, fn, ms.ta, ms.lqual_cb, wait, nr := nr); } function f_ms_tx_ul_block(inout GprsMS ms, template (value) RlcmacUlBlock ul_data, uint32_t fn := 0, template (omit) CodingScheme force_cs_mcs := omit, + boolean wait := true, /* wait for TDMA_EV_PDTCH_BLOCK_SENT? */ template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum) runs on MS_BTS_IFACE_CT { var octetstring data; @@ -665,7 +667,7 @@ data := f_pad_oct(data, f_rlcmac_cs_mcs2block_len(CS_1), '2b'O); } /* Enqueue DATA.ind (both TDMA frame and block numbers to be patched) */ - f_ms_tx_data_ind(ms, data, fn, nr := nr); + f_ms_tx_data_ind(ms, data, fn, wait, nr := nr); } function f_ms_tx_ul_data_block(inout GprsMS ms, octetstring payload, @@ -1084,20 +1086,24 @@ return f_pcuif_rx_imm_ass(PCU_IF_SAPI_AGCH, tr_IMM_TBF_ASS(false, ra, fn), nr); } -/* Enqueue DATA.ind (both TDMA frame and block numbers to be patched) */ +/* Enqueue DATA.ind (both TDMA frame and block numbers to be patched). + * By default, wait for TDMA_EV_PDTCH_BLOCK_SENT from the RAW_PCU_BTS_CT. */ function f_pcuif_tx_data_ind(octetstring data, uint32_t fn := 0, TimingAdvance ta := 0, int16_t lqual_cb := 0, + boolean wait := true, /* wait for TDMA_EV_PDTCH_BLOCK_SENT? */ template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum) runs on MS_BTS_IFACE_CT { - var template RAW_PCU_EventParam ev_param := {tdma_fn := ? }; BTS.send(ts_PCUIF_DATA_IND(nr.bts_nr, nr.trx_nr, nr.ts_nr, nr.blk_nr, sapi := PCU_IF_SAPI_PDTCH, data := data, fn := fn, arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), ta_offs_qbits := ta * 4, lqual_cb := lqual_cb)); - if (fn != 0) { - ev_param := {tdma_fn := fn }; + if (wait) { + if (fn != 0) { + BTS.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_SENT, { tdma_fn := fn })); + } else { + BTS.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_SENT)); + } } - BTS.receive(tr_RAW_PCU_EV(TDMA_EV_PDTCH_BLOCK_SENT, ev_param)); } /* Enqueue RTS.req, expect DATA.req with UL ACK from the PCU */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3200b8a2973f97f08714654e525c631da5d6e382 Gerrit-Change-Number: 29628 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022