October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: comsetic: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29630 ) Change subject: comsetic: Fix typo in comment ...................................................................... comsetic: Fix typo in comment Change-Id: I935ab303d2234656f8de0dbdb2de9f4254b02dce --- M src/osmo-bsc/bsc_ctrl_commands.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/30/29630/1 diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c index 304ccf9..fd0f5d2 100644 --- a/src/osmo-bsc/bsc_ctrl_commands.c +++ b/src/osmo-bsc/bsc_ctrl_commands.c @@ -175,7 +175,7 @@ continue; /* - * The ip.access nanoBTS seems to be unrelaible on BSSGP + * The ip.access nanoBTS seems to be unreliable on BSSGP * so let's us just reboot it. For the sysmoBTS we can just * restart the process as all state is gone. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I935ab303d2234656f8de0dbdb2de9f4254b02dce Gerrit-Change-Number: 29630 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: Log unexpected RSL message

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 ) Change subject: bts: Log unexpected RSL message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4 Gerrit-Change-Number: 29582 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 10:48:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc-nat[master]: [do not merge] test rpm/deb CI

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 to look at the new patch set (#2). Change subject: [do not merge] test rpm/deb CI ...................................................................... [do not merge] test rpm/deb CI Change-Id: I6842b5c641e6b6a0cfb428c7538e0a041751143e --- A test2 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/92/29492/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6842b5c641e6b6a0cfb428c7538e0a041751143e Gerrit-Change-Number: 29492 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: cosmetic: fix coding style in f_ms_rx_pkt_ass_pacch()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29626 ) Change subject: pcu: cosmetic: fix coding style in f_ms_rx_pkt_ass_pacch() ...................................................................... pcu: cosmetic: fix coding style in f_ms_rx_pkt_ass_pacch() Change-Id: I901a540e4461eed6019a8e3288ea0bb1f5c4d57d --- M pcu/GPRS_Components.ttcn 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 0f16d02..0f805ca 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -533,12 +533,12 @@ arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)), block_nr := nr.blk_nr)); alt { - [] as_ms_rx_pkt_ass_pacch(ms, poll_fn, t_pkt_ass, nr, dl_block); - [ignore_dummy] as_ms_rx_ignore_dummy(ms, nr); - /* TODO: fail */ - [] BTS.receive { - setverdict(fail, "Unexpected BTS message"); - f_shutdown(__BFILE__, __LINE__); + [] as_ms_rx_pkt_ass_pacch(ms, poll_fn, t_pkt_ass, nr, dl_block); + [ignore_dummy] as_ms_rx_ignore_dummy(ms, nr); + /* TODO: fail */ + [] BTS.receive { + setverdict(fail, "Unexpected BTS message"); + f_shutdown(__BFILE__, __LINE__); } } return dl_block; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I901a540e4461eed6019a8e3288ea0bb1f5c4d57d Gerrit-Change-Number: 29626 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: fix coding style in f_ms_handle_pkt_neighbor_cell_data()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29627 ) Change subject: pcu: fix coding style in f_ms_handle_pkt_neighbor_cell_data() ...................................................................... pcu: fix coding style in f_ms_handle_pkt_neighbor_cell_data() Change-Id: Ie30c2e031c17c8a6173499635cf10656c33b7e7f --- M pcu/GPRS_Components.ttcn 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 0f805ca..eb29787 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -976,15 +976,15 @@ block_nr := nr.blk_nr)); alt { [exp_container_idx == 0] as_ms_rx_ignore_dummy(ms, nr); - [exp_container_idx > 0] as_rx_fail_dummy(nr); - [] as_ms_rx_pkt_neighbor_cell_data(ms, exp_si, exp_container_idx, si_offset, nr, single_step); - [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DL_CTRL(?, ?) - )) -> value data_msg { - var GlobalTfi gtfi := { is_dl_tfi := false, tfi := ms.ul_tbf.tfi }; - setverdict(fail, "Rx unexpected DL block: ", data_msg.dl_block, " vs exp ", - tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_NEIGH_CELL_DATA(gtfi, exp_container_idx))); - f_shutdown(__BFILE__, __LINE__); + [exp_container_idx > 0] as_rx_fail_dummy(nr); + [] as_ms_rx_pkt_neighbor_cell_data(ms, exp_si, exp_container_idx, si_offset, nr, single_step); + [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, + tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), + tr_RLCMAC_DL_CTRL(?, ?))) -> value data_msg { + var GlobalTfi gtfi := { is_dl_tfi := false, tfi := ms.ul_tbf.tfi }; + setverdict(fail, "Rx unexpected DL block: ", data_msg.dl_block, " vs exp ", + tr_RLCMAC_DL_CTRL(?, tr_RlcMacDlCtrl_PKT_NEIGH_CELL_DATA(gtfi, exp_container_idx))); + f_shutdown(__BFILE__, __LINE__); } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie30c2e031c17c8a6173499635cf10656c33b7e7f Gerrit-Change-Number: 29627 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: cosmetic: fix coding style in f_tx_data_ind_fn()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29625 ) Change subject: pcu: cosmetic: fix coding style in f_tx_data_ind_fn() ...................................................................... pcu: cosmetic: fix coding style in f_tx_data_ind_fn() Change-Id: Ib7ffed5573281b343c7691ff218458a0641ee8b0 --- M pcu/PCUIF_Components.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/PCUIF_Components.ttcn b/pcu/PCUIF_Components.ttcn index 030da05..375af8e 100644 --- a/pcu/PCUIF_Components.ttcn +++ b/pcu/PCUIF_Components.ttcn @@ -403,8 +403,8 @@ pcu_msg.u.data_ind.block_nr := fn2macblock(fn); //log(prefix, "DATA.ind"); } else if (has_msg and pcu_msg.u.data_ind.fn < fn) { - setverdict(fail, "We are late scheduling the block! ", pcu_msg.u.data_ind.fn, " < ", fn); - mtc.stop; + setverdict(fail, "We are late scheduling the block! ", pcu_msg.u.data_ind.fn, " < ", fn); + mtc.stop; } else { /* NOPE.ind: */ pcu_msg := valueof(ts_PCUIF_DATA_IND(bts_nr, trx_nr, ts_nr, 0 /* FIXME */, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib7ffed5573281b343c7691ff218458a0641ee8b0 Gerrit-Change-Number: 29625 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library: add missing '(value)' specifier to ts_RLCMAC_CTRL_ACK

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29623 ) Change subject: library: add missing '(value)' specifier to ts_RLCMAC_CTRL_ACK ...................................................................... library: add missing '(value)' specifier to ts_RLCMAC_CTRL_ACK Change-Id: Ia3176d0443255cba909ec571cda93875704b08b3 --- M library/RLCMAC_Templates.ttcn 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/RLCMAC_Templates.ttcn b/library/RLCMAC_Templates.ttcn index 3b1e40a..738ee97 100644 --- a/library/RLCMAC_Templates.ttcn +++ b/library/RLCMAC_Templates.ttcn @@ -772,7 +772,8 @@ } /* Template for Uplink Control ACK */ - template RlcmacUlBlock ts_RLCMAC_CTRL_ACK(GprsTlli tlli, CtrlAck ack := MS_RCVD_TWO_RLC_SAME_RTI_DIFF_RBSN) := { + template (value) RlcmacUlBlock + ts_RLCMAC_CTRL_ACK(GprsTlli tlli, CtrlAck ack := MS_RCVD_TWO_RLC_SAME_RTI_DIFF_RBSN) := { ctrl := { mac_hdr := t_RLCMAC_UlMacCtrlH(MAC_PT_RLCMAC_NO_OPT), payload := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia3176d0443255cba909ec571cda93875704b08b3 Gerrit-Change-Number: 29623 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library: add send template for PACKET_UL_DUMMY_CTRL

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29624 ) Change subject: library: add send template for PACKET_UL_DUMMY_CTRL ...................................................................... library: add send template for PACKET_UL_DUMMY_CTRL Change-Id: I2e1a0a0523d3e6f7ba8a270ff21fbe17a90a61d0 --- M library/RLCMAC_Templates.ttcn 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/RLCMAC_Templates.ttcn b/library/RLCMAC_Templates.ttcn index 738ee97..d4204c7 100644 --- a/library/RLCMAC_Templates.ttcn +++ b/library/RLCMAC_Templates.ttcn @@ -788,6 +788,21 @@ } } + template (value) RlcmacUlBlock + ts_RLCMAC_UL_DUMMY_CTRL(template (value) GprsTlli tlli) := { + ctrl := { + mac_hdr := t_RLCMAC_UlMacCtrlH(MAC_PT_RLCMAC_NO_OPT), + payload := { + msg_type := PACKET_UL_DUMMY_CTRL, + u := { + ul_dummy := { + tlli := tlli + } + } + } + } + } + template LlcBlockHdr t_RLCMAC_LLCBLOCK_HDR(uint16_t length_ind, boolean more, boolean e) := { length_ind := length_ind, more := more, /* 1 = new LLC PDU starts */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2e1a0a0523d3e6f7ba8a270ff21fbe17a90a61d0 Gerrit-Change-Number: 29624 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library: s/tr_RLCMAC_DUMMY_CTRL/tr_RLCMAC_DL_DUMMY_CTRL/

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29622 ) Change subject: library: s/tr_RLCMAC_DUMMY_CTRL/tr_RLCMAC_DL_DUMMY_CTRL/ ...................................................................... library: s/tr_RLCMAC_DUMMY_CTRL/tr_RLCMAC_DL_DUMMY_CTRL/ There also exists UL equivalent of this message, for which I am planning to add a template. Let's clarify direction in the name. Change-Id: I3b19c6679eb432b062e28aee9dd1220dbf33ee31 --- M library/RLCMAC_Templates.ttcn M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 3 files changed, 16 insertions(+), 16 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/RLCMAC_Templates.ttcn b/library/RLCMAC_Templates.ttcn index e398491..3b1e40a 100644 --- a/library/RLCMAC_Templates.ttcn +++ b/library/RLCMAC_Templates.ttcn @@ -529,7 +529,7 @@ } } - template RlcmacDlBlock tr_RLCMAC_DUMMY_CTRL(template uint3_t usf := ?, template PageMode page_mode := ?) := { + template RlcmacDlBlock tr_RLCMAC_DL_DUMMY_CTRL(template uint3_t usf := ?, template PageMode page_mode := ?) := { ctrl := { mac_hdr := { payload_type := (MAC_PT_RLCMAC_NO_OPT, MAC_PT_RLCMAC_OPT), diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index d6749d7..0f16d02 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -549,7 +549,7 @@ var BTS_PDTCH_Block data_msg; [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DUMMY_CTRL())) -> value data_msg { + tr_RLCMAC_DL_DUMMY_CTRL())) -> value data_msg { BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH, fn := 0, @@ -579,7 +579,7 @@ var BTS_PDTCH_Block data_msg; [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DUMMY_CTRL())) -> value data_msg { + tr_RLCMAC_DL_DUMMY_CTRL())) -> value data_msg { setverdict(fail, "Unexpected Dummy Ctrl block ", data_msg); f_shutdown(__BFILE__, __LINE__); } @@ -1192,7 +1192,7 @@ var uint32_t dl_fn; f_rx_rlcmac_dl_block(dl_block, dl_fn, nr := nr); - if (not match(dl_block, tr_RLCMAC_DUMMY_CTRL())) { + if (not match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL())) { setverdict(fail, "Failed to match Packet DUMMY DL"); f_shutdown(__BFILE__, __LINE__); } diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 8012daa..611ca23 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -857,7 +857,7 @@ /* we will receive UL ACK/NACK from time to time. In that case, check CdCofing increases */ f_rx_rlcmac_dl_block(dl_block, unused_fn); - if (match(dl_block, tr_RLCMAC_DUMMY_CTRL())) { + if (match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL())) { continue; } if (not match(dl_block, tr_RLCMAC_UL_ACK_NACK_GPRS(ul_tfi := ?)) and @@ -927,7 +927,7 @@ while (true) { f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 15); f_rx_rlcmac_dl_block(dl_block, unused_fn); - if (match(dl_block, tr_RLCMAC_DUMMY_CTRL())) { + if (match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL())) { continue; } @@ -1092,7 +1092,7 @@ bsn := i mod bsn_mod; f_rx_rlcmac_dl_block(dl_block, fn); - if (match(dl_block, tr_RLCMAC_DUMMY_CTRL)) { + if (match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL)) { /* No more data to receive, done */ break; } @@ -1200,7 +1200,7 @@ while (true) { f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 15); f_rx_rlcmac_dl_block(dl_block, unused_fn); - if (match(dl_block, tr_RLCMAC_DUMMY_CTRL())) { + if (match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL())) { continue; } @@ -1636,7 +1636,7 @@ * above case before continuing (expect /* Dummy block): */ BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DUMMY_CTRL)); + tr_RLCMAC_DL_DUMMY_CTRL)); } [] BTS.receive { setverdict(fail, "Unexpected BTS message"); @@ -1979,7 +1979,7 @@ */ [N3105 == N3105_MAX] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DUMMY_CTRL)) -> value data_msg { + tr_RLCMAC_DL_DUMMY_CTRL)) -> value data_msg { if (not T_3195.running) { T_3195.start; /* We even send some new data, nothing should be sent to MS */ @@ -2256,7 +2256,7 @@ /* we will receive UL ACK/NACK from time to time, handle it. */ f_rx_rlcmac_dl_block(dl_block, dl_fn); - if (match(dl_block, tr_RLCMAC_DUMMY_CTRL())) { + if (match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL())) { continue; } if (not match(dl_block, tr_RLCMAC_UL_ACK_NACK_GPRS(ul_tfi := ?)) and @@ -2992,7 +2992,7 @@ alt { [data_received] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DUMMY_CTRL)) { /* done */ } + tr_RLCMAC_DL_DUMMY_CTRL)) { /* done */ } [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), tr_RLCMAC_DATA)) -> value data_msg { @@ -3429,7 +3429,7 @@ */ [N3105 == N3105_MAX] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DUMMY_CTRL)) -> value data_msg { + tr_RLCMAC_DL_DUMMY_CTRL)) -> value data_msg { if (not T_3195.running) { T_3195.start; } @@ -3455,7 +3455,7 @@ /* We receive Dummy blocks in between Pkt Ul Ass while PCU waits for us to ack it */ [not T_3195.running] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH), - tr_RLCMAC_DUMMY_CTRL)) -> value data_msg { + tr_RLCMAC_DL_DUMMY_CTRL)) -> value data_msg { log("Ignoring Dummy block FN ", data_msg.raw.fn); nr := ts_TsTrxBtsNum; BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr, @@ -4632,7 +4632,7 @@ for (var integer i := 0; i < 800; i := i + 1) { f_rx_rlcmac_dl_block(dl_block, dl_fn); - if (match(dl_block, tr_RLCMAC_DUMMY_CTRL)) { + if (match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL)) { /* No more data to receive, done */ break; } @@ -4894,7 +4894,7 @@ var integer i := 0; while (true) { f_rx_rlcmac_dl_block(dl_block, sched_fn); - if (not match(dl_block, tr_RLCMAC_DUMMY_CTRL())) { + if (not match(dl_block, tr_RLCMAC_DL_DUMMY_CTRL())) { break; } if (max_num_iter > 0 and i > max_num_iter) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3b19c6679eb432b062e28aee9dd1220dbf33ee31 Gerrit-Change-Number: 29622 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: f_pcuif_tx_data_ind(): make waiting behavior configurable

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29628 ) Change subject: pcu: f_pcuif_tx_data_ind(): make waiting behavior configurable ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29628/comment/ac443b94_af95… PS1, Line 11: dufferent TDMA TN (multi-slot TBFs). This change allows sending different -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3200b8a2973f97f08714654e525c631da5d6e382 Gerrit-Change-Number: 29628 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 09:07:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022