October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: ctrl: Introduce hopping-arfcn-{add,del} commands

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29632 ) Change subject: ctrl: Introduce hopping-arfcn-{add,del} commands ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib886cff70dd8940aa2f4095b84f9e60056c9588e Gerrit-Change-Number: 29632 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 07:42:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: Rearrange ctrl interface code

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29631 ) Change subject: Rearrange ctrl interface code ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51a9b31780a4a8026aafb2d732369cdc10c8bb70 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 07:41:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: cosmetic: Fix typo in comment

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29630 ) Change subject: cosmetic: Fix typo in comment ...................................................................... cosmetic: Fix typo in comment Change-Id: I935ab303d2234656f8de0dbdb2de9f4254b02dce --- M src/osmo-bsc/bsc_ctrl_commands.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c index 304ccf9..fd0f5d2 100644 --- a/src/osmo-bsc/bsc_ctrl_commands.c +++ b/src/osmo-bsc/bsc_ctrl_commands.c @@ -175,7 +175,7 @@ continue; /* - * The ip.access nanoBTS seems to be unrelaible on BSSGP + * The ip.access nanoBTS seems to be unreliable on BSSGP * so let's us just reboot it. For the sysmoBTS we can just * restart the process as all state is gone. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I935ab303d2234656f8de0dbdb2de9f4254b02dce Gerrit-Change-Number: 29630 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: Fix Typo in gsm0808_msgt_names[]

by pespin

Attention is currently required from: neels, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29637 ) Change subject: Fix Typo in gsm0808_msgt_names[] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I91585d81efd6e18f4b8f9eaeaaaa50412253d93b Gerrit-Change-Number: 29637 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 07:14:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: Fix LCLS-CONNECT-CONTROL generation

by pespin

Attention is currently required from: neels, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29636 ) Change subject: Fix LCLS-CONNECT-CONTROL generation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29636 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I455ac7695ad33ef9073bea7d1711508717732607 Gerrit-Change-Number: 29636 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 07:14:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: Fix Typo in gsm0808_msgt_names[]

by keith

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/29637 ) Change subject: Fix Typo in gsm0808_msgt_names[] ...................................................................... Fix Typo in gsm0808_msgt_names[] Change-Id: I91585d81efd6e18f4b8f9eaeaaaa50412253d93b --- M src/gsm/gsm0808.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/37/29637/1 diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index 42debac..e057832 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -1728,7 +1728,7 @@ { BSS_MAP_MSG_UPLINK_APP_DATA, "UPLINK APP DATA" }, { BSS_MAP_MSG_LCLS_CONNECT_CTRL, "LCLS-CONNECT-CONTROL" }, - { BSS_MAP_MSG_LCLS_CONNECT_CTRL_ACK, "CLS-CONNECT-CONTROL-ACK" }, + { BSS_MAP_MSG_LCLS_CONNECT_CTRL_ACK, "LCLS-CONNECT-CONTROL-ACK" }, { BSS_MAP_MSG_LCLS_NOTIFICATION, "LCLS-NOTIFICATION" }, { 0, NULL } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I91585d81efd6e18f4b8f9eaeaaaa50412253d93b Gerrit-Change-Number: 29637 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: Fix LCLS-CONNECT-CONTROL generation

by keith

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/29636 ) Change subject: Fix LCLS-CONNECT-CONTROL generation ...................................................................... Fix LCLS-CONNECT-CONTROL generation gsm0808_create_lcls_conn_ctrl() was adding the LCLS-Configuration IE twice. Correct is LCLS-Configuration followed by LCLS-Connection-Status-Control (TS 48.008 3.2.1.91) Change-Id: I455ac7695ad33ef9073bea7d1711508717732607 --- M src/gsm/gsm0808.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/29636/1 diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index 4bb7303..42debac 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -373,7 +373,7 @@ if (config != GSM0808_LCLS_CFG_NA) msgb_tv_put(msg, GSM0808_IE_LCLS_CONFIG, config); if (control != GSM0808_LCLS_CSC_NA) - msgb_tv_put(msg, GSM0808_IE_LCLS_CONFIG, control); + msgb_tv_put(msg, GSM0808_IE_LCLS_CONN_STATUS_CTRL, control); msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, msgb_length(msg)); return msg; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29636 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I455ac7695ad33ef9073bea7d1711508717732607 Gerrit-Change-Number: 29636 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-e1d[master]: vty: Add option to disable GPS-DO loop and use manual tuning values

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29635 ) Change subject: vty: Add option to disable GPS-DO loop and use manual tuning values ...................................................................... vty: Add option to disable GPS-DO loop and use manual tuning values Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I8668fe42e4c399f08696e497887120e501341f5a --- M src/e1d.h M src/usb.c M src/vty.c 3 files changed, 52 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/35/29635/1 diff --git a/src/e1d.h b/src/e1d.h index ff34800..82c9bb6 100644 --- a/src/e1d.h +++ b/src/e1d.h @@ -174,6 +174,11 @@ struct { char *serial_str; + struct { + bool manual; + uint16_t coarse; + uint16_t fine; + } gpsdo; } usb; bool vty_created; diff --git a/src/usb.c b/src/usb.c index a8a650c..4754966 100644 --- a/src/usb.c +++ b/src/usb.c @@ -778,6 +778,17 @@ { struct e1_usb_intf_data *id = intf->drv_data; + if (intf->usb.gpsdo.manual) { + struct e1usb_gpsdo_tune tune = { + .coarse = intf->usb.gpsdo.coarse, + .fine = intf->usb.gpsdo.fine, + }; + e1_usb_ctrl_set_gpsdo_mode(intf, ICE1USB_GPSDO_MODE_DISABLED); + e1_usb_ctrl_set_gpsdo_tune(intf, &tune); + } else { + e1_usb_ctrl_set_gpsdo_mode(intf, ICE1USB_GPSDO_MODE_AUTO); + } + osmo_timer_setup(&id->gpsdo.poll_timer, &_e1_usb_gpsdo_poll_cb, intf); osmo_timer_schedule(&id->gpsdo.poll_timer, 1, 0); } diff --git a/src/vty.c b/src/vty.c index 65eb334..5acb1d5 100644 --- a/src/vty.c +++ b/src/vty.c @@ -302,6 +302,38 @@ return CMD_SUCCESS; } +DEFUN(cfg_e1d_if_gpsdo_manual, cfg_e1d_if_gpsdo_manual_cmd, + "gpsdo-manual <0-4095> <0-4095>", + "Sets the GPS-DO to manual with the provided tune values\n" + "Coarse tune value\n" + "Fine tune value\n") +{ + struct e1_intf *intf = vty->index; + + if (intf->drv != E1_DRIVER_USB) + return CMD_WARNING; + + intf->usb.gpsdo.manual = true; + intf->usb.gpsdo.coarse = atoi(argv[0]); + intf->usb.gpsdo.fine = atoi(argv[1]); + + return CMD_SUCCESS; +} + +DEFUN(cfg_e1d_if_no_gpsdo_manual, cfg_e1d_if_no_gpsdo_manual_cmd, + "no gpsdo-manual", + NO_STR "Set the GPS-DO back to automatic mode\n") +{ + struct e1_intf *intf = vty->index; + + if (intf->drv != E1_DRIVER_USB) + return CMD_WARNING; + + intf->usb.gpsdo.manual = false; + + return CMD_SUCCESS; +} + DEFUN(cfg_e1d_if_line, cfg_e1d_if_line_cmd, "line <0-255>", "Configure an E1 line\n" "E1 Interface Number\n") @@ -387,6 +419,8 @@ vty_out(vty, " interface %u icE1usb%s", intf->id, VTY_NEWLINE); if (intf->usb.serial_str && strlen(intf->usb.serial_str)) vty_out(vty, " usb-serial %s%s", intf->usb.serial_str, VTY_NEWLINE); + if (intf->usb.gpsdo.manual) + vty_out(vty, " gpsdo-manual %d %d%s", intf->usb.gpsdo.coarse, intf->usb.gpsdo.fine, VTY_NEWLINE); break; case E1_DRIVER_VPAIR: vty_out(vty, " interface %u vpair%s", intf->id, VTY_NEWLINE); @@ -417,6 +451,8 @@ install_element(E1D_NODE, &cfg_e1d_if_vpair_cmd); install_element(INTF_NODE, &cfg_e1d_if_line_cmd); install_element(INTF_NODE, &cfg_e1d_if_usb_serial_cmd); + install_element(INTF_NODE, &cfg_e1d_if_gpsdo_manual_cmd); + install_element(INTF_NODE, &cfg_e1d_if_no_gpsdo_manual_cmd); install_node(&line_node, NULL); install_element(LINE_NODE, &cfg_e1d_if_line_mode_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8668fe42e4c399f08696e497887120e501341f5a Gerrit-Change-Number: 29635 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-e1d[master]: usb: Fix the length field of ICE1USB_INTF_SET_GPSDO_TUNE request

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29633 ) Change subject: usb: Fix the length field of ICE1USB_INTF_SET_GPSDO_TUNE request ...................................................................... usb: Fix the length field of ICE1USB_INTF_SET_GPSDO_TUNE request Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ibf1b1440696902757f4b1c1d9c4d80c1da453a36 --- M src/usb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/33/29633/1 diff --git a/src/usb.c b/src/usb.c index 07afc0e..0529535 100644 --- a/src/usb.c +++ b/src/usb.c @@ -645,7 +645,7 @@ const uint16_t bmReqType = LIBUSB_RECIPIENT_INTERFACE | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_ENDPOINT_OUT; return _e1_usb_intf_send_ctrl(intf, bmReqType, ICE1USB_INTF_SET_GPSDO_TUNE, 0, - (uint8_t *)gpsdo_tune, sizeof(gpsdo_tune)); + (uint8_t *)gpsdo_tune, sizeof(*gpsdo_tune)); } int -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ibf1b1440696902757f4b1c1d9c4d80c1da453a36 Gerrit-Change-Number: 29633 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-e1d[master]: usb: Fix ICE1USB_INTF_SET_GPSDO_MODE request parameter

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29634 ) Change subject: usb: Fix ICE1USB_INTF_SET_GPSDO_MODE request parameter ...................................................................... usb: Fix ICE1USB_INTF_SET_GPSDO_MODE request parameter This call takes its argument in wValue rather than as payload Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ibeebe3184a4744bd0cd9f5a19db84c12fab18806 --- M src/usb.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/34/29634/1 diff --git a/src/usb.c b/src/usb.c index 0529535..a8a650c 100644 --- a/src/usb.c +++ b/src/usb.c @@ -635,8 +635,8 @@ { const uint16_t bmReqType = LIBUSB_RECIPIENT_INTERFACE | LIBUSB_REQUEST_TYPE_VENDOR | LIBUSB_ENDPOINT_OUT; - return _e1_usb_intf_send_ctrl(intf, bmReqType, ICE1USB_INTF_SET_GPSDO_MODE, 0, - (uint8_t *)&gpsdo_mode, sizeof(gpsdo_mode)); + return _e1_usb_intf_send_ctrl(intf, bmReqType, ICE1USB_INTF_SET_GPSDO_MODE, gpsdo_mode, + NULL, 0); } int -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ibeebe3184a4744bd0cd9f5a19db84c12fab18806 Gerrit-Change-Number: 29634 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022