October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs/gerrit-binpkgs: new job for deb, rpm packages

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29604 ) Change subject: jobs/gerrit-binpkgs: new job for deb, rpm packages ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Can't we have both rpms and debs built as 1 job? Even better if it's done as a next step of the regu […] agreed with getting too many mails from jenkins/gerrit verifications... I'll look into implementing this better -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7ca8869c2e9f2e7c74a360933be12b5c2b47c2fc Gerrit-Change-Number: 29604 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 08:24:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: do not use msgb_l4 instead of msgb_sms

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/29620 ) Change subject: msgb: do not use msgb_l4 instead of msgb_sms ...................................................................... msgb: do not use msgb_l4 instead of msgb_sms The macro msgb_sms() is basically an alias for msgb_l4(). Lets use msgb_l4() in msgb_l4len() instead of msgb_sms(). Change-Id: I90d4f5c07fbaadd9e022752a2c64c4855f0b4227 --- M include/osmocom/core/msgb.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/29620/1 diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h index fbf1742..1e2b023 100644 --- a/include/osmocom/core/msgb.h +++ b/include/osmocom/core/msgb.h @@ -184,7 +184,7 @@ static inline unsigned int msgb_l4len(const struct msgb *msgb) { OSMO_ASSERT(msgb->l4h); - return msgb->tail - (uint8_t *)msgb_sms(msgb); + return msgb->tail - (uint8_t *)msgb_l4(msgb); } /*! determine the length of the header -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I90d4f5c07fbaadd9e022752a2c64c4855f0b4227 Gerrit-Change-Number: 29620 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: msgb: assert msgb->lXh to be not NULL

by dexter

Attention is currently required from: laforge, dexter. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29591 to look at the new patch set (#2). Change subject: msgb: assert msgb->lXh to be not NULL ...................................................................... msgb: assert msgb->lXh to be not NULL When any of l1h, l2h, l2h or l4h is set to NULL (which is the default for newly allocated message buffers). Then the msgb_lXhlen() functions will return the address value of msgb->tail. This can lead to unexpected results at a later point. We should have an OSMO_ASSERT to catch the problem early. Change-Id: I1795c559f190713ebbabfbabf3453ab77da46a49 Related: OS#5645 --- M include/osmocom/core/msgb.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/29591/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1795c559f190713ebbabfbabf3453ab77da46a49 Gerrit-Change-Number: 29591 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-e1d[master]: usb: Add support for new GPSDO status field "Accumulated error"

by tnt

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 to look at the new patch set (#3). Change subject: usb: Add support for new GPSDO status field "Accumulated error" ...................................................................... usb: Add support for new GPSDO status field "Accumulated error" Because we want to handle older firmwares too, we need to excepect we might get a smaller structure ! (We can't get a larger one since the wLength we send is limited to the structure we know) Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 --- M src/e1d.h M src/ice1usb_proto.h M src/intf_line.c M src/usb.c 4 files changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/18/29618/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 Gerrit-Change-Number: 29618 Gerrit-PatchSet: 3 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: coverity: fix prepare_source_Osmocom.sh terminating early

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29588 ) Change subject: coverity: fix prepare_source_Osmocom.sh terminating early ...................................................................... coverity: fix prepare_source_Osmocom.sh terminating early Since [1] was merged this script is executed with '-xe' making it fail immediately if a command returns a non-zero code. grep may return 1 if pattern is not found, so let's suspend it. Change-Id: I21a01478b64015fd699ed31634bf2fb1dc8f6750 Fixes: [1] Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved; Verified osmith: Looks good to me, but someone else must approve diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 63fbea0..526e9d3 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -65,7 +65,7 @@ # We want to compile tests, but not execute them. Using 'noinst_PROGRAMS' # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. for proj in $PROJECTS; do - files="$(git -C $proj grep -l check_PROGRAMS)" + files="$(git -C $proj grep -l check_PROGRAMS)" || true if [ -n "$files" ]; then (cd $proj && sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files) fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I21a01478b64015fd699ed31634bf2fb1dc8f6750 Gerrit-Change-Number: 29588 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: coverity: fix prepare_source_Osmocom.sh terminating early

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29588 ) Change subject: coverity: fix prepare_source_Osmocom.sh terminating early ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging this patch to unb0rk Coverity job. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I21a01478b64015fd699ed31634bf2fb1dc8f6750 Gerrit-Change-Number: 29588 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Oct 2022 07:11:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: bts_set_current_frame_number(): log expected TDMA FN

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29580 ) Change subject: bts_set_current_frame_number(): log expected TDMA FN ...................................................................... Patch Set 3: (1 comment) File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/29580/comment/d3227a48_2f33099e PS2, Line 346: "Detected FN jump! %u -> %u (next %u)\n", > next seems to imply it's the next in series of %u -> %u -> "next". Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id28776fb5f0f85cd35d3918c79f8c8e338156aae Gerrit-Change-Number: 29580 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Oct 2022 06:52:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: bts_set_current_frame_number(): log expected TDMA FN

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/29580 to look at the new patch set (#3). Change subject: bts_set_current_frame_number(): log expected TDMA FN ...................................................................... bts_set_current_frame_number(): log expected TDMA FN Change-Id: Id28776fb5f0f85cd35d3918c79f8c8e338156aae --- M src/bts.cpp M tests/tbf/TbfTest.err 2 files changed, 63 insertions(+), 62 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/29580/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id28776fb5f0f85cd35d3918c79f8c8e338156aae Gerrit-Change-Number: 29580 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: Add Osmux IPv6 support

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29614 ) Change subject: Add Osmux IPv6 support ...................................................................... Patch Set 2: (5 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/3ce99678_480fe64f PS2, Line 102: if (mgcp_conn_rtp_is_osmux(conn)) { Having a scoped const pointer: const struct mgcp_config *cfg = conn->conn->endp->trunk->cfg; would improve readability of this function. File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/044b50bd_e3407121 PS2, Line 459: cfg->osmux_addr_v4, cfg->osmux_port); broken alignment https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/fd4e87ff_7e22dcf9 PS2, Line 466: osmo_sock_get_name2(osmux_fd_v4.fd)); broken alignment https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/95438cb0_c39f945f PS2, Line 477: cfg->osmux_addr_v6, cfg->osmux_port); broken alignment https://gerrit.osmocom.org/c/osmo-mgw/+/29614/comment/c49269a8_7d2b4447 PS2, Line 484: osmo_sock_get_name2(osmux_fd_v6.fd)); broken alignment -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I446cd7da217e9f4a74995d7784ae55dcc60a29b7 Gerrit-Change-Number: 29614 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Oct 2022 19:45:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-e1d[master]: usb: Add support for new GPSDO status field "Accumulated error"

by tnt

Attention is currently required from: tnt. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 to look at the new patch set (#2). Change subject: usb: Add support for new GPSDO status field "Accumulated error" ...................................................................... usb: Add support for new GPSDO status field "Accumulated error" Because we want to handle older firmwares too, we need to excepect we might get a smaller structure ! (We can't get a larger one since the wLength we send is limited to the structure we know) Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 --- M src/e1d.h M src/ice1usb_proto.h M src/intf_line.c M src/usb.c 4 files changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/18/29618/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 Gerrit-Change-Number: 29618 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022