Attention is currently required from: tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29612 )
Change subject: icE1usb fw: Add support for building 1 channel version
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29612
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I147bb90fca3cead8db776ecfd60c23b4b8bafe2d
Gerrit-Change-Number: 29612
Gerrit-PatchSet: 2
Gerrit-Owner: tnt <tnt(a)246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Tue, 04 Oct 2022 17:15:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611 )
Change subject: icE1usb fw: Add Notify PPS on Carrier Detect option
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611/comment/07530ad4_e092…
PS2, Line 10: actually support PPS on CD for USB-CDC devices :(
I guess this is due to the fact that one generally assumes USB devices with no real CPU interrupt (just the slow / 1ms resolution USB serialized interrupt packet) have too much jitter for proper PPS.
Patchset:
PS2:
> I don't agree with the linter for the remaining one ... […]
well, it is the kernel coding style to have "} else {". The linter is correct to flag it - but it of course doesn't know that this is not an osmocom CNI project and hence those rules don't apply.
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Ie5d163434323a23912228003add9870fafefedf9
Gerrit-Change-Number: 29611
Gerrit-PatchSet: 2
Gerrit-Owner: tnt <tnt(a)246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Tue, 04 Oct 2022 17:15:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment
Attention is currently required from: tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29610 )
Change subject: icE1usb fw/gpsdo: If no PPS present for >= 3s, go to hold over mode
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29610
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Ia85a8bb0e146cb117ea6e2704c6a4dedf215c75a
Gerrit-Change-Number: 29610
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt(a)246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Tue, 04 Oct 2022 17:10:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29608 )
Change subject: icE1usb fw/gpsdo: Use a struct for VCTXO dependent params
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Iffea8992130eccd98a2952b08277e3d0d2568a1f
Gerrit-Change-Number: 29608
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt(a)246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Tue, 04 Oct 2022 17:09:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment