October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-sgsn[master]: SNDCP: log more details on failure

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29675 ) Change subject: SNDCP: log more details on failure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iad3ebbc28909a827db7b3a0ae2d3e1de7991210f Gerrit-Change-Number: 29675 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 14:27:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Introduce osmux peer-behind-nat (on|off) and rework conn activ...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29659 ) Change subject: osmux: Introduce osmux peer-behind-nat (on|off) and rework conn activation ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29659/comment/537b289b_18bc8344 PS1, Line 280: tha that -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7654ddf51d197a4107e55f4e406053b2e4a02f83 Gerrit-Change-Number: 29659 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 12:24:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_conn_dump(): Separate dump for osmux and iuup connections

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29653 ) Change subject: mgcp_conn_dump(): Separate dump for osmux and iuup connections ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iec1f2d61e4eb14a8a3c634e2642063bea6000c04 Gerrit-Change-Number: 29653 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 12:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Make conn_osmux_{allocate,release}_local_cid() APIs static

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29646 ) Change subject: osmux: Make conn_osmux_{allocate,release}_local_cid() APIs static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If7c83f98a94818090173a8be9d3bff9818b2ead1 Gerrit-Change-Number: 29646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 12:09:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Simplify and constify param passing

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29644 ) Change subject: osmux: Simplify and constify param passing ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idebd4a66630c16548f557632a54d6b7e1b3906fd Gerrit-Change-Number: 29644 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 12:09:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: Check once if remote addr is available when sending dummy packet

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29643 ) Change subject: Check once if remote addr is available when sending dummy packet ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I224dbfeda17c364b85166268e2ac1e019a87edb6 Gerrit-Change-Number: 29643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 12:04:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications: wrap in pipeline job

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29668 ) Change subject: jobs/gerrit-verifications: wrap in pipeline job ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks for the reviews. I'll wait with merging until the whole patchset is reviewed so I only need to roll it out once. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ica208a5177739655cdd493d461da146d440cd542 Gerrit-Change-Number: 29668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 11:51:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications: write summary comment

by osmith

Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29671 ) Change subject: jobs/gerrit-verifications: write summary comment ...................................................................... Patch Set 1: (2 comments) File jobs/gerrit-pipeline-result.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29671/comment/9af27be5_0067d052 PS1, Line 12: node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11 > What's the reason for using Debian 10? I though the plan is to migrate everything we can to Debian 1 […] see discussion here: https://gerrit.osmocom.org/c/osmo-ci/+/29604/4/jobs/gerrit-binpkgs.yml#16 File scripts/jenkins-gerrit/pipeline_summary.py: https://gerrit.osmocom.org/c/osmo-ci/+/29671/comment/f24a5859_d900f14b PS1, Line 174: def main(): > Why extra function? You can just move it directly below where main() is called. It's a convention used often in python code, and personally I think it looks better than just writing the code below the if. But functionally it would be the same. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idcab969e1b5ca4e0f1383bee8f36f2d1aac4f624 Gerrit-Change-Number: 29671 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 11:49:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: Debian: ignore .deb build byproducts

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29680 ) Change subject: Debian: ignore .deb build byproducts ...................................................................... Patch Set 1: (1 comment) File .gitignore: https://gerrit.osmocom.org/c/libosmocore/+/29680/comment/f1207764_da2a4c96 PS1, Line 45: debian/autoreconf.after > What's the point of manually shuffling stuff in a file which is edited using tools (IDE/editor etc)? The point is to save time for people viewing/editing files after you. Tooling (IDE/editor) is the matter of taste; consistency is another thing which should be kept regardless of the former choice. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idbd92096c9058eccd12e33453713815c7baf0792 Gerrit-Change-Number: 29680 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 11:42:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-binpkgs: new job for deb, rpm packages

by osmith

Attention is currently required from: fixeria, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29604 ) Change subject: jobs/gerrit-binpkgs: new job for deb, rpm packages ...................................................................... Patch Set 4: (2 comments) File jobs/gerrit-binpkgs.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29604/comment/90ba0591_aea18a63 PS4, Line 16: node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11 > What's the reason for using Debian 10? I though the plan is to migrate everything we can to Debian 1 […] Better use of resources. Until we have migrated all nodes at to debian 11, limiting to debian 11 here means the job would only run on the build2-deb11build-ansible node (https://jenkins.osmocom.org/jenkins/label/osmocom-gerrit-debian11/). If somebody submits a large patchset to gerrit, then running the gerrit verifications doesn't take as long if more nodes can be used. I did not include osmocom-gerrit-debian9 because the python version there is so old that the script doesn't run. Note that the debian version here is the one of the jenkins node that runs the python script. The script runs with a --docker argument, and the actual package build runs in debian 11. https://gerrit.osmocom.org/c/osmo-ci/+/29604/comment/cef36a91_5dfcc10a PS4, Line 86: rpm) distro="centos:8" ;; > That's EoL as well - see https://www.centos. […] True. But a customer is using it and we decided to use almalinux:8 in our infrastructure. centos:8 gets translated to almalinux:8 here: https://gitea.osmocom.org/osmocom/osmo-ci/src/commit/c449c5de8d9d891553db83… If you prefer I could refactor it so it says almalinux:8 here instead of translating it later on. Or add a comment here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7ca8869c2e9f2e7c74a360933be12b5c2b47c2fc Gerrit-Change-Number: 29604 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Oct 2022 11:41:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022