Attention is currently required from: dexter.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29651 )
Change subject: measurement: do not call msgb_l3len without checking
......................................................................
Patch Set 1:
(1 comment)
File src/common/measurement.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29651/comment/adc55589_49d077fa
PS1, Line 920: int l3_len;
That should be usigned. Although I'd just skip single-use variable and instead pass Pau's suggestion directly to rsl_tx_meas_res()
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie5a9fe1ba880e68edb74f5f4ca559ac191330d4f
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 08 Oct 2022 19:31:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29670 )
Change subject: jobs/gerrit-lint: run as part of pipeline
......................................................................
Patch Set 1:
(1 comment)
File jobs/gerrit-verifications.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/29670/comment/3866a61b_942285f8
PS1, Line 77: pipeline_build: false
Should this be "pipeline_lint: false"?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29670
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I5f1340248cd116c5fa5134eee3fae50baf7ef851
Gerrit-Change-Number: 29670
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 08 Oct 2022 19:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29604 )
Change subject: jobs/gerrit-binpkgs: new job for deb, rpm packages
......................................................................
Patch Set 4:
(2 comments)
File jobs/gerrit-binpkgs.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/29604/comment/8aa47af7_83ddfd83
PS4, Line 16: node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11
What's the reason for using Debian 10? I though the plan is to migrate everything we can to Debian 11.
https://gerrit.osmocom.org/c/osmo-ci/+/29604/comment/1ff99b79_829c32ed
PS4, Line 86: rpm) distro="centos:8" ;;
That's EoL as well - see https://www.centos.org/centos-linux-eol/
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29604
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I7ca8869c2e9f2e7c74a360933be12b5c2b47c2fc
Gerrit-Change-Number: 29604
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 08 Oct 2022 19:23:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29671 )
Change subject: jobs/gerrit-verifications: write summary comment
......................................................................
Patch Set 1:
(2 comments)
File jobs/gerrit-pipeline-result.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/29671/comment/ae341e30_acd70913
PS1, Line 12: node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11
What's the reason for using Debian 10? I though the plan is to migrate everything we can to Debian 11.
File scripts/jenkins-gerrit/pipeline_summary.py:
https://gerrit.osmocom.org/c/osmo-ci/+/29671/comment/399112c5_f5fc2401
PS1, Line 174: def main():
Why extra function? You can just move it directly below where main() is called.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29671
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Idcab969e1b5ca4e0f1383bee8f36f2d1aac4f624
Gerrit-Change-Number: 29671
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 08 Oct 2022 19:10:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29676 )
Change subject: GMM: permit E_GMM_COMMON_PROC_SUCCESS in normal state
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29676
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia97b50aac6c665812ddca9010de7f97b17b78bd5
Gerrit-Change-Number: 29676
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 08 Oct 2022 18:45:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment