Attention is currently required from: msuraev.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29670 )
Change subject: jobs/gerrit-lint: run as part of pipeline
......................................................................
Patch Set 1:
(1 comment)
File jobs/gerrit-verifications.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/29670/comment/486373af_25d10492
PS1, Line 77: pipeline_build: false
> Should this be "pipeline_lint: false"?
no. for docker-playground we don't have a contrib/jenkins.sh so pipeline_build is disabled. we do want the lint there that checks for "docker run" not being used without "--rm" among other things.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29670
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I5f1340248cd116c5fa5134eee3fae50baf7ef851
Gerrit-Change-Number: 29670
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Oct 2022 11:26:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29680 )
Change subject: Debian: ignore .deb build byproducts
......................................................................
Patch Set 1:
(1 comment)
File .gitignore:
https://gerrit.osmocom.org/c/libosmocore/+/29680/comment/c2d53e95_2dc3686d
PS1, Line 45: debian/autoreconf.after
> There are already some Debian related entries here, why spreading them across the file?
What's the point of manually shuffling stuff in a file which is edited using tools (IDE/editor etc)?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29680
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idbd92096c9058eccd12e33453713815c7baf0792
Gerrit-Change-Number: 29680
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Oct 2022 10:27:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29680 )
Change subject: Debian: ignore .deb build byproducts
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File .gitignore:
https://gerrit.osmocom.org/c/libosmocore/+/29680/comment/fb0c5aa4_6b4d7070
PS1, Line 45: debian/autoreconf.after
There are already some Debian related entries here, why spreading them across the file?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29680
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idbd92096c9058eccd12e33453713815c7baf0792
Gerrit-Change-Number: 29680
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Oct 2022 10:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29679 )
Change subject: LAPD: log unknown format value
......................................................................
Patch Set 1:
(1 comment)
File src/gsm/lapd_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/29679/comment/d886c403_5fba3451
PS1, Line 1711: %u
I suggest printing as hex instead: 0x%02x.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29679
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9efd433ed128ae1d9df45591b1a93e10f8a3372c
Gerrit-Change-Number: 29679
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Oct 2022 09:58:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29681 )
Change subject: cosmetic: remove trailing space
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29681
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibecfcccd3eabd81979b2296a2dbca1ffbbec8f1c
Gerrit-Change-Number: 29681
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sun, 09 Oct 2022 17:11:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29680 )
Change subject: Debian: ignore .deb build byproducts
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29680
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idbd92096c9058eccd12e33453713815c7baf0792
Gerrit-Change-Number: 29680
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sun, 09 Oct 2022 15:44:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29679 )
Change subject: LAPD: log unknown format value
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29679
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9efd433ed128ae1d9df45591b1a93e10f8a3372c
Gerrit-Change-Number: 29679
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sun, 09 Oct 2022 15:14:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29678 )
Change subject: Constify LLC/SNDCP parameters
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29678
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I903f8a747a8d3b7f734dac7b0c12373ecbb90b11
Gerrit-Change-Number: 29678
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 09 Oct 2022 11:56:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29677 )
Change subject: GTP: migrate from deprecated function
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29677
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I8b46cf8c52e36b0312eddf37f3e136662b95732e
Gerrit-Change-Number: 29677
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sun, 09 Oct 2022 11:46:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment