This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT".

The branch, je/master has been created at 81f2d449be7ab8c0d4b955b6c24a8cf646278ed3 (commit)

- Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=81f2d449be7ab8c0d4b955b6c24a8cf6...

commit 81f2d449be7ab8c0d4b955b6c24a8cf646278ed3 Author: Jacob Erlbeck jerlbeck@sysmocom.de Date: Thu Aug 13 18:36:56 2015 +0200

tbf: Always start T3193 when changing state to GPRS_RLCMAC_WAIT_RELEASE

Currently when receiving a PACKET DL ACK/NACK message with the Final Ack Indicator bit set, the TBF's state is set to GPRS_RLCMAC_WAIT_RELEASE but T3193 is only started when the LLC queue is empty. Otherwise the reuse_tbf() method is called to establish a new DL TBF. In that case, the timer is not started. This will leave the current TBF without a timer so it is potentially not released later on.

This is recognisable by sticky entries in the output of the 'show tbf all' command and possibly allocation failures if there are too many of them.

This commit changes the code to always start T3193 to make sure, that a timer is always active when the the state is set to GPRS_RLCMAC_WAIT_RELEASE.

Note that TS 44.060, 9.3.2.6 requests to release the 'old' TBF immediately in some cases, which is not implemented by this change. This will lead to a longer reservation period of the TFI only, which is safer than reassigning it too early.

Sponsored-by: On-Waves ehf

-----------------------------------------------------------------------

hooks/post-receive