This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/wip/ms-struct has been updated discards 5522d4a5ef71157c7429d687cbc96a3f29f74ea0 (commit) discards 4507a1f2aad235aff7cb56925a498d0175710f7d (commit) discards 058c0274f87a0cc0ade2e4b22ad3e2820031cff6 (commit) via 60d611adcea23fd28a32913aba4ac3e6774fd630 (commit) via c0cd2ffc2b07340ffe4e788a61d31800b4866980 (commit) via 939043b385ce0c0cbc2fc7c459e3f8f660a8260c (commit) via 1e96f228d4ffd10a8b19f0c85b84d3fd5f5b7dd5 (commit) via 6634635cf57c551538c43892de3e7eb2e10b1631 (commit) via 5823b20f2f81bff984461436e8e2512b5daa8793 (commit) via 6659c516fa32ab64642b5822bf4b880f3cc27bbb (commit) via 54fff3b3e4cef0bf182ec7779793a252b73c48b0 (commit) via 3bea905e0d013de9a0b9d77fdc5318a133a6af9b (commit) via 4ff709c3aca86f9974c99b99aea3da9bfde714a3 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (5522d4a5ef71157c7429d687cbc96a3f29f74ea0) \ N -- N -- N (60d611adcea23fd28a32913aba4ac3e6774fd630) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=60d611adcea23fd28a32913aba4ac3e6... commit 60d611adcea23fd28a32913aba4ac3e6774fd630 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Fri Jun 12 10:52:34 2015 +0200 tbf: Reduce CS level if only a few LLC bytes are left (TODO) This is an experimental commit to reduce the coding scheme level if just a few bytes are left to send to the MS. This makes the transmission more robust and can improve throughput and latency if only a few small packages like TCP ACKs or ICMP PINGs are sent. TODO: - commit message - make threshold configurable (at least by a macro) - test case http://cgit.osmocom.org/osmo-pcu/commit/?id=c0cd2ffc2b07340ffe4e788a61d31800... commit c0cd2ffc2b07340ffe4e788a61d31800b4866980 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Fri Jun 12 14:06:09 2015 +0200 tbf: Fix downlink packet loss When the MS is pinged with a longer interval, many packets get lost even if the GprsMs object is kept. If the interval is above the time where the DL TBF is in state FLOW (mainly influenced be the dl-tbf-idle-time command), an new TBF must be requested via AGCH for each ICMP PING message. Currently the LLC frame containing the PING is immediately stored in the TBF and gets lost, if TBF establishment fails for some reason. This commit moves all calls to put_frame() to schedule_next_frame(), where the data is moved from the LLC queue to the frame storage within the TBF object. This method is only called from within create_new_bsn() when the TBF is in the FLOW state and the frame is going to be encoded immediately. At all other places, where put_frame() has been called before, the LLC message is just appended to the LLC queue in the GprsMs object. This change effectively simplifies the related code parts, since date/len information and discard notifications is no longer needed there. Ticket: #1759 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=939043b385ce0c0cbc2fc7c459e3f8f6... commit 939043b385ce0c0cbc2fc7c459e3f8f660a8260c Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Fri Jun 12 13:41:00 2015 +0200 tbf/test: Add test for DL LLC packet loss Currently LLC frames are lost or even reordered when the TBF has be established via the AGCH and the procedure fails for some reason. This test tries to reproduce this behaviour by throwing away the first TBF while calling the handle() method several times. The results of create_dl_acked_block() are checked against expected values (this is currently party disabled because the bug still persists). Ticket: #1759 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=1e96f228d4ffd10a8b19f0c85b84d3fd... commit 1e96f228d4ffd10a8b19f0c85b84d3fd5f5b7dd5 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Fri Jun 12 16:01:56 2015 +0200 ms: Store the NACK rate in the MS object Currently the NACK/unconfirmed ratio is already passed to the corresponding MS object, but the value is not being stored there. This commit adds a member and a getter method and include the values into the output of the 'show ms' command. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=6634635cf57c551538c43892de3e7eb2... commit 6634635cf57c551538c43892de3e7eb2e10b1631 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Fri Jun 12 10:48:05 2015 +0200 tbf: Include CS into create_new_bsn log message This change lets the test suite fail, so it get its own commit. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=5823b20f2f81bff984461436e8e2512b... commit 5823b20f2f81bff984461436e8e2512b5daa8793 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Thu Jun 11 18:09:00 2015 +0200 l1: Add debug log messages for I_LEVEL The I_LEVEL values that are obtained now look suspicious. They do not seem to be contained in messages recorded via gsmtab. To help debugging this issue, this commit adds related debug messages that are generated while the encoded values are taken from the RLC/MAC messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=6659c516fa32ab64642b5822bf4b880f... commit 6659c516fa32ab64642b5822bf4b880f3cc27bbb Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Thu Jun 11 16:54:50 2015 +0200 l1: Store measurement values sent by the MS This commit extends the pcu_l1_meas structure by MS side measurement values which are transmitted by PACKET DOWNLINK ACK/NACK and PACKET RESOURCE REQUEST messages. The encoded values are remapped to dB respectively % values. The values are stored in the corresponding MS object (if there is one). Note that the values are store as (rounded) integers, so some different encodings are mapped to the same decoded value. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=54fff3b3e4cef0bf182ec7779793a252... commit 54fff3b3e4cef0bf182ec7779793a252b73c48b0 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Jun 9 09:44:36 2015 +0200 ms: Add UL CS selection based on L1 link quality Currently the UL CS values are set to the corresponding DL CS value, eventually limited by a maximum value. This approach does not reflect the general situation of the RF link between ME and BTS, which is rather asymmetric e.g. due to a lower degree of TX efficiency of the built-in antenna. This means, that UL and DL CS control should be decoupled for better results. This commit adds automatic UL CS selection based on the link quality measurement parameter. Each coding scheme is mapped to a link quality range. If the link quality value leaves that range, the current UL CS value is increased/decreased accordingly. This value will be copied when the next PACKET_UPLINK_ACK_NACK or PACKET_UPLINK_ASSIGMENT is sent to the MS. The following VTY command will be added to the config-pcu node: - cs link-quality-ranges cs1 <0-35> cs2 <0-35> <0-35> cs3 <0-35> <0-35> cs4 <0-35> which sets the ranges for the four coding schemes. For instance the example below reflects the current default values: cs link-quality-ranges cs1 6 cs2 5 8 cs3 7 13 cs4 12 set the following ranges, where the overlapping is used to configure a hysteresis: CS1: -inf .. 6 CS2: 5 .. 8 CS3: 7 .. 13 CS4: 12 .. inf Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=3bea905e0d013de9a0b9d77fdc5318a1... commit 3bea905e0d013de9a0b9d77fdc5318a133a6af9b Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Mon Jun 8 11:26:38 2015 +0200 ms: Store the L1 measurement values in the MS objects This commits adds the GprsMs::update_l1_meas() and GprsMs::l1_meas() methods to store and access the measurement values. The internal state is updated depending on which values are actually set. In addition, these values are shown in the output of the 'show ms imsi|tlli' command. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=4ff709c3aca86f9974c99b99aea3da9b... commit 4ff709c3aca86f9974c99b99aea3da9bfde714a3 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Mon Jun 8 11:05:45 2015 +0200 l1: Pass all L1 measurements upwards Currently only the RSSI value is passed to the upper layers. Other values like TA and BER which are needed for TA update respectively CS selection are not propagated. This commit introduces and passes a struct that contains a set of measurement values. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 72 ++++++++++++++++++++- src/gprs_ms.cpp | 53 ++++++++++++++- src/gprs_ms.h | 12 ++-- src/pcu_l1_if.h | 46 ++++++++++++- src/pcu_main.cpp | 8 +-- src/pcu_vty.c | 2 +- src/pcu_vty_functions.cpp | 19 ++++++ src/tbf.h | 3 +- src/tbf_dl.cpp | 137 ++++++++++++++++++++------------------- tests/tbf/TbfTest.cpp | 70 ++++++++++++++++++++ tests/tbf/TbfTest.err | 161 ++++++++++++++++++++++++++++++++++++++-------- tests/tbf/TbfTest.ok | 2 + 12 files changed, 475 insertions(+), 110 deletions(-) hooks/post-receive -- UNNAMED PROJECT