27 Apr
2017
27 Apr
'17
9:51 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SCCP Library".
The branch, master has been updated
via b3546525024e8a183bb9b2e07eba82ead1397ed0 (commit)
via fa3325fb8b2f8bf31593b24e4e50693916feef1e (commit)
via 982c0ce33787443cdef9f342eb5fac30e806cd8e (commit)
via b30b011e34c1b8faa1e797be5df3ef2177945f48 (commit)
via 6fa19331784dabd49eba9778e3fe1ad0d60d340c (commit)
via 023d4f962b73aef5ef12af3b5a910fd1c80a26d5 (commit)
via 36a0ca83abde4e547f69c1989d24d24c5f394fb5 (commit)
via 14bdce0743a8dd4f481f37aaa81a7dd7103394cd (commit)
via 8a1f5a72db12fe4b48ea50e3700dc626c58332f6 (commit)
via 48c72f1f5c8f07cd6c7cb3558e9249f20aefb108 (commit)
from 4c880a02f4186406a53ce7fa28b061ce3a0d3955 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmo-sccp/commit/?id=b3546525024e8a183bb9b2e07eb…
commit b3546525024e8a183bb9b2e07eba82ead1397ed0
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 12:31:01 2017 +0200
osmo_sccp_addr_parse() Fix point code integer precision handling
"(cur[1] << 8) & 0x3f" is always 0 regardless of the values of
its
operands.
Change-Id: Ie47e632f4bca490baf4282dc5d55ee55ca7f1ae8
Fixes: coverity CID#166932
http://cgit.osmocom.org/libosmo-sccp/commit/?id=fa3325fb8b2f8bf31593b24e4e5…
commit fa3325fb8b2f8bf31593b24e4e50693916feef1e
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 12:24:38 2017 +0200
osmo_ss7_user_unregister(): Don't dereference NULL user
The 'user' argument to osmo_ss7_user_unregister() can be NULL, so let's
make sure we don't dereference it.
Change-Id: Ia34b181dcbcb179b2639e2f405364cc952069842
Fixes: coverity CID#166933
http://cgit.osmocom.org/libosmo-sccp/commit/?id=982c0ce33787443cdef9f342eb5…
commit 982c0ce33787443cdef9f342eb5fac30e806cd8e
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 12:17:20 2017 +0200
sccp_scoc: don't pass variable as argument if we know it's NULL
xua will always be NULL in one particular switch case of
scoc_fsm_conn_pend_out(), so let's use NULL directly rather than obscure
it though a variable that might be understood as this being non-NULL in
some cases.
Change-Id: Id6dc56442441489aefc706bcebc49197ca3dae1e
Fixes: coverity CID#166934
http://cgit.osmocom.org/libosmo-sccp/commit/?id=b30b011e34c1b8faa1e797be5df…
commit b30b011e34c1b8faa1e797be5df3ef2177945f48
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 12:11:24 2017 +0200
m3ua_decode_notify(): Ensure status_ie is valid before using it
Change-Id: I3cdd0fbdffcbeeb68dbc979385de045220ea0b0c
Fixes: coverity CID#166939
http://cgit.osmocom.org/libosmo-sccp/commit/?id=6fa19331784dabd49eba9778e3f…
commit 6fa19331784dabd49eba9778e3fe1ad0d60d340c
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 12:09:29 2017 +0200
sclc_rx_cldr(): Don't try to dereference user data_ie without check
While the SUA / SCCP2SUA code is ensuring that mandatory information
elements such as the user data IE in a CLD$ message, we might still have
current or future callers of sclc_rx_cldr() that don't comply with that.
So let's make sure data_ie is valid before dereferencing it.
Change-Id: I7c1010b0ac82ee0b7bd5e2c7413899695eae0070
Fixes: coverity CID#166940
http://cgit.osmocom.org/libosmo-sccp/commit/?id=023d4f962b73aef5ef12af3b5a9…
commit 023d4f962b73aef5ef12af3b5a910fd1c80a26d5
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 12:06:23 2017 +0200
m3ua_to_xfer_ind(): don't use data_ie without checking it exists
Change-Id: I5f7551e49c1b4ea417bee3516da1b2ece5ee0699
Fixes: coverity CID#166941
http://cgit.osmocom.org/libosmo-sccp/commit/?id=36a0ca83abde4e547f69c1989d2…
commit 36a0ca83abde4e547f69c1989d24d24c5f394fb5
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 12:02:47 2017 +0200
sclc_rx_cldt(): Don't try to dereference user data_ie without check
While the SUA / SCCP2SUA code is ensuring that mandatory information
elements such as the user data IE in a CLDT message, we might still have
current or future callers of sclc_rx_cldt() that don't comply with that.
So let's make sure data_ie is valid before dereferencing it.
Change-Id: Ia102f6c4cd5c6c3f823cb219635c42b9a87765f8
Fixes: coverity CID#166942
http://cgit.osmocom.org/libosmo-sccp/commit/?id=14bdce0743a8dd4f481f37aaa81…
commit 14bdce0743a8dd4f481f37aaa81a7dd7103394cd
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 11:53:53 2017 +0200
ss7_test: Fix '=' that should have been '=='
Change-Id: I1be4529c73992cb342a62aa19ba79be25e982620
Fixes: coverity CID#166944
http://cgit.osmocom.org/libosmo-sccp/commit/?id=8a1f5a72db12fe4b48ea50e3700…
commit 8a1f5a72db12fe4b48ea50e3700dc626c58332f6
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 11:52:43 2017 +0200
scu_gen_encode_and_send(): Fix NULL pointer deref
We were using the 'xua' pointer before checkin if it actually is valid
Change-Id: I5cd3250afc0b787b78683cd8ab6b2512e0d5c69e
Fixes: coverity CID#166945
http://cgit.osmocom.org/libosmo-sccp/commit/?id=48c72f1f5c8f07cd6c7cb3558e9…
commit 48c72f1f5c8f07cd6c7cb3558e9249f20aefb108
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Apr 27 11:50:51 2017 +0200
deliver_to_mtp_user(): Fix null pointer dereference
We had used + derefernced the 'prim' pointer before checking its
validity.
Change-Id: I0ca5026091e91926924b297f9342bda5f9fd38c9
Fixes: coverity CID#166946
-----------------------------------------------------------------------
Summary of changes:
src/m3ua.c | 4 ++++
src/osmo_ss7.c | 3 ++-
src/osmo_ss7_hmrt.c | 4 ++--
src/sccp2sua.c | 3 ++-
src/sccp_sclc.c | 10 ++++++++++
src/sccp_scoc.c | 4 ++--
tests/ss7/ss7_test.c | 2 +-
7 files changed, 23 insertions(+), 7 deletions(-)
hooks/post-receive
--
SCCP Library