25 Dec
2017
25 Dec
'17
2:45 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom code for Iuh interface".
The branch, master has been updated
via 23f3fdc6b25d8c5fc5a8f7f23eb69d2ac3d712b3 (commit)
via 4e2681df26399e2ff6260f3eaaeca23c3e25bfa6 (commit)
via da58d26cbcfb1b523830b359a17beb8660311bd7 (commit)
via e045da02613850aa1beff73516644834fcbc26f8 (commit)
via 1e9f4f5432fff3ff96d23b16252dd865b9e7aa62 (commit)
via b10e2937d94d30a9c33bb70ea291c856868490be (commit)
via aa3e9ebcb409e97ab3e61f17df7c154b8455d568 (commit)
via f33d16404d6cd78bfe33d445d1786f731a036440 (commit)
via 9e17e054e4bc48cf608c6fec1d7729a9ce74b872 (commit)
via 140f38c55ec208f9ed4c8b81e228bf0091cb1731 (commit)
from 6eeef115a9096b954dd6d873978abbb28055d301 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-iuh/commit/?id=23f3fdc6b25d8c5fc5a8f7f23eb69d2…
commit 23f3fdc6b25d8c5fc5a8f7f23eb69d2ac3d712b3
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Dec 25 00:00:04 2017 +0100
comments: hnbgw_rua.c: remove obsolete fixmes for asn1 free
The comments are all right above the line that does the proper asn1 free step.
Change-Id: I60e3be8c56ecc75c22e76f9e9dce8c72753e153b
http://cgit.osmocom.org/osmo-iuh/commit/?id=4e2681df26399e2ff6260f3eaaeca23…
commit 4e2681df26399e2ff6260f3eaaeca23c3e25bfa6
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Sun Dec 24 23:54:07 2017 +0100
osmo-hnbgw: startup: log the RNC-Id that is going to be used
Change-Id: I8aeb93fe8037e5fdc0784f5fc3bdb527de3b76bd
http://cgit.osmocom.org/osmo-iuh/commit/?id=da58d26cbcfb1b523830b359a17beb8…
commit da58d26cbcfb1b523830b359a17beb8660311bd7
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Dec 25 00:01:37 2017 +0100
osmo-hnbgw config: add 'rnc-id' config item
So far, the RNC-Id is hard-coded as 23. Still use 23 as default, but allow
configuring by config file. Hence make it possible to run multiple osmo-hnbgw
with differing RNC-Id each.
Change-Id: I374f558cc4bb36055f39efe9c58ae1b9bd49da46
http://cgit.osmocom.org/osmo-iuh/commit/?id=e045da02613850aa1beff7351664483…
commit e045da02613850aa1beff73516644834fcbc26f8
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Sun Dec 24 20:34:38 2017 +0100
cosmetic: context_map_tmr_cb(): fix comment
Change-Id: I4dd07a4d09d3cd4dc2a08e42ee48344967e5e3a6
http://cgit.osmocom.org/osmo-iuh/commit/?id=1e9f4f5432fff3ff96d23b16252dd86…
commit 1e9f4f5432fff3ff96d23b16252dd865b9e7aa62
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Sun Dec 24 23:57:58 2017 +0100
rua_to_scu(): don't create a context map for UNITDATA
UNITDATA is connection-less, and as can be observed further below, the 'map'
doesn't get used in the N_UNIDATA case.
Related: OS#2776
Change-Id: Ic35562e6d7bfa54b6be859860657f9a235ad5a50
http://cgit.osmocom.org/osmo-iuh/commit/?id=b10e2937d94d30a9c33bb70ea291c85…
commit b10e2937d94d30a9c33bb70ea291c856868490be
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Sun Dec 24 21:49:44 2017 +0100
rua: discard context maps on id-Disconnect
When an id-Disconnect is received, the RUA to SCCP user context becomes unused.
Mark the context map as inactive in that case. It will be cleaned up by the
context map garbage collector.
Related: OS#2776
Change-Id: I9616f72bfa566de081098ee13e720ff0f5266c77
http://cgit.osmocom.org/osmo-iuh/commit/?id=aa3e9ebcb409e97ab3e61f17df7c154…
commit aa3e9ebcb409e97ab3e61f17df7c154b8455d568
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Sun Dec 24 21:47:59 2017 +0100
segfault: context_map gc: use llist_for_each_entry_safe()
The context map garbage collector removes entries from the list, hence it must
use llist_for_each_entry_safe().
We haven't hit this before since nothing is yet flagging context maps to be
discarded.
Related: OS#2776
Change-Id: I9d5899923054d1bf862d542fec862fb1e6f07dce
http://cgit.osmocom.org/osmo-iuh/commit/?id=f33d16404d6cd78bfe33d445d1786f7…
commit f33d16404d6cd78bfe33d445d1786f731a036440
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Thu Dec 21 05:23:44 2017 +0100
compiler warning: asn1tostruct.py: return 0 at end of *_free_*()
Part of the resulting diff in the generated code:
--- /tmp/hnbap_decoder.c 2017-12-24 17:06:50.983979866 +0100
+++ /tmp/hnbap_decoder.c 2017-12-24 17:07:10.760223354 +0100
@@ -1179,6 +1179,7 @@
TNLUpdateResponseIEs_t *tnlUpdateResponseIEs) {
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_Context_ID,
&tnlUpdateResponseIEs->context_ID);
+ return 0;
}
int hnbap_free_tnlupdaterequesties(
@@ -1187,6 +1188,7 @@
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_Context_ID,
&tnlUpdateRequestIEs->context_ID);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RABList,
&tnlUpdateRequestIEs->rabList);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_Update_cause,
&tnlUpdateRequestIEs->update_cause);
+ return 0;
}
int hnbap_free_errorindicationies(
@@ -1197,12 +1199,14 @@
if ((errorIndicationIEs->presenceMask &
ERRORINDICATIONIES_CRITICALITYDIAGNOSTICS_PRESENT)
== ERRORINDICATIONIES_CRITICALITYDIAGNOSTICS_PRESENT)
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_CriticalityDiagnostics,
&errorIndicationIEs->criticalityDiagnostics);
+ return 0;
}
int hnbap_free_hnbconfigtransferrequesties(
HNBConfigTransferRequestIEs_t *hnbConfigTransferRequestIEs) {
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_NeighbourInfoRequestList,
&hnbConfigTransferRequestIEs->neighbourInfoRequestList);
+ return 0;
}
int hnbap_free_tnlupdatefailureies(
[etc.]
Related: OS#2670
Change-Id: Ieba12c09c33a81da964bf88a858714d922ced8c0
http://cgit.osmocom.org/osmo-iuh/commit/?id=9e17e054e4bc48cf608c6fec1d7729a…
commit 9e17e054e4bc48cf608c6fec1d7729a9ce74b872
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Dec 25 00:35:05 2017 +0100
osmo-hnbgw: vty: revamp output of context maps on 'show hnb'
Instead of listing each and every context map, rather output a summary of
context counts.
Rationale: in a list of a hundred HNBs, I don't want to also see a dozen (or
potentially thousands of) context map lines for each. Furthermore, the conn IDs
aren't necessarily useful on network traces either.
For example, what was shown as SUA Id is incidentally the SCCP Reference, but
this is not a hard requirement and may change. Also, the reference is shown in
wireshark as a hex in mismatching byte order ... so rather don't bother.
The result now looks like
OsmoHNBGW> show hnb all
HNB (r=192.168.0.124:29169<->l=192.168.0.9:29169)
"000295-0000152614(a)ap.ipaccess.com"
MCC 901 MNC 70 LAC 14357 RAC 11 SAC 1 CID 8595638 SCCP-stream:HNBAP=0,RUA=0
IuCS: 1 contexts: inactive-reserved:1
IuPS: 1 contexts: active:1
1 HNB connected
Related: OS#2772 OS#2773
Change-Id: Iae76b68e85863c8663bb5c508b85534c00e1d2c9
http://cgit.osmocom.org/osmo-iuh/commit/?id=140f38c55ec208f9ed4c8b81e228bf0…
commit 140f38c55ec208f9ed4c8b81e228bf0091cb1731
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Dec 20 23:48:02 2017 +0100
vty: tweak / improve HNB and cnlink introspection
Add 'show cnlink' (uses new osmo_sccp_user_name(), see 'Depends'
below).
Tweak 'show hnb all'.
The result looks something like:
OsmoHNBGW> show cnlink
IuCS: OsmoHNBGW:RI=SSN_PC,PC=0.23.5,SSN=RANAP <->
RI=SSN_PC,PC=0.23.1,SSN=RANAP
SS7 route: pc=0=0.0.0 mask=0x0=0.0.0 via AS as-clnt-OsmoHNBGW proto=m3ua ASP
asp-clnt-OsmoHNBGW (r=127.0.0.1:2905<->l=127.0.0.1:37699)
IuPS: OsmoHNBGW:RI=SSN_PC,PC=0.23.5,SSN=RANAP <->
RI=SSN_PC,PC=0.23.4,SSN=RANAP
SS7 route: pc=0=0.0.0 mask=0x0=0.0.0 via AS as-clnt-OsmoHNBGW proto=m3ua ASP
asp-clnt-OsmoHNBGW (r=127.0.0.1:2905<->l=127.0.0.1:37699)
OsmoHNBGW> show hnb all
No HNB connected
OsmoHNBGW> show hnb all
HNB (r=192.168.0.124:29169<->l=192.168.0.9:29169)
"000295-0000152614(a)ap.ipaccess.com"
MCC 901 MNC 70 LAC 14357 RAC 11 SAC 1 CID 8595638 SCCP-stream:HNBAP=0,RUA=0
IuCS 24->1002 (RUA->SUA) state=1
IuPS 24->1003 (RUA->SUA) state=1
HNB (r=192.168.0.15:29169<->l=192.168.0.9:29169)
"000295-0000154153(a)ap.ipaccess.com"
MCC 901 MNC 70 LAC 24358 RAC 22 SAC 65535 CID 1048575 SCCP-stream:HNBAP=0,RUA=0
IuCS 23->1000 (RUA->SUA) state=1
IuPS 23->1001 (RUA->SUA) state=1
2 HNB connected
Related: OS#2772 OS#2773
Depends: Ib7abf69cfcf4c56273223054b280458451e6c2f6 (libosmo-sccp)
Ia0d15a2814b08bc3f052a1ed12dbb68bade55309 (libosmo-sccp)
Change-Id: I3c937306a011715e163a40bc8ef8ec7e8d4e5d08
-----------------------------------------------------------------------
Summary of changes:
asn1/utils/asn1tostruct.py | 2 +
include/osmocom/iuh/context_map.h | 5 ++
src/context_map.c | 14 +++--
src/hnbgw.c | 2 +
src/hnbgw_rua.c | 31 +++++++----
src/hnbgw_vty.c | 108 +++++++++++++++++++++++++++++++++++---
6 files changed, 142 insertions(+), 20 deletions(-)
hooks/post-receive
--
Osmocom code for Iuh interface